[PATCH] emacs: Improved printing support.

2012-01-18 Thread David Edmondson
Add various functions to print notmuch messages and tie them together with a simple frontend. Add a binding ('#') in `notmuch-show-mode' to print the current message. --- Updates based on Aaron's review - the comments were very useful in improving things - thanks! Add a keybinding to

Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions

2012-01-18 Thread David Edmondson
Very happy with the overall ideas. On Tue, 17 Jan 2012 10:05:26 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: -(defun notmuch-show-archive-thread-internal (show-next) - ;; Remove the tag from the current set of messages. +(defun notmuch-show-tag-thread-internal (tag optional

Re: [PATCH 2/6] emacs: break out thread navigation from notmuch-show-archive-thread

2012-01-18 Thread David Edmondson
+1. pgpiBtWVmyHt6.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 3/6] emacs: add message archiving functions

2012-01-18 Thread David Edmondson
+1. pgpmQNrG3IoQL.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

2012-01-18 Thread David Edmondson
On Tue, 17 Jan 2012 10:05:29 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: -(defun notmuch-show-next-open-message () +(defun notmuch-show-next-open-message (optional pop-at-end) Show the next message. (interactive) - (let (r) + (let ((r) + (parent-buffer

Re: [PATCH 6/6] emacs: modify the default show-mode key bindings for archiving

2012-01-18 Thread David Edmondson
+1. pgpxIDMWtKOaN.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions

2012-01-18 Thread David Edmondson
On Tue, 17 Jan 2012 12:17:54 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Tue, 17 Jan 2012 15:10:40 -0500, Aaron Ecay aarone...@gmail.com wrote: This should be a docstring instead of a comment. (This applies equally to the old version) We're not currently in the

Re: [PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6

2012-01-18 Thread Tomi Ollila
On Tue, 17 Jan 2012 17:25:46 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Thomas Jost on Jan 17 at 11:50 am: +#ifdef GMIME_26 +/* sig_list may be created in both above cases, so we need to + * cleanly handle it here. */ +if (node-sig_list) { +

Re: on deleting messages

2012-01-18 Thread David Edmondson
Add the bindings. Provide documentation that makes it clear that they just add tags and never delete anything. pgp3b1CEVBlBs.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/3] emacs: bind s to `notmuch-search' in notmuch-hello buffer

2012-01-18 Thread David Edmondson
Looks fine. pgpvjhm6aqI2W.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 2/3] emacs: use a single history for all searches

2012-01-18 Thread David Edmondson
On Tue, 17 Jan 2012 23:34:09 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: There are two ways to do search in Emacs UI: search widget in notmuch-hello buffer and `notmuch-search' function bound to s. Before the change, these search mechanisms used different history lists. The

Re: [PATCH 3/3] emacs: bind s to `notmuch-hello-search' in notmuch-hello buffer

2012-01-18 Thread David Edmondson
+1. pgpZyJWo7ibRf.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2 3/3] search: Support automatic tag exclusions

2012-01-18 Thread David Edmondson
On Tue, 17 Jan 2012 15:32:11 -0500, Austin Clements amdra...@mit.edu wrote: Quoth David Edmondson on Jan 17 at 9:08 am: On Mon, 16 Jan 2012 15:16:24 -0700, Jeremy Nickurak jer...@nickurak.ca wrote: On Mon, Jan 16, 2012 at 12:28, Austin Clements amdra...@mit.edu wrote: Having deleted

Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

2012-01-18 Thread Jameson Graef Rollins
On Wed, 18 Jan 2012 08:12:27 +, David Edmondson d...@dme.org wrote: No need for brackets around `r'. Please put initialised local variables before uninitialised. Yeah, that's another comment of Aron's that I forgot to fix this time around. Sorry about that. (while (and (setq r

Re: [PATCH] emacs: Improved printing support.

2012-01-18 Thread Aaron Ecay
On Wed, 18 Jan 2012 08:00:21 +, David Edmondson d...@dme.org wrote: Add various functions to print notmuch messages and tie them together with a simple frontend. Add a binding ('#') in `notmuch-show-mode' to print the current message. --- Updates based on Aaron's review - the

Re: [PATCH v2 3/3] search: Support automatic tag exclusions

2012-01-18 Thread Jameson Graef Rollins
On Wed, 18 Jan 2012 08:38:23 +, David Edmondson d...@dme.org wrote: Something must create the initial configuration file if none exists. I'd be okay with that code adding 'deleted' and 'spam' to the excluded list. This would mean that an existing user would see no change without taking

Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 00:47:11 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: (while (and (setq r (notmuch-show-goto-message-next)) (not (notmuch-show-message-visible-p (if r (progn (notmuch-show-mark-read)

Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.

2012-01-18 Thread Tomi Ollila
On Tue, 17 Jan 2012 15:09:22 +, David Edmondson d...@dme.org wrote: On Tue, 17 Jan 2012 18:49:36 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: + # We cannot call 'test_emacs' in a subshell, because + # the setting of EMACS_SERVER would not persist +

Re: [PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-18 Thread Pieter Praet
On Mon, 16 Jan 2012 17:03:44 +, David Edmondson d...@dme.org wrote: On Mon, 16 Jan 2012 17:46:55 +0100, Pieter Praet pie...@praet.org wrote: Make `notmuch-cycle-notmuch-buffers' more Lispy and merge into `notmuch', eliminating the need to hog yet another keybind. ... diff --git

[RFC] [PATCH v3] emacs: rewrite `notmuch-cycle-notmuch-buffers'

2012-01-18 Thread Pieter Praet
Get rid of the compile-time `cl' requirement for this particular function. --- emacs/notmuch.el | 40 ++-- 1 files changed, 22 insertions(+), 18 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index ef4dcc7..2426c0a 100644 ---

Re: [PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-18 Thread Pieter Praet
On Mon, 16 Jan 2012 23:10:27 +0200, Jani Nikula j...@nikula.org wrote: On Mon, 16 Jan 2012 17:46:55 +0100, Pieter Praet pie...@praet.org wrote: Make `notmuch-cycle-notmuch-buffers' more Lispy and merge into `notmuch', eliminating the need to hog yet another keybind. What does merge mean

Re: [PATCH] v2 emacs: colorize buttonized 'id:' links depending on the target message's state

2012-01-18 Thread Pieter Praet
On Mon, 16 Jan 2012 16:43:06 -0500, Aaron Ecay aarone...@gmail.com wrote: On Mon, 16 Jan 2012 17:57:33 +0100, Pieter Praet pie...@praet.org wrote: * emacs/notmuch-show.el (notmuch-show-buttonized-link-colors): new defcustom, allows toggling colorization of buttonized links. *

Re: [PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 11:03:09 +0100, Pieter Praet pie...@praet.org wrote: [...] What's wrong with '(loop ... collect ...)'? Nothing at all. I was fixing my own patch [1] without resorting to requiring the `cl' package at runtime :) Would be nice if we could get rid of the compile-time

Re: [PATCH v3] Make buttons for attachments allow viewing as well as saving

2012-01-18 Thread Mark Walters
+(defun notmuch-show-view-part (message-id nth optional filename content-type ) + (notmuch-with-temp-part-buffer message-id nth +;; set mm-inlined-types to nil to force an external viewer +(let ((handle (mm-make-handle (current-buffer) (list content-type))) +

Re: [PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-18 Thread Pieter Praet
On Wed, 18 Jan 2012 10:13:35 +, David Edmondson d...@dme.org wrote: On Wed, 18 Jan 2012 11:03:09 +0100, Pieter Praet pie...@praet.org wrote: [...] What's wrong with '(loop ... collect ...)'? Nothing at all. I was fixing my own patch [1] without resorting to requiring the `cl'

[PATCH] test: always report missing prereqs, independent of `--verbose' option

2012-01-18 Thread Pieter Praet
When tests are skipped due to missing prereqs, those prereqs are only displayed when running with the `--verbose' option. This is essential information when troubleshooting, so always send to stdout. --- test/test-lib.sh |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 3/3 v3] emacs: colorize buttonized 'id:' links depending on the target message's state

2012-01-18 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-buttonized-link-colors): - new defcustom, allows toggling colorization of buttonized links. (notmuch-show-buttonized-link-available), (notmuch-show-buttonized-link-available-and-unread), (notmuch-show-buttonized-link-missing): - new faces for

Re: [PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 13:15:55 +0100, Pieter Praet pie...@praet.org wrote: On Wed, 18 Jan 2012 10:13:35 +, David Edmondson d...@dme.org wrote: On Wed, 18 Jan 2012 11:03:09 +0100, Pieter Praet pie...@praet.org wrote: [...] What's wrong with '(loop ... collect ...)'? Nothing at all.

Re: [PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-18 Thread Pieter Praet
On Wed, 18 Jan 2012 13:03:06 +, David Edmondson d...@dme.org wrote: Hey, look - I deliberately pressed 'r' instead of 'R'! You have remarkably malleable muscle memory. Care to donate some to the less fortunate ? :) On Wed, 18 Jan 2012 12:57:53 +, David Edmondson d...@dme.org wrote:

Re: [PATCH v2] emacs: add invisible dot instead of space at the end of notmuch-hello search box

2012-01-18 Thread Pieter Praet
On Tue, 17 Jan 2012 19:55:34 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: This makes `show-trailing-whitespace' happy, i.e. it does not mark the whole search box line as trailing spaces. Since the dot is invisible, this change makes no visible difference for `notmuch-hello'.

Re: [PATCH] test: always report missing prereqs, independent of `--verbose' option

2012-01-18 Thread Tomi Ollila
On Wed, 18 Jan 2012 13:19:41 +0100, Pieter Praet pie...@praet.org wrote: When tests are skipped due to missing prereqs, those prereqs are only displayed when running with the `--verbose' option. This is essential information when troubleshooting, so always send to stdout. --- Instead of

compressing header lines - quick prototype

2012-01-18 Thread David Edmondson
Here's something that I was playing with this morning. It's not finished, but has some nasty corners, so I'd like to solicit opinion on whether it's worth finishing. When faced with a long thread where most of the messages are closed, it might be convenient to hide large stretches of closed

RFC: tag macros

2012-01-18 Thread David Bremner
Hi All; Here is a very early stage proposal to provide tagging macros for notmuch show mode. The idea is that user defines a mapping from single key to a sequence of tagging operations. It might be nice if there as some kind of pop-up menu, or at least a prompt, but I didn't do that so far.

[feature request] thread-based queries

2012-01-18 Thread Patrick Totzke
Hi everyone, A recent discussion on alot's issue tracker[0] made it clear that it might be useful to have a thread-based matching for queries as an alternative to the current message based approach: Consider a thread with two messages, one has a single tag 'flagged', the other a single tag

Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.

2012-01-18 Thread Tomi Ollila
On Tue, 17 Jan 2012 14:07:03 +, David Edmondson d...@dme.org wrote: Add a new test function to allow simpler testing of emacs functionality. `test_emacs_expect_t' takes one argument - a list expression to evaluate. The test passes if the expression returns `t', otherwise it fails and

Re: [PATCH v2] emacs: add invisible dot instead of space at the end of notmuch-hello search box

2012-01-18 Thread Tomi Ollila
On Tue, 17 Jan 2012 19:55:34 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: This makes `show-trailing-whitespace' happy, i.e. it does not mark the whole search box line as trailing spaces. Since the dot is invisible, this change makes no visible difference for `notmuch-hello'.

Re: RFC: tag macros

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 10:45:06 -0400, David Bremner da...@tethera.net wrote: Here is a very early stage proposal to provide tagging macros for notmuch show mode. Nice idea. Please make it work on regions as well. pgp9jDOp95V8d.pgp Description: PGP signature

Re: [PATCH] Fix dependency generation for CLI sources

2012-01-18 Thread Tomi Ollila
On Sun, 15 Jan 2012 15:20:23 -0500, Austin Clements amdra...@mit.edu wrote: Previously, the dependency file list was generated before the CLI sources were added to SRCS, so dependency files weren't generated for CLI sources. This moves that code to after the CLI sources are added. --- +1

Re: [PATCH] Fix dependency generation for compat, test, and util

2012-01-18 Thread Tomi Ollila
On Sun, 15 Jan 2012 15:20:42 -0500, Austin Clements amdra...@mit.edu wrote: This adds source files in compat, test, and util to SRCS so that the top-level Makefile.local will generate dependency files for them. --- +1 ___ notmuch mailing list

Re: [PATCH v2 4/5] emacs: Use the new JSON reply format.

2012-01-18 Thread Adam Wolfe Gordon
On Tue, Jan 17, 2012 at 23:54, David Edmondson d...@dme.org wrote: On Tue, 17 Jan 2012 15:53:37 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: +(defun notmuch-parts-filter-by-type (parts type) +  Return a list of message parts with the given type +  (let (result) +    (dolist (part

[PATCH v2 4/5] emacs: Use the new JSON reply format.

2012-01-18 Thread Adam Wolfe Gordon
Using the new JSON reply format allows emacs to quote HTML parts nicely by using mm-display-part to turn them into displayable text, then quoting them. This is very useful for users who regularly receive HTML-only email. The behavior for messages that contain plain text parts should be unchanged.

Re: [PATCH v2 4/5] emacs: Use the new JSON reply format.

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 09:32:34 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: Using the new JSON reply format allows emacs to quote HTML parts nicely by using mm-display-part to turn them into displayable text, then quoting them. This is very useful for users who regularly receive HTML-only

Re: [PATCH v2 4/5] emacs: Use the new JSON reply format.

2012-01-18 Thread Adam Wolfe Gordon
On Wed, Jan 18, 2012 at 09:41, David Edmondson d...@dme.org wrote: I think that this looks pretty good now. We should get some experience of using it. Thanks for the reviews and guidance - I think the patch is in much better shape than when it started. FWIW, I've been using the original

Re: [PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6

2012-01-18 Thread Tom Prince
On Tue, 17 Jan 2012 11:50:53 +0100, Thomas Jost schno...@schnouki.net wrote: This was tested against both gmime 2.6.4 and 2.4.31. With gmime 2.4.31, the crypto tests all work fine (as expected). With gmime 2.6.4, one crypto test fails (signature verification with signer key unavailable) but

[PATCH] emacs: Make the part content available to the mm-inline* checks.

2012-01-18 Thread David Edmondson
The `mm-inlinable-p' and `mm-inlined-p' functions work better if they have access to the data of the relevant part, so load that content before calling either function. This fixes the display of attached image/jpeg parts, for example. --- I dropped this on the floor after discussing it in

Re: [PATCH] emacs: Make the part content available to the mm-inline* checks.

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 17:33:13 +, David Edmondson d...@dme.org wrote: + ;; Nonsense required to have the new gnus `shr' HTML + ;; display code work. + (let ((gnus-inhibit-images nil)) + (makunbound 'gnus-summary-buffer) ; Blech. + (mm-display-part handle))

[PATCH v2] emacs: Make the part content available to the mm-inline* checks.

2012-01-18 Thread David Edmondson
The `mm-inlinable-p' and `mm-inlined-p' functions work better if they have access to the data of the relevant part, so load that content before calling either function. This fixes the display of attached image/jpeg parts, for example. --- Removed the cruft that crept into the previous patch.

Re: [PATCH 2/3] emacs: use a single history for all searches

2012-01-18 Thread Dmitry Kurochkin
On Wed, 18 Jan 2012 08:25:22 +, David Edmondson d...@dme.org wrote: On Tue, 17 Jan 2012 23:34:09 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: There are two ways to do search in Emacs UI: search widget in notmuch-hello buffer and `notmuch-search' function bound to s.

Re: [PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6

2012-01-18 Thread Tomi Ollila
On Wed, 18 Jan 2012 12:19:45 -0500, Tom Prince tom.pri...@ualberta.net wrote: How did you test against multiple versions? Using different machines? If there was a way for configure (or something to pick the version, I would setup the buildbot to test against both, so we don't regress either.

Re: [PATCH v2] emacs: Make the part content available to the mm-inline* checks.

2012-01-18 Thread Dmitry Kurochkin
Hi David. On Wed, 18 Jan 2012 17:39:31 +, David Edmondson d...@dme.org wrote: The `mm-inlinable-p' and `mm-inlined-p' functions work better if they have access to the data of the relevant part, so load that content before calling either function. This fixes the display of attached

Re: [PATCH 2/3] emacs: use a single history for all searches

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 21:57:27 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: The test output updates included here should be with the previous patch, shouldn't they? Indeed. Would send v2. That's not necessary for me. Should user-typed queries be trimmed? IMO that would

Re: [PATCH v2] emacs: Make the part content available to the mm-inline* checks.

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 22:04:36 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Wed, 18 Jan 2012 17:39:31 +, David Edmondson d...@dme.org wrote: The `mm-inlinable-p' and `mm-inlined-p' functions work better if they have access to the data of the relevant part, so load that

Re: RFC: tag macros

2012-01-18 Thread Austin Clements
Quoth David Bremner on Jan 18 at 10:45 am: Hi All; Here is a very early stage proposal to provide tagging macros for notmuch show mode. The idea is that user defines a mapping from single key to a sequence of tagging operations. It might be nice if there as some kind of pop-up menu,

Re: [PATCH v4] emacs: logically group def{custom,face}s

2012-01-18 Thread Austin Clements
Quoth Pieter Praet on Jan 18 at 11:00 am: On Mon, 16 Jan 2012 14:16:22 -0500, Austin Clements amdra...@mit.edu wrote: LGTM. Quoth Pieter Praet on Jan 16 at 11:38 am: - Add `notmuch-send' to the `message' group, as per Austin's recommendation [1]. This is actually the reverse

Re: RFC: tag macros

2012-01-18 Thread Jameson Graef Rollins
On Wed, 18 Jan 2012 10:45:06 -0400, David Bremner da...@tethera.net wrote: The advantage of this rather than just writing lots of little lambdas is that it combines adding and deleting, and it could be done via customize. Is all of this really easier than just adding the following to your

Re: [PATCH v2 3/3] search: Support automatic tag exclusions

2012-01-18 Thread Jameson Graef Rollins
On Wed, 18 Jan 2012 09:52:52 +, David Edmondson d...@dme.org wrote: I agree that as long as no keys are pre-bound it will make little difference. That just transfers the discussion to the thread about adding the bindings, which seems silly. I think that's ok. The tag exclusion is in,

Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

2012-01-18 Thread Jameson Graef Rollins
On Wed, 18 Jan 2012 08:56:26 +, David Edmondson d...@dme.org wrote: I'm used to the cursor going to the bottom of the thread to let me know that I reached the end, then I hit 'space' and move on to the next thread. Will that behaviour be retained with this patch? (Well, including your

Re: [PATCH v2] emacs: Make the part content available to the mm-inline* checks.

2012-01-18 Thread Dmitry Kurochkin
On Wed, 18 Jan 2012 18:30:36 +, David Edmondson d...@dme.org wrote: On Wed, 18 Jan 2012 22:04:36 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Wed, 18 Jan 2012 17:39:31 +, David Edmondson d...@dme.org wrote: The `mm-inlinable-p' and `mm-inlined-p' functions work

Re: RFC: tag macros

2012-01-18 Thread David Bremner
On Wed, 18 Jan 2012 13:33:04 -0500, Austin Clements amdra...@mit.edu wrote: Quoth David Bremner on Jan 18 at 10:45 am: What about simply providing an API that takes a bunch of tag operations and applies them to the current thread/message/region? My main motivation here is (as you can probably

Re: RFC: tag macros

2012-01-18 Thread Austin Clements
Quoth David Bremner on Jan 18 at 3:03 pm: On Wed, 18 Jan 2012 13:33:04 -0500, Austin Clements amdra...@mit.edu wrote: Quoth David Bremner on Jan 18 at 10:45 am: What about simply providing an API that takes a bunch of tag operations and applies them to the current thread/message/region?

Re: [PATCH v3] Make buttons for attachments allow viewing as well as saving

2012-01-18 Thread Austin Clements
Quoth Mark Walters on Jan 18 at 10:46 am: +(defun notmuch-show-view-part (message-id nth optional filename content-type ) + (notmuch-with-temp-part-buffer message-id nth +;; set mm-inlined-types to nil to force an external viewer +(let ((handle (mm-make-handle

Re: RFC: tag macros

2012-01-18 Thread Jameson Graef Rollins
On Wed, 18 Jan 2012 15:03:52 -0400, David Bremner da...@tethera.net wrote: My main motivation here is (as you can probably see from the example) dealing with patches, and in that setting, tagging the whole thread is is almost never what you want. The example I sent was about tagging individual

Re: [PATCH v2] emacs: Make the part content available to the mm-inline* checks.

2012-01-18 Thread Austin Clements
Quoth Dmitry Kurochkin on Jan 18 at 11:00 pm: On Wed, 18 Jan 2012 18:30:36 +, David Edmondson d...@dme.org wrote: On Wed, 18 Jan 2012 22:04:36 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Wed, 18 Jan 2012 17:39:31 +, David Edmondson d...@dme.org wrote: The

Re: [PATCH v2] emacs: Make the part content available to the mm-inline* checks.

2012-01-18 Thread Dmitry Kurochkin
On Wed, 18 Jan 2012 14:35:01 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Dmitry Kurochkin on Jan 18 at 11:00 pm: On Wed, 18 Jan 2012 18:30:36 +, David Edmondson d...@dme.org wrote: On Wed, 18 Jan 2012 22:04:36 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On

[PATCH v2 0/3] emacs: notmuch-hello search cleanup

2012-01-18 Thread Dmitry Kurochkin
Changes in v2 since v1: * expected results changes for tests moved from patch 2 to 1 where it belong Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v2 1/3] emacs: bind s to `notmuch-search' in notmuch-hello buffer

2012-01-18 Thread Dmitry Kurochkin
Before the change, s in notmuch-hello buffer would jump to the search box. The patch changes the binding to `notmuch-search' which is consistent with all other notmuch buffers. --- emacs/notmuch-hello.el | 19 ++-

[PATCH v2 3/3] emacs: bind s to `notmuch-hello-search' in notmuch-hello buffer

2012-01-18 Thread Dmitry Kurochkin
`notmuch-hello-search' uses `notmuch-search' function but refreshes notmuch-hello buffer when the search buffer is closed. --- emacs/notmuch-hello.el |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index cb36977..e908659

[PATCH v2 2/3] emacs: use a single history for all searches

2012-01-18 Thread Dmitry Kurochkin
There are two ways to do search in Emacs UI: search widget in notmuch-hello buffer and `notmuch-search' function bound to s. Before the change, these search mechanisms used different history lists. The patch makes notmuch-hello search use the same history list as `notmuch-search' function. ---

[PATCH 0/3] Second step of 'show' rewrite

2012-01-18 Thread Austin Clements
This adds support for self-recursive message formatters, while maintaining backwards compatibility with old style formatters. After this, each format can be converted to the new style individually and, once they're all converted, a bunch of code can be deleted. These three patches are

[PATCH 1/3] mime node: Record depth-first part numbers

2012-01-18 Thread Austin Clements
This makes the part numbers readily accessible to formatters. Hierarchical part numbering would be a more natural and efficient fit for MIME and may be the way to go in the future, but depth-first numbering maintains compatibility with what we currently do. --- mime-node.c | 33

[PATCH 2/3] show: Use consistent header ordering in the text format

2012-01-18 Thread Austin Clements
Previously, top-level message headers were printed as Subject, From, To, Date, while embedded message headers were printed From, To, Subject, Date. This makes both cases use the former order and updates the tests accordingly. Strangely, the raw format also uses this function, so this also fixes

[PATCH 3/3] show: Introduce mime_node formatter callback

2012-01-18 Thread Austin Clements
This callback is the gateway to the new mime_node_t-based formatters. This maintains backwards compatibility so the formatters can be transitioned one at a time. Once all formatters are converted, the formatter structure can be reduced to only message_set_{start,sep,end} and part, most of

Re: [PATCH 0/3] Second step of 'show' rewrite

2012-01-18 Thread Dmitry Kurochkin
Hi Austin. On Wed, 18 Jan 2012 15:28:24 -0500, Austin Clements amdra...@mit.edu wrote: This adds support for self-recursive message formatters, while maintaining backwards compatibility with old style formatters. After this, each format can be converted to the new style individually and,

Re: [PATCH 0/3] Second step of 'show' rewrite

2012-01-18 Thread Austin Clements
Quoth Dmitry Kurochkin on Jan 19 at 12:35 am: Hi Austin. On Wed, 18 Jan 2012 15:28:24 -0500, Austin Clements amdra...@mit.edu wrote: This adds support for self-recursive message formatters, while maintaining backwards compatibility with old style formatters. After this, each format can

[PATCH] config: Better formatting for search section comment

2012-01-18 Thread Austin Clements
Since auto_exclude_tags is long and its description is multi-line, start the description on the next line and indent it consistently. --- notmuch-config.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/notmuch-config.c b/notmuch-config.c index 3d4d5b9..8dcfe86

[PATCH] News for tag exclusion

2012-01-18 Thread Austin Clements
--- NEWS | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 1e561a9..6afa912 100644 --- a/NEWS +++ b/NEWS @@ -11,6 +11,13 @@ Reply to sender to all. The feature is available through the new command line option --reply-to=(all|sender).

Re: [PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-18 Thread Aaron Ecay
On Wed, 18 Jan 2012 14:48:02 +0100, Pieter Praet pie...@praet.org wrote: My original intent of conserving a key(chord) [1] (which in retrospect was a fairly pointless exercise in and of itself [2,3]) seems to have inconspicuously morphed into an equally questionable crusade [4] against the

Re: [PATCH 1/3] mime node: Record depth-first part numbers

2012-01-18 Thread Jani Nikula
On Wed, 18 Jan 2012 15:28:25 -0500, Austin Clements amdra...@mit.edu wrote: This makes the part numbers readily accessible to formatters. Hierarchical part numbering would be a more natural and efficient fit for MIME and may be the way to go in the future, but depth-first numbering maintains

Re: [PATCH] config: Better formatting for search section comment

2012-01-18 Thread Jameson Graef Rollins
On Wed, 18 Jan 2012 15:56:45 -0500, Austin Clements amdra...@mit.edu wrote: Since auto_exclude_tags is long and its description is multi-line, start the description on the next line and indent it consistently. lgtm. pgpMNovZHNU66.pgp Description: PGP signature

Re: [PATCH 3/3] show: Introduce mime_node formatter callback

2012-01-18 Thread Jani Nikula
On Wed, 18 Jan 2012 15:28:27 -0500, Austin Clements amdra...@mit.edu wrote: This callback is the gateway to the new mime_node_t-based formatters. This maintains backwards compatibility so the formatters can be transitioned one at a time. Once all formatters are converted, the formatter

Sort by newest first from notmuch-hello ?

2012-01-18 Thread Xavier Maillard
Hi, I am running latest release (0.11). I have set notmuch-search-oldest-first to t. When doing M-x notmuch-search, messages order does not respect this setting -i.e newest com firts -. On the other hand, from notmuch-hello I get expected behaviour. How can this be more consistent ? By the way,

Re: [PATCH v2 2/4] reply: Add a JSON reply format.

2012-01-18 Thread Jani Nikula
On Mon, 16 Jan 2012 11:13:21 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: This new JSON format for replies includes headers generated for a reply message as well as the headers and all text parts of the original message. Using this data, a client can intelligently create a reply. For

Re: [PATCH v2 2/4] reply: Add a JSON reply format.

2012-01-18 Thread Adam Wolfe Gordon
On Wed, Jan 18, 2012 at 16:07, Jani Nikula j...@nikula.org wrote: I know I asked you to adhere to notmuch coding style like above, but I meant in the context of your patch, not elsewhere. Cleanups like this should really be separate patches. Sorry if I was ambiguous. Oops - my bad. I assumed

Re: RFC: tag macros

2012-01-18 Thread David Bremner
On Wed, 18 Jan 2012 10:50:50 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: I've been wanting to put together a wiki page that lists all the useful functions and has examples of how to put them together into useful functions. If we're going to go the way of providing a

[PATCH 0/2] Fix or silence unused result warnings

2012-01-18 Thread Austin Clements
I'm afraid I bikeshedded dme's original patch for this into oblivion (id:1324503532-5799-1-git-send-email-...@dme.org) and we still have these warnings on the buildbot. Tomi convinced me that dme was right and I was wrong, so I'm bringing dme's patch back. The first patch actually fixes the

[PATCH 2/2] Silence buildbot warnings about unused results

2012-01-18 Thread Austin Clements
This ignores the results of the two writes in sigint handlers even harder than before. While my libc lacks the declarations that trigger these warnings, this can be tested by adding the following to notmuch.h: __attribute__((warn_unused_result)) ssize_t write(int fd, const void *buf, size_t

[PATCH 1/2] show: Handle read and write errors

2012-01-18 Thread Austin Clements
For showing a message in raw format, rather than silently succeeding when a read or a write fails (or, probably, looping if a read fails), try to print an error message and exit with a non-zero status. This silences one of the buildbot warnings about unused resuls. While my libc lacks the

Re: [PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-18 Thread Austin Clements
Quoth Aaron Ecay on Jan 18 at 5:18 pm: Compile-time dependencies on ‘cl’ are absolutely not a problem. Virtually every major elisp program depends on cl at compile time. Runtime dependencies are not allowed in code distributed with emacs because of RMS’s conservativism[1]. Since notmuch

Re: [PATCH 1/3] mime node: Record depth-first part numbers

2012-01-18 Thread Austin Clements
Quoth Jani Nikula on Jan 19 at 12:25 am: On Wed, 18 Jan 2012 15:28:25 -0500, Austin Clements amdra...@mit.edu wrote: This makes the part numbers readily accessible to formatters. Hierarchical part numbering would be a more natural and efficient fit for MIME and may be the way to go in the

Re: RFC: tag macros

2012-01-18 Thread Jameson Graef Rollins
On Wed, 18 Jan 2012 20:04:44 -0400, David Bremner da...@tethera.net wrote: If we're going to go the way of providing a toolkit/api for uses to make their own bindings, then I think that we should make the effort to provide a proper info document with the distribution, rather than relying on

Re: [PATCH 3/3] show: Introduce mime_node formatter callback

2012-01-18 Thread Austin Clements
Quoth Jani Nikula on Jan 19 at 12:33 am: On Wed, 18 Jan 2012 15:28:27 -0500, Austin Clements amdra...@mit.edu wrote: This callback is the gateway to the new mime_node_t-based formatters. This maintains backwards compatibility so the formatters can be transitioned one at a time. Once all

Re: RFC: tag macros

2012-01-18 Thread David Bremner
On Wed, 18 Jan 2012 18:15:37 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: Can't we just use the emacs build-in documentation? If you mean docstrings, that is only per function/variable. Which is better than nothing, but not very good for getting an overview of what is

Re: [PATCH 2/2] Silence buildbot warnings about unused results

2012-01-18 Thread David Edmondson
On Wed, 18 Jan 2012 19:40:11 -0500, Austin Clements amdra...@mit.edu wrote: +/* See handle_sigint in notmuch-new.c for the justification for + * ignoring write's result. */ +IGNORE_RESULT (write (2, msg, sizeof(msg)-1)); Just include the comment in both places. Someone will work

[PATCH 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer

2012-01-18 Thread Dmitry Kurochkin
[of course I sent this email privately, sorry for duplicates] On Tue, 17 Jan 2012 23:22:30 +0200, Jani Nikula wrote: > On Tue, 17 Jan 2012 23:34:08 +0400, Dmitry Kurochkin gmail.com> wrote: > > Before the change, "s" in notmuch-hello buffer would jump to the > > search box. The patch changes

Improving notmuch query documentation [was: Re: Partial words on notmuch search?]

2012-01-18 Thread Andrei Popescu
lain it simply, you don't understand it well enough. (Albert Einstein) -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 490 bytes Desc: Digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120118/d4b267ff/attachment.pgp>

[PATCH v3] Make buttons for attachments allow viewing as well as saving

2012-01-18 Thread Mark Walters
> Oof, sorry. Two more tweaks that I really should have caught in the > previous version. After that this gets my automatic +1. Both fixed. I have also fixed the bug I mentioned (missing filename when "view" falls back on save); I couldn't make it work with the "no-default" option. However

[PATCH v2 4/5] emacs: Use the new JSON reply format.

2012-01-18 Thread David Edmondson
not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120118/261935f8/attachment.pgp>

ANNOUNCE: nottoomuch-addresses.sh 2.0

2012-01-18 Thread Tomi Ollila
nottoomuch-addresses.sh -- email address substring matcher -- completion helper version 2.0 is available. Note to 1.92 prerelease tester(s): ignore regexp "indicator" has changed from ^re:... to ^/.../[i]. This allows this 'i' flag and trailing whitespace in re. Changes: * Added regexp-based

[PATCH] emacs: Improved printing support.

2012-01-18 Thread David Edmondson
Add various functions to print notmuch messages and tie them together with a simple frontend. Add a binding ('#') in `notmuch-show-mode' to print the current message. --- Updates based on Aaron's review - the comments were very useful in improving things - thanks! Add a keybinding to

[PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions

2012-01-18 Thread David Edmondson
oop do (funcall tag-function tag) > + until (not (notmuch-show-goto-message-next) Otherwise good. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchm

  1   2   >