Re: Infinite loop in emacs interface

2012-01-24 Thread Florian Friesdorf
On Mon, 23 Jan 2012 15:26:20 +0100, Florian Friesdorf f...@chaoflow.net wrote: On Tue, 17 Jan 2012 23:44:40 +0100, Rodney Lorrimar d...@rodney.id.au wrote: Debugger entered--Lisp error: (void-variable gnus-inhibit-images) mm-shr((#buffer *temp* (text/html) nil nil nil nil nil nil))

Re: [RFC][PATCH] emacs: Provide scaffolding so that the new `shr' HTML renderer can run.

2012-01-24 Thread Florian Friesdorf
On Mon, 19 Dec 2011 23:38:36 -0700, Chris Gray chrismg...@gmail.com wrote: +;; Nonsense required to have the new gnus `shr' HTML display code +;; work. +(defvar gnus-summary-buffer) +(defvar gnus-inhibit-images) I believe that gnus-inhibit-images is defined in gnus-art.el. Perhaps

Re: [PATCH v3 6/6] NEWS: update Tag exclusion section

2012-01-24 Thread Austin Clements
Series LGTM. Quoth Pieter Praet on Jan 23 at 6:41 am: --- Added note re new configurations, as suggested by Austin: id:20120123044108.gs16...@mit.edu NEWS | 19 +++ 1 files changed, 15 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index 2c2d9e9..2acdce5

Re: [PATCH 1/3] test: Don't return the result of checking for running emacs to the tester.

2012-01-24 Thread Dmitry Kurochkin
LGTM. Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.

2012-01-24 Thread Dmitry Kurochkin
On Thu, 19 Jan 2012 12:54:02 +, David Edmondson d...@dme.org wrote: Add a new test function to allow simpler testing of emacs functionality. `test_emacs_expect_t' takes one argument - a list expression to evaluate. The test passes if the expression returns `t', otherwise it fails and

Re: [PATCH 3/3] test: Add address cleaning tests.

2012-01-24 Thread Dmitry Kurochkin
On Thu, 19 Jan 2012 12:54:03 +, David Edmondson d...@dme.org wrote: Including some more test framework in test-lib.el. IMO test-lib.el changes should be in a separate patch. --- test/emacs-address-cleaning.el | 29 + test/emacs-address-cleaning.sh | 12

Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

2012-01-24 Thread Jameson Graef Rollins
On Mon, 23 Jan 2012 11:02:04 +, David Edmondson d...@dme.org wrote: On Mon, 23 Jan 2012 00:34:23 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: -(defun notmuch-show-next-open-message () +(defun notmuch-show-next-open-message (optional pop-at-end) Show the next

[PATCH 3/4 v42] test: Add more helpers for emacs tests.

2012-01-24 Thread David Edmondson
--- Split out from the tests and re-factored. test/test-lib.el | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/test/test-lib.el b/test/test-lib.el index 96752f0..c4a5db4 100644 --- a/test/test-lib.el +++ b/test/test-lib.el @@ -20,6 +20,8 @@ ;; ;;

Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

2012-01-24 Thread David Edmondson
On Mon, 23 Jan 2012 09:39:30 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Mon, 23 Jan 2012 11:02:04 +, David Edmondson d...@dme.org wrote: On Mon, 23 Jan 2012 00:34:23 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: -(defun

[PATCH 1/4 v42] test: Don't return the result of checking for running emacs to the tester.

2012-01-24 Thread David Edmondson
When checking for a running emacs, test_emacs evaluates the empty list '()'. This returns 'nil' when emacs is running, which is then prepended to the actual test result. Given that it is not part of the actual test output the test harness can incorrectly report test failure (or success). ---

[PATCH 4/4 v42] test: Add address cleaning tests.

2012-01-24 Thread David Edmondson
--- Anticipate the failure of test 3. test/emacs-address-cleaning.el | 29 + test/emacs-address-cleaning.sh | 19 +++ test/notmuch-test |1 + 3 files changed, 49 insertions(+), 0 deletions(-) create mode 100644

Re: [PATCH v2 1/3] mime node: Record depth-first part numbers

2012-01-24 Thread Jani Nikula
On Sun, 22 Jan 2012 21:31:11 -0500, Austin Clements amdra...@mit.edu wrote: This makes the part numbers readily accessible to formatters. Hierarchical part numbering would be a more natural and efficient fit for MIME and may be the way to go in the future, but depth-first numbering maintains

Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

2012-01-24 Thread Jameson Graef Rollins
On Mon, 23 Jan 2012 17:55:14 +, David Edmondson d...@dme.org wrote: On that basis, I hope no-one will complain if I fix them as a 'drive by' during another change... Hrm. I don't think that follows. Unless the patch is already touching that code, I would really prefer we continue to

Re: [PATCH 08/10] test: set variables using `let' instead of `setq' in Emacs tests

2012-01-24 Thread Xavier Maillard
On Tue, 28 Jun 2011 08:45:09 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Using `setq' for setting variables in Emacs tests affect other tests that may run in the same Emacs environment. Currently it works because each test is run in a separate Emacs instance. But in the future

Re: [PATCH 10/10] test: use emacsclient(1) for Emacs tests

2012-01-24 Thread Xavier Maillard
On Tue, 28 Jun 2011 08:45:11 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Before the change, every Emacs test ran in a separate Emacs instance. Starting Emacs many times wastes considerable time and it gets worse as the test suite grows. The patch solves this by using a single

[PATCH v3 1/2] mime node: Record depth-first part numbers

2012-01-24 Thread Austin Clements
This makes the part numbers readily accessible to formatters. Hierarchical part numbering would be a more natural and efficient fit for MIME and may be the way to go in the future, but depth-first numbering maintains compatibility with what we currently do. --- mime-node.c | 36

[PATCH v3 0/2] Second step of 'show' rewrite

2012-01-24 Thread Austin Clements
Fix a silly comment mistake pointed out by Jani ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v5 2/2] show: Introduce mime_node formatter callback

2012-01-24 Thread Austin Clements
This callback is the gateway to the new mime_node_t-based formatters. This maintains backwards compatibility so the formatters can be transitioned one at a time. Once all formatters are converted, the formatter structure can be reduced to only message_set_{start,sep,end} and part, most of

Re: [PATCH v5 1/2] mime node: Record depth-first part numbers

2012-01-24 Thread Dmitry Kurochkin
On Mon, 23 Jan 2012 18:33:09 -0500, Austin Clements amdra...@mit.edu wrote: This makes the part numbers readily accessible to formatters. Hierarchical part numbering would be a more natural and efficient fit for MIME and may be the way to go in the future, but depth-first numbering maintains

Re: [PATCH v5 2/2] show: Introduce mime_node formatter callback

2012-01-24 Thread Dmitry Kurochkin
On Mon, 23 Jan 2012 18:33:10 -0500, Austin Clements amdra...@mit.edu wrote: This callback is the gateway to the new mime_node_t-based formatters. This maintains backwards compatibility so the formatters can be transitioned one at a time. Once all formatters are converted, the formatter

[PATCH v3 0/3] emacs: notmuch-hello search cleanup

2012-01-24 Thread Dmitry Kurochkin
Changes: v3: * rebased on current master v2: * expected results changes for tests moved from patch 2 to 1 where it belong Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v3 1/3] emacs: bind s to `notmuch-search' in notmuch-hello buffer

2012-01-24 Thread Dmitry Kurochkin
Before the change, s in notmuch-hello buffer would jump to the search box. The patch changes the binding to `notmuch-search' which is consistent with all other notmuch buffers. --- emacs/notmuch-hello.el | 19 ++-

[PATCH v3 2/3] emacs: use a single history for all searches

2012-01-24 Thread Dmitry Kurochkin
There are two ways to do search in Emacs UI: search widget in notmuch-hello buffer and `notmuch-search' function bound to s. Before the change, these search mechanisms used different history lists. The patch makes notmuch-hello search use the same history list as `notmuch-search' function. ---

[PATCH v3 3/3] emacs: bind s to `notmuch-hello-search' in notmuch-hello buffer

2012-01-24 Thread Dmitry Kurochkin
`notmuch-hello-search' uses `notmuch-search' function but refreshes notmuch-hello buffer when the search buffer is closed. --- emacs/notmuch-hello.el |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 004287a..64011d4

Re: [PATCH] Automatically exclude tags in notmuch-show

2012-01-24 Thread Mark Walters
On Sun, 22 Jan 2012 20:52:22 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Mark Walters on Jan 23 at 1:13 am: On Sun, 22 Jan 2012 13:16:09 -0500, Austin Clements amdra...@mit.edu wrote: Quoth myself on Jan 20 at 12:18 pm: Quoth Mark Walters on Jan 20 at 12:10 am:

Re: [PATCH] Automatically exclude tags in notmuch-show

2012-01-24 Thread Austin Clements
Quoth Mark Walters on Jan 24 at 1:05 am: On Sun, 22 Jan 2012 20:52:22 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Mark Walters on Jan 23 at 1:13 am: On Sun, 22 Jan 2012 13:16:09 -0500, Austin Clements amdra...@mit.edu wrote: Quoth myself on Jan 20 at 12:18 pm: Quoth

[RFC PATCH 1/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

2012-01-24 Thread Mark Walters
Slightly refactor the exclude code to give the callers access to the exclude query itself. There should be no functional change. --- lib/query.cc | 29 +++-- 1 files changed, 19 insertions(+), 10 deletions(-) diff --git a/lib/query.cc b/lib/query.cc index

[RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

2012-01-24 Thread Mark Walters
Form excluded doc_ids set and use that to exclude messages. Should be no functional change. --- lib/notmuch-private.h |1 + lib/query.cc | 28 ++-- 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h

[RFC PATCH 3/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

2012-01-24 Thread Mark Walters
Add the actual NOTMUCH_MESSAGE_FLAG_EXCLUDED flag. --- lib/notmuch-private.h |1 + lib/notmuch.h |3 ++- lib/query.cc | 11 +++ lib/thread.cc | 14 ++ 4 files changed, 20 insertions(+), 9 deletions(-) diff --git a/lib/notmuch-private.h

Re: [RFC PATCH 4/5] show: Convert text format to the new self-recursive style

2012-01-24 Thread Dmitry Kurochkin
On Wed, 11 Jan 2012 20:49:32 -0500, Austin Clements amdra...@mit.edu wrote: This is all code movement and a smidgen of glue. This moves the existing text formatter code into one self-recursive function, but doesn't change any of the logic. The next patch will actually take advantage of what

Re: [RFC PATCH 5/5] show: Simplify new text formatter code

2012-01-24 Thread Dmitry Kurochkin
On Wed, 11 Jan 2012 20:49:33 -0500, Austin Clements amdra...@mit.edu wrote: This makes the text formatter take advantage of the new code structure. The previously duplicated header logic is now unified, several things that we used to compute repeatedly across different callbacks are now

Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

2012-01-24 Thread Austin Clements
The overall structure of this series looks great. There's obviously a lot of clean up to do, but I'll reply with a few high-level comments. Quoth Mark Walters on Jan 24 at 1:18 am: Form excluded doc_ids set and use that to exclude messages. Should be no functional change. ---

Re: [RFC PATCH 3/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

2012-01-24 Thread Austin Clements
Quoth Mark Walters on Jan 24 at 1:18 am: Add the actual NOTMUCH_MESSAGE_FLAG_EXCLUDED flag. --- lib/notmuch-private.h |1 + lib/notmuch.h |3 ++- lib/query.cc | 11 +++ lib/thread.cc | 14 ++ 4 files changed, 20 insertions(+), 9

Re: [PATCH v5 1/2] mime node: Record depth-first part numbers

2012-01-24 Thread Tomi Ollila
On Mon, 23 Jan 2012 18:33:09 -0500, Austin Clements amdra...@mit.edu wrote: This makes the part numbers readily accessible to formatters. Hierarchical part numbering would be a more natural and efficient fit for MIME and may be the way to go in the future, but depth-first numbering maintains

Re: [PATCH v5 2/2] show: Introduce mime_node formatter callback

2012-01-24 Thread Tomi Ollila
On Mon, 23 Jan 2012 18:33:10 -0500, Austin Clements amdra...@mit.edu wrote: This callback is the gateway to the new mime_node_t-based formatters. This maintains backwards compatibility so the formatters can be transitioned one at a time. Once all formatters are converted, the formatter

[PATCH] emacs: Add `notmuch-show-stash-gmane' and `notmuch-show-stash-gmane-and-go'.

2012-01-24 Thread David Edmondson
`notmuch-show-stash-gmane' stashes a URI for the current message at Gmane, presuming that Gmane has a copy of the message with the same Message-Id. `notmuch-show-stash-gmane-and-go' both stashes the message and opens the relevant page in the configured browser. Add the relevant test for

Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

2012-01-24 Thread Mark Walters
On Mon, 23 Jan 2012 21:45:21 -0500, Austin Clements amdra...@mit.edu wrote: The overall structure of this series looks great. There's obviously a lot of clean up to do, but I'll reply with a few high-level comments. Quoth Mark Walters on Jan 24 at 1:18 am: Form excluded doc_ids set and

use text properties rather than overlays

2012-01-24 Thread David Edmondson
In preparation for changes to support showing and hiding MIME parts on the fly (general parts, choosing amongst multipart/alternative and show updated signing/encryption status without redisplay) I'm trying to clean up some of the `notmuch-show-mode' code. This patch is part of that, though it

[PATCH 2/2] test: Update test to match previous patch.

2012-01-24 Thread David Edmondson
Indentation now uses tabs where possible. --- ...hread-maildir-storage-with-fourfold-indentation |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/emacs.expected-output/notmuch-show-thread-maildir-storage-with-fourfold-indentation

[PATCH 1/2] emacs: Use text properties rather than overlays in `notmuch-show-mode'.

2012-01-24 Thread David Edmondson
Except for where invisibility is involved, replace the use of overlays in `notmuch-show-mode' with text properties, which are more efficient and can be merged together more effectively. --- emacs/notmuch-show.el | 66 +++- emacs/notmuch-wash.el |8

Re: [PATCH v7 2/2] emacs: Tests for user-defined sections

2012-01-24 Thread Dmitry Kurochkin
Hi Daniel. There are some trailing whitespaces in the tests. Also, please consider moving the hello sections tests to a separate file (emacs-hello-sections, perhaps?). I am worried that test/emacs file becomes too big. And we will probably add more notmuch-hello section-related tests in the

Re: [PATCH v2 1/3] mime node: Record depth-first part numbers

2012-01-24 Thread Austin Clements
Quoth Dmitry Kurochkin on Jan 24 at 2:19 am: On Sun, 22 Jan 2012 21:31:11 -0500, Austin Clements amdra...@mit.edu wrote: This makes the part numbers readily accessible to formatters. Hierarchical part numbering would be a more natural and efficient fit for MIME and may be the way to go in

Re: [PATCH v2 3/3] show: Introduce mime_node formatter callback

2012-01-24 Thread Austin Clements
Thanks for the review. New version coming shortly (v4, since the list ate v3 while everyone was still reading v2). Quoth Dmitry Kurochkin on Jan 24 at 2:37 am: On Sun, 22 Jan 2012 21:31:13 -0500, Austin Clements amdra...@mit.edu wrote: This callback is the gateway to the new

Re: [PATCH 6/6] emacs: modify the default show-mode key bindings for archiving

2012-01-24 Thread Xavier Maillard
This is also +1 for me. /Xavier ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 3/3] emacs: Don't insert a part header if it's the first part and text/*.

2012-01-24 Thread David Edmondson
Previously this logic applied only to text/plain. Allow it for other text/* parts as well. --- emacs/notmuch-show.el |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index a0a2873..23bf1f4 100644 ---

[PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

2012-01-24 Thread David Edmondson
Instead, allow the caller to specify some parameters for the button. Rework `notmuch-show-insert-part-multipart/signed' and `notmuch-show-insert-part-multipart/encrypted' accordingly. --- emacs/notmuch-show.el | 86 +--- 1 files changed, 45

Re: [PATCH v3 0/3] emacs: notmuch-hello search cleanup

2012-01-24 Thread David Edmondson
On Tue, 24 Jan 2012 03:48:54 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Changes: v3: * rebased on current master v2: * expected results changes for tests moved from patch 2 to 1 where it belong This set look fine to me. Poor Daniel has to re-merge...

Re: [PATCH 1/4 v42] test: Don't return the result of checking for running emacs to the tester.

2012-01-24 Thread Dmitry Kurochkin
On Mon, 23 Jan 2012 18:05:44 +, David Edmondson d...@dme.org wrote: When checking for a running emacs, test_emacs evaluates the empty list '()'. This returns 'nil' when emacs is running, which is then prepended to the actual test result. Given that it is not part of the actual test output

Re: [PATCH 2/4 v42] test: Add `test_emacs_expect_t'.

2012-01-24 Thread Dmitry Kurochkin
On Mon, 23 Jan 2012 18:05:45 +, David Edmondson d...@dme.org wrote: Add a new test function to allow simpler testing of emacs functionality. `test_emacs_expect_t' takes one argument - a lisp expression to evaluate. The test passes if the expression returns `t', otherwise it fails and

Re: [PATCH 4/4 v42] test: Add address cleaning tests.

2012-01-24 Thread Dmitry Kurochkin
On Mon, 23 Jan 2012 18:05:47 +, David Edmondson d...@dme.org wrote: --- Anticipate the failure of test 3. LGTM Regards, Dmitry test/emacs-address-cleaning.el | 29 + test/emacs-address-cleaning.sh | 19 +++ test/notmuch-test

Re: [PATCH v3 0/3] emacs: notmuch-hello search cleanup

2012-01-24 Thread Austin Clements
Quoth Dmitry Kurochkin on Jan 24 at 3:48 am: Changes: v3: * rebased on current master LGTM. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 3/4 v42] test: Add more helpers for emacs tests.

2012-01-24 Thread Dmitry Kurochkin
On Mon, 23 Jan 2012 18:05:46 +, David Edmondson d...@dme.org wrote: --- Split out from the tests and re-factored. test/test-lib.el | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/test/test-lib.el b/test/test-lib.el index

Re: [PATCH 3/4 v42] test: Add more helpers for emacs tests.

2012-01-24 Thread David Edmondson
On Tue, 24 Jan 2012 19:45:18 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: 1. rename notmuch-test-compare to notmuch-test-expect-equal I'll change this. 2. move the top level equal check to the non-list branch I'd rather not change this, though I'll write some commentary to

[PATCH 0/4 v43] emacs test helpers

2012-01-24 Thread David Edmondson
Small changes as per Dmitry's last comments. David Edmondson (4): test: Don't return the result of checking for running emacs to the tester. test: Add `test_emacs_expect_t'. test: Add more helpers for emacs tests. test: Add address cleaning tests. test/README|

[PATCH 1/4 v43] test: Don't return the result of checking for running emacs to the tester.

2012-01-24 Thread David Edmondson
When checking for a running emacs, test_emacs evaluates the empty list '()'. This returns 'nil' when emacs is running, which is then prepended to the actual test result. Given that it is not part of the actual test output the test harness can incorrectly report test failure (or success). ---

[PATCH 3/4 v43] test: Add more helpers for emacs tests.

2012-01-24 Thread David Edmondson
--- test/test-lib.el | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/test/test-lib.el b/test/test-lib.el index 96752f0..bc75f06 100644 --- a/test/test-lib.el +++ b/test/test-lib.el @@ -20,6 +20,8 @@ ;; ;; Authors: Dmitry Kurochkin

[PATCH 2/4 v43] test: Add `test_emacs_expect_t'.

2012-01-24 Thread David Edmondson
Add a new test function to allow simpler testing of emacs functionality. `test_emacs_expect_t' takes one argument - a lisp expression to evaluate. The test passes if the expression returns `t', otherwise it fails and the output is reported to the tester. --- test/README |8

[PATCH 4/4 v43] test: Add address cleaning tests.

2012-01-24 Thread David Edmondson
--- test/emacs-address-cleaning.el | 29 + test/emacs-address-cleaning.sh | 19 +++ test/notmuch-test |1 + 3 files changed, 49 insertions(+), 0 deletions(-) create mode 100644 test/emacs-address-cleaning.el create mode 100755

Re: [PATCH 1/2] emacs: Use text properties rather than overlays in `notmuch-show-mode'.

2012-01-24 Thread Austin Clements
LGTM other than one very minor nit, though I pretty reliably make fence post errors when dealing with text properties, so perhaps somebody else should check that. Quoth David Edmondson on Jan 24 at 11:36 am: Except for where invisibility is involved, replace the use of overlays in

Re: [PATCH 0/4 v43] emacs test helpers

2012-01-24 Thread Dmitry Kurochkin
On Tue, 24 Jan 2012 16:14:03 +, David Edmondson d...@dme.org wrote: Small changes as per Dmitry's last comments. LGTM Regards, Dmitry David Edmondson (4): test: Don't return the result of checking for running emacs to the tester. test: Add `test_emacs_expect_t'. test:

Re: [PATCH 1/2] emacs: Use text properties rather than overlays in `notmuch-show-mode'.

2012-01-24 Thread David Edmondson
On Tue, 24 Jan 2012 11:15:11 -0500, Austin Clements amdra...@mit.edu wrote: LGTM other than one very minor nit, though I pretty reliably make fence post errors when dealing with text properties, so perhaps somebody else should check that. Quoth David Edmondson on Jan 24 at 11:36 am: Except

Re: [PATCH v5 2/2] show: Introduce mime_node formatter callback

2012-01-24 Thread Jani Nikula
On Mon, 23 Jan 2012 18:33:10 -0500, Austin Clements amdra...@mit.edu wrote: This callback is the gateway to the new mime_node_t-based formatters. This maintains backwards compatibility so the formatters can be transitioned one at a time. Once all formatters are converted, the formatter

Re: [PATCH 3/6] emacs: add message archiving functions

2012-01-24 Thread Tomi Ollila
On Mon, 23 Jan 2012 00:34:22 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: This adds two new message archiving functions that parallel the thread archiving functions: notmuch-show-archive-message{,-then-next}. The former also takes a prefix argument to unarchive the message

Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

2012-01-24 Thread Jameson Graef Rollins
On Tue, 24 Jan 2012 12:53:38 +, David Edmondson d...@dme.org wrote: Instead, allow the caller to specify some parameters for the button. Rework `notmuch-show-insert-part-multipart/signed' and `notmuch-show-insert-part-multipart/encrypted' accordingly. Hi, David. I was thinking about this,

Re: [PATCH 6/6] emacs: modify the default show-mode key bindings for archiving

2012-01-24 Thread Tomi Ollila
On Mon, 23 Jan 2012 00:34:25 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: This changes the default key bindings for the 'a' key in notmuch-show mode. Instead of archiving the entire thread, it now just archives the current message, and then advance to the next open message

Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

2012-01-24 Thread David Edmondson
On Tue, 24 Jan 2012 10:46:57 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Tue, 24 Jan 2012 12:53:38 +, David Edmondson d...@dme.org wrote: Instead, allow the caller to specify some parameters for the button. Rework `notmuch-show-insert-part-multipart/signed' and

Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

2012-01-24 Thread Tomi Ollila
On Tue, 24 Jan 2012 12:53:38 +, David Edmondson d...@dme.org wrote: Instead, allow the caller to specify some parameters for the button. Rework `notmuch-show-insert-part-multipart/signed' and `notmuch-show-insert-part-multipart/encrypted' accordingly. --- LGTM.

Re: [PATCH 2/3] emacs: Optionally hide some part headers.

2012-01-24 Thread Tomi Ollila
On Tue, 24 Jan 2012 12:53:39 +, David Edmondson d...@dme.org wrote: Add a regexp, `notmuch-show-part-headers-hidden' and if the content-type of a part matches, don't show the part header. --- LGTM... (I wonder ow easy is it to write regexps in custimization interface)

Re: [PATCH 3/3] emacs: Don't insert a part header if it's the first part and text/*.

2012-01-24 Thread Tomi Ollila
On Tue, 24 Jan 2012 12:53:40 +, David Edmondson d...@dme.org wrote: Previously this logic applied only to text/plain. Allow it for other text/* parts as well. --- LGTM. ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

2012-01-24 Thread Jameson Graef Rollins
On Tue, 24 Jan 2012 19:25:19 +, David Edmondson d...@dme.org wrote: On Tue, 24 Jan 2012 10:46:57 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: Is there a reason it's really necessary to make this change? Can't callers just ignore the returned button if they don't care

Re: [PATCH 0/4 v43] emacs test helpers

2012-01-24 Thread Tomi Ollila
On Tue, 24 Jan 2012 16:14:03 +, David Edmondson d...@dme.org wrote: Small changes as per Dmitry's last comments. David Edmondson (4): test: Don't return the result of checking for running emacs to the tester. test: Add `test_emacs_expect_t'. test: Add more helpers for emacs

[PATCH] uncrustify.cfg: label indent, some known types, not, # and ##

2012-01-24 Thread Tomi Ollila
Adjusted some uncrustify variables to get closer to prevailing style: * Label indent (for goto) relative to current indentation. * Eegistered GMimeObject and mime_node_t being as types. * Space after ! (not) operator. * No space after 'stringify' (#) preprosessor token. * No spacing change around

Re: Emacs: Crypto: How to get automatic encryption?

2012-01-24 Thread micah anderson
On Tue, 17 Jan 2012 09:19:51 +, David Edmondson d...@dme.org wrote: On Mon, 16 Jan 2012 23:48:30 -0500, Antoine Beaupré anar...@anarcat.ath.cx wrote: Jumping in here, I have modified the previously posted code here to provide me with a more complete solution. This looks good. I'll

[no subject]

2012-01-24 Thread Jameson Graef Rollins
Final v3 rework of this patch series: * reworked pop-at-end patch to be much simpler (which also happens to get around other issues with this patch that dme had) * added pop-at-end function to both show-next-...message functions * fixed call to search-next-thread in show-next-thread function *

[PATCH v3 4/8] emacs: add message archiving functions

2012-01-24 Thread Jameson Graef Rollins
This adds two new message archiving functions that parallel the thread archiving functions: notmuch-show-archive-message{,-then-next}. The former also takes a prefix argument to unarchive the message (ie. put back in inbox). --- emacs/notmuch-show.el | 17 + 1 files changed, 17

Re: ignore folders patch?

2012-01-24 Thread Pieter Praet
On Sun, 22 Jan 2012 12:32:12 +0100, Fabio Zanini fabio.zan...@fastmail.fm wrote: Hi! This is my first message to the list. In 2010 a patch was developed that enabled notmuch new to ignore certain subdirectories of the mail folder: http://notmuchmail.org/pipermail/notmuch/2010/003170.html

[PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility

2012-01-24 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-open-or-close-all): Rename to `notmuch-show-toggle-all-messages', and make it toggle visibility of all messages based on the visibility of the current message, instead of setting visibility based on whether or not a prefix arg was supplied. Same

Re: [PATCH 1/3] emacs: Don't return the button from `notmuch-show-insert-part-header'.

2012-01-24 Thread David Edmondson
On Tue, 24 Jan 2012 11:52:09 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Tue, 24 Jan 2012 19:25:19 +, David Edmondson d...@dme.org wrote: On Tue, 24 Jan 2012 10:46:57 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: Is there a reason it's really

Re: Emacs: Crypto: How to get automatic encryption?

2012-01-24 Thread David Edmondson
On Tue, 24 Jan 2012 16:10:47 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Tue, 24 Jan 2012 16:34:32 -0500, micah anderson mi...@riseup.net wrote: David replied to it because it was sent to him, but the list email hasn't come through yet (I want this functionality, so I'm

Re: [PATCH 0/3] Configuration file option to exclude files/directories

2012-01-24 Thread David Edmondson
On Thu, 08 Dec 2011 11:05:50 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: On Wed, 07 Dec 2011 19:51:32 -0400, David Bremner da...@tethera.net wrote: On Wed, 14 Sep 2011 00:32:01 +0300, tomi.oll...@iki.fi wrote: This patch set adds a configuration option 'database.exclude'; a list of

Re: [PATCH] emacs: Add `notmuch-show-stash-gmane' and `notmuch-show-stash-gmane-and-go'.

2012-01-24 Thread David Edmondson
On Wed, 25 Jan 2012 01:50:08 +0100, Pieter Praet pie...@praet.org wrote: In a perfect world, everyone would be using Notmuch and have a local copy of every message ever sent to any ML. While we're waiting for Atlantis to resurface, we'll need an interim solution. +1 for the idea, but Gmane

Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility

2012-01-24 Thread David Edmondson
On Wed, 25 Jan 2012 06:25:39 +0100, Pieter Praet pie...@praet.org wrote: * emacs/notmuch-show.el (notmuch-show-open-or-close-all): Rename to `notmuch-show-toggle-all-messages', and make it toggle visibility of all messages based on the visibility of the current message, instead of

[PATCH v5 1/2] mime node: Record depth-first part numbers

2012-01-24 Thread Dmitry Kurochkin
On Mon, 23 Jan 2012 18:33:09 -0500, Austin Clements wrote: > This makes the part numbers readily accessible to formatters. > Hierarchical part numbering would be a more natural and efficient fit > for MIME and may be the way to go in the future, but depth-first > numbering maintains compatibility

[PATCH v5 2/2] show: Introduce mime_node formatter callback

2012-01-24 Thread Dmitry Kurochkin
On Mon, 23 Jan 2012 18:33:10 -0500, Austin Clements wrote: > This callback is the gateway to the new mime_node_t-based formatters. > This maintains backwards compatibility so the formatters can be > transitioned one at a time. Once all formatters are converted, the > formatter structure can be

[PATCH v3 0/3] emacs: notmuch-hello search cleanup

2012-01-24 Thread Dmitry Kurochkin
Changes: v3: * rebased on current master v2: * expected results changes for tests moved from patch 2 to 1 where it belong Regards, Dmitry

[PATCH v3 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer

2012-01-24 Thread Dmitry Kurochkin
Before the change, "s" in notmuch-hello buffer would jump to the search box. The patch changes the binding to `notmuch-search' which is consistent with all other notmuch buffers. --- emacs/notmuch-hello.el | 19 ++-

[PATCH v3 2/3] emacs: use a single history for all searches

2012-01-24 Thread Dmitry Kurochkin
There are two ways to do search in Emacs UI: search widget in notmuch-hello buffer and `notmuch-search' function bound to "s". Before the change, these search mechanisms used different history lists. The patch makes notmuch-hello search use the same history list as `notmuch-search' function. ---

[PATCH v3 3/3] emacs: bind "s" to `notmuch-hello-search' in notmuch-hello buffer

2012-01-24 Thread Dmitry Kurochkin
`notmuch-hello-search' uses `notmuch-search' function but refreshes notmuch-hello buffer when the search buffer is closed. --- emacs/notmuch-hello.el |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 004287a..64011d4

[PATCH] Automatically exclude tags in notmuch-show

2012-01-24 Thread Mark Walters
On Sun, 22 Jan 2012 20:52:22 -0500, Austin Clements wrote: > Quoth Mark Walters on Jan 23 at 1:13 am: > > On Sun, 22 Jan 2012 13:16:09 -0500, Austin Clements > > wrote: > > > Quoth myself on Jan 20 at 12:18 pm: > > > > Quoth Mark Walters on Jan 20 at 12:10 am: > > > > > > > > > > Ok Having

[RFC PATCH 1/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

2012-01-24 Thread Mark Walters
Slightly refactor the exclude code to give the callers access to the exclude query itself. There should be no functional change. --- lib/query.cc | 29 +++-- 1 files changed, 19 insertions(+), 10 deletions(-) diff --git a/lib/query.cc b/lib/query.cc index

[RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

2012-01-24 Thread Mark Walters
Form excluded doc_ids set and use that to exclude messages. Should be no functional change. --- lib/notmuch-private.h |1 + lib/query.cc | 28 ++-- 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h

[RFC PATCH 3/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

2012-01-24 Thread Mark Walters
Add the actual NOTMUCH_MESSAGE_FLAG_EXCLUDED flag. --- lib/notmuch-private.h |1 + lib/notmuch.h |3 ++- lib/query.cc | 11 +++ lib/thread.cc | 14 ++ 4 files changed, 20 insertions(+), 9 deletions(-) diff --git a/lib/notmuch-private.h

[RFC PATCH 4/5] show: Convert text format to the new self-recursive style

2012-01-24 Thread Dmitry Kurochkin
On Wed, 11 Jan 2012 20:49:32 -0500, Austin Clements wrote: > This is all code movement and a smidgen of glue. This moves the > existing text formatter code into one self-recursive function, but > doesn't change any of the logic. The next patch will actually take > advantage of what the new

[RFC PATCH 5/5] show: Simplify new text formatter code

2012-01-24 Thread Dmitry Kurochkin
On Wed, 11 Jan 2012 20:49:33 -0500, Austin Clements wrote: > This makes the text formatter take advantage of the new code > structure. The previously duplicated header logic is now unified, > several things that we used to compute repeatedly across different > callbacks are now computed once,

[PATCH v5 1/2] mime node: Record depth-first part numbers

2012-01-24 Thread Tomi Ollila
On Mon, 23 Jan 2012 18:33:09 -0500, Austin Clements wrote: > This makes the part numbers readily accessible to formatters. > Hierarchical part numbering would be a more natural and efficient fit > for MIME and may be the way to go in the future, but depth-first > numbering maintains compatibility

[PATCH v5 2/2] show: Introduce mime_node formatter callback

2012-01-24 Thread Tomi Ollila
On Mon, 23 Jan 2012 18:33:10 -0500, Austin Clements wrote: > This callback is the gateway to the new mime_node_t-based formatters. > This maintains backwards compatibility so the formatters can be > transitioned one at a time. Once all formatters are converted, the > formatter structure can be

[PATCH] emacs: Add `notmuch-show-stash-gmane' and `notmuch-show-stash-gmane-and-go'.

2012-01-24 Thread David Edmondson
`notmuch-show-stash-gmane' stashes a URI for the current message at Gmane, presuming that Gmane has a copy of the message with the same Message-Id. `notmuch-show-stash-gmane-and-go' both stashes the message and opens the relevant page in the configured browser. Add the relevant test for

[RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

2012-01-24 Thread Mark Walters
On Mon, 23 Jan 2012 21:45:21 -0500, Austin Clements wrote: > The overall structure of this series looks great. There's obviously a > lot of clean up to do, but I'll reply with a few high-level comments. > > Quoth Mark Walters on Jan 24 at 1:18 am: > > Form excluded doc_ids set and use that to

use text properties rather than overlays

2012-01-24 Thread David Edmondson
In preparation for changes to support showing and hiding MIME parts on the fly (general parts, choosing amongst multipart/alternative and show updated signing/encryption status without redisplay) I'm trying to clean up some of the `notmuch-show-mode' code. This patch is part of that, though it

[PATCH 2/2] test: Update test to match previous patch.

2012-01-24 Thread David Edmondson
Indentation now uses tabs where possible. --- ...hread-maildir-storage-with-fourfold-indentation |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/emacs.expected-output/notmuch-show-thread-maildir-storage-with-fourfold-indentation

  1   2   >