Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other toggles

2012-01-30 Thread David Edmondson
On Sun, 29 Jan 2012 12:06:57 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: My inclination is to remove `notmuch-crypto-process-mime' altogether (declared it an obsolete variable) and allow users to set a default for `notmuch-show-process-crypto' directly, but that is not

Re: Bug: emacs 23.2 doesn't like ido-completing-read

2012-01-30 Thread David Edmondson
On Sun, 29 Jan 2012 23:17:55 +, Mark Walters markwalters1...@gmail.com wrote: I have been experimenting with notmuch-always-prompt-for-sender on my debian stable setup (emacs 23.2.1) and it doesn't like ido-completing-read. It goes to the minibuffer and then it seems to be impossible to

[PATCH 1/2 v2] emacs: Stop the `truncate-string-to-width' madness.

2012-01-30 Thread David Edmondson
There's no need to call `truncate-string-to-width' twice in this code path. --- emacs/notmuch.el | 22 ++ 1 files changed, 10 insertions(+), 12 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 72f78ed..d4d6904 100644 --- a/emacs/notmuch.el +++

Re: [PATCH 0/2 v2] minor cleanup and improvements

2012-01-30 Thread David Edmondson
Oops. That should be 'v3'. I need a bunch of automation to make posting patches simpler. pgpkwFC77M8DY.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/3 v2] emacs: Rework crypto switch toggle.

2012-01-30 Thread David Edmondson
Re-work the existing crypto switch toggle to be based on a persistant buffer-local variable. To allow this, modify `notmuch-show-refresh-view' to erase and re-draw in the current buffer rather than killing the current buffer and creating a new one. (This will also allow more per-buffer behaviour

[PATCH 1/2] test: add test for hiding Original Message region at beginning of a message

2012-01-30 Thread Dmitry Kurochkin
The test is currently broken and will be fixed by a subsequent patch. The patch adds a new file for tests of Emacs notmuch-show view. Based on patch by David Edmondson [1]. [1] id:1327562380-12894-4-git-send-email-...@dme.org --- test/emacs-show | 28

[PATCH 2/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

2012-01-30 Thread Dmitry Kurochkin
`Notmuch-wash-region-to-button' is the function that creates hidden regions with buttons for signatures, citations and original messages. Before the change, it did not work correctly if the to-be-hidden region started at the beginning of a message: the visibility toggle button was hidden as well.

Re: [PATCH 0/4 v3] more care when hiding regions with buttons

2012-01-30 Thread Dmitry Kurochkin
Hi David. Here is my attempt to fix the issue in a cleaner way: id:1327926286-16680-1-git-send-email-dmitry.kuroch...@gmail.com Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] lib: update notmuch_tags_get examle to reflect api change

2012-01-30 Thread Allan Wind
The function notmuch_database_find_message_by_filename now requires a notmuch_message_t and returns a notmuch_status_t. This change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2, version 0.9. --- lib/notmuch.h | 21 +++-- 1 files changed, 11 insertions(+), 10

Re: [PATCH] lib: update notmuch_tags_get examle to reflect api change

2012-01-30 Thread Allan Wind
Ignore this one. /Allan -- Allan Wind Life Integrity, LLC http://lifeintegrity.com ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] lib: update notmuch_tags_get examle to reflect api change

2012-01-30 Thread Tomi Ollila
On Mon, 30 Jan 2012 09:02:33 -0500, Allan Wind allan_w...@lifeintegrity.com wrote: The function notmuch_database_find_message_by_filename now requires a notmuch_message_t and returns a notmuch_status_t. This change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2, version 0.9.

[PATCH] lib: update notmuch_tags_get examle to reflect api change

2012-01-30 Thread Allan Wind
The function notmuch_database_find_message_by_filename now requires a notmuch_message_t and returns a notmuch_status_t. This change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2, version 0.9. --- lib/notmuch.h | 21 +++-- 1 files changed, 11 insertions(+), 10

Re: [PATCH 2/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

2012-01-30 Thread Tomi Ollila
On Mon, 30 Jan 2012 16:24:46 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: `Notmuch-wash-region-to-button' is the function that creates hidden regions with buttons for signatures, citations and original messages. Before the change, it did not work correctly if the to-be-hidden

Re: [PATCH] STYLE: Initial draft of coding style document

2012-01-30 Thread Tomi Ollila
On Fri, 27 Jan 2012 19:46:58 -0400, David Bremner da...@tethera.net wrote: From: David Bremner brem...@debian.org [ ... ] + +* Indent is 4 spaces with mixed tabs/spaces and a tab width of 8. + Tabs should be only at the beginning of the line. So, after initial indentation (with tabs) there

Re: [PATCH 2/2] show: Simplify new text formatter code

2012-01-30 Thread Tomi Ollila
On Thu, 26 Jan 2012 01:55:26 -0500, Austin Clements amdra...@mit.edu wrote: This makes the text formatter take advantage of the new code structure. The previously duplicated header logic is now unified, several things that we used to compute repeatedly across different callbacks are now

Re: [PATCH] emacs: More address cleaning.

2012-01-30 Thread Austin Clements
loop freaks me out a little, but LGTM. Quoth David Edmondson on Jan 30 at 2:59 pm: Remove outer single-quotes from the mailbox part. Allow for multiple sets of nested single and double quotes. Add more tests. --- emacs/notmuch-show.el | 24 +---

Re: [PATCH] moved _config_(get|set)_list () functions earlyer in the file

2012-01-30 Thread Austin Clements
s/earlyer/earlier/, but unless someone feels strongly about that, I don't think we need another version of this trivial patch. Quoth Tomi Ollila on Jan 30 at 12:31 pm: Moved static functions _config_get_list () and _config_set_list () closer to the beginning of file so that their definition is

Re: emacs: more flexible and consistent tagging operations

2012-01-30 Thread Austin Clements
The whole series LGTM. Quoth Dmitry Kurochkin on Jan 30 at 9:33 am: Changes: v3: * merged 3 `notmuch-show-tag-all'-related patches into one * add patch to clean up tagging function argument names * fix other comments from Austin's reviews [5,6] v2: * add patch to remove No

Re: emacs: more flexible and consistent tagging operations

2012-01-30 Thread Tomi Ollila
Works fine. +1 Tomi ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles

2012-01-30 Thread David Edmondson
v3: - Add a toggle for line truncation (). - Retain the state of a show buffer across a call to refresh (which includes the various toggles here). David Edmondson (5): emacs: Rework crypto switch toggle. emacs: Allow `notmuch-show-mode' to display only matching messages. emacs: Allow

[PATCH 2/5] emacs: Allow `notmuch-show-mode' to display only matching messages.

2012-01-30 Thread David Edmondson
The current behaviour (all messages shown, non-matching collapsed) is retained as the default. Type '!' to switch to showing only the matching messages - non-matching messages are not available. '!' will switch back to showing everything. --- emacs/notmuch-show.el | 18 +- 1

[PATCH 4/5] emacs: Add a binding () to toggle the truncation of long lines.

2012-01-30 Thread David Edmondson
--- emacs/notmuch-show.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index a2c4daf..8b07adf 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -1114,6 +1114,7 @@ Refreshes the current view, observing

[PATCH 5/5] emacs: Retain the state of the buffer during `notmuch-show-refresh-view'.

2012-01-30 Thread David Edmondson
Record the state of the buffer during `notmuch-show-refresh-view'. In this context, state is defined as: - the open/closed state of each message, - the current message. --- emacs/notmuch-show.el | 41 + 1 files changed, 37 insertions(+), 4 deletions(-)

[PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

2012-01-30 Thread David Edmondson
The blank line doesn't really change position, but is now considered to be part of the body rather than part of the headers. This means that it is visible when the body is visible rather than when the headers are visible. --- I'm interested in getting feedback on this. Unless you run with

Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles

2012-01-30 Thread Tomi Ollila
On Mon, 30 Jan 2012 16:30:59 +, David Edmondson d...@dme.org wrote: v3: - Add a toggle for line truncation (). - Retain the state of a show buffer across a call to refresh (which includes the various toggles here). Applied and tested -- patches 2-5 works fine -- I currently don't

Re: [PATCH 4/5] emacs: Add a binding () to toggle the truncation of long lines.

2012-01-30 Thread Jani Nikula
On Jan 30, 2012 6:31 PM, David Edmondson d...@dme.org wrote: --- emacs/notmuch-show.el |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index a2c4daf..8b07adf 100644 --- a/emacs/notmuch-show.el +++

Re: [PATCH 2/2] emacs: new mua mailto: URI handler

2012-01-30 Thread Jameson Graef Rollins
On Mon, 30 Jan 2012 15:43:10 +, David Edmondson d...@dme.org wrote: On Sun, 29 Jan 2012 11:33:44 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: The new function 'notmuch-mua-mailto' provides an interactive handler for rfc6068 mailto:; URIs. It attempts to implement the

Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other toggles

2012-01-30 Thread Jameson Graef Rollins
On Mon, 30 Jan 2012 11:26:32 +, David Edmondson d...@dme.org wrote: The simplest approach is to have `notmuch-show-process-crypto' inherit the value of `notmuch-crypto-process-mime' when any `notmuch-show-mode' buffers are first created. Currently that happens in only one place

Re: [PATCH 5/5] emacs: Retain the state of the buffer during `notmuch-show-refresh-view'.

2012-01-30 Thread Mark Walters
On Mon, 30 Jan 2012 16:31:04 +, David Edmondson d...@dme.org wrote: Record the state of the buffer during `notmuch-show-refresh-view'. In this context, state is defined as: - the open/closed state of each message, - the current message. This looks great! I have two very minor queries

[PATCH] lib: update notmuch_tags_get example to reflect api change

2012-01-30 Thread Allan Wind
The function notmuch_database_find_message_by_filename now requires a notmuch_message_t and returns a notmuch_status_t. This change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2, version 0.9. --- lib/notmuch.h | 21 +++-- 1 files changed, 11 insertions(+), 10

Re: Bug?: notmuch-search-show-thread shows several threads; only one containing matching messages

2012-01-30 Thread Mark Walters
On Mon, 30 Jan 2012 20:04:25 +0100, Gregor Zattler telegr...@gmx.net wrote: Hi Pieter, * Pieter Praet pie...@praet.org [30. Jan. 2012]: On Mon, 30 Jan 2012 00:42:14 +0100, Gregor Zattler telegr...@gmx.net wrote: * Pieter Praet pie...@praet.org [26. Jan. 2012]: On Thu, 26 Jan 2012

[PATCH 1/2] test: remove Generate some messages test from raw

2012-01-30 Thread Dmitry Kurochkin
Before the change, the first subtest in raw format tests just generated messages and checked that they are added successfully. This is not really a raw format test, it is creating of environment required for other subtests to run. The patch removes the first subtest from raw and replaces it with

[PATCH 2/2] test: use subtest name for generated message subject by default

2012-01-30 Thread Dmitry Kurochkin
Before the change, messages generated by generate_message() used Test message #N for default subject where N is the generated messages counter. Since message subject is commonly present in expected results, there is a chance of breaking other tests when a new generate_message() call is added.

Re: [PATCH] lib: update notmuch_tags_get example to reflect api change

2012-01-30 Thread Allan Wind
On 2012-01-30 17:42:01, Austin Clements wrote: Sorry, I replied to the wrong one. This one LGTM. (BTW, for future reference, it's helpful if you send later versions in reply to the first version so that they're grouped in threads. Sorry that the documentation on notmuch's coding

Re: Bug?: notmuch-search-show-thread shows several threads; only one containing matching messages

2012-01-30 Thread Mark Walters
On Mon, 30 Jan 2012 23:34:16 +0100, Gregor Zattler telegr...@gmx.net wrote: Hi Mark, * Mark Walters markwalters1...@gmail.com [30. Jan. 2012]: On Mon, 30 Jan 2012 20:04:25 +0100, Gregor Zattler telegr...@gmx.net wrote: * Pieter Praet pie...@praet.org [30. Jan. 2012]: On Mon, 30 Jan 2012

Re:

2012-01-30 Thread David Bremner
On Tue, 24 Jan 2012 16:06:15 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: Final v3 rework of this patch series: pushed. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/7] cli: add --do-not-exclude option to count and search.

2012-01-30 Thread Austin Clements
Quoth Mark Walters on Jan 29 at 6:39 pm: This option turns off the exclusion so all matching messages are returned. We do not need to add this to show as notmuch-show does not (yet) exclude. --- notmuch-count.c | 12 notmuch-search.c | 12 2 files changed,

Re: [PATCH 3/7] lib: Make notmuch_query_search_messages set the exclude flag

2012-01-30 Thread Austin Clements
Quoth Mark Walters on Jan 29 at 6:39 pm: Add a flag NOTMUCH_MESSAGE_FLAG_EXCLUDED which is set by notmuch_query_search_messages for excluded messages. Also add an option omit_excluded_messages to the search that we do not want the excludes at all. This exclude flag will be added to

Re: [PATCH 4/7] lib: Add the exclude flag to notmuch_query_search_threads

2012-01-30 Thread Austin Clements
Quoth Mark Walters on Jan 29 at 6:39 pm: Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to notmuch_query_search_threads. Implemented by inspecting the tags directly in _notmuch_thread_create/_thread_add_message rather than as a Xapian query for speed reasons. --- lib/notmuch-private.h | 16

[PATCH v4 02/12] emacs: remove text properties from `notmuch-search-get-tags' result

2012-01-30 Thread Dmitry Kurochkin
--- emacs/notmuch.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 84d7d0a..ff46617 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -577,7 +577,7 @@ the messages that were tagged (let ((beg (+ (point) 1)))

[PATCH v4 07/12] emacs: add * binding for notmuch-show view

2012-01-30 Thread Dmitry Kurochkin
The patch adds `notmuch-show-tag-all' function bound to * in notmuch-show view. The function is similar to the `notmuch-search-tag-all' function for the notmuch-search view: it changes tags for all messages in the current thread. --- emacs/notmuch-show.el | 35

Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

2012-01-30 Thread Austin Clements
This is looking really good. I think this overall approach is significantly better than the initial exclude support and the UI aspects look like they should be much more pleasant. Quoth Mark Walters on Jan 29 at 6:36 pm: Ok I now have a patch set which might be complete enough to be worth

[PATCH 1/6] emacs: move tag format validation to `notmuch-tag' function

2012-01-30 Thread Dmitry Kurochkin
Hi Austin. On Sun, 29 Jan 2012 16:34:27 -0500, Austin Clements wrote: > One philosophical nit below, but not enough to hold this up. > > Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: > > Before the change, tag format validation was done in > > `notmuch-search-operate-all' function only. The

[PATCH 4/6] test: fix emacs tests after tagging operations changes

2012-01-30 Thread Dmitry Kurochkin
On Sun, 29 Jan 2012 17:58:41 -0500, Austin Clements wrote: > Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: > > After the recent tagging operations changes, functions bound to "+" > > and "-" in notmuch-search and notmuch-show views always read input > > from the minibuffer. Use kbd macros

[PATCH 1/6] emacs: move tag format validation to `notmuch-tag' function

2012-01-30 Thread Dmitry Kurochkin
On Sun, 29 Jan 2012 18:16:50 -0500, Austin Clements wrote: > Quoth Dmitry Kurochkin on Jan 30 at 2:54 am: > > Hi Austin. > > > > On Sun, 29 Jan 2012 16:34:27 -0500, Austin Clements > > wrote: > > > One philosophical nit below, but not enough to hold this up. > > > > > > Quoth Dmitry

Bug?: notmuch-search-show-thread shows several threads; only one containing matching messages

2012-01-30 Thread Gregor Zattler
Hi Jani, notmuch developers, executive summary: notmuch almangamates several e-mail threads into one notmuch-thread, I consider this a bug: * Jani Nikula [26. Jan. 2012]: > On Thu, 26 Jan 2012 13:44:50 +0100, Gregor Zattler > wrote: >> * Jameson Graef Rollins [25. Jan. 2012]: >>> On Wed, 25

Bug?: notmuch-search-show-thread shows several threads; only one containing matching messages

2012-01-30 Thread Gregor Zattler
Hi Pieter, notmuch developers * Pieter Praet [26. Jan. 2012]: > On Thu, 26 Jan 2012 13:44:50 +0100, Gregor Zattler > wrote: >>|> [2] grep -I "^Message-Id:" /tmp/thread-I-m-interested-in.mbox |sed -e >> "s/Message-Id: $//" >really.mid >>|> grep -I -F really.mid rest.mbox >>|>

[PATCH 3/6] emacs: make "+" and "-" tagging operations more robust

2012-01-30 Thread Dmitry Kurochkin
Hi Austin. The below changes will be send as v2 soon. On Sun, 29 Jan 2012 17:57:10 -0500, Austin Clements wrote: > I'm looking forward to having this. I think it'll streamline tagging > operations. > > Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: > > Before the change, "+" and "-" tagging

[PATCH 6/6] emacs: separate history for operations which accept single and multiple tags

2012-01-30 Thread Dmitry Kurochkin
On Sun, 29 Jan 2012 18:02:29 -0500, Austin Clements wrote: > Quoth Dmitry Kurochkin on Jan 28 at 8:41 am: > > Some tag-related operations accept a single tag without prefix > > (`notmuch-select-tag-with-completion'), others accept multiple tags > > prefixed with '+' or '-'

[PATCH 8/6] emacs: use message ids instead of thread id in `notmuch-show-operate-all'

2012-01-30 Thread Dmitry Kurochkin
EOn Sun, 29 Jan 2012 18:11:20 -0500, Austin Clements wrote: > Eighth in the increasingly inaccurately named six patch series... > > Quoth Dmitry Kurochkin on Jan 28 at 9:59 am: > > Before the change, `notmuch-show-operate-all' used thread id for > > "notmuch tag" search. This could result in

[PATCH v2 00/13] emacs: more robust and consistent tagging operations

2012-01-30 Thread Dmitry Kurochkin
Changes in v2: * add patch to remove "No tags given" error from `notmuch-tag' as suggested by Austin in [1] * split patch 3 in two (search and show) for easier review * add patch with NEWS entry * rename `notmuch-{search,show}-operate-all' to `notmuch-{search,show}-tag-all' * fix other

[PATCH v2 01/13] emacs: move tag format validation to `notmuch-tag' function

2012-01-30 Thread Dmitry Kurochkin
Before the change, tag format validation was done in `notmuch-search-operate-all' function only. The patch moves it down to `notmuch-tag', so that all users of that function get input validation. --- emacs/notmuch.el | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff

[PATCH v2 02/13] emacs: remove text properties from `notmuch-search-get-tags' result

2012-01-30 Thread Dmitry Kurochkin
--- emacs/notmuch.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 84d7d0a..ff46617 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -577,7 +577,7 @@ the messages that were tagged" (let ((beg (+ (point) 1)))

[PATCH v2 04/13] emacs: make "+" and "-" tagging operations in notmuch-show more robust

2012-01-30 Thread Dmitry Kurochkin
Before the change, "+" and "-" tagging operations in notmuch-show view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function, which allows to enter multiple tags with "+" and "-" prefixes. So after the change, "+" and "-" bindings in

[PATCH v2 03/13] emacs: make "+" and "-" tagging operations in notmuch-search more robust

2012-01-30 Thread Dmitry Kurochkin
Before the change, "+" and "-" tagging operations in notmuch-search view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function (renamed `notmuch-select-tags-with-completion'), which allows to enter multiple tags with "+" and "-" prefixes. So

[PATCH v2 05/13] test: fix emacs tests after tagging operations changes

2012-01-30 Thread Dmitry Kurochkin
After the recent tagging operations changes, functions bound to "+" and "-" in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly. --- test/emacs | 20 ++-- 1 files changed, 10 insertions(+), 10

[PATCH v2 06/13] emacs: rename `notmuch-search-operate-all' to `notmuch-search-tag-all'

2012-01-30 Thread Dmitry Kurochkin
`Notmuch-search-tag-all' is more clear and consistent with other tagging function names. --- emacs/notmuch.el |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 90b594c..90627dc 100644 --- a/emacs/notmuch.el +++

[PATCH v2 07/13] emacs: add "*" binding for notmuch-show view

2012-01-30 Thread Dmitry Kurochkin
The patch adds `notmuch-show-tag-all' function bound to "*" in notmuch-show view. The function is similar to the `notmuch-search-tag-all' function for the notmuch-search view: it changes tags for all messages in the current thread. --- emacs/notmuch-show.el | 15 +++ 1 files

[PATCH v2 08/13] emacs: separate history for operations which accept single and multiple tags

2012-01-30 Thread Dmitry Kurochkin
Some tag-related operations accept a single tag without prefix (`notmuch-select-tag-with-completion'), others accept multiple tags prefixed with '+' or '-' (`notmuch-read-tag-changes'). Before the change, both functions used a single default minibuffer history. This is inconvenient because you

[PATCH v2 09/13] emacs: relax tag syntax check in `notmuch-tag' function

2012-01-30 Thread Dmitry Kurochkin
The tag syntax check in `notmuch-tag' function was too strict and did not allow nmbug tags with "::". Since the check is done for all tagging operations in Emacs UI, this basically means that no nmbug tags can be changed. The patch relaxes the tag syntax check to allow any tag names that do not

[PATCH v2 10/13] emacs: use message ids instead of thread id in `notmuch-show-operate-all'

2012-01-30 Thread Dmitry Kurochkin
Before the change, `notmuch-show-operate-all' used thread id for "notmuch tag" search. This could result in tagging unexpected messages that were added to the thread after the notmuch-show buffer was created. The patch changes `notmuch-show-operate-all' to use ids of shown messages to fix this.

[PATCH v2 11/13] emacs: code cleanup in `notmuch-show-operate-all', no functional changes

2012-01-30 Thread Dmitry Kurochkin
Use `notmuch-show-mapc' function instead of a custom `loop'. --- emacs/notmuch-show.el | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index b115a8f..69381ac 100644 --- a/emacs/notmuch-show.el +++

[PATCH v2 12/13] emacs: accept empty tag list in `notmuch-tag'

2012-01-30 Thread Dmitry Kurochkin
Since `notmuch-tag' is a non-interactive function and hence is meant to be invoked programmatically, it should accept zero tags. Also, the tagging operations (bound to "*", "+", "-") would accept empty input without an error. --- emacs/notmuch.el | 10 +- 1 files changed, 5

[PATCH v2 13/13] NEWS: document Emacs UI tagging operations changes

2012-01-30 Thread Dmitry Kurochkin
--- NEWS | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 2acdce5..dc3acc4 100644 --- a/NEWS +++ b/NEWS @@ -39,6 +39,24 @@ Reply to sender and search modes, 'r' has been bound to reply to sender, replacing reply to all, which now

[PATCH v2 13/13] NEWS: document Emacs UI tagging operations changes

2012-01-30 Thread Austin Clements
Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: > --- > NEWS | 18 ++ > 1 files changed, 18 insertions(+), 0 deletions(-) > > diff --git a/NEWS b/NEWS > index 2acdce5..dc3acc4 100644 > --- a/NEWS > +++ b/NEWS > @@ -39,6 +39,24 @@ Reply to sender >and search modes, 'r' has

[PATCH v2 03/13] emacs: make "+" and "-" tagging operations in notmuch-search more robust

2012-01-30 Thread Dmitry Kurochkin
On Sun, 29 Jan 2012 23:48:06 -0500, Austin Clements wrote: > Looking good. Just a few small points below. > > Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: > > Before the change, "+" and "-" tagging operations in notmuch-search > > view accepted only a single tag. The patch makes them use the

[PATCH v2 13/13] NEWS: document Emacs UI tagging operations changes

2012-01-30 Thread Dmitry Kurochkin
On Mon, 30 Jan 2012 00:04:02 -0500, Austin Clements wrote: > Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: > > --- > > NEWS | 18 ++ > > 1 files changed, 18 insertions(+), 0 deletions(-) > > > > diff --git a/NEWS b/NEWS > > index 2acdce5..dc3acc4 100644 > > --- a/NEWS > > +++

[PATCH v2 10/13] emacs: use message ids instead of thread id in `notmuch-show-operate-all'

2012-01-30 Thread Dmitry Kurochkin
On Sun, 29 Jan 2012 23:57:09 -0500, Austin Clements wrote: > Quoth Dmitry Kurochkin on Jan 30 at 6:26 am: > > Before the change, `notmuch-show-operate-all' used thread id for > > notmuch-show-tag-all? > ouch > > "notmuch tag" search. This could result in tagging unexpected > > messages that

emacs: more flexible and consistent tagging operations

2012-01-30 Thread Dmitry Kurochkin
Changes: v3: * merged 3 `notmuch-show-tag-all'-related patches into one * add patch to clean up tagging function argument names * fix other comments from Austin's reviews [5,6] v2: * add patch to remove "No tags given" error from `notmuch-tag' as suggested by Austin in [1] * split patch 3

[PATCH v3 01/12] emacs: move tag format validation to `notmuch-tag' function

2012-01-30 Thread Dmitry Kurochkin
Before the change, tag format validation was done in `notmuch-search-operate-all' function only. The patch moves it down to `notmuch-tag', so that all users of that function get input validation. --- emacs/notmuch.el | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff

[PATCH v3 02/12] emacs: remove text properties from `notmuch-search-get-tags' result

2012-01-30 Thread Dmitry Kurochkin
--- emacs/notmuch.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 84d7d0a..ff46617 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -577,7 +577,7 @@ the messages that were tagged" (let ((beg (+ (point) 1)))

[PATCH v3 04/12] emacs: make "+" and "-" tagging operations in notmuch-show more flexible

2012-01-30 Thread Dmitry Kurochkin
Before the change, "+" and "-" tagging operations in notmuch-show view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function, which allows to enter multiple tags with "+" and "-" prefixes. So after the change, "+" and "-" bindings in

[PATCH v3 03/12] emacs: make "+" and "-" tagging operations in notmuch-search more flexible

2012-01-30 Thread Dmitry Kurochkin
Before the change, "+" and "-" tagging operations in notmuch-search view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function (renamed `notmuch-select-tags-with-completion'), which allows to enter multiple tags with "+" and "-" prefixes. So

[PATCH v3 05/12] test: fix emacs tests after tagging operations changes

2012-01-30 Thread Dmitry Kurochkin
After the recent tagging operations changes, functions bound to "+" and "-" in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly. --- test/emacs | 20 ++-- 1 files changed, 10 insertions(+), 10

[PATCH v3 06/12] emacs: rename `notmuch-search-operate-all' to `notmuch-search-tag-all'

2012-01-30 Thread Dmitry Kurochkin
`Notmuch-search-tag-all' is more clear and consistent with other tagging function names. --- emacs/notmuch.el |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index ce8bef6..7d06109 100644 --- a/emacs/notmuch.el +++

[PATCH v3 07/12] emacs: add "*" binding for notmuch-show view

2012-01-30 Thread Dmitry Kurochkin
The patch adds `notmuch-show-tag-all' function bound to "*" in notmuch-show view. The function is similar to the `notmuch-search-tag-all' function for the notmuch-search view: it changes tags for all messages in the current thread. --- emacs/notmuch-show.el | 35

[PATCH v3 08/12] emacs: separate history for operations which accept single and multiple tags

2012-01-30 Thread Dmitry Kurochkin
Some tag-related operations accept a single tag without prefix (`notmuch-select-tag-with-completion'), others accept multiple tags prefixed with '+' or '-' (`notmuch-read-tag-changes'). Before the change, both functions used a single default minibuffer history. This is inconvenient because you

[PATCH v3 09/12] emacs: relax tag syntax check in `notmuch-tag' function

2012-01-30 Thread Dmitry Kurochkin
The tag syntax check in `notmuch-tag' function was too strict and did not allow nmbug tags with "::". Since the check is done for all tagging operations in Emacs UI, this basically means that no nmbug tags can be changed. The patch relaxes the tag syntax check to allow any tag names that do not

[PATCH v3 10/12] emacs: accept empty tag list in `notmuch-tag'

2012-01-30 Thread Dmitry Kurochkin
Since `notmuch-tag' is a non-interactive function and hence is meant to be invoked programmatically, it should accept zero tags. Also, the tagging operations (bound to "*", "+", "-") would accept empty input without an error. --- emacs/notmuch.el | 10 +- 1 files changed, 5

[PATCH v3 11/12] emacs: s/tags/tag-changes/ for arguments of tagging functions

2012-01-30 Thread Dmitry Kurochkin
This makes the argument names more consistent and clear. The following functions changed: `notmuch-tag', `notmuch-search-tag-thread', `notmuch-search-tag-region' and `notmuch-search-tag-all'. --- emacs/notmuch.el | 33 + 1 files changed, 17 insertions(+), 16

[PATCH v3 12/12] NEWS: document Emacs UI tagging operations changes

2012-01-30 Thread Dmitry Kurochkin
--- NEWS | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 2acdce5..7506d68 100644 --- a/NEWS +++ b/NEWS @@ -39,6 +39,24 @@ Reply to sender and search modes, 'r' has been bound to reply to sender, replacing reply to all, which now

[PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-01-30 Thread Pieter Praet
On Sat, 28 Jan 2012 08:41:36 -0400, David Bremner wrote: > On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet wrote: > > Less code, same results, without sacrificing readability. > > > > This looks OK, although the re-indenting makes these kind of changes > painful to review (not that I'm

Bug?: notmuch-search-show-thread shows several threads; only one containing matching messages

2012-01-30 Thread Pieter Praet
On Mon, 30 Jan 2012 00:42:14 +0100, Gregor Zattler wrote: > Hi Pieter, notmuch developers > * Pieter Praet [26. Jan. 2012]: > > On Thu, 26 Jan 2012 13:44:50 +0100, Gregor Zattler > > wrote: > >>|> [2] grep -I "^Message-Id:" /tmp/thread-I-m-interested-in.mbox |sed > >> -e "s/Message-Id:

[PATCH v2 1/2] emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

2012-01-30 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-get-message-id): Add optional arg BARE. When non-nil, return a Message-Id without quotes and prefix, thus obviating the need to strip them off again in various places. (notmuch-show-stash-message-id-stripped): Update wrt changes in

[PATCH v2 2/2] emacs: add `notmuch-show-stash-mlarchive-link{, -and-go}'

2012-01-30 Thread Pieter Praet
* emacs/notmuch-show.el (notmuch-show-stash-mlarchive-link-alist): New defcustom of type `alist' (key = name, value = URI), containing Mailing List Archive URI's for searching by Message-Id. (notmuch-show-stash-mlarchive-link-default): New defcustom, default MLA to use when

[PATCH v4?] emacs: add `notmuch-show-stash-mlarchive-link{, -and-go}'

2012-01-30 Thread Pieter Praet
On Fri, 27 Jan 2012 09:18:40 +, David Edmondson wrote: > Much nicer :-) > > On Fri, 27 Jan 2012 09:44:26 +0100, Pieter Praet wrote: > > +(defcustom notmuch-show-stash-mlarchive-link-alist > > + '(("Gmane" . "http://mid.gmane.org/;) > > +("MARC" . "http://marc.info/?i=;) > > +("Mail

[RFC] Re: [PATCH] emacs: Add `notmuch-show-stash-gmane' and `notmuch-show-stash-gmane-and-go'.

2012-01-30 Thread Pieter Praet
On Fri, 27 Jan 2012 20:36:40 +0400, Dmitry Kurochkin wrote: > On Fri, 27 Jan 2012 09:42:23 +0100, Pieter Praet wrote: > > On Thu, 26 Jan 2012 14:40:26 +, David Edmondson wrote: > > > In general, I like this. > > > > > > - I think that the stash function(s) should take an optional argument

NEWS: add entries for the changes in the python bindings

2012-01-30 Thread Tomi Ollila
On Sun, 29 Jan 2012 18:08:50 +0100, Justus Winter <4winter at informatik.uni-hamburg.de> wrote: > This patch series adds a section for the python binding changes to the > NEWS file. LGTM -- although knowing which python 2.x versions works would be nice to know. At least tests pass using python

[PATCH v4] test: emacs: add test for `notmuch-search-operate-all'

2012-01-30 Thread Pieter Praet
`notmuch-search-operate-all' (bound to "*") adds and removes tags to/from all messages which match the query used to populate the current search buffer. --- Rebased to current master. Previous versions (chronologically): - id:"1309450108-2793-1-git-send-email-pieter at praet.org" -

[PATCH 3/3] lib: Use talloc to simplify cleanup in notmuch_database_open

2012-01-30 Thread Tomi Ollila
LGTM. all 3. Tomi

[PATCH] lib: update notmuch_tags_get examle to reflect api change

2012-01-30 Thread Tomi Ollila
On Sun, 29 Jan 2012 10:29:01 -0500, Allan Wind wrote: > The function notmuch_database_find_message_by_filename now requires a > notmuch_message_t and returns a notmuch_status_t. This > change was introduced with 02a3076711, LIBNOTMUCH_VERSION_MAJOR = 2, > version 0.9. > --- Good, but [ ... ]

[PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-01-30 Thread Tomi Ollila
On Mon, 30 Jan 2012 08:03:59 +0100, Pieter Praet wrote: > On Sat, 28 Jan 2012 08:41:36 -0400, David Bremner > wrote: > > On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet > > wrote: > > > Less code, same results, without sacrificing readability. > > > > > > > This looks OK, although the

[PATCH v4] test: emacs: add test for `notmuch-search-operate-all'

2012-01-30 Thread Dmitry Kurochkin
Hi Pieter. On Mon, 30 Jan 2012 08:45:50 +0100, Pieter Praet wrote: > `notmuch-search-operate-all' (bound to "*") adds and removes tags > to/from all messages which match the query used to populate the > current search buffer. > > --- > > Rebased to current master. > > Previous versions

[PATCH 2/2] emacs: Quote MML tags in replies

2012-01-30 Thread Tomi Ollila
On Sun, 29 Jan 2012 01:07:08 -0500, Aaron Ecay wrote: > Emacs message-mode uses certain text strings to indicate how to attach > files to outgoing mail. If these are present in the text of an email, > and a user is tricked into replying to the message, the user?s files > could be exposed. > ---

[PATCH v2 1/2] emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

2012-01-30 Thread David Edmondson
Looks good. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/692e7b4e/attachment.pgp>

[PATCH v2 2/2] emacs: add `notmuch-show-stash-mlarchive-link{, -and-go}'

2012-01-30 Thread David Edmondson
Looks good. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/02522874/attachment.pgp>

[PATCH 1/3] emacs: Stop the `truncate-string-to-width' madness.

2012-01-30 Thread David Edmondson
ct necessarily a string at this point? Previously this only > ran if the code determined there was a thread at point. No, it's a bug. It's fixed in the third patch, but should be fixed here as well. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/96898fb4/attachment.pgp>

[PATCH 0/2] Add a fake 'Tags' header

2012-01-30 Thread David Edmondson
non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/e072261c/attachment.pgp>

[PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

2012-01-30 Thread David Edmondson
--- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/272614fb/attachment.pgp>

[PATCH 1/2] test: auto load elisp tests file in test_emacs if available

2012-01-30 Thread David Edmondson
Nice idea, +1. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120130/fff78d13/attachment-0001.pgp>

  1   2   >