Re: [PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface

On Sat, Apr 07 2012, Mark Walters markwalters1...@gmail.com wrote: I think this is what is making the two tests fail: they count the number of invocations of notmuch and in case there is one invocation of notmuch show and one of notmuch tag -unread message-id, where before it was just the

[PATCH 1/4] Make configure use /bin/bash instead of /bin/sh

From: Vladimir Marek vlma...@volny.cz Posix /bin/sh is not capable of running this configure and fails. Signed-off-by: Vladimir Marek vlma...@volny.cz --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 71981b7..6870341 100755 ---

[PATCH 2/4] dirent-d_type not available on Soalris

From: Vladimir Marek vlma...@volny.cz The inspiration was taken from similar issue in mutt: http://does-not-exist.org/mail-archives/mutt-dev/msg11290.html Signed-off-by: Vladimir Marek vlma...@volny.cz --- notmuch-new.c | 19 +-- 1 files changed, 13 insertions(+), 6

[PATCH 4/4] Explicitly type void* pointers

From: Vladimir Marek vlma...@volny.cz Signed-off-by: Vladimir Marek vlma...@volny.cz --- lib/database.cc |2 +- lib/message.cc |2 +- lib/thread.cc |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index 16c4354..3c82632

notmuch on Solaris

Hi, In order to make notmuch compilable on Solaris, I had to make some changes in the source code. Some changes are not yet ready to be included to official tree, some I believe are. So I took first few to see if I'm doing anything which could be accepted and hopefully decrease number of local

[PATCH 3/4] Private strsep implementation

From: Vladimir Marek vlma...@volny.cz strsep is not available on Solaris 10, so we stole the one used by mutt. Signed-off-by: Vladimir Marek vlma...@volny.cz --- compat/Makefile.local |4 +++ compat/compat.h |4 +++ compat/have_strsep.c | 10 +++ compat/strsep.c |

Re: [PATCH 1/4] Make configure use /bin/bash instead of /bin/sh

On Apr 9, 2012 1:18 PM, vladimir.ma...@oracle.com wrote: From: Vladimir Marek vlma...@volny.cz Posix /bin/sh is not capable of running this configure and fails. What fails? What would it take to make this work on posix sh instead? The tests do require bash, but generally I think it would be

Re: [PATCH 2/4] dirent-d_type not available on Soalris

On Apr 9, 2012 1:18 PM, vladimir.ma...@oracle.com wrote: From: Vladimir Marek vlma...@volny.cz The inspiration was taken from similar issue in mutt: http://does-not-exist.org/mail-archives/mutt-dev/msg11290.html Signed-off-by: Vladimir Marek vlma...@volny.cz --- notmuch-new.c | 19

Re: [PATCH 1/4] Make configure use /bin/bash instead of /bin/sh

Posix /bin/sh is not capable of running this configure and fails. What fails? What would it take to make this work on posix sh instead? The tests do require bash, but generally I think it would be preferable to not depend on bash to build. Well I gave it a quick stab. This is not posix:

Re: [PATCH] emacs: get rid of trailing spaces in notmuch-hello view

Hi all. I am going to remove needs-review tag from this one since there seems to be no one interested in reviewing it. The patch itself may not be trivial, but it is pretty simple and does not make any critical changes. So I believe it is safe to push it. If there are any issues with the patch

Re: [PATCH 2/4] dirent-d_type not available on Soalris

Notmuch new is possibly one of the most performance critical bits for people with, uh, much mail. The performance impact of the new syscalls should be measured. (Can't do this myself atm.) Fair enough. Is there some performance test suite? Another way would be to make this compile time option

Re: [PATCH] emacs: get rid of trailing spaces in notmuch-hello view

Dmitry Kurochkin dmitry.kuroch...@gmail.com writes: I am going to remove needs-review tag from this one since there seems to be no one interested in reviewing it. The patch itself may not be trivial, but it is pretty simple and does not make any critical changes. So I believe it is safe to

Re: [PATCH] emacs: get rid of trailing spaces in notmuch-hello view

David Bremner da...@tethera.net writes: Dmitry Kurochkin dmitry.kuroch...@gmail.com writes: I am going to remove needs-review tag from this one since there seems to be no one interested in reviewing it. The patch itself may not be trivial, but it is pretty simple and does not make any

[PATCH 2/4] dirent-d_type not available on Soalris

From: Vladimir Marek vlma...@volny.cz The inspiration was taken from similar issue in mutt: http://does-not-exist.org/mail-archives/mutt-dev/msg11290.html Signed-off-by: Vladimir Marek vlma...@volny.cz --- notmuch-new.c | 28 1 files changed, 28 insertions(+), 0

Re: [PATCH 2/8] emacs: update tag-completion function

On Sun, 08 Apr 2012, Jameson Graef Rollins jroll...@finestructure.net wrote: search-tags is deprecated, so we move to the more modern and supported search --output=tags. --- emacs/notmuch-tag.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-tag.el

Re: [PATCH 2/8] emacs: update tag-completion function

On Mon, Apr 09 2012, Mark Walters markwalters1...@gmail.com wrote: - nil search-tags search-terms))) + nil search --output=tags search-terms))) Perhaps make this + nil search --output=tags --exclude=false search-terms))) to fix the existing bug that if the message is

Re: [PATCH 4/4] Explicitly type void* pointers

Hi, Hi, does notmuch not compile without this? IIRC talloc_steal is a macro that's supposed to provide type safety (at least with GCC), and I'd be hesitant about adding the casts. Please look in your talloc.h. It does not compile. It might be that I'm using Sun/Oracle CC instead of gcc. The

[PATCH 2/3] emacs: include tags from excluded messages in tag tab completion

The new message exclude functionality will hide tags that only exist on excluded messages. However, one might very well want to manually modify excluded tags. This makes sure tags from excluded messages are always available in tab completion. --- emacs/notmuch.el |2 +- 1 files changed, 1

[PATCH 1/3] emacs: update call in tag-completion function

search-tags is deprecated, so use the more modern and supported search --output=tags. --- emacs/notmuch.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index f0afa07..38ae005 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@

[PATCH 3/3] emacs: have tag-completion return all tags for nil input

Previously the function would fail if the initial input was nil. Now it will return a list of all tags, which obviously makes much more sense. --- emacs/notmuch.el |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 8b48399..ba833e6

Re: [PATCH 5/8] emacs: modify search tag functions to use new notmuch-tag interface

On Sun, 08 Apr 2012, Jameson Graef Rollins jroll...@finestructure.net wrote: The main change here is to modify argument parsing so as to not force tag-changes to be a list, and to let notmuch-tag handle prompting the user when required. doc strings are also updated and cleaned up. ---

Re: bug fixes to emacs notmuch-tag-completion function

All three of these look good to me and include some genuine bug fixes. +1 Best wishes Mark On Mon, 09 Apr 2012, Jameson Graef Rollins jroll...@finestructure.net wrote: I had originally included this fixes as part of a more involved series to fix up tagging functions [0]. However, these are

[PATCH] replace gnu xargs usage in notmuch-mutt with perl

--- contrib/notmuch-mutt/notmuch-mutt | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/contrib/notmuch-mutt/notmuch-mutt b/contrib/notmuch-mutt/notmuch-mutt index 71206c3..dbe7f2d 100755 --- a/contrib/notmuch-mutt/notmuch-mutt +++

Re: [PATCH 4/4] Explicitly type void* pointers

Vladimir Marek vladimir.ma...@oracle.com writes: Hi, Hi, does notmuch not compile without this? IIRC talloc_steal is a macro that's supposed to provide type safety (at least with GCC), and I'd be hesitant about adding the casts. Please look in your talloc.h. It does not compile. It might

Re: Message deletion wisdom

Mark Anderson wrote at 2012-04-06 15:17 -0500: On Thu, 5 Apr 2012 12:20:43 -0400, Antoine Beaupré anar...@anarcat.ath.cx wrote: Finally, I want to voice that I feel a delete key, even if it doesn't delete mails, seems like an important part of a mail user agent. Archiving mail is one

Re: [PATCH] emacs: get rid of trailing spaces in notmuch-hello view

This looks fine to me (but I am not a lisp expert). Mark On Sat, 10 Mar 2012, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: This patch removes trailing spaces in notmuch-hello view. A side effect of this change is that tag/query buttons no longer include a space at the end. This means

Re: [PATCH] replace gnu xargs usage in notmuch-mutt with perl

Hi Taylor, and thanks for the patch. In general for notmuch patches we prefer - some kind of commit message beyond the one line summary explaining the rationale for the change. - not to have unrelated changes (/usr/bin/env perl) in the patch. d

Why not tags inside messages?

>On Sat, Apr 7, 2012 at 10:46, David Belohrad wrote: >> I'd love to use notmuch with offline imap ?to work rather on local >copy of >> messages, than using remote notmuch, which is slightly slower due to >> bandwidth limitation of my vdsl line. There is however fundamental >problem >> of syncing

notmuch-poll and OfflineIMAP

Jani Nikula wrote: >Jacek Generowicz writes: > >> Hello, >> >> Would you have any advice on how to construct a notmuch-poll script >> that would work well in concert with OfflineIMAP? In particlular, >how >> can you avoid having to re-issue the IMAP account passwords? >> Any words of wisdom?

Message deletion wisdom

Jameson Graef Rollins wrote: >So in summary, if you would like to "delete" messages, you can: > > * add a key binding to emacs (or your favorite ui) to add a "deleted" > tag to messages that you want to delete: > >(define-key notmuch-show-mode-map "d" > (lambda () >

notmuch-poll and OfflineIMAP

Adam Wolfe Gordon wrote: > >I run offlineimap in autorefresh mode (with IDLE too, actually) and >use a script based on inotify to update notmuch whenever new mail >comes in: https://gist.github.com/1952483 . It sounds like some >variant of this would probably work for you.

[PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface

t part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120409/d9120d2c/attachment.pgp>

[PATCH 2/4] dirent->d_type not available on Soalris

From: Vladimir Marek The inspiration was taken from similar issue in mutt: http://does-not-exist.org/mail-archives/mutt-dev/msg11290.html Signed-off-by: Vladimir Marek --- notmuch-new.c | 19 +-- 1 files changed, 13 insertions(+), 6 deletions(-) diff --git

[PATCH 4/4] Explicitly type void* pointers

From: Vladimir Marek Signed-off-by: Vladimir Marek --- lib/database.cc |2 +- lib/message.cc |2 +- lib/thread.cc |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index 16c4354..3c82632 100644 ---

notmuch on Solaris

Hi, In order to make notmuch compilable on Solaris, I had to make some changes in the source code. Some changes are not yet ready to be included to official tree, some I believe are. So I took first few to see if I'm doing anything which could be accepted and hopefully decrease number of local

[PATCH 3/4] Private strsep implementation

From: Vladimir Marek strsep is not available on Solaris 10, so we stole the one used by mutt. Signed-off-by: Vladimir Marek --- compat/Makefile.local |4 +++ compat/compat.h |4 +++ compat/have_strsep.c | 10 +++ compat/strsep.c | 65

[PATCH 4/4] Explicitly type void* pointers

gt; 1.7.3.2 > > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch -- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120409/31478ded/attachment.html>

[PATCH 1/4] Make configure use /bin/bash instead of /bin/sh

org > http://notmuchmail.org/mailman/listinfo/notmuch -- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120409/39f64c38/attachment-0001.html>

[PATCH 2/4] dirent->d_type not available on Soalris

ry->d_type != DT_REG) { > + } else if ( statbuf.st_mode & S_IFREG) { >continue; >} > > -- > 1.7.3.2 > > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch -- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120409/223c13d0/attachment.html>

[PATCH 1/4] Make configure use /bin/bash instead of /bin/sh

> > Posix /bin/sh is not capable of running this configure and fails. > > What fails? What would it take to make this work on posix sh instead? > > The tests do require bash, but generally I think it would be preferable to > not depend on bash to build. Well I gave it a quick stab. This is not

[PATCH] emacs: get rid of trailing spaces in notmuch-hello view

Hi all. I am going to remove needs-review tag from this one since there seems to be no one interested in reviewing it. The patch itself may not be trivial, but it is pretty simple and does not make any critical changes. So I believe it is safe to push it. If there are any issues with the patch

[PATCH 2/4] dirent->d_type not available on Soalris

> Notmuch new is possibly one of the most performance critical bits for > people with, uh, much mail. The performance impact of the new syscalls > should be measured. (Can't do this myself atm.) Fair enough. Is there some performance test suite? Another way would be to make this compile time

[PATCH] emacs: get rid of trailing spaces in notmuch-hello view

Dmitry Kurochkin writes: > I am going to remove needs-review tag from this one since there seems to > be no one interested in reviewing it. The patch itself may not be > trivial, but it is pretty simple and does not make any critical changes. > So I believe it is safe to push it. If there are

[PATCH] emacs: get rid of trailing spaces in notmuch-hello view

David Bremner writes: > Dmitry Kurochkin writes: > >> I am going to remove needs-review tag from this one since there seems to >> be no one interested in reviewing it. The patch itself may not be >> trivial, but it is pretty simple and does not make any critical changes. >> So I believe it is

[PATCH 2/4] dirent->d_type not available on Soalris

On Mon, Apr 9, 2012 at 09:12, Vladimir Marek wrote: > Fair enough. Is there some performance test suite? Another way would be > to make this compile time option set by configure. Used only when the > system in question does not have dirent->d_type member. I like the idea of making it

[PATCH 2/4] dirent->d_type not available on Soalris

From: Vladimir Marek The inspiration was taken from similar issue in mutt: http://does-not-exist.org/mail-archives/mutt-dev/msg11290.html Signed-off-by: Vladimir Marek --- notmuch-new.c | 28 1 files changed, 28 insertions(+), 0 deletions(-)

[PATCH 2/8] emacs: update tag-completion function

On Sun, 08 Apr 2012, Jameson Graef Rollins wrote: > "search-tags" is deprecated, so we move to the more modern and > supported "search --output=tags". > --- > emacs/notmuch-tag.el |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/emacs/notmuch-tag.el

[PATCH 2/8] emacs: update tag-completion function

f has been pushed this should be included as well. I'll send a patch for this now. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120409/50a1649a/attachment.pgp>

[PATCH 4/4] Explicitly type void* pointers

Hi, > Hi, does notmuch not compile without this? IIRC talloc_steal is a macro > that's supposed to provide type safety (at least with GCC), and I'd be > hesitant about adding the casts. Please look in your talloc.h. It does not compile. It might be that I'm using Sun/Oracle CC instead of gcc.

[PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface

On Mon, 09 Apr 2012, Jameson Graef Rollins wrote: > On Sat, Apr 07 2012, Mark Walters wrote: >> I think this is what is making the two tests fail: they count the number >> of invocations of notmuch and in case there is one invocation of notmuch >> show and one of notmuch tag -unread message-id,

[PATCH 2/3] emacs: include tags from excluded messages in tag tab completion

The new message exclude functionality will hide tags that only exist on excluded messages. However, one might very well want to manually modify excluded tags. This makes sure tags from excluded messages are always available in tab completion. --- emacs/notmuch.el |2 +- 1 files changed, 1

bug fixes to emacs notmuch-tag-completion function

I had originally included this fixes as part of a more involved series to fix up tagging functions [0]. However, these are actually bug fixes that stand alone and should not be bogged down in a series that's likely going to take a while to come to fruition. The changes here are pretty trivial,

[PATCH 1/3] emacs: update call in tag-completion function

"search-tags" is deprecated, so use the more modern and supported "search --output=tags". --- emacs/notmuch.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index f0afa07..38ae005 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el

[PATCH 3/3] emacs: have tag-completion return all tags for nil input

Previously the function would fail if the initial input was nil. Now it will return a list of all tags, which obviously makes much more sense. --- emacs/notmuch.el |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 8b48399..ba833e6

[PATCH 5/8] emacs: modify search tag functions to use new notmuch-tag interface

On Sun, 08 Apr 2012, Jameson Graef Rollins wrote: > The main change here is to modify argument parsing so as to not force > tag-changes to be a list, and to let notmuch-tag handle prompting the > user when required. doc strings are also updated and cleaned up. > --- > emacs/notmuch.el | 36

[PATCH 7/8] emacs: modify show tag functions to use new notmuch-tag interface

On Sun, 08 Apr 2012, Jameson Graef Rollins wrote: > The main change here is to modify argument parsing so as to not force > tag-changes to be a list, and to let notmuch-tag handle prompting the > user when required. doc strings are also updated and cleaned up. One other comment on this patch

bug fixes to emacs notmuch-tag-completion function

All three of these look good to me and include some genuine bug fixes. +1 Best wishes Mark On Mon, 09 Apr 2012, Jameson Graef Rollins wrote: > I had originally included this fixes as part of a more involved series > to fix up tagging functions [0]. However, these are actually bug > fixes

[PATCH] replace gnu xargs usage in notmuch-mutt with perl

--- contrib/notmuch-mutt/notmuch-mutt | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/contrib/notmuch-mutt/notmuch-mutt b/contrib/notmuch-mutt/notmuch-mutt index 71206c3..dbe7f2d 100755 --- a/contrib/notmuch-mutt/notmuch-mutt +++

Message deletion wisdom

-- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120409/e5aebcca/attachment.pgp>

[PATCH] emacs: get rid of trailing spaces in notmuch-hello view

This looks fine to me (but I am not a lisp expert). Mark On Sat, 10 Mar 2012, Dmitry Kurochkin wrote: > This patch removes trailing spaces in notmuch-hello view. > > A side effect of this change is that tag/query buttons no longer > include a space at the end. This means that pressing RET

[PATCH] replace gnu xargs usage in notmuch-mutt with perl

Hi Taylor, and thanks for the patch. In general for notmuch patches we prefer - some kind of commit message beyond the one line summary explaining the rationale for the change. - not to have unrelated changes (/usr/bin/env perl) in the patch. d