Re: images as attachment?

2012-10-15 Thread David Belohrad
Hi Jameson, I guess this is exactly the point. Hence one would say, that this is a bug to repair? What is bit curious to me is that so far nobody complained about it. So is it just my emacs/notmuch configuration which does it? (note that i'm using notmuch remotely and notmuch pulled from

Re: images as attachment?

2012-10-15 Thread Jameson Graef Rollins
On Mon, Oct 15 2012, David Belohrad da...@belohrad.ch wrote: I guess this is exactly the point. Hence one would say, that this is a bug to repair? What is bit curious to me is that so far nobody complained about it. So is it just my emacs/notmuch configuration which does it? (note that i'm

Re: images as attachment?

2012-10-15 Thread Jani Nikula
On Mon, 15 Oct 2012, Jameson Graef Rollins jroll...@finestructure.net wrote: If you want to look into patching it, I think the offending code is in emacs/notmuch-show.el (notmuch-show-buttonise-links). Maybe just adding a blank space before id: in the regexp would fix the issue? Or

Re: nbook: a notmuch based address book written in python

2012-10-15 Thread Justus Winter
Hi Suvayu :) welcome to notmuch and python. Quoting Patrick Totzke (2012-10-13 18:58:51) And If I look for my own name, this takes over a minute, eventually dying. This could be an issue with libnotmuch though. Possibly, your algorithm takes very long and then reads from an initially

Re: nbook: a notmuch based address book written in python

2012-10-15 Thread Suvayu Ali
Hello Patrick, On Sat, Oct 13, 2012 at 05:58:51PM +0100, Patrick Totzke wrote: Quoting Suvayu Ali (2012-10-08 10:34:29) But to your tool; practice test: I wasn't able to use wildcards or simply prefixes of names. This is essential if you want to use it for tabcompleting contacts

Re: [PATCH 1/2] test: emacs mailto: URI handling

2012-10-15 Thread Ethan Glasser-Camp
Jameson Graef Rollins jroll...@finestructure.net writes: This adds a test for proposed rfc6068 mailto:; URI handling. The proposed function would be called 'notmuch-mua-mailto'. The test provides an example mailto: string that should test some subset of the rfc6068 specification:

Re: [PATCH v8 0/8] reworked crypto toggle, plus a few other toggles

2012-10-15 Thread Ethan Glasser-Camp
Pieter Praet pie...@praet.org writes: Great work! Here's some tests. Hi! These look fine to me. With Mark's review (id:87k41e45hi@qmul.ac.uk), I'm removing the needs-review tag. Ethan ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH 3/3] new: don't read unchanged directories from disk

2012-10-15 Thread Ethan Glasser-Camp
Sascha Silbe sascha-...@silbe.org writes: Previously, notmuch new listed all directories on disk, even if they were unchanged from the state recorded in the database. This could take a huge amount of time for large numbers of mails as it would list each individual mail. By iterating over

Re: [PATCH v2 2/6] test: emacs: new test notmuch-show: change tags of all messages in current buffer

2012-10-15 Thread Ethan Glasser-Camp
Pieter Praet pie...@praet.org writes: * test/emacs: New subtest notmuch-show: change tags of all messages in current buffer: `notmuch-show-tag-all' (*) changes tags of *all* messages in current buffer. --- test/emacs | 15 +++ 1 files changed, 15 insertions(+), 0

Re: [PATCH v2 4/6] emacs: add optional predicate arg to `notmuch-show-mapc'

2012-10-15 Thread Ethan Glasser-Camp
Pieter Praet pie...@praet.org writes: * emacs/notmuch-show.el (notmuch-show-mapc): If provided with optional argument PREDICATE, only call FUNCTION if calling PREDICATE returns non-nil. Also correct original docstring: 's/thread/buffer/'. --- This patch was marked stale, but isn't.

Re: [PATCH v2 4/6] emacs: add optional predicate arg to `notmuch-show-mapc'

2012-10-15 Thread Ethan Glasser-Camp
Mark Walters markwalters1...@gmail.com writes: The original function feels a little fragile to me as to what happens if predicate or function move point. Eg what happens if function collapses the message: where does point go, and so where does notmuch-show-goto-message-next go. Is this just

Re: [PATCH v2 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}'

2012-10-15 Thread Ethan Glasser-Camp
Mark Walters markwalters1...@gmail.com writes: I like the use of separator rather than hard-wiring or . My personal preference would be to make that change but keep the two functions separate (my Cness makes me like functions that have clear return types!) But I am happy with the change too.

Re: [PATCH v2 6/6] emacs: `notmuch-show-tag-all' with prefix arg only tags open messages

2012-10-15 Thread Ethan Glasser-Camp
Pieter Praet pie...@praet.org writes: * emacs/notmuch-show.el (notmuch-show-get-messages-ids): If provided with optional argument PREDICATE, only return Message-Id's of messages for which PREDICATE returns non-nil. (notmuch-show-tag-all): New argument ONLY-OPEN (set to

[PATCH v4 2/9] parse-time-string: add a date/time parser to notmuch

2012-10-15 Thread Ethan Glasser-Camp
Jani Nikula writes: Hi! I commend you for your work and persistence. This represents a lot of work and I think it's good enough to be merged. I would certainly love to see "last" and "ago" supported but this patch series, and this patch especially, is cumbersome enough that I'd really rather it

[PATCH 3/4] Private strsep implementation

2012-10-15 Thread Ethan Glasser-Camp
Vladimir.Marek at oracle.com writes: > From: Vladimir Marek > > strsep is not available on Solaris 10, so we stole the one used by > mutt. Hi! Just going through the patch queue. This patch looks fine to me, but it no longer applies cleanly to master. Can you rebase it? It'll have my +1. Ethan

images as attachment?

2012-10-15 Thread David Belohrad
Hi Jameson, I guess this is exactly the point. Hence one would say, that this is a bug to repair? What is bit curious to me is that so far nobody complained about it. So is it just my emacs/notmuch configuration which does it? (note that i'm using notmuch remotely and notmuch pulled from

images as attachment?

2012-10-15 Thread Jameson Graef Rollins
t;id:" in the regexp would fix the issue? jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20121015/ed4d0910/attachment.pgp>

images as attachment?

2012-10-15 Thread Jani Nikula
On Mon, 15 Oct 2012, Jameson Graef Rollins wrote: > If you want to look into patching it, I think the offending code is in > emacs/notmuch-show.el (notmuch-show-buttonise-links). Maybe just adding > a blank space before "id:" in the regexp would fix the issue? Or [^A-Za-z_-] or similar instead

[PATCH 1/2] test: emacs mailto: URI handling

2012-10-15 Thread Ethan Glasser-Camp
Jameson Graef Rollins writes: > This adds a test for proposed rfc6068 "mailto:; URI handling. The > proposed function would be called 'notmuch-mua-mailto'. The test > provides an example mailto: string that should test some subset of the > rfc6068 specification:

[PATCH v8 0/8] reworked crypto toggle, plus a few other toggles

2012-10-15 Thread Ethan Glasser-Camp
Pieter Praet writes: > Great work! > > Here's some tests. Hi! These look fine to me. With Mark's review (id:"87k41e45hi.fsf at qmul.ac.uk"), I'm removing the needs-review tag. Ethan

[PATCH 3/3] new: don't read unchanged directories from disk

2012-10-15 Thread Ethan Glasser-Camp
Sascha Silbe writes: > Previously, notmuch new listed all directories on disk, even if they > were unchanged from the state recorded in the database. This could take > a huge amount of time for large numbers of mails as it would list each > individual mail. > > By iterating over the

[PATCH v2 2/6] test: emacs: new test "notmuch-show: change tags of all messages in current buffer"

2012-10-15 Thread Ethan Glasser-Camp
Pieter Praet writes: > * test/emacs: > > New subtest "notmuch-show: change tags of all messages in current buffer": > `notmuch-show-tag-all' ("*") changes tags of *all* messages in current > buffer. > --- > test/emacs | 15 +++ > 1 files changed, 15 insertions(+), 0

[PATCH v2 4/6] emacs: add optional predicate arg to `notmuch-show-mapc'

2012-10-15 Thread Ethan Glasser-Camp
Pieter Praet writes: > * emacs/notmuch-show.el (notmuch-show-mapc): > > If provided with optional argument PREDICATE, only call > FUNCTION if calling PREDICATE returns non-nil. > > Also correct original docstring: 's/thread/buffer/'. > --- This patch was marked stale, but isn't. >

[PATCH v2 4/6] emacs: add optional predicate arg to `notmuch-show-mapc'

2012-10-15 Thread Ethan Glasser-Camp
Mark Walters writes: > The original function feels a little fragile to me as to what happens if > predicate or function move point. Eg what happens if function collapses > the message: where does point go, and so where does > notmuch-show-goto-message-next go. Is this just my naivete as a lisp >