test suite crash with TERM=dumb

2013-01-21 Thread David Bremner
In 0.15 (or current master) try running % TERM=dump make test At least for me and the Debian build daemons, this causes the run to end with PASS Show message: json, utf-8 FATAL: Unexpected exit with code 1 make: *** [test] Error 124 This is much worse than a test failure since it

Re: test suite crash with TERM=dumb

2013-01-21 Thread Tomi Ollila
On Mon, Jan 21 2013, David Bremner da...@tethera.net wrote: In 0.15 (or current master) try running % TERM=dump make test At least for me and the Debian build daemons, this causes the run to end with PASS Show message: json, utf-8 FATAL: Unexpected exit with code 1 make: ***

Re: test suite crash with TERM=dumb

2013-01-21 Thread Tomi Ollila
On Mon, Jan 21 2013, Tomi Ollila tomi.oll...@iki.fi wrote: In your tests you could just run `TERM=xterm make test` (and forget the issue ;) or better, vt100: localhost$ TERM=vt100 tput setaf 1 zsh: exit 1 TERM=vt100 tput setaf 1 So that say_color () will not print colors. $ TERM=vt100

Re: update top level argument handling

2013-01-21 Thread Jani Nikula
On Sat, 19 Jan 2013, da...@tethera.net wrote: The only new feature here is an option --leak-report to notmuch new, as requested in id:m2hangivfu@guru.guru-group.fi There is also a bunch of cleanup of the argument handling. One casualty of this is that the use of aliases (in particular

Re: [PATCH 0/5] notmuch batch count

2013-01-21 Thread Jani Nikula
On Wed, 16 Jan 2013, Tomi Ollila tomi.oll...@iki.fi wrote: On Wed, Jan 16 2013, Mark Walters markwalters1...@gmail.com wrote: On Tue, 15 Jan 2013, Jani Nikula j...@nikula.org wrote: Hi all - Notmuch remote usage [1] is a pretty handy way of accessing a notmuch database on a remote server.

Re: [PATCH v3 08/20] tag-util: move out 'tag' command-line checks

2013-01-21 Thread Jani Nikula
On Sun, 20 Jan 2013, Peter Wang noval...@gmail.com wrote: parse_tag_command_line checked for two error conditions which are specific to the 'tag' command. It can be reused for the notmuch 'insert' command if we move the checks out, into notmuch-tag.c. *three* error conditions, two of which

Re: [PATCH v3 07/20] tag-util: do not reset list in parse_tag_command_line

2013-01-21 Thread Jani Nikula
On Sun, 20 Jan 2013, Peter Wang noval...@gmail.com wrote: No current callers of parse_tag_command_line require that it clear its tag list argument. The notmuch 'insert' command will be better served if the function modifies a pre-populated list (of new.tags) instead of clobbering it outright.

Re: [PATCH] lib/Makefile.local: depend on libs we are linking with

2013-01-21 Thread Jani Nikula
LGTM, and fixes the issue. On Mon, 21 Jan 2013, Amadeusz Żołnowski aide...@aidecoe.name wrote: --- lib/Makefile.local | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Makefile.local b/lib/Makefile.local index 7785944..155ac02 100644 --- a/lib/Makefile.local +++

Re: [PATCH] lib/Makefile.local: depend on libs we are linking with

2013-01-21 Thread Tomi Ollila
On Tue, Jan 22 2013, Jani Nikula j...@nikula.org wrote: LGTM, and fixes the issue. LGTM. Tomi On Mon, 21 Jan 2013, Amadeusz Żołnowski aide...@aidecoe.name wrote: --- lib/Makefile.local | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Makefile.local

[PATCH 5/7] CLI: add --leak-report top level option

2013-01-21 Thread Tomi Ollila
On Sun, Jan 20 2013, Jameson Graef Rollins wrote: > On Sat, Jan 19 2013, david at tethera.net wrote: >> This roughly mimics the samba4 argument. The presence of the command >> line argument overrides any value of NOTMUCH_TALLOC_REPORT in the >> environment. >> --- >> man/man1/notmuch.1 |8

[PATCH 2/2] test/test-lib.sh: separate signaled exit

2013-01-21 Thread Tomi Ollila
When execution of tests is interrupted by signal coming outside of the test system itself, output just one line "interrupted by signal " message to standard output. This distinguishes the case from internal exit and reduces noise. --- test/test-lib.sh | 15 ++- 1 file changed, 14

[PATCH 1/2] test/test-lib.sh: use $test_subtest_name in all tests

2013-01-21 Thread Tomi Ollila
Set the variable '$test_subtest_name' in all functions which starts a new test and use that variable in all functions that output test results. Additionally output the latest '$test_subtest_name' in case of abnormal exit, to avoid confusion. --- This obsoletes

[PATCH 1/2] test/test-lib.sh: use $test_subtest_name in all tests

2013-01-21 Thread Tomi Ollila
On Mon, Jan 21 2013, Tomi Ollila wrote: > Set the variable '$test_subtest_name' in all functions which starts > a new test and use that variable in all functions that output > test results. > > Additionally output the latest '$test_subtest_name' in case of > abnormal exit, to avoid confusion. >

test suite crash with TERM=dumb

2013-01-21 Thread David Bremner
lable Type: application/pgp-signature Size: 315 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20130121/8f1336e6/attachment.pgp>

test suite crash with TERM=dumb

2013-01-21 Thread Tomi Ollila
On Mon, Jan 21 2013, David Bremner wrote: > In 0.15 (or current master) try running > > % TERM=dump make test > > At least for me and the Debian build daemons, this causes the run to end > with > > PASS Show message: json, utf-8 > FATAL: Unexpected exit with code 1 > make: *** [test]

test suite crash with TERM=dumb

2013-01-21 Thread Tomi Ollila
On Mon, Jan 21 2013, Tomi Ollila wrote: > > In your tests you could just run `TERM=xterm make test` (and forget the > issue >;) or better, vt100: localhost$ TERM=vt100 tput setaf 1 zsh: exit 1 TERM=vt100 tput setaf 1 So that say_color () will not print colors. $ TERM=vt100 emacs -nw

update top level argument handling

2013-01-21 Thread Jani Nikula
On Sat, 19 Jan 2013, david at tethera.net wrote: > The only new feature here is an option --leak-report > to notmuch new, as requested in id:m2hangivfu.fsf at guru.guru-group.fi > > There is also a bunch of cleanup of the argument handling. One > casualty of this is that the use of aliases (in

[PATCH 0/5] notmuch batch count

2013-01-21 Thread Jani Nikula
On Wed, 16 Jan 2013, Tomi Ollila wrote: > On Wed, Jan 16 2013, Mark Walters wrote: > >> On Tue, 15 Jan 2013, Jani Nikula wrote: >>> Hi all - >>> >>> Notmuch remote usage [1] is a pretty handy way of accessing a notmuch >>> database on a remote server. However, the more you have saved searches

[PATCH v3 08/20] tag-util: move out 'tag' command-line checks

2013-01-21 Thread Jani Nikula
On Sun, 20 Jan 2013, Peter Wang wrote: > parse_tag_command_line checked for two error conditions which are > specific to the 'tag' command. It can be reused for the notmuch > 'insert' command if we move the checks out, into notmuch-tag.c. *three* error conditions, two of which are specific to

[PATCH v3 07/20] tag-util: do not reset list in parse_tag_command_line

2013-01-21 Thread Jani Nikula
On Sun, 20 Jan 2013, Peter Wang wrote: > No current callers of parse_tag_command_line require that it clear its > tag list argument. The notmuch 'insert' command will be better served > if the function modifies a pre-populated list (of new.tags) instead of > clobbering it outright. I think I'd

[PATCH] lib/Makefile.local: depend on libs we are linking with

2013-01-21 Thread Amadeusz Żołnowski
--- lib/Makefile.local | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Makefile.local b/lib/Makefile.local index 7785944..155ac02 100644 --- a/lib/Makefile.local +++ b/lib/Makefile.local @@ -73,7 +73,7 @@ libnotmuch_modules := $(libnotmuch_c_srcs:.c=.o)