LGTM.
On Thu, 24 Jan 2013, Tomi Ollila tomi.oll...@iki.fi wrote:
The TERM environment variable is set to 'dumb' when running tests, but
the original value of it is stored for echoing colors and running emacs
(somewhat interactively) in detached session. Emacs requires some
terminal control
Tomi Ollila tomi.oll...@iki.fi writes:
To fix this problem dtach (and emacs as it's child
process) is run with TERM=vt100 in case original TERM was unset, empty
or 'dumb'. This way there is a chance to run emacs tests with different
user terminals and potentially find problems there.
OK,
Jani Nikula j...@nikula.org writes:
M-RET notmuch-show-open-or-close-all opens all closed messages.
The archiving change is mentioned twice, remove dupe.
notmuch search supports --format=text0 to work with xargs -0
pushed.
d
___
notmuch mailing
pushed,
d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Differences from v3:
- squashed patches; take it up with Jani
- address some review comments (interdiff follows)
- some stylistic things I left for someone who cares
(either I tried it and didn't like it, or disagree with the premise)
- split doc and test patches so series can be partially
parse_tag_command_line checked for two error conditions which are
specific to the 'tag' command. It can be reused for the forthcoming
notmuch 'insert' command if we move the checks out, into notmuch-tag.c.
---
notmuch-tag.c | 10 ++
tag-util.c| 11 +++
2 files changed, 13
No current callers of parse_tag_command_line require that it clear its
tag list argument. The notmuch 'insert' command will be better served
if the function modifies a pre-populated list (of new.tags) instead of
clobbering it outright.
---
tag-util.c | 2 --
tag-util.h | 2 ++
2 files changed, 2
The notmuch insert command reads a message from standard input,
writes it to a Maildir folder, and then incorporates the message into
the notmuch database. Essentially it moves the functionality of
notmuch-deliver into notmuch.
Though it could be used as an alternative to notmuch new, the reason
Add initial documentation for notmuch insert command.
---
man/Makefile.local| 1 +
man/man1/notmuch-insert.1 | 37 +
2 files changed, 38 insertions(+)
create mode 100644 man/man1/notmuch-insert.1
diff --git a/man/Makefile.local b/man/Makefile.local
Add references to notmuch-insert.1 from other man pages.
---
man/man1/notmuch-config.1 | 4 ++--
man/man1/notmuch-count.1| 4 ++--
man/man1/notmuch-dump.1 | 4 ++--
man/man1/notmuch-new.1 | 4 ++--
man/man1/notmuch-reply.1| 3 ++-
man/man1/notmuch-restore.1
Add tests for new 'insert' command.
---
test/insert | 69 +++
test/notmuch-test | 1 +
2 files changed, 70 insertions(+)
create mode 100755 test/insert
diff --git a/test/insert b/test/insert
new file mode 100755
index 000..d880af9
Allow the new message to be inserted into a folder within the Maildir
hierarchy instead of the top-level folder.
---
notmuch-insert.c | 47 +--
1 file changed, 45 insertions(+), 2 deletions(-)
diff --git a/notmuch-insert.c b/notmuch-insert.c
index
Add documentation for notmuch insert --folder option.
---
man/man1/notmuch-insert.1 | 14 ++
1 file changed, 14 insertions(+)
diff --git a/man/man1/notmuch-insert.1 b/man/man1/notmuch-insert.1
index 387e274..27c2658 100644
--- a/man/man1/notmuch-insert.1
+++
Add tests for notmuch insert --folder option.
---
test/insert | 17 +
1 file changed, 17 insertions(+)
diff --git a/test/insert b/test/insert
index d880af9..44e071c 100755
--- a/test/insert
+++ b/test/insert
@@ -66,4 +66,21 @@ notmuch insert +custom -unread $gen_msg_filename
Allow the insert command to create the maildir folder
into which the new message should be delivered.
---
notmuch-insert.c | 100 +++
1 file changed, 100 insertions(+)
diff --git a/notmuch-insert.c b/notmuch-insert.c
index bc848ff..69329ad
Add documentation for notmuch insert --create-folder option.
---
man/man1/notmuch-insert.1 | 12
1 file changed, 12 insertions(+)
diff --git a/man/man1/notmuch-insert.1 b/man/man1/notmuch-insert.1
index 27c2658..8ce634e 100644
--- a/man/man1/notmuch-insert.1
+++
Add tests for notmuch insert --create-folder option.
---
test/insert | 24
1 file changed, 24 insertions(+)
diff --git a/test/insert b/test/insert
index 44e071c..24a61e1 100755
--- a/test/insert
+++ b/test/insert
@@ -83,4 +83,28 @@ gen_insert_msg
test_expect_code 1
Official announcement below.
Unofficial Summary: Distros might want this to help with autobuilding
problems. People building from source probably won't notice a difference
From 0.15.
Where to obtain notmuch 0.15.1
===
Tomi Ollila tomi.oll...@iki.fi writes:
The TERM environment variable is set to 'dumb' when running tests, but
the original value of it is stored for echoing colors and running emacs
(somewhat interactively) in detached session.
Pushed.
d
___
l/notmuch/attachments/20130124/1254de21/attachment.mht>
The TERM environment variable is set to 'dumb' when running tests, but
the original value of it is stored for echoing colors and running emacs
(somewhat interactively) in detached session. Emacs requires some
terminal control sequences to be available for interactive operation.
In case original
The TERM environment variable is set to 'dumb' when running tests, but
the original value of it is stored for echoing colors and running emacs
(somewhat interactively) in detached session. Emacs requires some
terminal control sequences to be available for interactive operation.
In case original
LGTM.
On Thu, 24 Jan 2013, Tomi Ollila wrote:
> The TERM environment variable is set to 'dumb' when running tests, but
> the original value of it is stored for echoing colors and running emacs
> (somewhat interactively) in detached session. Emacs requires some
> terminal control sequences to be
Tomi Ollila writes:
> To fix this problem dtach (and emacs as it's child
> process) is run with TERM=vt100 in case original TERM was unset, empty
> or 'dumb'. This way there is a chance to run emacs tests with different
> user terminals and potentially find problems there.
OK, this looks
Jani Nikula writes:
> M-RET notmuch-show-open-or-close-all opens all closed messages.
>
> The archiving change is mentioned twice, remove dupe.
>
> "notmuch search" supports --format=text0 to work with xargs -0
pushed.
d
pushed,
d
Differences from v3:
- squashed patches; take it up with Jani
- address some review comments (interdiff follows)
- some stylistic things I left for someone who cares
(either I tried it and didn't like it, or disagree with the premise)
- split doc and test patches so series can be partially
parse_tag_command_line checked for two error conditions which are
specific to the 'tag' command. It can be reused for the forthcoming
notmuch 'insert' command if we move the checks out, into notmuch-tag.c.
---
notmuch-tag.c | 10 ++
tag-util.c| 11 +++
2 files changed, 13
No current callers of parse_tag_command_line require that it clear its
tag list argument. The notmuch 'insert' command will be better served
if the function modifies a pre-populated list (of new.tags) instead of
clobbering it outright.
---
tag-util.c | 2 --
tag-util.h | 2 ++
2 files changed, 2
The notmuch insert command reads a message from standard input,
writes it to a Maildir folder, and then incorporates the message into
the notmuch database. Essentially it moves the functionality of
notmuch-deliver into notmuch.
Though it could be used as an alternative to notmuch new, the reason
Add initial documentation for notmuch insert command.
---
man/Makefile.local| 1 +
man/man1/notmuch-insert.1 | 37 +
2 files changed, 38 insertions(+)
create mode 100644 man/man1/notmuch-insert.1
diff --git a/man/Makefile.local b/man/Makefile.local
Add references to notmuch-insert.1 from other man pages.
---
man/man1/notmuch-config.1 | 4 ++--
man/man1/notmuch-count.1| 4 ++--
man/man1/notmuch-dump.1 | 4 ++--
man/man1/notmuch-new.1 | 4 ++--
man/man1/notmuch-reply.1| 3 ++-
man/man1/notmuch-restore.1
Add tests for new 'insert' command.
---
test/insert | 69 +++
test/notmuch-test | 1 +
2 files changed, 70 insertions(+)
create mode 100755 test/insert
diff --git a/test/insert b/test/insert
new file mode 100755
index 000..d880af9
Allow the new message to be inserted into a folder within the Maildir
hierarchy instead of the top-level folder.
---
notmuch-insert.c | 47 +--
1 file changed, 45 insertions(+), 2 deletions(-)
diff --git a/notmuch-insert.c b/notmuch-insert.c
index
Add documentation for notmuch insert --folder option.
---
man/man1/notmuch-insert.1 | 14 ++
1 file changed, 14 insertions(+)
diff --git a/man/man1/notmuch-insert.1 b/man/man1/notmuch-insert.1
index 387e274..27c2658 100644
--- a/man/man1/notmuch-insert.1
+++
Add tests for notmuch insert --folder option.
---
test/insert | 17 +
1 file changed, 17 insertions(+)
diff --git a/test/insert b/test/insert
index d880af9..44e071c 100755
--- a/test/insert
+++ b/test/insert
@@ -66,4 +66,21 @@ notmuch insert +custom -unread < "$gen_msg_filename"
Allow the insert command to create the maildir folder
into which the new message should be delivered.
---
notmuch-insert.c | 100 +++
1 file changed, 100 insertions(+)
diff --git a/notmuch-insert.c b/notmuch-insert.c
index bc848ff..69329ad
Add documentation for notmuch insert --create-folder option.
---
man/man1/notmuch-insert.1 | 12
1 file changed, 12 insertions(+)
diff --git a/man/man1/notmuch-insert.1 b/man/man1/notmuch-insert.1
index 27c2658..8ce634e 100644
--- a/man/man1/notmuch-insert.1
+++
Add tests for notmuch insert --create-folder option.
---
test/insert | 24
1 file changed, 24 insertions(+)
diff --git a/test/insert b/test/insert
index 44e071c..24a61e1 100755
--- a/test/insert
+++ b/test/insert
@@ -83,4 +83,28 @@ gen_insert_msg
test_expect_code 1
Official announcement below.
Unofficial Summary: Distros might want this to help with autobuilding
problems. People building from source probably won't notice a difference
Tomi Ollila writes:
> The TERM environment variable is set to 'dumb' when running tests, but
> the original value of it is stored for echoing colors and running emacs
> (somewhat interactively) in detached session.
Pushed.
d
41 matches
Mail list logo
