[RFC PATCH v4 2/3] doc: add target rst2man to build man pages using rst2man

2014-02-25 Thread David Bremner
Many people have docutils installed, but not sphinx. Allow these people to build the man pages. --- Makefile | 2 +- doc/conf.py| 2 +- doc/rst2man/Makefile | 5 + doc/rst2man/Makefile.local | 37

[RFC PATCH v4 3/3] doc: fix for conversion errors

2014-02-25 Thread David Bremner
notmuch-show: For some reason a url got dropped. --- doc/man1/notmuch-show.rst | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/doc/man1/notmuch-show.rst b/doc/man1/notmuch-show.rst index 3fc3eca..bad868b 100644 --- a/doc/man1/notmuch-show.rst +++ b/doc/man1/notmuch-show.rst

Sphinx/docutils conversion v4

2014-02-25 Thread David Bremner
I think I got most of the formatting problems in this round. There are a few places where blank lines could be added; for technical reasons I'd prefer to leave that tidying to followup patches. I didn't do anything about python style/portability issues yet, or integrate the new docs completely

Re: Sphinx/docutils conversion v4

2014-02-25 Thread Mark Walters
This version LGTM with one small comment mentioned on irc (and already fixed). The small comment is that the --format option for dump and restore is in bold and not in [ ] so it looks required. Aside from that +1 from me. Best wishes Mark On Tue, 25 Feb 2014, David Bremner da...@tethera.net

[PATCH] test: Simplify CLEAN list construction

2014-02-25 Thread Austin Clements
Construct as much of the CLEAN list from TEST_BINARIES as possible, rather than duplicating this information by hand. --- test/Makefile.local | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/test/Makefile.local b/test/Makefile.local index 8870ca3..99324ba 100644 ---

Re: [PATCH] cli: command line option parser cleanup

2014-02-25 Thread Tomi Ollila
On Mon, Feb 24 2014, Jani Nikula j...@nikula.org wrote: Reduce the indentation for clarity. No functional changes. --- LGTM. I like the style. Tomi I've had this around for a while now, in preparation for something else that was never needed... --- command-line-arguments.c | 69

Re: [PATCH] test: Simplify CLEAN list construction

2014-02-25 Thread Tomi Ollila
On Tue, Feb 25 2014, Austin Clements amdra...@mit.edu wrote: Construct as much of the CLEAN list from TEST_BINARIES as possible, rather than duplicating this information by hand. --- LGTM. database-test.c is a library Tomi test/Makefile.local | 7 +-- 1 file changed, 1 insertion(+),

Re: [RFC PATCH v4 2/3] doc: add target rst2man to build man pages using rst2man

2014-02-25 Thread Jani Nikula
On Tue, 25 Feb 2014, David Bremner da...@tethera.net wrote: Many people have docutils installed, but not sphinx. Allow these people to build the man pages. Some bikeshedding... :) I think I'd prefer sphinx and docutils to be checked in the configure script (preferring sphinx over rst2man if

Re: [PATCH] emacs: remove newlines from input to notmuch count --batch

2014-02-25 Thread David Bremner
David Bremner da...@tethera.net writes: Since a newline starts a new query in batch mode, this causes mysterious crashes in the emacs interface if saved searches contain newlines. See the discussion at id:87wqhcxb5j@maritornes.cs.unb.ca pushed, d

Re: sanitization of args notmuch-cli in notmuch-emacs

2014-02-25 Thread David Bremner
David Bremner da...@tethera.net writes: Antoine Beaupré found a bug when notmuch-saved-searches contains newlines: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=737496 We can remove newlines with something like (mapcar (lambda (arg)

Re: [PATCH] man: escape backslash in notmuch-tag example

2014-02-25 Thread David Bremner
David Bremner da...@tethera.net writes: Tomi sortof convinced me on IRC that \e was a better choice that \\. I also looked at the groff manual, but that mostly encouraged me to work more on converting to something other than *roff. pushed this second version, although hopefully it will soon

Re: [PATCH] cli: command line option parser cleanup

2014-02-25 Thread David Bremner
Jani Nikula j...@nikula.org writes: Reduce the indentation for clarity. No functional changes. pushed, d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] test: Simplify CLEAN list construction

2014-02-25 Thread David Bremner
Austin Clements amdra...@mit.edu writes: Construct as much of the CLEAN list from TEST_BINARIES as possible, rather than duplicating this information by hand. pushed, d ___ notmuch mailing list notmuch@notmuchmail.org

Sphinx/docutils conversion v4

2014-02-25 Thread David Bremner
I think I got most of the formatting problems in this round. There are a few places where blank lines could be added; for technical reasons I'd prefer to leave that tidying to followup patches. I didn't do anything about python style/portability issues yet, or integrate the new docs completely

[RFC PATCH v4 2/3] doc: add target rst2man to build man pages using rst2man

2014-02-25 Thread David Bremner
Many people have docutils installed, but not sphinx. Allow these people to build the man pages. --- Makefile | 2 +- doc/conf.py| 2 +- doc/rst2man/Makefile | 5 + doc/rst2man/Makefile.local | 37

[RFC PATCH v4 3/3] doc: fix for conversion errors

2014-02-25 Thread David Bremner
notmuch-show: For some reason a url got dropped. --- doc/man1/notmuch-show.rst | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/doc/man1/notmuch-show.rst b/doc/man1/notmuch-show.rst index 3fc3eca..bad868b 100644 --- a/doc/man1/notmuch-show.rst +++ b/doc/man1/notmuch-show.rst

[RFC PATCH v4 1/3] doc: start of sphinx based docs

2014-02-25 Thread David Bremner
This is the output from sphinx-quickstart, massaged a bit, along with a man and texinfo pages all converted to rst. --- Makefile | 2 +- doc/Makefile | 5 + doc/Makefile.local| 28 + doc/conf.py | 166

Sphinx/docutils conversion v4

2014-02-25 Thread Mark Walters
This version LGTM with one small comment mentioned on irc (and already fixed). The small comment is that the --format option for dump and restore is in bold and not in [ ] so it looks required. Aside from that +1 from me. Best wishes Mark On Tue, 25 Feb 2014, David Bremner wrote: > I think

[PATCH] test: Simplify CLEAN list construction

2014-02-25 Thread Austin Clements
Construct as much of the CLEAN list from TEST_BINARIES as possible, rather than duplicating this information by hand. --- test/Makefile.local | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/test/Makefile.local b/test/Makefile.local index 8870ca3..99324ba 100644 ---

[PATCH] cli: command line option parser cleanup

2014-02-25 Thread Tomi Ollila
On Mon, Feb 24 2014, Jani Nikula wrote: > Reduce the indentation for clarity. No functional changes. > > --- LGTM. I like the style. Tomi > > I've had this around for a while now, in preparation for something > else that was never needed... > --- > command-line-arguments.c | 69 >

[PATCH] test: Simplify CLEAN list construction

2014-02-25 Thread Tomi Ollila
On Tue, Feb 25 2014, Austin Clements wrote: > Construct as much of the CLEAN list from TEST_BINARIES as possible, > rather than duplicating this information by hand. > --- LGTM. database-test.c is a "library" Tomi > test/Makefile.local | 7 +-- > 1 file changed, 1 insertion(+), 6

[RFC PATCH v4 2/3] doc: add target rst2man to build man pages using rst2man

2014-02-25 Thread Jani Nikula
On Tue, 25 Feb 2014, David Bremner wrote: > Many people have docutils installed, but not sphinx. Allow these > people to build the man pages. Some bikeshedding... :) I think I'd prefer sphinx and docutils to be checked in the configure script (preferring sphinx over rst2man if available,

[PATCH] emacs: remove newlines from input to notmuch count --batch

2014-02-25 Thread David Bremner
David Bremner writes: > Since a newline starts a new query in batch mode, this causes > mysterious crashes in the emacs interface if saved searches contain > newlines. See the discussion at > > id:87wqhcxb5j.fsf at maritornes.cs.unb.ca > pushed, d

sanitization of args notmuch-cli in notmuch-emacs

2014-02-25 Thread David Bremner
David Bremner writes: > Antoine Beaupr? found a bug when notmuch-saved-searches contains > newlines: > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=737496 > > We can remove newlines with something like > > (mapcar (lambda (arg) > (replace-regexp-in-string "\n"

[PATCH] man: escape backslash in notmuch-tag example

2014-02-25 Thread David Bremner
David Bremner writes: > > Tomi sortof convinced me on IRC that \e was a better choice that \\. I > also looked at the groff manual, but that mostly encouraged me to work > more on converting to something other than *roff. pushed this second version, although hopefully it will soon be obsolete.

[PATCH] cli: command line option parser cleanup

2014-02-25 Thread David Bremner
Jani Nikula writes: > Reduce the indentation for clarity. No functional changes. > pushed, d

[PATCH] test: Simplify CLEAN list construction

2014-02-25 Thread David Bremner
Austin Clements writes: > Construct as much of the CLEAN list from TEST_BINARIES as possible, > rather than duplicating this information by hand. pushed, d