Re: [PATCH] test: Print the number of the test along with its name

2014-03-04 Thread Tomi Ollila
On Tue, Mar 04 2014, Austin Clements amdra...@mit.edu wrote: Previously, we stripped the Tnnn- part from the test name when printing its description at the beginning of each test. However, this makes it difficult to find the source script for a test (e.g., when a test fails). Put this

[PATCH] cli: add missing \n in error message

2014-03-04 Thread Jani Nikula
The error messages returned by illegal_tag() don't contain newlines. --- tag-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tag-util.c b/tag-util.c index e2d5b795acc3..343c161f471a 100644 --- a/tag-util.c +++ b/tag-util.c @@ -172,7 +172,7 @@ parse_tag_command_line

[PATCH 1/1] test: use 'bare' test names in NOTMUCH_SKIP_TESTS comparisons

2014-03-04 Thread Tomi Ollila
The 'bare' part of test file name stays constant even when the filename prefixes of test scripts are renumbered. Also this change makes test skipping behave like documented. --- test/test-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test-lib.sh

Re: [PATCH] test: Print the number of the test along with its name

2014-03-04 Thread Jani Nikula
On Tue, 04 Mar 2014, Austin Clements amdra...@mit.edu wrote: Previously, we stripped the Tnnn- part from the test name when printing its description at the beginning of each test. However, this makes it difficult to find the source script for a test (e.g., when a test fails). Put this prefix

Re: [PATCH v2 00/13] literal folder: prefix, new path: prefix

2014-03-04 Thread Jani Nikula
On Sun, 02 Mar 2014, David Bremner da...@tethera.net wrote: Jani Nikula j...@nikula.org writes: I've dropped most of the content in patches 7 and 10 due to their size. The patches (and the whole series) are available in the boolean-folder-and-path-v2 branch at

[PATCH v2] test: NOTMUCH_SKIP_TESTS accepts test names with or without Tddd- prefix

2014-03-04 Thread Tomi Ollila
The test names assigned to NOTMUCH_SKIP_TESTS variable can now be given with or without the Tddd- prefix for tester convenience: The test name without Tddd -prefix stays constant even when test filenames are renumbered. The test name with Tddd -prefix is printed out when tests run. --- this

Re: [PATCH v2 00/13] literal folder: prefix, new path: prefix

2014-03-04 Thread David Bremner
Jani Nikula j...@nikula.org writes: I think we should use the prereq mechanism in the tests to check if a required test database is in place, skipping the test if not. This should be fairly straightforward to do, and does not care *how* the test database is to be fetched. (I'm undecided

Re: [PATCH] emacs: use the originating buffer's working directory for pipe

2014-03-04 Thread David Bremner
Jani Nikula j...@nikula.org writes: Always use the current show buffer's working directory for piping. The user can check that with M-x pwd and change it with M-x cd. This is consistent with notmuch-show-pipe-part. pushed, d ___ notmuch mailing

Re: NEWS/changelog patches

2014-03-04 Thread David Bremner
David Bremner da...@tethera.net writes: I went to mark the parent trivial when I realized the wording was wrong/confusing. Here is a second version, along with two more bug closings. series pushed. d ___ notmuch mailing list

Re: [PATCH v2] emacs: Simplify and fix `notmuch-mua-prompt-for-sender'

2014-03-04 Thread David Bremner
Austin Clements amdra...@mit.edu writes: Mark, is this better? hopefully so, because I pushed it. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] test: Print the number of the test along with its name

2014-03-04 Thread Austin Clements
Previously, we stripped the "Tnnn-" part from the test name when printing its description at the beginning of each test. However, this makes it difficult to find the source script for a test (e.g., when a test fails). Put this prefix back. --- test/test-lib.sh | 2 +- 1 file changed, 1

[PATCH] test: Print the number of the test along with its name

2014-03-04 Thread Tomi Ollila
On Tue, Mar 04 2014, Austin Clements wrote: > Previously, we stripped the "Tnnn-" part from the test name when > printing its description at the beginning of each test. However, this > makes it difficult to find the source script for a test (e.g., when a > test fails). Put this prefix back.

[PATCH] cli: add missing \n in error message

2014-03-04 Thread Jani Nikula
The error messages returned by illegal_tag() don't contain newlines. --- tag-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tag-util.c b/tag-util.c index e2d5b795acc3..343c161f471a 100644 --- a/tag-util.c +++ b/tag-util.c @@ -172,7 +172,7 @@ parse_tag_command_line

[PATCH 1/1] test: use 'bare' test names in NOTMUCH_SKIP_TESTS comparisons

2014-03-04 Thread Tomi Ollila
The 'bare' part of test file name stays constant even when the filename prefixes of test scripts are renumbered. Also this change makes test skipping behave like documented. --- test/test-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test-lib.sh

[PATCH] test: Print the number of the test along with its name

2014-03-04 Thread Jani Nikula
On Tue, 04 Mar 2014, Austin Clements wrote: > Previously, we stripped the "Tnnn-" part from the test name when > printing its description at the beginning of each test. However, this > makes it difficult to find the source script for a test (e.g., when a > test fails). Put this prefix back.

[PATCH v2 00/13] literal folder: prefix, new path: prefix

2014-03-04 Thread Jani Nikula
On Sun, 02 Mar 2014, David Bremner wrote: > Jani Nikula writes: >> >> I've dropped most of the content in patches 7 and 10 due to their >> size. The patches (and the whole series) are available in the >> boolean-folder-and-path-v2 branch at >> git://gitorious.org/jani/notmuch.git. Web interface

[PATCH v2] test: NOTMUCH_SKIP_TESTS accepts test names with or without Tddd- prefix

2014-03-04 Thread Tomi Ollila
The test names assigned to NOTMUCH_SKIP_TESTS variable can now be given with or without the Tddd- prefix for tester convenience: The test name without Tddd -prefix stays constant even when test filenames are renumbered. The test name with Tddd -prefix is printed out when tests run. --- this

[PATCH v2 00/13] literal folder: prefix, new path: prefix

2014-03-04 Thread David Bremner
Jani Nikula writes: > > I think we should use the prereq mechanism in the tests to check if a > required test database is in place, skipping the test if not. This > should be fairly straightforward to do, and does not care *how* the test > database is to be fetched. (I'm undecided whether the

NEWS/changelog patches

2014-03-04 Thread David Bremner
David Bremner writes: > I went to mark the parent trivial when I realized the wording was > wrong/confusing. > Here is a second version, along with two more "bug closings". series pushed. d

[PATCH] emacs: use the originating buffer's working directory for pipe

2014-03-04 Thread David Bremner
Jani Nikula writes: > > Always use the current show buffer's working directory for piping. The > user can check that with M-x pwd and change it with M-x cd. This is > consistent with notmuch-show-pipe-part. > pushed, d

[PATCH v2] emacs: Simplify and fix `notmuch-mua-prompt-for-sender'

2014-03-04 Thread David Bremner
Austin Clements writes: > > Mark, is this better? > hopefully so, because I pushed it. d