[PATCH] emacs: make sure tagging on an empty query is harmless

Currently notmuch-tag throws a wrong-type-argument stringp nil if passed a nil query-string. Catch this and provide a more useful error message. This fixes a case in notmuch-tree (if you try to tag when at the end of the buffer). Secondly, as pointed out by David (dme)

Re: [PATCH] emacs: make sure tagging on an empty query is harmless

On Wed, May 21 2014, Mark Walters wrote: Currently notmuch-tag throws a wrong-type-argument stringp nil if passed a nil query-string. Catch this and provide a more useful error message. This fixes a case in notmuch-tree (if you try to tag when at the end of the buffer). Secondly, as pointed

Re: [PATCH] emacs: make sure tagging on an empty query is harmless

On Wed, May 21 2014, Mark Walters markwalters1...@gmail.com wrote: Currently notmuch-tag throws a wrong-type-argument stringp nil if passed a nil query-string. Catch this and provide a more useful error message. This fixes a case in notmuch-tree (if you try to tag when at the end of the

[PATCH] configure: use cc/c++ when GCC not installed

Some systems (e.g. FreeBSD 10) do not ship with the GNU Compiler Collection. Use generic cc/c++ as a fallback when gcc/g++ are not available. --- configure | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 9bde2eb..3f4942b 100755 ---

Re: [PATCH 1/2] configure: add a fallback check for zlib

On Sat, May 10, 2014 at 05:27:34PM -0500, Felipe Contreras wrote: Tomi Ollila wrote: On Sun, May 11 2014, Felipe Contreras felipe.contre...@gmail.com wrote: Xīcò wrote: Since zlib is part of the base system, FreeBSD chose not to register it in pkg-config through zlib.pc. As a

Re: [PATCH 1/2] configure: add a fallback check for zlib

On Wed, May 21 2014, Fraser Tweedale fr...@frase.id.au wrote: On Sat, May 10, 2014 at 05:27:34PM -0500, Felipe Contreras wrote: Tomi Ollila wrote: On Sun, May 11 2014, Felipe Contreras felipe.contre...@gmail.com wrote: Xīcò wrote: Since zlib is part of the base system, FreeBSD chose

Re: [PATCH] configure: use cc/c++ when GCC not installed

On Wed, May 21 2014, Fraser Tweedale fr...@frase.id.au wrote: Some systems (e.g. FreeBSD 10) do not ship with the GNU Compiler Collection. Use generic cc/c++ as a fallback when gcc/g++ are not available. --- configure | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-)

Re: [PATCH] configure: use cc/c++ when GCC not installed

Tomi Ollila tomi.oll...@iki.fi writes: hash is builtin in modern shells, and is command in some systems which(1) is builtin in zsh (only?). Solaris 10 which(1) exits 0 even the command is not found. Tomi I thought command -v was the posix way of testing for a binary? d

Re: [PATCH v1] emacs: `notmuch-search-find-stable-query-region' should never return an empty query.

Mark Walters markwalters1...@gmail.com writes: Ok I now understand some of why it is a bug and it is a pretty gross mix: emacs does something odd, then notmuch-tag.c then xapian. It only happens in some cases: WARNING the following will archive some random messages: have a dump or backup or

Re: [PATCH 1/2] configure: add a fallback check for zlib

On Wed, May 21, 2014 at 10:34:25PM +0300, Tomi Ollila wrote: On Wed, May 21 2014, Fraser Tweedale fr...@frase.id.au wrote: On Sat, May 10, 2014 at 05:27:34PM -0500, Felipe Contreras wrote: Tomi Ollila wrote: On Sun, May 11 2014, Felipe Contreras felipe.contre...@gmail.com wrote:

Re: [PATCH] configure: use cc/c++ when GCC not installed

On Wed, May 21 2014, David Bremner da...@tethera.net wrote: Tomi Ollila tomi.oll...@iki.fi writes: hash is builtin in modern shells, and is command in some systems which(1) is builtin in zsh (only?). Solaris 10 which(1) exits 0 even the command is not found. Tomi I thought command -v was

RE: [PATCH] configure: use cc/c++ when GCC not installed

Fraser Tweedale wrote: Some systems (e.g. FreeBSD 10) do not ship with the GNU Compiler Collection. Use generic cc/c++ as a fallback when gcc/g++ are not available. --- configure | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/configure b/configure

Re: [PATCH] configure: use cc/c++ when GCC not installed

On Wed, May 21, 2014 at 10:49:03PM -0500, Felipe Contreras wrote: Fraser Tweedale wrote: Some systems (e.g. FreeBSD 10) do not ship with the GNU Compiler Collection. Use generic cc/c++ as a fallback when gcc/g++ are not available. --- configure | 12 ++-- 1 file changed, 10

[PATCH v1] emacs: `notmuch-search-find-stable-query-region' should never return an empty query.

On Tue, 20 May 2014, David Edmondson wrote: > On Mon, May 19 2014, Mark Walters wrote: >> On Mon, 19 May 2014, David Edmondson wrote: >>> `notmuch-search-find-stable-query-region' is expected to examine the >>> region between `beg' and `end' to generate a query that can be used to >>> include

[PATCH] emacs: make sure tagging on an empty query is harmless

Currently notmuch-tag throws a "wrong-type-argument stringp nil" if passed a nil query-string. Catch this and provide a more useful error message. This fixes a case in notmuch-tree (if you try to tag when at the end of the buffer). Secondly, as pointed out by David (dme)

[PATCH] emacs: make sure tagging on an empty query is harmless

(") ")"))) > +(when query-list > + (concat "(" (mapconcat 'identity query-list ") or (") ")" > > (defun notmuch-search-find-authors () >"Return the authors for the current thread" > -- > 1.7.10.4 -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 310 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140521/c1a9bf26/attachment.pgp>

[PATCH] emacs: make sure tagging on an empty query is harmless

On Wed, May 21 2014, Mark Walters wrote: > Currently notmuch-tag throws a "wrong-type-argument stringp nil" if > passed a nil query-string. Catch this and provide a more useful error > message. This fixes a case in notmuch-tree (if you try to tag when at > the end of the buffer). > > Secondly,

[PATCH] configure: use cc/c++ when GCC not installed

Some systems (e.g. FreeBSD 10) do not ship with the GNU Compiler Collection. Use generic cc/c++ as a fallback when gcc/g++ are not available. --- configure | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 9bde2eb..3f4942b 100755 ---

[PATCH 1/2] configure: add a fallback check for zlib

oblems with the patch as it is; I have tested it on FreeBSD 10.0 and it works. Regards, Fraser > -- > Felipe Contreras -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 834 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140521/7077f7e3/attachment.pgp>

[PATCH 1/2] configure: add a fallback check for zlib

On Wed, May 21 2014, Fraser Tweedale wrote: > On Sat, May 10, 2014 at 05:27:34PM -0500, Felipe Contreras wrote: >> Tomi Ollila wrote: >> > On Sun, May 11 2014, Felipe Contreras >> > wrote: >> > >> > > X?c? wrote: >> > >> Since zlib is part of the base system, FreeBSD chose not to register it

[PATCH] configure: use cc/c++ when GCC not installed

Tomi Ollila writes: > > hash is builtin in modern shells, and is command in some systems > which(1) is builtin in zsh (only?). Solaris 10 which(1) exits 0 > even the command is not found. > > Tomi I thought "command -v" was the posix way of testing for a binary? d

[PATCH] configure: use cc/c++ when GCC not installed

Fraser Tweedale wrote: > Some systems (e.g. FreeBSD 10) do not ship with the GNU Compiler > Collection. Use generic cc/c++ as a fallback when gcc/g++ are not > available. > --- > configure | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/configure