On Fri, 01 Aug 2014, Austin Clements amdra...@mit.edu wrote:
The version number has always been pretty meaningless to the user and
it's about to become even more meaningless with the introduction of
features. Hopefully, the database will remain on version 3 for some
time to come; however, the
On Fri, 01 Aug 2014, Austin Clements amdra...@mit.edu wrote:
Previously, our database schema was versioned by a single number.
Each database schema change had to occur atomically in Notmuch's
development history: before some commit, Notmuch used version N, after
that commit, it used version
On Fri, 01 Aug 2014, Austin Clements amdra...@mit.edu wrote:
This will let us test basic version and feature handling.
LGTM.
---
test/.gitignore | 1 +
test/Makefile.local | 4
test/make-db-version.cc | 35 +++
3 files changed, 40
Austin Clements amdra...@mit.edu writes:
+/* Bit mask of features used by this database. Features are
+ * named, independent aspects of the database schema. This is a
+ * bitwise-OR of NOTMUCH_FEATURE_* values (below). */
+unsigned int features;
Should we be using a fixed
Quoth Jani Nikula on Aug 23 at 6:39 pm:
On Fri, 01 Aug 2014, Austin Clements amdra...@mit.edu wrote:
The version number has always been pretty meaningless to the user and
it's about to become even more meaningless with the introduction of
features. Hopefully, the database will remain on
Quoth Jani Nikula on Aug 23 at 7:02 pm:
On Fri, 01 Aug 2014, Austin Clements amdra...@mit.edu wrote:
Previously, our database schema was versioned by a single number.
Each database schema change had to occur atomically in Notmuch's
development history: before some commit, Notmuch used
On Sat, 23 Aug 2014, David Bremner da...@tethera.net wrote:
Austin Clements amdra...@mit.edu writes:
+/* Bit mask of features used by this database. Features are
+ * named, independent aspects of the database schema. This is a
+ * bitwise-OR of NOTMUCH_FEATURE_* values
Austin Clements amdra...@mit.edu writes:
@@ -1048,7 +1164,8 @@ notmuch_database_get_version (notmuch_database_t
*notmuch)
notmuch_bool_t
notmuch_database_needs_upgrade (notmuch_database_t *notmuch)
{
-return notmuch-needs_upgrade;
+return notmuch-mode ==
On Fri, 01 Aug 2014, Austin Clements wrote:
> The version number has always been pretty meaningless to the user and
> it's about to become even more meaningless with the introduction of
> "features". Hopefully, the database will remain on version 3 for some
> time to come; however, the
On Fri, 01 Aug 2014, Austin Clements wrote:
> Previously, our database schema was versioned by a single number.
> Each database schema change had to occur "atomically" in Notmuch's
> development history: before some commit, Notmuch used version N, after
> that commit, it used version N+1. Hence,
On Fri, 01 Aug 2014, Austin Clements wrote:
> This will let us test basic version and feature handling.
LGTM.
> ---
> test/.gitignore | 1 +
> test/Makefile.local | 4
> test/make-db-version.cc | 35 +++
> 3 files changed, 40 insertions(+)
>
Austin Clements writes:
>
> +/* Bit mask of features used by this database. Features are
> + * named, independent aspects of the database schema. This is a
> + * bitwise-OR of NOTMUCH_FEATURE_* values (below). */
> +unsigned int features;
Should we be using a fixed size
Quoth Jani Nikula on Aug 23 at 6:39 pm:
> On Fri, 01 Aug 2014, Austin Clements wrote:
> > The version number has always been pretty meaningless to the user and
> > it's about to become even more meaningless with the introduction of
> > "features". Hopefully, the database will remain on version
Quoth Jani Nikula on Aug 23 at 7:02 pm:
> On Fri, 01 Aug 2014, Austin Clements wrote:
> > Previously, our database schema was versioned by a single number.
> > Each database schema change had to occur "atomically" in Notmuch's
> > development history: before some commit, Notmuch used version N,
On Sat, 23 Aug 2014, David Bremner wrote:
> Austin Clements writes:
>>
>> +/* Bit mask of features used by this database. Features are
>> + * named, independent aspects of the database schema. This is a
>> + * bitwise-OR of NOTMUCH_FEATURE_* values (below). */
>> +unsigned
Austin Clements writes:
>>> @@ -1048,7 +1164,8 @@ notmuch_database_get_version (notmuch_database_t
>>> *notmuch)
>>> notmuch_bool_t
>>> notmuch_database_needs_upgrade (notmuch_database_t *notmuch)
>>> {
>>> -return notmuch->needs_upgrade;
>>> +return notmuch->mode ==
16 matches
Mail list logo