Re: [PATCH v3 03/13] new: Don't report version after upgrade

2014-08-23 Thread Jani Nikula
On Fri, 01 Aug 2014, Austin Clements amdra...@mit.edu wrote: The version number has always been pretty meaningless to the user and it's about to become even more meaningless with the introduction of features. Hopefully, the database will remain on version 3 for some time to come; however, the

Re: [PATCH v3 04/13] lib: Database version 3: Introduce fine-grained features

2014-08-23 Thread Jani Nikula
On Fri, 01 Aug 2014, Austin Clements amdra...@mit.edu wrote: Previously, our database schema was versioned by a single number. Each database schema change had to occur atomically in Notmuch's development history: before some commit, Notmuch used version N, after that commit, it used version

Re: [PATCH v3 05/13] test: Tool to build DB with specific version and features

2014-08-23 Thread Jani Nikula
On Fri, 01 Aug 2014, Austin Clements amdra...@mit.edu wrote: This will let us test basic version and feature handling. LGTM. --- test/.gitignore | 1 + test/Makefile.local | 4 test/make-db-version.cc | 35 +++ 3 files changed, 40

Re: [PATCH v3 04/13] lib: Database version 3: Introduce fine-grained features

2014-08-23 Thread David Bremner
Austin Clements amdra...@mit.edu writes: +/* Bit mask of features used by this database. Features are + * named, independent aspects of the database schema. This is a + * bitwise-OR of NOTMUCH_FEATURE_* values (below). */ +unsigned int features; Should we be using a fixed

Re: [PATCH v3 03/13] new: Don't report version after upgrade

2014-08-23 Thread Austin Clements
Quoth Jani Nikula on Aug 23 at 6:39 pm: On Fri, 01 Aug 2014, Austin Clements amdra...@mit.edu wrote: The version number has always been pretty meaningless to the user and it's about to become even more meaningless with the introduction of features. Hopefully, the database will remain on

Re: [PATCH v3 04/13] lib: Database version 3: Introduce fine-grained features

2014-08-23 Thread Austin Clements
Quoth Jani Nikula on Aug 23 at 7:02 pm: On Fri, 01 Aug 2014, Austin Clements amdra...@mit.edu wrote: Previously, our database schema was versioned by a single number. Each database schema change had to occur atomically in Notmuch's development history: before some commit, Notmuch used

Re: [PATCH v3 04/13] lib: Database version 3: Introduce fine-grained features

2014-08-23 Thread Austin Clements
On Sat, 23 Aug 2014, David Bremner da...@tethera.net wrote: Austin Clements amdra...@mit.edu writes: +/* Bit mask of features used by this database. Features are + * named, independent aspects of the database schema. This is a + * bitwise-OR of NOTMUCH_FEATURE_* values

Re: [PATCH v3 04/13] lib: Database version 3: Introduce fine-grained features

2014-08-23 Thread David Bremner
Austin Clements amdra...@mit.edu writes: @@ -1048,7 +1164,8 @@ notmuch_database_get_version (notmuch_database_t *notmuch) notmuch_bool_t notmuch_database_needs_upgrade (notmuch_database_t *notmuch) { -return notmuch-needs_upgrade; +return notmuch-mode ==

[PATCH v3 03/13] new: Don't report version after upgrade

2014-08-23 Thread Jani Nikula
On Fri, 01 Aug 2014, Austin Clements wrote: > The version number has always been pretty meaningless to the user and > it's about to become even more meaningless with the introduction of > "features". Hopefully, the database will remain on version 3 for some > time to come; however, the

[PATCH v3 04/13] lib: Database version 3: Introduce fine-grained "features"

2014-08-23 Thread Jani Nikula
On Fri, 01 Aug 2014, Austin Clements wrote: > Previously, our database schema was versioned by a single number. > Each database schema change had to occur "atomically" in Notmuch's > development history: before some commit, Notmuch used version N, after > that commit, it used version N+1. Hence,

[PATCH v3 05/13] test: Tool to build DB with specific version and features

2014-08-23 Thread Jani Nikula
On Fri, 01 Aug 2014, Austin Clements wrote: > This will let us test basic version and feature handling. LGTM. > --- > test/.gitignore | 1 + > test/Makefile.local | 4 > test/make-db-version.cc | 35 +++ > 3 files changed, 40 insertions(+) >

[PATCH v3 04/13] lib: Database version 3: Introduce fine-grained "features"

2014-08-23 Thread David Bremner
Austin Clements writes: > > +/* Bit mask of features used by this database. Features are > + * named, independent aspects of the database schema. This is a > + * bitwise-OR of NOTMUCH_FEATURE_* values (below). */ > +unsigned int features; Should we be using a fixed size

[PATCH v3 03/13] new: Don't report version after upgrade

2014-08-23 Thread Austin Clements
Quoth Jani Nikula on Aug 23 at 6:39 pm: > On Fri, 01 Aug 2014, Austin Clements wrote: > > The version number has always been pretty meaningless to the user and > > it's about to become even more meaningless with the introduction of > > "features". Hopefully, the database will remain on version

[PATCH v3 04/13] lib: Database version 3: Introduce fine-grained "features"

2014-08-23 Thread Austin Clements
Quoth Jani Nikula on Aug 23 at 7:02 pm: > On Fri, 01 Aug 2014, Austin Clements wrote: > > Previously, our database schema was versioned by a single number. > > Each database schema change had to occur "atomically" in Notmuch's > > development history: before some commit, Notmuch used version N,

[PATCH v3 04/13] lib: Database version 3: Introduce fine-grained "features"

2014-08-23 Thread Austin Clements
On Sat, 23 Aug 2014, David Bremner wrote: > Austin Clements writes: >> >> +/* Bit mask of features used by this database. Features are >> + * named, independent aspects of the database schema. This is a >> + * bitwise-OR of NOTMUCH_FEATURE_* values (below). */ >> +unsigned

[PATCH v3 04/13] lib: Database version 3: Introduce fine-grained "features"

2014-08-23 Thread David Bremner
Austin Clements writes: >>> @@ -1048,7 +1164,8 @@ notmuch_database_get_version (notmuch_database_t >>> *notmuch) >>> notmuch_bool_t >>> notmuch_database_needs_upgrade (notmuch_database_t *notmuch) >>> { >>> -return notmuch->needs_upgrade; >>> +return notmuch->mode ==