Re: [PATCH] test: Port atomicity test to Python

2014-10-04 Thread David Bremner
Austin Clements acleme...@csail.mit.edu writes: Hi Amadeusz. Does this patch fix the problem for you? I don't have GDB 7.8, so I can't test against it, but the Python interface is less fragile than the GDB scripting language. (Even if this doesn't fix your problem, I think we should

Re: tests for notmuch-insert

2014-10-04 Thread David Bremner
David Bremner da...@tethera.net writes: This is in some sense a successor to id:cover.1411914914.git.j...@nikula.org It includes the first two patches of that series verbatim, and adds some tests. This series depends on the enabling of debug symbols in

Re: [PATCH 00/11] Add ghost messages and fix thread linking

2014-10-04 Thread Tomi Ollila
On Fri, Oct 03 2014, Austin Clements acleme...@csail.mit.edu wrote: This series modifies our database representation of messages that have been referenced by other messages, but for which we don't have the message itself. Currently, we store this information as Xapian metadata, but this has

Re: [PATCH] debian: append elinks to notmuch-vim dependencies

2014-10-04 Thread David Bremner
Sergei Shilovsky sshilov...@gmail.com writes: notmuch-vim uses elinks to convert HTML messages to text. --- debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/control b/debian/control index 6298deb..146dfea 100644 --- a/debian/control +++

[PATCH] hex-escape: remove unused variable default_buf_size

2014-10-04 Thread Jani Nikula
Found by clang: CC -O2 util/hex-escape.o util/hex-escape.c:28:21: warning: unused variable 'default_buf_size' [-Wunused-const-variable] static const size_t default_buf_size = 1024; ^ 1 warning generated. --- util/hex-escape.c | 2 -- 1 file changed, 2 deletions(-)

[PATCH] doc: build notmuch-emacs info/html docs, link from index

2014-10-04 Thread David Bremner
Although this manual is far from complete, it may be helpful for someone. In particular building it as part of the standard build process makes it easier to find problems when editing the notmuch-emacs-manual. --- doc/conf.py | 2 +- doc/index.rst | 1 + 2 files changed, 2 insertions(+), 1

Re: [PATCH] doc: build notmuch-emacs info/html docs, link from index

2014-10-04 Thread David Bremner
David Bremner da...@tethera.net writes: Although this manual is far from complete, it may be helpful for someone. In particular building it as part of the standard build process makes it easier to find problems when editing the notmuch-emacs-manual. this patch was motivated by the fact that

Re: [PATCH 00/11] Add ghost messages and fix thread linking

2014-10-04 Thread Austin Clements
On Sat, 04 Oct 2014, Tomi Ollila tomi.oll...@iki.fi wrote: On Fri, Oct 03 2014, Austin Clements acleme...@csail.mit.edu wrote: This series modifies our database representation of messages that have been referenced by other messages, but for which we don't have the message itself. Currently,

Re: [PATCH v6 1/2] nmbug: Translate to Python

2014-10-04 Thread David Bremner
W. Trevor King wk...@tremily.us writes: This allows us to capture stdout and stderr separately, and do other explicit subprocess manipulation without resorting to external packages. It should be compatible with Python 2.7 and later (including the 3.x series). Pushed patch 1/2 to master.

Re: [PATCH] hex-escape: remove unused variable default_buf_size

2014-10-04 Thread David Bremner
Jani Nikula j...@nikula.org writes: Found by clang: pushed d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] test: check for debug symbols in notmuch

2014-10-04 Thread David Bremner
Tomi Ollila tomi.oll...@iki.fi writes: On Fri, Oct 03 2014, David Bremner da...@tethera.net wrote: In the future, tests may rely on debug symbols being present in notmuch, so we plan to switch the default flags. The main purpose of this test is to help explain the perhaps mysterious

Re: [PATCH] test: Port atomicity test to Python

2014-10-04 Thread David Bremner
Austin Clements acleme...@csail.mit.edu writes: Previously, this was implemented using a horrible GDB script (because there is no such thing as a non-horrible GDB script). This GDB script often broke with newer versions of GDB for mysterious reasons. Port the test script to GDB's Python

[PATCH] NEWS: mention the change in default build flags

2014-10-04 Thread David Bremner
It blows things up by a factor of six or so, so it's worth giving people a heads up. It won't effect e.g. Debian, that already builds with -g and then strips. --- NEWS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS b/NEWS index fa57e5d..eb769fd 100644 --- a/NEWS +++ b/NEWS @@

[PATCH 1/2] test: check for debug symbols in notmuch

2014-10-04 Thread Tomi Ollila
On Fri, Oct 03 2014, David Bremner wrote: > In the future, tests may rely on debug symbols being present in > notmuch, so we plan to switch the default flags. > > The main purpose of this test is to help explain the perhaps > mysterious failures of other tests which rely on symbols being >

No subject

2014-10-04 Thread David Bremner
This is in some sense a successor to id:cover.1411914914.git.jani at nikula.org It includes the first two patches of that series verbatim, and adds some tests.

[Patch v2.5 3/4] cli/insert: require succesful message indexing for success status

2014-10-04 Thread David Bremner
From: Jani Nikula Add --keep option to keep any remaining stuff in index or file. We could distinguish between failures to index and failures to apply tags or maildir sync, but for simplicity just have one. --- doc/man1/notmuch-insert.rst | 19 ---

[Patch v2.5 1/4] test/insert: add known broken tests for indexing failures

2014-10-04 Thread David Bremner
These tests are written with the assumption that we want all indexing failures to be considered as failures by notmuch insert. --- test/T070-insert.sh | 22 ++ 1 file changed, 22 insertions(+) diff --git a/test/T070-insert.sh b/test/T070-insert.sh index ea9db07..40a7636

[Patch v2.5 4/4] test/insert: check that indexing errors are accepted with --keep

2014-10-04 Thread David Bremner
This is overkill for the current code path, but should provide some robustness for future changes in error handling. --- test/T070-insert.sh | 5 + 1 file changed, 5 insertions(+) diff --git a/test/T070-insert.sh b/test/T070-insert.sh index be8060e..80a22c1 100755 --- a/test/T070-insert.sh

[Patch v2.5 2/4] cli/insert: add fail path to add_file_to_database

2014-10-04 Thread David Bremner
From: Jani Nikula Handle failures gracefully in add_file_to_database, renamed simply add_file while at it. Add keep option to not remove the message from database if tagging or tag syncing to maildir flags fails. Expand the function documentation to cover the changes. ---

[no subject]

2014-10-04 Thread David Bremner
David Bremner writes: > This is in some sense a successor to > > id:cover.1411914914.git.jani at nikula.org > > It includes the first two patches of that series verbatim, and adds > some tests. I should have said _almost_ verbatim; it marks some tests non-broken.

[PATCH] Add default configuration values to the man page

2014-10-04 Thread David Bremner
Sergei Shilovsky writes: > **new.tags** > A list of tags that will be added to all messages incorporated > by **notmuch new**. > > +Default: ``unread;inbox``. > + There is actually something a bit subtle about some of these defaults. Some of them are applied

[PATCH] NEWS: News for notmuch-jump

2014-10-04 Thread David Bremner
Austin Clements writes: > --- > NEWS | 15 +++ > 1 file changed, 15 insertions(+) pushed, with thanks. d

[PATCH] test: Port atomicity test to Python

2014-10-04 Thread David Bremner
Austin Clements writes: > > Hi Amadeusz. Does this patch fix the problem for you? I don't have > GDB 7.8, so I can't test against it, but the Python interface is less > fragile than the GDB scripting language. (Even if this doesn't fix > your problem, I think we should switch to the Python

tests for notmuch-insert

2014-10-04 Thread David Bremner
David Bremner writes: > This is in some sense a successor to > > id:cover.1411914914.git.jani at nikula.org > > It includes the first two patches of that series verbatim, and adds > some tests. > This series depends on the enabling of debug symbols in

[PATCH 00/11] Add ghost messages and fix thread linking

2014-10-04 Thread Tomi Ollila
On Fri, Oct 03 2014, Austin Clements wrote: > This series modifies our database representation of messages that have > been referenced by other messages, but for which we don't have the > message itself. Currently, we store this information as Xapian > metadata, but this has several downsides

[PATCH] debian: append elinks to notmuch-vim dependencies

2014-10-04 Thread David Bremner
Sergei Shilovsky writes: > notmuch-vim uses elinks to convert HTML messages to text. > --- > debian/control | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian/control b/debian/control > index 6298deb..146dfea 100644 > --- a/debian/control > +++ b/debian/control > @@

[PATCH] hex-escape: remove unused variable default_buf_size

2014-10-04 Thread Jani Nikula
Found by clang: CC -O2 util/hex-escape.o util/hex-escape.c:28:21: warning: unused variable 'default_buf_size' [-Wunused-const-variable] static const size_t default_buf_size = 1024; ^ 1 warning generated. --- util/hex-escape.c | 2 -- 1 file changed, 2 deletions(-)

[PATCH] doc: build notmuch-emacs info/html docs, link from index

2014-10-04 Thread David Bremner
Although this manual is far from complete, it may be helpful for someone. In particular building it as part of the standard build process makes it easier to find problems when editing the notmuch-emacs-manual. --- doc/conf.py | 2 +- doc/index.rst | 1 + 2 files changed, 2 insertions(+), 1

[PATCH] doc: build notmuch-emacs info/html docs, link from index

2014-10-04 Thread David Bremner
David Bremner writes: > Although this manual is far from complete, it may be helpful for > someone. In particular building it as part of the standard build > process makes it easier to find problems when editing the > notmuch-emacs-manual. this patch was motivated by the fact that Austin's

[PATCH 00/11] Add ghost messages and fix thread linking

2014-10-04 Thread Austin Clements
On Sat, 04 Oct 2014, Tomi Ollila wrote: > On Fri, Oct 03 2014, Austin Clements wrote: > >> This series modifies our database representation of messages that have >> been referenced by other messages, but for which we don't have the >> message itself. Currently, we store this information as