Re: [PATCH] NEWS: mention the change in default build flags

On Sun, Oct 05 2014, David Bremner da...@tethera.net wrote: It blows things up by a factor of six or so, so it's worth giving people a heads up. It won't effect e.g. Debian, that already builds with -g and then strips. Maybe SomeOne(™) could make a patch that strip(1)s at make install time ?

Re: [PATCH 02/11] lib: Refactor _notmuch_database_link_message

Austin Clements acleme...@csail.mit.edu writes: +void *local = talloc_new (NULL); What's the advantage of using a local talloc context here? Is this just an optimization? d ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH 06/11] lib: Internal support for querying and creating ghost messages

Austin Clements acleme...@csail.mit.edu writes: + message-flags = ~(1 NOTMUCH_MESSAGE_FLAG_GHOST); What do you think about using bit set / clear / read macros? I don't insist, but I wonder if it would make this part more readable. + else if (*i == Tghost) +

Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature

Austin Clements acleme...@csail.mit.edu writes: +if (new_features NOTMUCH_FEATURE_GHOSTS) { + t_end = db-metadata_keys_end (thread_id_); + for (t = db-metadata_keys_begin (thread_id_); t != t_end; ++t) + ++total; +} It would be nice to have the comment below, or

Re: [PATCH 00/11] Add ghost messages and fix thread linking

Austin Clements acleme...@csail.mit.edu writes: This series modifies our database representation of messages that have been referenced by other messages, but for which we don't have the message itself. Currently, we store this information as Xapian metadata, but this has several downsides

Re: [PATCH] NEWS: mention the change in default build flags

Tomi Ollila tomi.oll...@iki.fi writes: On Sun, Oct 05 2014, David Bremner da...@tethera.net wrote: It blows things up by a factor of six or so, so it's worth giving people a heads up. It won't effect e.g. Debian, that already builds with -g and then strips. Maybe SomeOne(™) could make a

Re: [PATCH] Add default configuration values to the man page

On Wed, Oct 01 2014, Sergei Shilovsky wrote: --- doc/man1/notmuch-config.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/man1/notmuch-config.rst b/doc/man1/notmuch-config.rst index 3c9a568..9de5534 100644 --- a/doc/man1/notmuch-config.rst +++

[PATCH] NEWS: Document nmbug: Translate to Python

This is mostly culled from the commit message for 7f2cb3be (nmbug: Translate to Python, 2014-10-03). I realized while writing it that the 7f2cb3be commit message has: * 'nmbug log' now execs 'git log', as there's no need to keep the Python process around once we've launched Git there. But

[PATCH v2 0/4] notmuch search --output=addresses

Hi, this is a second version of my adaptation of Jani's patch series adding --output=addresses and similar arguments to notmuch search. Based on the feedback from others, this version uses Jani's original keyword flags implementation with --flag=a --flab=b syntax. Also the tests for --output and

[PATCH v2 4/4] cli: Add configurable address deduplication for --output=addresses

The code here is an extended version of a patch from Jani Nikula. --- completion/notmuch-completion.bash | 6 ++- completion/notmuch-completion.zsh | 3 +- doc/man1/notmuch-search.rst| 32 notmuch-search.c | 101 ++---

[PATCH v2 3/4] cli: Add support for parsing multiple keyword arguments

From: Jani Nikula j...@nikula.org This allows having multiple --foo=bar --foo=baz options on the command line, with the corresponding values OR'd together. [Test added by Michal Sojka] --- command-line-arguments.c | 6 +- command-line-arguments.h | 1 +

[PATCH v2 1/4] cli: Refactor option passing in the search command

Many functions that implement the search command need to access command line options. Instead of passing each option in a separate variable, put them in a structure and pass only this structure. This will become handy in the following patches. --- notmuch-search.c | 122

[PATCH v2 2/4] cli: Extend the search command for --output=addresses and similar

The new outputs allow printing senders, recipients or both of matching messages. This code based on a patch from Jani Nikula. --- completion/notmuch-completion.bash | 2 +- completion/notmuch-completion.zsh | 3 +- doc/man1/notmuch-search.rst| 22 +++- notmuch-search.c

Re: [PATCH 02/11] lib: Refactor _notmuch_database_link_message

Quoth David Bremner on Oct 05 at 9:45 am: Austin Clements acleme...@csail.mit.edu writes: +void *local = talloc_new (NULL); What's the advantage of using a local talloc context here? Is this just an optimization? There are a few allocations that wind up going in to this local context

Re: [PATCH 06/11] lib: Internal support for querying and creating ghost messages

Quoth David Bremner on Oct 05 at 10:30 am: Austin Clements acleme...@csail.mit.edu writes: + message-flags = ~(1 NOTMUCH_MESSAGE_FLAG_GHOST); What do you think about using bit set / clear / read macros? I don't insist, but I wonder if it would make this part more readable. I'm

Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature

Quoth David Bremner on Oct 05 at 10:56 am: Austin Clements acleme...@csail.mit.edu writes: +if (new_features NOTMUCH_FEATURE_GHOSTS) { + t_end = db-metadata_keys_end (thread_id_); + for (t = db-metadata_keys_begin (thread_id_); t != t_end; ++t) + ++total; +} It

[PATCH v6 1/2] nmbug: Translate to Python

"W. Trevor King" writes: > This allows us to capture stdout and stderr separately, and do other > explicit subprocess manipulation without resorting to external > packages. It should be compatible with Python 2.7 and later > (including the 3.x series). > Pushed patch 1/2 to master. This

[PATCH] hex-escape: remove unused variable default_buf_size

Jani Nikula writes: > Found by clang: > pushed d

[PATCH 1/2] test: check for debug symbols in notmuch

Tomi Ollila writes: > On Fri, Oct 03 2014, David Bremner wrote: > >> In the future, tests may rely on debug symbols being present in >> notmuch, so we plan to switch the default flags. >> >> The main purpose of this test is to help explain the perhaps >> mysterious failures of other tests which

[PATCH] test: Port atomicity test to Python

Austin Clements writes: > Previously, this was implemented using a horrible GDB script (because > there is no such thing as a non-horrible GDB script). This GDB script > often broke with newer versions of GDB for mysterious reasons. Port > the test script to GDB's Python API, which makes the

[PATCH] NEWS: mention the change in default build flags

It blows things up by a factor of six or so, so it's worth giving people a heads up. It won't effect e.g. Debian, that already builds with -g and then strips. --- NEWS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS b/NEWS index fa57e5d..eb769fd 100644 --- a/NEWS +++ b/NEWS @@

[PATCH] NEWS: mention the change in default build flags

On Sun, Oct 05 2014, David Bremner wrote: > It blows things up by a factor of six or so, so it's worth giving > people a heads up. It won't effect e.g. Debian, that already builds > with -g and then strips. Maybe SomeOne(?) could make a patch that strip(1)s at make install time ? Tomi > ---

[PATCH 02/11] lib: Refactor _notmuch_database_link_message

Austin Clements writes: > +void *local = talloc_new (NULL); What's the advantage of using a local talloc context here? Is this just an optimization? d

[PATCH 06/11] lib: Internal support for querying and creating ghost messages

Austin Clements writes: > + message->flags &= ~(1 << NOTMUCH_MESSAGE_FLAG_GHOST); What do you think about using bit set / clear / read macros? I don't insist, but I wonder if it would make this part more readable. > + else if (*i == "Tghost") > + message->flags |= (1 <<

[PATCH 08/11] lib: Implement upgrade to ghost messages feature

Austin Clements writes: > +if (new_features & NOTMUCH_FEATURE_GHOSTS) { > + t_end = db->metadata_keys_end ("thread_id_"); > + for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t) > + ++total; > +} It would be nice to have the comment below, or something like

[PATCH 00/11] Add ghost messages and fix thread linking

Austin Clements writes: > This series modifies our database representation of messages that have > been referenced by other messages, but for which we don't have the > message itself. Currently, we store this information as Xapian > metadata, but this has several downsides for performance and >

[PATCH] NEWS: mention the change in default build flags

Tomi Ollila writes: > On Sun, Oct 05 2014, David Bremner wrote: > >> It blows things up by a factor of six or so, so it's worth giving >> people a heads up. It won't effect e.g. Debian, that already builds >> with -g and then strips. > > Maybe SomeOne(?) could make a patch that strip(1)s at

[PATCH] Add default configuration values to the man page

On Wed, Oct 01 2014, Sergei Shilovsky wrote: > --- > doc/man1/notmuch-config.rst | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/doc/man1/notmuch-config.rst b/doc/man1/notmuch-config.rst > index 3c9a568..9de5534 100644 > --- a/doc/man1/notmuch-config.rst > +++

[PATCH] NEWS: Document "nmbug: Translate to Python"

This is mostly culled from the commit message for 7f2cb3be (nmbug: Translate to Python, 2014-10-03). I realized while writing it that the 7f2cb3be commit message has: * 'nmbug log' now execs 'git log', as there's no need to keep the Python process around once we've launched Git there. But

[PATCH v2 4/4] cli: Add configurable address deduplication for --output=addresses

The code here is an extended version of a patch from Jani Nikula. --- completion/notmuch-completion.bash | 6 ++- completion/notmuch-completion.zsh | 3 +- doc/man1/notmuch-search.rst| 32 notmuch-search.c | 101 ++---

[PATCH v2 0/4] notmuch search --output=addresses

Hi, this is a second version of my adaptation of Jani's patch series adding --output=addresses and similar arguments to notmuch search. Based on the feedback from others, this version uses Jani's original "keyword flags" implementation with --flag=a --flab=b syntax. Also the tests for --output

[PATCH v2 1/4] cli: Refactor option passing in the search command

Many functions that implement the search command need to access command line options. Instead of passing each option in a separate variable, put them in a structure and pass only this structure. This will become handy in the following patches. --- notmuch-search.c | 122

[PATCH v2 3/4] cli: Add support for parsing multiple keyword arguments

From: Jani Nikula This allows having multiple --foo=bar --foo=baz options on the command line, with the corresponding values OR'd together. [Test added by Michal Sojka] --- command-line-arguments.c | 6 +- command-line-arguments.h | 1 +

[PATCH v2 2/4] cli: Extend the search command for --output=addresses and similar

The new outputs allow printing senders, recipients or both of matching messages. This code based on a patch from Jani Nikula. --- completion/notmuch-completion.bash | 2 +- completion/notmuch-completion.zsh | 3 +- doc/man1/notmuch-search.rst| 22 +++- notmuch-search.c

[PATCH 02/11] lib: Refactor _notmuch_database_link_message

Quoth David Bremner on Oct 05 at 9:45 am: > Austin Clements writes: > > +void *local = talloc_new (NULL); > > What's the advantage of using a local talloc context here? Is this just > an optimization? There are a few allocations that wind up going in to this local context because of the

[PATCH 06/11] lib: Internal support for querying and creating ghost messages

Quoth David Bremner on Oct 05 at 10:30 am: > Austin Clements writes: > > > + message->flags &= ~(1 << NOTMUCH_MESSAGE_FLAG_GHOST); > > What do you think about using bit set / clear / read macros? I don't > insist, but I wonder if it would make this part more readable. I'm used to

[PATCH 08/11] lib: Implement upgrade to ghost messages feature

Quoth David Bremner on Oct 05 at 10:56 am: > Austin Clements writes: > > +if (new_features & NOTMUCH_FEATURE_GHOSTS) { > > + t_end = db->metadata_keys_end ("thread_id_"); > > + for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t) > > + ++total; > > +} > > It would