[PATCH 1/5] build: integrate building ruby bindings into notmuch build process

2015-01-01 Thread David Bremner
Because ruby generates a Makefile, we have to use recursive make. Because mkmf.rb hardcodes the name Makefile, put our Makefile{.local} in the parent directory. --- Makefile.local | 2 +- bindings/Makefile | 7 +++ bindings/Makefile.local | 18 ++

[PATCH 5/5] test: add initial ruby tests

2015-01-01 Thread David Bremner
This is pretty much a line by line translation of the existing python tests, with two new tests for the count API. --- test/T395-ruby.sh | 86 +++ test/test-lib.sh | 5 2 files changed, 91 insertions(+) create mode 100755

[PATCH 4/5] build/ruby: use notmuch configure script values for shared lib

2015-01-01 Thread David Bremner
This is supposed to help build on systems like MacOS with different conventions for naming shared libraries. We have already computed the relevant names, so doing it again in ruby seems like a bad idea. --- bindings/Makefile.local | 1 + bindings/ruby/extconf.rb | 13 +++-- 2 files

[PATCH 2/5] build/ruby: make use of -Wl,--no-undefined configurable

2015-01-01 Thread David Bremner
In particular this is supposed to help build on systems (presumably using a non-gnu ld) where this flag is not available. --- bindings/Makefile.local | 4 +++- bindings/ruby/extconf.rb | 5 +++-- configure| 13 + 3 files changed, 19 insertions(+), 3 deletions(-)

Re: [PATCH v3 10/10] cli: address: Add --filter-by option to configure address filtering

2015-01-01 Thread Tomi Ollila
On Wed, Dec 31 2014, David Bremner da...@tethera.net wrote: Michal Sojka sojk...@fel.cvut.cz writes: This option allows to configure the criterion for duplicate address filtering. Without this option, all unique combinations of name and address parts are printed. This option allows to filter

[PATCH 3/5] bindings/ruby: gitignore *.o

2015-01-01 Thread David Bremner
--- bindings/ruby/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/bindings/ruby/.gitignore b/bindings/ruby/.gitignore index fa25752..d682798 100644 --- a/bindings/ruby/.gitignore +++ b/bindings/ruby/.gitignore @@ -4,3 +4,4 @@ Makefile mkmf.log notmuch.so +*.o -- 2.1.3

Re: [PATCH 2/2] completion: complete notmuch insert --folder to maildir folders only

2015-01-01 Thread Jani Nikula
On Thu, 01 Jan 2015, Tomi Ollila tomi.oll...@iki.fi wrote: On Wed, Dec 31 2014, David Bremner da...@tethera.net wrote: Jani Nikula j...@nikula.org writes: + local path=`notmuch config get database.path` + compopt -o nospace + COMPREPLY=( $(compgen -d $path/${cur##folder:} |

Re: [PATCH 2/2] completion: complete notmuch insert --folder to maildir folders only

2015-01-01 Thread Tomi Ollila
On Wed, Dec 31 2014, David Bremner da...@tethera.net wrote: Jani Nikula j...@nikula.org writes: +local path=`notmuch config get database.path` +compopt -o nospace +COMPREPLY=( $(compgen -d $path/${cur##folder:} | \ +sed s|^$path/|| | grep -v

[PATCH v2] completion: complete notmuch insert --folder to maildir folders only

2015-01-01 Thread Jani Nikula
The --folder option expects a folder relative from maildir root, so complete like the folder: search term. --- completion/notmuch-completion.bash | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/completion/notmuch-completion.bash b/completion/notmuch-completion.bash index

Re: [PATCH] ruby: allow bindings to compile on Mac OS X

2015-01-01 Thread David Bremner
Ludovic LANGE ll-notmuchm...@lange.nom.fr writes: On OS X, the library ends with .dylib (instead of .so). I also added the .dll handling in any case. Also, the flags '-Wl,--no-undefined' seems not accepted, so I excluded them on OS X (only) If you have a chance, please check out the series

Re: [PATCH v2] emacs: add stash support for git send-email command line

2015-01-01 Thread David Edmondson
On Thu, Jan 01 2015, Jani Nikula wrote: Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as --in-reply-to, suitable for pasting to git send-email command line. --- emacs/notmuch-show.el | 38 ++ 1 file changed, 38 insertions(+) diff --git

Re: [PATCH] lib: another iterator-temporary/stale-pointer bug

2015-01-01 Thread Jani Nikula
On Sun, 28 Dec 2014, David Bremner da...@tethera.net wrote: Tamas Szakaly points out [1] that the bug fixed in 51b073c still exists in at least one place. This change follows the suggestion of [2] and creates a block scope temporary std::string to avoid the rules of iterators temporaries.

[PATCH v2] emacs: add stash support for git send-email command line

2015-01-01 Thread Jani Nikula
Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as --in-reply-to, suitable for pasting to git send-email command line. --- emacs/notmuch-show.el | 38 ++ 1 file changed, 38 insertions(+) diff --git a/emacs/notmuch-show.el

[PATCH] HACK: lib: add brute and ignorant handling of database lock errors

2015-01-01 Thread Jani Nikula
From: Jani Nikula jani.nik...@intel.com Instead of failing at first try, back off for an increasing number of seconds, and only fail after three attempts. One of my notmuch installations that gets plenty of mail hits db locked exceptions quite often, and even more than before since I switched to

Re: [PATCH] lib: drop the deprecation message for single-message mbox files

2015-01-01 Thread David Bremner
Jani Nikula j...@nikula.org writes: We generally do not support mbox files, but for historical reasons we've supported single-message mbox files, with a deprecation message. We've tried dropping the support altogether, but backed out of it because we'd need to stop indexing them, while

Re: [PATCH 3/5] bindings/ruby: gitignore *.o

2015-01-01 Thread David Bremner
David Bremner da...@tethera.net writes: --- bindings/ruby/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/bindings/ruby/.gitignore b/bindings/ruby/.gitignore index fa25752..d682798 100644 --- a/bindings/ruby/.gitignore +++ b/bindings/ruby/.gitignore @@ -4,3 +4,4 @@

Re: [PATCH v2] Add default configuration values to the man page

2015-01-01 Thread David Bremner
Sergei Shilovsky sshilov...@gmail.com writes: --- doc/man1/notmuch-config.rst | 21 + 1 file changed, 21 insertions(+) Pushed to master, thanks for your contribution, and sorry about the delay. d ___ notmuch mailing list

[PATCH 2/2] completion: complete notmuch insert --folder to maildir folders only

2015-01-01 Thread Tomi Ollila
On Wed, Dec 31 2014, David Bremner wrote: > Jani Nikula writes: >> +local path=`notmuch config get database.path` >> +compopt -o nospace >> +COMPREPLY=( $(compgen -d "$path/${cur##folder:}" | \ >> +sed "s|^$path/||" | grep -v "\(^\|/\)\(cur\|new\|tmp\)$" > >

[PATCH 3/5] bindings/ruby: gitignore *.o

2015-01-01 Thread David Bremner
--- bindings/ruby/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/bindings/ruby/.gitignore b/bindings/ruby/.gitignore index fa25752..d682798 100644 --- a/bindings/ruby/.gitignore +++ b/bindings/ruby/.gitignore @@ -4,3 +4,4 @@ Makefile mkmf.log notmuch.so +*.o -- 2.1.3

Build and test ruby bindings

2015-01-01 Thread David Bremner
This series collects some patches that were originally part of the "count API change" series, and adds a few fixups that are designed to help with building in MacOS and other non-Gnu places (although they haven't been tested there yet). [PATCH 1/5] build: integrate building ruby bindings into

[PATCH 5/5] test: add initial ruby tests

2015-01-01 Thread David Bremner
This is pretty much a line by line translation of the existing python tests, with two new tests for the count API. --- test/T395-ruby.sh | 86 +++ test/test-lib.sh | 5 2 files changed, 91 insertions(+) create mode 100755

[PATCH 1/5] build: integrate building ruby bindings into notmuch build process

2015-01-01 Thread David Bremner
Because ruby generates a Makefile, we have to use recursive make. Because mkmf.rb hardcodes the name Makefile, put our Makefile{.local} in the parent directory. --- Makefile.local | 2 +- bindings/Makefile | 7 +++ bindings/Makefile.local | 18 ++

[PATCH 2/5] build/ruby: make use of -Wl,--no-undefined configurable

2015-01-01 Thread David Bremner
In particular this is supposed to help build on systems (presumably using a non-gnu ld) where this flag is not available. --- bindings/Makefile.local | 4 +++- bindings/ruby/extconf.rb | 5 +++-- configure| 13 + 3 files changed, 19 insertions(+), 3 deletions(-)

[PATCH 4/5] build/ruby: use notmuch configure script values for shared lib

2015-01-01 Thread David Bremner
This is supposed to help build on systems like MacOS with different conventions for naming shared libraries. We have already computed the relevant names, so doing it again in ruby seems like a bad idea. --- bindings/Makefile.local | 1 + bindings/ruby/extconf.rb | 13 +++-- 2 files

[PATCH] ruby: allow bindings to compile on Mac OS X

2015-01-01 Thread David Bremner
Ludovic LANGE writes: > On OS X, the library ends with .dylib (instead of .so). I also added > the .dll handling in any case. > Also, the flags '-Wl,--no-undefined' seems not accepted, so I excluded > them on OS X (only) If you have a chance, please check out the series at

[PATCH 2/2] completion: complete notmuch insert --folder to maildir folders only

2015-01-01 Thread Jani Nikula
On Thu, 01 Jan 2015, Tomi Ollila wrote: > On Wed, Dec 31 2014, David Bremner wrote: > >> Jani Nikula writes: >>> + local path=`notmuch config get database.path` >>> + compopt -o nospace >>> + COMPREPLY=( $(compgen -d "$path/${cur##folder:}" | \ >>> + sed

[PATCH v2] completion: complete notmuch insert --folder to maildir folders only

2015-01-01 Thread Jani Nikula
The --folder option expects a folder relative from maildir root, so complete like the folder: search term. --- completion/notmuch-completion.bash | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/completion/notmuch-completion.bash b/completion/notmuch-completion.bash index

[PATCH] lib: another iterator-temporary/stale-pointer bug

2015-01-01 Thread Jani Nikula
On Sun, 28 Dec 2014, David Bremner wrote: > Tamas Szakaly points out [1] that the bug fixed in 51b073c still > exists in at least one place. This change follows the suggestion of > [2] and creates a block scope temporary std::string to avoid the rules > of iterators temporaries. > > [1]:

[PATCH] lib: drop the deprecation message for single-message mbox files

2015-01-01 Thread David Bremner
Jani Nikula writes: > We generally do not support mbox files, but for historical reasons > we've supported single-message mbox files, with a deprecation > message. We've tried dropping the support altogether, but backed out > of it because we'd need to stop indexing them, while keeping support >

[PATCH 3/5] bindings/ruby: gitignore *.o

2015-01-01 Thread David Bremner
David Bremner writes: > --- > bindings/ruby/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/bindings/ruby/.gitignore b/bindings/ruby/.gitignore > index fa25752..d682798 100644 > --- a/bindings/ruby/.gitignore > +++ b/bindings/ruby/.gitignore > @@ -4,3 +4,4 @@ > Makefile >

[PATCH v2] Add default configuration values to the man page

2015-01-01 Thread David Bremner
Sergei Shilovsky writes: > --- > doc/man1/notmuch-config.rst | 21 + > 1 file changed, 21 insertions(+) > Pushed to master, thanks for your contribution, and sorry about the delay. d

[PATCH v2] emacs: add stash support for git send-email command line

2015-01-01 Thread Jani Nikula
Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as --in-reply-to, suitable for pasting to git send-email command line. --- emacs/notmuch-show.el | 38 ++ 1 file changed, 38 insertions(+) diff --git a/emacs/notmuch-show.el

[PATCH] HACK: lib: add brute and ignorant handling of database lock errors

2015-01-01 Thread Jani Nikula
From: Jani Nikula Instead of failing at first try, back off for an increasing number of seconds, and only fail after three attempts. One of my notmuch installations that gets plenty of mail hits db locked exceptions quite often, and even more than before since I switched

[PATCH v3 10/10] cli: address: Add --filter-by option to configure address filtering

2015-01-01 Thread Tomi Ollila
On Wed, Dec 31 2014, David Bremner wrote: > Michal Sojka writes: > >> This option allows to configure the criterion for duplicate address >> filtering. Without this option, all unique combinations of name and >> address parts are printed. This option allows to filter the output >> more, for