[PATCH] lib: convert two iterator copy strings into references.

2015-01-02 Thread David Bremner
Apparently this is a supported and even idiomatic way of keeping a temporary object (e.g. like that returned from an operator dereference) alive. --- I decided it was better to do both of these keepalive strings the same way, so I applied the parent patch as is. lib/message.cc | 4 ++-- 1 file

Re: [PATCH 1/2] completion: complete notmuch insert --keep and --no-hooks options

2015-01-02 Thread David Bremner
Jani Nikula j...@nikula.org writes: --- completion/notmuch-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied this, and v2 of the next patch. I guess this means the zsh completion is falling behind? d ___ notmuch

Re: [PATCH v3] emacs: add stash support for git send-email command line

2015-01-02 Thread Tomi Ollila
On Fri, Jan 02 2015, David Edmondson d...@dme.org wrote: Looks good to me. LGTM, too, and seems to work -- and docstrings actually adhere the conventions... from http://web.mit.edu/Emacs/source/emacs/lisp/emacs-lisp/checkdoc.el ;; * Format the documentation string so that it fits in an

Re: [PATCH v2] emacs: add stash support for git send-email command line

2015-01-02 Thread Jani Nikula
On Fri, 02 Jan 2015, David Edmondson d...@dme.org wrote: On Thu, Jan 01 2015, Jani Nikula wrote: Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as --in-reply-to, suitable for pasting to git send-email command line. --- emacs/notmuch-show.el | 38

Re: [PATCH v3] emacs: add stash support for git send-email command line

2015-01-02 Thread David Edmondson
Looks good to me. On Fri, Jan 02 2015, Jani Nikula wrote: Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as --in-reply-to, suitable for pasting to git send-email command line. --- emacs/notmuch-show.el | 38 ++ 1 file changed, 38

[PATCH v3] emacs: add stash support for git send-email command line

2015-01-02 Thread Jani Nikula
Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as --in-reply-to, suitable for pasting to git send-email command line. --- emacs/notmuch-show.el | 38 ++ 1 file changed, 38 insertions(+) diff --git a/emacs/notmuch-show.el

Re: [PATCH] lib: convert two iterator copy strings into references.

2015-01-02 Thread Tomi Ollila
On Fri, Jan 02 2015, David Bremner da...@tethera.net wrote: Apparently this is a supported and even idiomatic way of keeping a temporary object (e.g. like that returned from an operator dereference) alive. --- Based on internet search with words 'c++ reference to temporary' (*) I believe the

Re: [PATCH] lib: convert two iterator copy strings into references.

2015-01-02 Thread Jani Nikula
On Fri, 02 Jan 2015, David Bremner da...@tethera.net wrote: Apparently this is a supported and even idiomatic way of keeping a temporary object (e.g. like that returned from an operator dereference) alive. --- I decided it was better to do both of these keepalive strings the same way, so I

Re: [PATCH] completion: remove the broken notmuch-completion.tcsh

2015-01-02 Thread Tomi Ollila
On Fri, Jan 02 2015, Jani Nikula j...@nikula.org wrote: The tcsh completion is minimal yet doesn't work at all. We're better off without it, it's more embarrassing than useful. --- Agreed. Tomi completion/README | 4 completion/notmuch-completion.tcsh | 2 -- 2

[PATCH] completion: remove the broken notmuch-completion.tcsh

2015-01-02 Thread Jani Nikula
The tcsh completion is minimal yet doesn't work at all. We're better off without it, it's more embarrassing than useful. --- completion/README | 4 completion/notmuch-completion.tcsh | 2 -- 2 files changed, 6 deletions(-) delete mode 100644

Re: [PATCH 1/2] completion: complete notmuch insert --keep and --no-hooks options

2015-01-02 Thread Jani Nikula
On Fri, 02 Jan 2015, David Bremner da...@tethera.net wrote: Jani Nikula j...@nikula.org writes: --- completion/notmuch-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied this, and v2 of the next patch. I guess this means the zsh completion is falling behind?

[PATCH v2] emacs: add stash support for git send-email command line

2015-01-02 Thread David Edmondson
On Thu, Jan 01 2015, Jani Nikula wrote: > Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as > --in-reply-to, suitable for pasting to git send-email command line. > --- > emacs/notmuch-show.el | 38 ++ > 1 file changed, 38 insertions(+) > >

[PATCH] lib: convert two "iterator copy strings" into references.

2015-01-02 Thread David Bremner
Apparently this is a supported and even idiomatic way of keeping a temporary object (e.g. like that returned from an operator dereference) alive. --- I decided it was better to do both of these "keepalive" strings the same way, so I applied the parent patch as is. lib/message.cc | 4 ++-- 1

[PATCH 1/2] completion: complete notmuch insert --keep and --no-hooks options

2015-01-02 Thread David Bremner
Jani Nikula writes: > --- > completion/notmuch-completion.bash | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied this, and v2 of the next patch. I guess this means the zsh completion is falling behind? d

[PATCH v3] emacs: add stash support for git send-email command line

2015-01-02 Thread Jani Nikula
Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as --in-reply-to, suitable for pasting to git send-email command line. --- emacs/notmuch-show.el | 38 ++ 1 file changed, 38 insertions(+) diff --git a/emacs/notmuch-show.el

[PATCH v2] emacs: add stash support for git send-email command line

2015-01-02 Thread Jani Nikula
On Fri, 02 Jan 2015, David Edmondson wrote: > On Thu, Jan 01 2015, Jani Nikula wrote: >> Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as >> --in-reply-to, suitable for pasting to git send-email command line. >> --- >> emacs/notmuch-show.el | 38

[PATCH] lib: convert two "iterator copy strings" into references.

2015-01-02 Thread Jani Nikula
On Fri, 02 Jan 2015, David Bremner wrote: > Apparently this is a supported and even idiomatic way of keeping a > temporary object (e.g. like that returned from an operator > dereference) alive. > --- > > I decided it was better to do both of these "keepalive" strings the > same way, so I applied

[PATCH 1/2] completion: complete notmuch insert --keep and --no-hooks options

2015-01-02 Thread Jani Nikula
On Fri, 02 Jan 2015, David Bremner wrote: > Jani Nikula writes: > >> --- >> completion/notmuch-completion.bash | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Applied this, and v2 of the next patch. > > I guess this means the zsh completion is falling behind? Since a long time ago

[PATCH] completion: remove the broken notmuch-completion.tcsh

2015-01-02 Thread Jani Nikula
The tcsh completion is minimal yet doesn't work at all. We're better off without it, it's more embarrassing than useful. --- completion/README | 4 completion/notmuch-completion.tcsh | 2 -- 2 files changed, 6 deletions(-) delete mode 100644

[PATCH v3] emacs: add stash support for git send-email command line

2015-01-02 Thread David Edmondson
Looks good to me. On Fri, Jan 02 2015, Jani Nikula wrote: > Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as > --in-reply-to, suitable for pasting to git send-email command line. > --- > emacs/notmuch-show.el | 38 ++ > 1 file changed, 38

[PATCH v3] emacs: add stash support for git send-email command line

2015-01-02 Thread Tomi Ollila
On Fri, Jan 02 2015, David Edmondson wrote: > Looks good to me. LGTM, too, and seems to work -- and docstrings actually adhere the conventions... from http://web.mit.edu/Emacs/source/emacs/lisp/emacs-lisp/checkdoc.el ;; * Format the documentation string so that it fits in an ;;

[PATCH] completion: remove the broken notmuch-completion.tcsh

2015-01-02 Thread Tomi Ollila
On Fri, Jan 02 2015, Jani Nikula wrote: > The tcsh completion is minimal yet doesn't work at all. We're better > off without it, it's more embarrassing than useful. > --- Agreed. Tomi > completion/README | 4 > completion/notmuch-completion.tcsh | 2 -- > 2 files

[PATCH] lib: convert two "iterator copy strings" into references.

2015-01-02 Thread Tomi Ollila
On Fri, Jan 02 2015, David Bremner wrote: > Apparently this is a supported and even idiomatic way of keeping a > temporary object (e.g. like that returned from an operator > dereference) alive. > --- Based on internet search with words 'c++ reference to temporary' (*) I believe the change is