[PATCH 1/2] configure: add check for python interepreter name

2015-01-03 Thread David Bremner
Currently we hardcode python in several places. This makes things hard for people who have only commands called python3 and/or python2. We also add the name to sh.config to eventually replace the current workaround in the test suite. --- configure | 26 ++ 1 file changed,

[PATCH 2/2] completion: generate notmuch-completion.zsh using doc/conf.py

2015-01-03 Thread David Bremner
I noticed that the (out of date) list of subcommands was simply repeating the summary lines from the manpage. Since those summary lines are already kept in machine readable form in doc/conf.py, it's easy to compute that part of the completion file. --- completion/Makefile.local | 12

[PATCH] doc: Allow rst2man.py as an alternative to rst2man

2015-01-03 Thread Tomi Ollila
From: W. Trevor King wk...@tremily.us Gentoo's dev-python/docutils-0.10 installs Docutils scripts with a *.py extension, so I have /usr/bin/rst2man.py and no rst2man script. This patch supports users with both types of systems by checking for rst2man, falling back on rst2man.py, and giving up

Re: [PATCH] build: eliminate use of python execfile command

2015-01-03 Thread Tomi Ollila
On Sat, Jan 03 2015, David Bremner da...@tethera.net wrote: As discussed in id:8cc9dd580ad672527e12f43706f9803b2c8e99d8.1405220724.git.wk...@tremily.us, execfile is unavailable in python3. The approach of this commit avoids modifying the python module path, which is arguably preferable

Re: [PATCH 2/2] completion: generate notmuch-completion.zsh using doc/conf.py

2015-01-03 Thread Tomi Ollila
On Sat, Jan 03 2015, David Bremner da...@tethera.net wrote: David Bremner da...@tethera.net writes: I noticed that the (out of date) list of subcommands was simply repeating the summary lines from the manpage. Since those summary lines are already kept in machine readable form in

[PATCH] build: eliminate use of python execfile command

2015-01-03 Thread David Bremner
As discussed in id:8cc9dd580ad672527e12f43706f9803b2c8e99d8.1405220724.git.wk...@tremily.us, execfile is unavailable in python3. The approach of this commit avoids modifying the python module path, which is arguably preferable since it avoids potentially accidentally importing a module from the

Re: [PATCH 2/2] completion: generate notmuch-completion.zsh using doc/conf.py

2015-01-03 Thread David Bremner
David Bremner da...@tethera.net writes: I noticed that the (out of date) list of subcommands was simply repeating the summary lines from the manpage. Since those summary lines are already kept in machine readable form in doc/conf.py, it's easy to compute that part of the completion file. I

Re: BUG: Using pointer that points to a destructed string's content

2015-01-03 Thread David Bremner
Tamas Szakaly sghct...@gmail.com writes: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dear notmuch developers, The following line is from _notmuch_message_add_directory_terms in lib/message.cc (line 652 in HEAD): direntry = (*i).c_str (); This should be fixed in commit 3d978a0d d

Re: [PATCH] lib: convert two iterator copy strings into references.

2015-01-03 Thread David Bremner
David Bremner da...@tethera.net writes: Apparently this is a supported and even idiomatic way of keeping a temporary object (e.g. like that returned from an operator dereference) alive. pushed. d ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH] completion: remove the broken notmuch-completion.tcsh

2015-01-03 Thread David Bremner
Jani Nikula j...@nikula.org writes: The tcsh completion is minimal yet doesn't work at all. We're better off without it, it's more embarrassing than useful. pushed d ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH] doc: Allow rst2man.py as an alternative to rst2man

2015-01-03 Thread David Bremner
From: W. Trevor King wk...@tremily.us Gentoo's dev-python/docutils-0.10 installs Docutils scripts with a *.py extension, so I have /usr/bin/rst2man.py and no rst2man script. This patch supports users with both types of systems by checking for rst2man, falling back on rst2man.py, and giving up

Re: [PATCH] doc: Allow rst2man.py as an alternative to rst2man

2015-01-03 Thread W. Trevor King
On Sat, Jan 03, 2015 at 04:49:27PM +0100, David Bremner wrote: At the risk of bike-shedding, rewrite the configure check to be more obvious. This is pretty subjective, but in particular I'm not a big fan of resetting RST2MAN at the bottom of every iteration of the for loop. Also conform a bit

Re: [PATCH] doc: Allow rst2man.py as an alternative to rst2man

2015-01-03 Thread Tomi Ollila
On Sat, Jan 03 2015, W. Trevor King wk...@tremily.us wrote: On Sat, Jan 03, 2015 at 04:49:27PM +0100, David Bremner wrote: At the risk of bike-shedding, rewrite the configure check to be more obvious. This is pretty subjective, but in particular I'm not a big fan of resetting RST2MAN at the

Re: [PATCH] doc: Allow rst2man.py as an alternative to rst2man

2015-01-03 Thread David Bremner
Tomi Ollila tomi.oll...@iki.fi writes: I'd presume anyone else using such an old system will have bigger problems getting their notmuch compiled (recent enough zlib being one of those), so this makes me wonder whether there is actually anyone needing rst2man there (besides me, of course :) I

[PATCH] completion: remove the broken notmuch-completion.tcsh

2015-01-03 Thread David Bremner
Jani Nikula writes: > The tcsh completion is minimal yet doesn't work at all. We're better > off without it, it's more embarrassing than useful. pushed d

[PATCH] lib: convert two "iterator copy strings" into references.

2015-01-03 Thread David Bremner
David Bremner writes: > Apparently this is a supported and even idiomatic way of keeping a > temporary object (e.g. like that returned from an operator > dereference) alive. pushed. d

[PATCH 1/2] configure: add check for python interepreter name

2015-01-03 Thread David Bremner
Currently we hardcode "python" in several places. This makes things hard for people who have only commands called python3 and/or python2. We also add the name to sh.config to eventually replace the current workaround in the test suite. --- configure | 26 ++ 1 file

[PATCH 2/2] completion: generate notmuch-completion.zsh using doc/conf.py

2015-01-03 Thread David Bremner
I noticed that the (out of date) list of subcommands was simply repeating the summary lines from the manpage. Since those summary lines are already kept in machine readable form in doc/conf.py, it's easy to compute that part of the completion file. --- completion/Makefile.local | 12

[PATCH] build: eliminate use of python execfile command

2015-01-03 Thread David Bremner
As discussed in id:8cc9dd580ad672527e12f43706f9803b2c8e99d8.1405220724.git.wking at tremily.us, execfile is unavailable in python3. The approach of this commit avoids modifying the python module path, which is arguably preferable since it avoids potentially accidentally importing a module from

[PATCH 2/2] completion: generate notmuch-completion.zsh using doc/conf.py

2015-01-03 Thread David Bremner
David Bremner writes: > I noticed that the (out of date) list of subcommands was simply > repeating the summary lines from the manpage. Since those summary > lines are already kept in machine readable form in doc/conf.py, > it's easy to compute that part of the completion file. I meant to

BUG: Using pointer that points to a destructed string's content

2015-01-03 Thread David Bremner
Tamas Szakaly writes: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Dear notmuch developers, > > The following line is from _notmuch_message_add_directory_terms in > lib/message.cc (line 652 in HEAD): > > direntry = (*i).c_str (); > This should be fixed in commit 3d978a0d d

[PATCH 2/2] completion: generate notmuch-completion.zsh using doc/conf.py

2015-01-03 Thread Tomi Ollila
On Sat, Jan 03 2015, David Bremner wrote: > David Bremner writes: > >> I noticed that the (out of date) list of subcommands was simply >> repeating the summary lines from the manpage. Since those summary >> lines are already kept in machine readable form in doc/conf.py, >> it's easy to compute

[PATCH] build: eliminate use of python execfile command

2015-01-03 Thread Tomi Ollila
On Sat, Jan 03 2015, David Bremner wrote: > As discussed in > id:8cc9dd580ad672527e12f43706f9803b2c8e99d8.1405220724.git.wking at > tremily.us, > execfile is unavailable in python3. > > The approach of this commit avoids modifying the python module path, > which is arguably preferable since it

[PATCH] doc: Allow rst2man.py as an alternative to rst2man

2015-01-03 Thread Tomi Ollila
From: W. Trevor King Gentoo's dev-python/docutils-0.10 installs Docutils scripts with a *.py extension, so I have /usr/bin/rst2man.py and no rst2man script. This patch supports users with both types of systems by checking for rst2man, falling back on rst2man.py, and giving up

[PATCH] doc: Allow rst2man.py as an alternative to rst2man

2015-01-03 Thread David Bremner
From: "W. Trevor King" Gentoo's dev-python/docutils-0.10 installs Docutils scripts with a *.py extension, so I have /usr/bin/rst2man.py and no rst2man script. This patch supports users with both types of systems by checking for rst2man, falling back on rst2man.py, and giving up

[PATCH] doc: Allow rst2man.py as an alternative to rst2man

2015-01-03 Thread W. Trevor King
t was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20150103/99d1a698/attachment.pgp>

[PATCH] doc: Allow rst2man.py as an alternative to rst2man

2015-01-03 Thread Tomi Ollila
On Sat, Jan 03 2015, "W. Trevor King" wrote: > On Sat, Jan 03, 2015 at 04:49:27PM +0100, David Bremner wrote: >> At the risk of bike-shedding, rewrite the configure check to be more >> "obvious". This is pretty subjective, but in particular I'm not a >> big fan of resetting RST2MAN at the bottom

[PATCH] doc: Allow rst2man.py as an alternative to rst2man

2015-01-03 Thread David Bremner
Tomi Ollila writes: > I'd presume anyone else using such an old system will have bigger > problems getting their notmuch compiled (recent enough zlib being one > of those), so this makes me wonder whether there is actually anyone > needing rst2man there (besides me, of course :) I guess the

[PATCH] doc: Allow rst2man.py as an alternative to rst2man

2015-01-03 Thread W. Trevor King
ytes Desc: OpenPGP digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20150103/a9333c23/attachment.pgp>