Re: [PATCH] VIM: Make an option to save sent mail locally

2015-01-13 Thread Bartosz Telenczuk
Great work! Yeah, I can add it so the folder can be changed. I figured this was just the start of things. Really we should be able to fcc it to our upstream provider sent mailbox too. I would appreciate an option to configure the sent box per provider. I implemented this feature in this

RE: [PATCH v3] VIM: Improve moving between messages in a thread

2015-01-13 Thread Bartosz Telenczuk
Hi Ian, The patch looks good. I tested it on my system and it works fine. I just have one suggestion regarding coding style. +function! s:show_prev_msg() function! s:show_next_msg() Since these functions are almost the same, you could avoid code repetition by replacing them by a function

[PATCH v2 1/5] Add a failing unit test for indexed mime types

2015-01-13 Thread Todd
--- test/T190-multipart.sh | 32 1 file changed, 32 insertions(+) diff --git a/test/T190-multipart.sh b/test/T190-multipart.sh index 85cbf67..26f7c7a 100755 --- a/test/T190-multipart.sh +++ b/test/T190-multipart.sh @@ -104,6 +104,30 @@ Content-Transfer-Encoding:

[PATCH v2 0/5] Index the content-type of MIME parts

2015-01-13 Thread Todd
This set of patches allows for queries for like: Find calendar invites - mimetype:text/calendar or mimetype:application/ics Find any image attachments - mimetype:image Find all patches - mimetype:text/x-patch It is a rework of a previous set of patches that now adds a new database feature,

[PATCH v2 3/5] Add indexing for the mimetype term

2015-01-13 Thread Todd
--- lib/database.cc | 1 + lib/index.cc| 6 ++ 2 files changed, 7 insertions(+) diff --git a/lib/database.cc b/lib/database.cc index 2de60f8..7c7a267 100644 --- a/lib/database.cc +++ b/lib/database.cc @@ -254,6 +254,7 @@ static prefix_t PROBABILISTIC_PREFIX[]= { { from,

[PATCH v2 5/5] Update documentation

2015-01-13 Thread Todd
--- NEWS | 16 doc/man7/notmuch-search-terms.rst | 6 ++ 2 files changed, 22 insertions(+) diff --git a/NEWS b/NEWS index 44e8d05..0df7977 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,19 @@ +Notmuch 0.20 (TBD) += + +Overview

[PATCH v2 2/5] Add the NOTMUCH_FEATURE_INDEXED_MIMETYPES database feature

2015-01-13 Thread Todd
--- lib/database-private.h | 15 --- lib/database.cc| 10 -- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/lib/database-private.h b/lib/database-private.h index 15e03cc..6d6fa2c 100644 --- a/lib/database-private.h +++ b/lib/database-private.h @@ -92,6

[PATCH v2 4/5] Update completions for Emacs and bash

2015-01-13 Thread Todd
This adds completions for Emacs and bash, ZSH does not appear to have completions for search terms. --- completion/notmuch-completion.bash | 2 +- emacs/notmuch.el | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/completion/notmuch-completion.bash

[PATCH v3] VIM: Improve moving between messages in a thread

2015-01-13 Thread Bartosz Telenczuk
Hi Ian, The patch looks good. I tested it on my system and it works fine. I just have one suggestion regarding coding style. > +function! s:show_prev_msg() > function! s:show_next_msg() Since these functions are almost the same, you could avoid code repetition by replacing them by a

[PATCH] VIM: Make an option to save sent mail locally

2015-01-13 Thread Bartosz Telenczuk
Great work! > Yeah, I can add it so the folder can be changed. I figured this was just the > start of things. Really we should be able to fcc it to our upstream provider > sent mailbox too. I would appreciate an option to configure the "sent" box per provider. I implemented this feature in

[PATCH v2 0/5] Index the content-type of MIME parts

2015-01-13 Thread Todd
This set of patches allows for queries for like: Find calendar invites - mimetype:text/calendar or mimetype:application/ics Find any image attachments - mimetype:image Find all patches - mimetype:text/x-patch It is a rework of a previous set of patches that now adds a new database feature,

[PATCH v2 1/5] Add a failing unit test for indexed mime types

2015-01-13 Thread Todd
--- test/T190-multipart.sh | 32 1 file changed, 32 insertions(+) diff --git a/test/T190-multipart.sh b/test/T190-multipart.sh index 85cbf67..26f7c7a 100755 --- a/test/T190-multipart.sh +++ b/test/T190-multipart.sh @@ -104,6 +104,30 @@ Content-Transfer-Encoding:

[PATCH v2 2/5] Add the NOTMUCH_FEATURE_INDEXED_MIMETYPES database feature

2015-01-13 Thread Todd
--- lib/database-private.h | 15 --- lib/database.cc| 10 -- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/lib/database-private.h b/lib/database-private.h index 15e03cc..6d6fa2c 100644 --- a/lib/database-private.h +++ b/lib/database-private.h @@ -92,6

[PATCH v2 4/5] Update completions for Emacs and bash

2015-01-13 Thread Todd
This adds completions for Emacs and bash, ZSH does not appear to have completions for search terms. --- completion/notmuch-completion.bash | 2 +- emacs/notmuch.el | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/completion/notmuch-completion.bash

[PATCH v2 3/5] Add indexing for the mimetype term

2015-01-13 Thread Todd
--- lib/database.cc | 1 + lib/index.cc| 6 ++ 2 files changed, 7 insertions(+) diff --git a/lib/database.cc b/lib/database.cc index 2de60f8..7c7a267 100644 --- a/lib/database.cc +++ b/lib/database.cc @@ -254,6 +254,7 @@ static prefix_t PROBABILISTIC_PREFIX[]= { { "from",

[PATCH v2 5/5] Update documentation

2015-01-13 Thread Todd
--- NEWS | 16 doc/man7/notmuch-search-terms.rst | 6 ++ 2 files changed, 22 insertions(+) diff --git a/NEWS b/NEWS index 44e8d05..0df7977 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,19 @@ +Notmuch 0.20 (TBD) += + +Overview