Re: [PATCH v2 3/5] Add indexing for the mimetype term

Please add a commit message. On Wed, 14 Jan 2015, Todd t...@electricoding.com wrote: --- lib/database.cc | 1 + lib/index.cc| 6 ++ 2 files changed, 7 insertions(+) diff --git a/lib/database.cc b/lib/database.cc index 2de60f8..7c7a267 100644 --- a/lib/database.cc +++

Re: [PATCH v2 1/5] Add a failing unit test for indexed mime types

On Wed, 14 Jan 2015, Todd t...@electricoding.com wrote: --- test/T190-multipart.sh | 32 1 file changed, 32 insertions(+) diff --git a/test/T190-multipart.sh b/test/T190-multipart.sh index 85cbf67..26f7c7a 100755 --- a/test/T190-multipart.sh +++

Re: [PATCH v2 4/5] Update completions for Emacs and bash

On Wed, 14 Jan 2015, Todd t...@electricoding.com wrote: This adds completions for Emacs and bash, ZSH does not appear to have completions for search terms. --- completion/notmuch-completion.bash | 2 +- emacs/notmuch.el | 2 +- 2 files changed, 2 insertions(+), 2

Re: [PATCH v2 2/5] Add the NOTMUCH_FEATURE_INDEXED_MIMETYPES database feature

Just one nit. Otherwise this patch LGTM. On January 15, 2015 12:20:08 PM EST, Jani Nikula j...@nikula.org wrote: Austin, would you mind having a look at this one please? Thanks, Jani. On Wed, 14 Jan 2015, Todd t...@electricoding.com wrote: --- lib/database-private.h | 15 ---

Re: [PATCH v2 1/5] Add a failing unit test for indexed mime types

On Thu, 15 Jan 2015, Jani Nikula j...@nikula.org wrote: On Wed, 14 Jan 2015, Todd t...@electricoding.com wrote: --- test/T190-multipart.sh | 32 1 file changed, 32 insertions(+) diff --git a/test/T190-multipart.sh b/test/T190-multipart.sh index

Re: [PATCH v2 2/5] Add the NOTMUCH_FEATURE_INDEXED_MIMETYPES database feature

Austin, would you mind having a look at this one please? Thanks, Jani. On Wed, 14 Jan 2015, Todd t...@electricoding.com wrote: --- lib/database-private.h | 15 --- lib/database.cc| 10 -- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git

Re: Images being displayed inline depending on the window size

On Tue, 30 Dec 2014, Sebastian Fischmeister sfisc...@uwaterloo.ca wrote: Hi, I have an email with 8 pictures attached. When I open the email (notmuch-search-show-thread), some of them are opened and shown inline, others are not. It seems that notmuch only shows the ones that fit on the

Re: proposal: remove support for gmime2.4

On Thu 2015-01-15 05:20:47 -0500, David Bremner wrote: It seems no very recent system has gmime2.4. I guess several of these gmime2.4 only code paths are both security critical (e.g. in crypto.c) and mostly untested. Is there good reason to keep supporting gmime 2.4? gmime 2.6 is available

Re: [WIP PATCH 4/4] lib: Add lastmod: queries for filtering by last modification

Austin Clements acleme...@csail.mit.edu writes: From: Austin Clements amdra...@mit.edu XXX Includes reference to notmuch search --db-revision, which doesn't exist. What would --db-revision do if it was implimented? Did you want to pass a UUID in? d

[PATCH v3 4/5] Update completions for Emacs and bash

This adds completions for Emacs and bash, ZSH does not appear to have completions for search terms. --- completion/notmuch-completion.bash | 2 +- emacs/notmuch.el | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/completion/notmuch-completion.bash

[PATCH v3 5/5] Update documentation

--- NEWS | 11 +++ doc/man7/notmuch-search-terms.rst | 6 ++ 2 files changed, 17 insertions(+) diff --git a/NEWS b/NEWS index abb5ad7..baa4519 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,5 @@ Notmuch 0.20 (UNRELEASED) += Contrib

[PATCH v3 3/5] Add indexing for the mimetype term

Adds the indexing and removes the broken test flag --- lib/database.cc| 1 + lib/index.cc | 10 ++ test/T190-multipart.sh | 4 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index 0d2c417..3974e2e 100644 ---

[PATCH v3 2/5] Add the NOTMUCH_FEATURE_INDEXED_MIMETYPES database feature

--- lib/database-private.h | 15 --- lib/database.cc| 10 -- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/lib/database-private.h b/lib/database-private.h index 15e03cc..6d6fa2c 100644 --- a/lib/database-private.h +++ b/lib/database-private.h @@ -92,6

[PATCH v3 1/5] Add failing unit tests for indexed mime types

--- test/T190-multipart.sh | 44 1 file changed, 44 insertions(+) diff --git a/test/T190-multipart.sh b/test/T190-multipart.sh index 85cbf67..57f1b61 100755 --- a/test/T190-multipart.sh +++ b/test/T190-multipart.sh @@ -104,6 +104,30 @@

Re: [WIP PATCH 4/4] lib: Add lastmod: queries for filtering by last modification

Quoth David Bremner on Jan 15 at 10:08 pm: Austin Clements acleme...@csail.mit.edu writes: From: Austin Clements amdra...@mit.edu XXX Includes reference to notmuch search --db-revision, which doesn't exist. What would --db-revision do if it was implimented? Did you want to pass a

proposal: remove support for gmime2.4

It seems no very recent system has gmime2.4. I guess several of these gmime2.4 only code paths are both security critical (e.g. in crypto.c) and mostly untested. Is there good reason to keep supporting gmime 2.4? d ___ notmuch mailing list

proposal: remove support for gmime2.4

It seems no very recent system has gmime2.4. I guess several of these gmime2.4 only code paths are both security critical (e.g. in crypto.c) and mostly untested. Is there good reason to keep supporting gmime 2.4? d

proposal: remove support for gmime2.4

On Thu, Jan 15 2015, David Bremner wrote: > It seems no very recent system has gmime2.4. I guess several of these > gmime2.4 only code paths are both security critical (e.g. in crypto.c) > and mostly untested. > > Is there good reason to keep supporting gmime 2.4? if there are potential

[PATCH v2 1/5] Add a failing unit test for indexed mime types

On Wed, 14 Jan 2015, Todd wrote: > --- > test/T190-multipart.sh | 32 > 1 file changed, 32 insertions(+) > > diff --git a/test/T190-multipart.sh b/test/T190-multipart.sh > index 85cbf67..26f7c7a 100755 > --- a/test/T190-multipart.sh > +++ b/test/T190-multipart.sh

[PATCH v2 3/5] Add indexing for the mimetype term

Please add a commit message. On Wed, 14 Jan 2015, Todd wrote: > --- > lib/database.cc | 1 + > lib/index.cc| 6 ++ > 2 files changed, 7 insertions(+) > > diff --git a/lib/database.cc b/lib/database.cc > index 2de60f8..7c7a267 100644 > --- a/lib/database.cc > +++ b/lib/database.cc > @@

[PATCH v2 4/5] Update completions for Emacs and bash

On Wed, 14 Jan 2015, Todd wrote: > This adds completions for Emacs and bash, ZSH does not appear to have > completions for search terms. > --- > completion/notmuch-completion.bash | 2 +- > emacs/notmuch.el | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff

[PATCH v2 1/5] Add a failing unit test for indexed mime types

On Thu, 15 Jan 2015, Jani Nikula wrote: > On Wed, 14 Jan 2015, Todd wrote: >> --- >> test/T190-multipart.sh | 32 >> 1 file changed, 32 insertions(+) >> >> diff --git a/test/T190-multipart.sh b/test/T190-multipart.sh >> index 85cbf67..26f7c7a 100755 >> ---

[PATCH v2 2/5] Add the NOTMUCH_FEATURE_INDEXED_MIMETYPES database feature

Austin, would you mind having a look at this one please? Thanks, Jani. On Wed, 14 Jan 2015, Todd wrote: > --- > lib/database-private.h | 15 --- > lib/database.cc| 10 -- > 2 files changed, 20 insertions(+), 5 deletions(-) > > diff --git a/lib/database-private.h

Images being displayed inline depending on the window size

On Tue, 30 Dec 2014, Sebastian Fischmeister wrote: > Hi, > > I have an email with 8 pictures attached. When I open the email > (notmuch-search-show-thread), some of them are opened and shown inline, > others are not. > > It seems that notmuch only shows the ones that fit on the screen > depending

[PATCH v2 2/5] Add the NOTMUCH_FEATURE_INDEXED_MIMETYPES database feature

Just one nit. Otherwise this patch LGTM. On January 15, 2015 12:20:08 PM EST, Jani Nikula wrote: > >Austin, would you mind having a look at this one please? > >Thanks, >Jani. > >On Wed, 14 Jan 2015, Todd wrote: >> --- >> lib/database-private.h | 15 --- >> lib/database.cc|

proposal: remove support for gmime2.4

nature.asc Type: application/pgp-signature Size: 948 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20150115/62b8265f/attachment.pgp>

[WIP PATCH 4/4] lib: Add "lastmod:" queries for filtering by last modification

Austin Clements writes: > From: Austin Clements > > XXX Includes reference to notmuch search --db-revision, which doesn't > exist. What would --db-revision do if it was implimented? Did you want to pass a UUID in? d

[PATCH v3 1/5] Add failing unit tests for indexed mime types

--- test/T190-multipart.sh | 44 1 file changed, 44 insertions(+) diff --git a/test/T190-multipart.sh b/test/T190-multipart.sh index 85cbf67..57f1b61 100755 --- a/test/T190-multipart.sh +++ b/test/T190-multipart.sh @@ -104,6 +104,30 @@

[PATCH v3 2/5] Add the NOTMUCH_FEATURE_INDEXED_MIMETYPES database feature

--- lib/database-private.h | 15 --- lib/database.cc| 10 -- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/lib/database-private.h b/lib/database-private.h index 15e03cc..6d6fa2c 100644 --- a/lib/database-private.h +++ b/lib/database-private.h @@ -92,6

[PATCH v3 4/5] Update completions for Emacs and bash

This adds completions for Emacs and bash, ZSH does not appear to have completions for search terms. --- completion/notmuch-completion.bash | 2 +- emacs/notmuch.el | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/completion/notmuch-completion.bash

[PATCH v3 3/5] Add indexing for the mimetype term

Adds the indexing and removes the broken test flag --- lib/database.cc| 1 + lib/index.cc | 10 ++ test/T190-multipart.sh | 4 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index 0d2c417..3974e2e 100644 ---

[PATCH v3 5/5] Update documentation

--- NEWS | 11 +++ doc/man7/notmuch-search-terms.rst | 6 ++ 2 files changed, 17 insertions(+) diff --git a/NEWS b/NEWS index abb5ad7..baa4519 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,5 @@ Notmuch 0.20 (UNRELEASED) += Contrib

[WIP PATCH 4/4] lib: Add "lastmod:" queries for filtering by last modification

Quoth David Bremner on Jan 15 at 10:08 pm: > Austin Clements writes: > > > From: Austin Clements > > > > XXX Includes reference to notmuch search --db-revision, which doesn't > > exist. > > What would --db-revision do if it was implimented? Did you want to pass > a UUID in? Yes, exactly. And