[PATCH v2] VIM: Exclude mails tagged with any tag specified in 'notmuch config get search.exclude_tags' in folders list and search list.

2015-01-22 Thread Franz Fellner
--- vim/notmuch.vim | 9 + 1 file changed, 9 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index cad9517..cb6695a 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -477,6 +477,7 @@ ruby EOF $db_name = nil $email = $email_name = $email_address = nil +

Re: [PATCH] emacs: escape % in header line format

2015-01-22 Thread Jinwoo Lee
Thanks, David. But I don't think it's the correct fix. REPLACE-STRING seems to replace a string in a buffer, not a string given as a param. And it's for interactive use only. -jinwoo On Wed, Jan 21, 2015 at 11:18 PM, David Bremner da...@tethera.net wrote: We set header-line-format to the

[PATCH] emacs: escape % in header line format

2015-01-22 Thread David Bremner
We set header-line-format to the message subject, but if the subject contains percents, the next character is interpreted as a formatting control, which is not desired. --- You're correct of course. I have no idea how my testing convinced me the previous version worked. emacs/notmuch-show.el | 6

[LATE NIGHT PATCH] build gzipped apidoc in case have doxygen but not sphinx

2015-01-22 Thread Tomi Ollila
In case we had doxygen but not sphinx notmuch.3 was created but notmuch.3.gz not -- which means install fails! This patch (with late night unpolished commit message will fix that) --- I'll do better one... hmm, next week (unless someone gets there first \o/) doc/Makefile.local | 11 ++-

Re: [PATCH] emacs: show: allow user to hide some mime types by default.

2015-01-22 Thread Daniel Kahn Gillmor
On Thu 2015-01-22 16:07:32 -0500, Mark Walters wrote: This commit adds a customize variable that allows the user to choose to hide some mime types by default. They can still choose to view the part by toggling the part button. thanks for this, Mark. I'll try to test it out soon. Given the

[PATCH v4 5/5] Update documentation

2015-01-22 Thread Todd
Adds new entry to the NEWS file, and updates the search terms section of the man page. The search terms section needs to be updated again once the new section in the documentation covering probablistic terms has been committed. --- NEWS | 11 +++

[PATCH v4 4/5] Update completions for Emacs and bash

2015-01-22 Thread Todd
This adds completions for both Emacs and bash. ZSH does not appear to have completions for search terms. --- completion/notmuch-completion.bash | 2 +- emacs/notmuch.el | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/completion/notmuch-completion.bash

[PATCH v4 3/5] Add indexing for the mimetype term

2015-01-22 Thread Todd
This adds the indexing support for the mimetype: term and removes the broken test flag. The indexing is probablistic in Xapian terms, which gives a better experience to end users. Standard content-types of the form foo/bar are automatically interpreted as phrases in Xapian due to the embedded

[PATCH v4 0/5] Index the content-type of MIME parts

2015-01-22 Thread Todd
I think I've finished incorporating the feedback. The final notmuch-search-terms.rst could use more details, but it should probably occur after the recent patch that was posted documenting the probablistic indexing/searching has been committed. Todd (5): test: Add failing unit tests for

[PATCH v4 1/5] test: Add failing unit tests for indexed mime types

2015-01-22 Thread Todd
Adds three failing unit tests for searching of mime-types. An attempt was made at adding a negative test (i.e. searching for a non-existent mime-type and ensuring it didn't return a message), but that test would always pass making it pointless. --- test/T190-multipart.sh | 39

Re: [PATCH v2] VIM: Exclude mails tagged with any tag specified in 'notmuch config get search.exclude_tags' in folders list and search list.

2015-01-22 Thread David Bremner
Thanks Franz. I reformatted the commit message a bit and merged to master. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: escape % in header line format

2015-01-22 Thread David Bremner
Jinwoo Lee jinwo...@gmail.com writes: Yup. It works! Thanks for the quick fix. Is this going to be merged to HEAD soon? Probably in the next day or so, unless somebody complains. d ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH] VIM: Improve performance of folders_render

2015-01-22 Thread Franz Fellner
Simply use query.count_[messages,threads] instead of actually running the query and using the count attribute of the result set. --- vim/notmuch.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index cb6695a..ad8b7c8 100644 ---

RE: [PATCH 1/4] VIM: implemented message folding in thread view

2015-01-22 Thread Franz Fellner
Hi Bartosz, We already had folding via syntax in Ians fork. It turned out to be not that great. https://github.com/imain/notmuch-vim/issues/3 In short: Those syntax fold marks are for one specific notmuch-show-buffer. If you open a second show-buffer those new fold marks will overwrite the ones

Re: [PATCH] emacs: escape % in header line format

2015-01-22 Thread Jinwoo Lee
Yup. It works! Thanks for the quick fix. Is this going to be merged to HEAD soon? -jinwoo On Thu, Jan 22, 2015 at 12:37 AM, David Bremner da...@tethera.net wrote: We set header-line-format to the message subject, but if the subject contains percents, the next character is interpreted as a

[PATCH] emacs: show: allow user to hide some mime types by default.

2015-01-22 Thread Mark Walters
This commit adds a customize variable that allows the user to choose to hide some mime types by default. They can still choose to view the part by toggling the part button. One use is for hiding all text/html parts. This would mean that some explicit user action was required before the part was

Re: [PATCH] emacs: show: allow user to hide some mime types by default.

2015-01-22 Thread David Edmondson
On Thu, Jan 22 2015, Mark Walters wrote: This commit adds a customize variable that allows the user to choose to hide some mime types by default. They can still choose to view the part by toggling the part button. One use is for hiding all text/html parts. This would mean that some explicit

[PATCH] emacs: escape % in header line format

2015-01-22 Thread David Bremner
We set header-line-format to the message subject, but if the subject contains percents, the next character is interpreted as a formatting control, which is not desired. --- Ironically you have to apply this patch to read it's subject properly ;). There is whitespace change here because the

privacy problem: text/html parts pull in network resources

2015-01-22 Thread Tomi Ollila
On Wed, Jan 21 2015, Daniel Kahn Gillmor wrote: > If i send a message with a text/html part (either it's only text/html, > or all parts are rendered, or it's multipart/alternative with only a > text/html subpart) and that HTML has src="http://example.org/test.png"/> in it, then notmuch will

[PATCH] doc: remove support for rst2man

2015-01-22 Thread David Bremner
David Bremner writes: > It was becoming increasingly complicated to support rst2man, and there > were apparently not many people that relied on it. > --- > > Now's your chance to tell us how useful rst2man support is to you. Nobody complained, so I merged this change. d

[PATCH] emacs: escape % in header line format

2015-01-22 Thread Jinwoo Lee
Thanks, David. But I don't think it's the correct fix. REPLACE-STRING seems to replace a string in a buffer, not a string given as a param. And it's for interactive use only. -jinwoo On Wed, Jan 21, 2015 at 11:18 PM, David Bremner wrote: > We set header-line-format to the message subject, but

[PATCH] emacs: escape % in header line format

2015-01-22 Thread David Bremner
We set header-line-format to the message subject, but if the subject contains percents, the next character is interpreted as a formatting control, which is not desired. --- You're correct of course. I have no idea how my testing convinced me the previous version worked. emacs/notmuch-show.el | 6

[PATCH v2] VIM: Exclude mails tagged with any tag specified in 'notmuch config get search.exclude_tags' in folders list and search list.

2015-01-22 Thread Franz Fellner
--- vim/notmuch.vim | 9 + 1 file changed, 9 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index cad9517..cb6695a 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -477,6 +477,7 @@ ruby << EOF $db_name = nil $email = $email_name = $email_address = nil

[PATCH] emacs: escape % in header line format

2015-01-22 Thread Jinwoo Lee
Yup. It works! Thanks for the quick fix. Is this going to be merged to HEAD soon? -jinwoo On Thu, Jan 22, 2015 at 12:37 AM, David Bremner wrote: > We set header-line-format to the message subject, but if the subject > contains percents, the next character is interpreted as a formatting >

[PATCH v2] VIM: Exclude mails tagged with any tag specified in 'notmuch config get search.exclude_tags' in folders list and search list.

2015-01-22 Thread David Bremner
Thanks Franz. I reformatted the commit message a bit and merged to master. d

[PATCH] emacs: escape % in header line format

2015-01-22 Thread David Bremner
Jinwoo Lee writes: > Yup. It works! Thanks for the quick fix. Is this going to be merged > to HEAD soon? > Probably in the next day or so, unless somebody complains. d

[PATCH] VIM: Improve performance of folders_render

2015-01-22 Thread Franz Fellner
Simply use query.count_[messages,threads] instead of actually running the query and using the count attribute of the result set. --- vim/notmuch.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index cb6695a..ad8b7c8 100644 ---

[PATCH 1/4] VIM: implemented message folding in thread view

2015-01-22 Thread Franz Fellner
Hi Bartosz, We already had folding via syntax in Ians fork. It turned out to be not that great. https://github.com/imain/notmuch-vim/issues/3 In short: Those syntax fold marks are for one specific notmuch-show-buffer. If you open a second show-buffer those new fold marks will overwrite the ones

[PATCH] emacs: show: allow user to hide some mime types by default.

2015-01-22 Thread Mark Walters
This commit adds a customize variable that allows the user to choose to hide some mime types by default. They can still choose to view the part by toggling the part button. One use is for hiding all text/html parts. This would mean that some explicit user action was required before the part was

[PATCH] emacs: show: allow user to hide some mime types by default.

2015-01-22 Thread Daniel Kahn Gillmor
On Thu 2015-01-22 16:07:32 -0500, Mark Walters wrote: > This commit adds a customize variable that allows the user to choose > to hide some mime types by default. They can still choose to view the > part by toggling the part button. thanks for this, Mark. I'll try to test it out soon. > Given

[LATE NIGHT PATCH] build gzipped apidoc in case have doxygen but not sphinx

2015-01-22 Thread Tomi Ollila
In case we had doxygen but not sphinx notmuch.3 was created but notmuch.3.gz not -- which means install fails! This patch (with late night unpolished commit message will fix that) --- I'll do better one... hmm, next week (unless someone gets there first \o/) doc/Makefile.local | 11 ++-

[PATCH v4 0/5] Index the content-type of MIME parts

2015-01-22 Thread Todd
I think I've finished incorporating the feedback. The final notmuch-search-terms.rst could use more details, but it should probably occur after the recent patch that was posted documenting the probablistic indexing/searching has been committed. Todd (5): test: Add failing unit tests for

[PATCH v4 3/5] Add indexing for the mimetype term

2015-01-22 Thread Todd
This adds the indexing support for the "mimetype:" term and removes the broken test flag. The indexing is probablistic in Xapian terms, which gives a better experience to end users. Standard content-types of the form "foo/bar" are automatically interpreted as phrases in Xapian due to the

[PATCH v4 1/5] test: Add failing unit tests for indexed mime types

2015-01-22 Thread Todd
Adds three failing unit tests for searching of mime-types. An attempt was made at adding a negative test (i.e. searching for a non-existent mime-type and ensuring it didn't return a message), but that test would always pass making it pointless. --- test/T190-multipart.sh | 39

[PATCH v4 4/5] Update completions for Emacs and bash

2015-01-22 Thread Todd
This adds completions for both Emacs and bash. ZSH does not appear to have completions for search terms. --- completion/notmuch-completion.bash | 2 +- emacs/notmuch.el | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/completion/notmuch-completion.bash

[PATCH v4 5/5] Update documentation

2015-01-22 Thread Todd
Adds new entry to the NEWS file, and updates the search terms section of the man page. The search terms section needs to be updated again once the new section in the documentation covering probablistic terms has been committed. --- NEWS | 11 +++

[PATCH v4 2/5] Add the NOTMUCH_FEATURE_INDEXED_MIMETYPES database feature

2015-01-22 Thread Todd
This feature will exist in all newly created databases, but there is no upgrade provided for it. If this flag exists, it indicates that the database was created after the indexed MIME-types feature was added. --- lib/database-private.h | 15 --- lib/database.cc| 10 --