Last call for 0.23 NEWS

2016-10-01 Thread David Bremner
David Bremner writes: > We are now frozen for 0.23. I have tagged 0.23_rc0 in git, and uploaded > it to debian experimental. At this point I expect only NEWS changes and > serious bug fixes before release. I have tagged 0.23_rc1 in git (and uploaded to Debian experimental).

Re: [PATCH 2/2] emacs: postpone/resume support

2016-10-01 Thread David Bremner
Mark Walters writes: > This provides preliminary support for postponing and resuming in the > emacs frontend. On postponing it uses notmuch insert to put the > message in the notmuch database; resume gets the raw file from notmuch > and using the emacs function

[PATCH] lib: bump minor version to mark added symbols

2016-10-01 Thread David Bremner
This should not change the SONAME, and therefore won't change the dynamic linking behaviour, but it may help some users debug missing symbols in case their libnotmuch is too old. --- this should probably go into 0.23 lib/notmuch.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/5] lib: eagerly parse queries

2016-10-01 Thread David Bremner
Rather than waiting for a call to count/search, parse the query string when the notmuch_query_t is created. This is a small reduction in duplicated code, and a potential efficiency improvement if many count/search operations are called on the same query (although the latter sounds a bit unusual).

[PATCH 5/5] lib: make notmuch_query_add_tag_exclude return a status value

2016-10-01 Thread David Bremner
Since this is an ABI breaking change, bump the SONAME. --- lib/notmuch.h| 23 +++ lib/query.cc | 7 --- notmuch-count.c | 9 +++-- notmuch-search.c | 12 ++-- notmuch-show.c | 13 +++-- 5 files changed, 51 insertions(+), 13 deletions(-)

[PATCH 4/5] lib: query make exclude handling non-destructive

2016-10-01 Thread David Bremner
We filter added exclude at add time, rather than modifying the query by count search. As noted in the comments, there are several ignored conditions here. Returning proper status is split into a separate commit because it is ABI breaking. --- lib/query.cc | 48

[PATCH 2/5] lib/query: make query parsing lazy again, keep centralized.

2016-10-01 Thread David Bremner
This is mainly to fix the nasty error path introduced in the last commit, by moving the parsing into functions where the API is already set up to return error status. It preserves the feature of having a pre-parsed query available for further processing. --- lib/query.cc | 36

V2 non-destructive excludes

2016-10-01 Thread David Bremner
This mainly rebases against master, and fixes the two minor problems already pointed out. I would like feedback on breaking the API for this. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 3/5] test: add known broken test for nondestructiveness of count

2016-10-01 Thread David Bremner
Thanks to Lucas (id:147263183913.27784.12274024193186585889@mbp) for the bug report and the test case. I decided to use the python version because the python bindings could use more exercise. --- test/T060-count.sh | 28 1 file changed, 28 insertions(+) diff --git