Re: [PATCH] cli: consider files vanishing during notmuch new non-fatal

2016-11-12 Thread Brian Sniffen
> > OK, but the patch proposed works both for people who want to be notified > of this problem, and those that don't (with appropriate shell wrapping > checking the return code). I think it will loop; how do I guarantee termination and indexing of all present messages if deletions cause

Re: [PATCH] cli: consider files vanishing during notmuch new non-fatal

2016-11-12 Thread David Bremner
Brian Sniffen writes: >> >> OK, but the patch proposed works both for people who want to be notified >> of this problem, and those that don't (with appropriate shell wrapping >> checking the return code). > > I think it will loop; how do I guarantee termination and indexing

Re: [PATCH v4] emacs: add notmuch-address-post-completion-hook

2016-11-12 Thread David Bremner
Tomi Ollila writes: > Like someone (whose message I cannot find just now) mentioned in another > thread, just now it is right time to mention here too... > > https://www.gnu.org/software/emacs/manual/html_node/elisp/Hooks.html > > ... that when hook name ends with `-hook` it

Re: [PATCH] cli: consider files vanishing during notmuch new non-fatal

2016-11-12 Thread David Bremner
Brian Sniffen writes: > That's hard, given dovecot pointed at the same maildir: it quickly > moves files from new to cur. That makes notmuch insert pretty useless, > and I rely on notmuch new to approach correctness. I don't think this discussion is related to notmuch insert

Re: [PATCH] cli: consider files vanishing during notmuch new non-fatal

2016-11-12 Thread David Bremner
Paul Wise writes: > On Sat, 2016-11-05 at 14:57 +0200, Jani Nikula wrote: > >> Add a new exit code for when files vanished, so the caller has a >> chance to detect the race and re-run notmuch new to recover. > > I don't think this is the right approach for two reasons: > > The

Re: [PATCH] cli: consider files vanishing during notmuch new non-fatal

2016-11-12 Thread David Bremner
David Bremner writes: > Brian Sniffen writes: > >>> >>> OK, but the patch proposed works both for people who want to be notified >>> of this problem, and those that don't (with appropriate shell wrapping >>> checking the return code). >> >> I think it

Re: [PATCH] cli: consider files vanishing during notmuch new non-fatal

2016-11-12 Thread Jani Nikula
On Sat, 12 Nov 2016, Brian Sniffen wrote: >> >> OK, but the patch proposed works both for people who want to be notified >> of this problem, and those that don't (with appropriate shell wrapping >> checking the return code). > > I think it will loop; how do I guarantee

Re: [PATCH v4] emacs: add notmuch-address-post-completion-hook

2016-11-12 Thread Tomi Ollila
On Fri, Nov 04 2016, David Bremner wrote: > This hook can be used to update the message based on the results of > address completion. For example using message-templ or gnus-alias to set > the From address based on the To address just completed. > > The post-completion command

Re: [PATCH] cli: consider files vanishing during notmuch new non-fatal

2016-11-12 Thread Brian Sniffen
> On Nov 12, 2016, at 11:10 AM, David Bremner wrote: > > Brian Sniffen writes: > >>> >>> OK, but the patch proposed works both for people who want to be notified >>> of this problem, and those that don't (with appropriate shell wrapping >>> checking the

Re: [Paul Wise] Bug#843127: notmuch: race condition in `notmuch new`?

2016-11-12 Thread Austin Clements
Quoth David Bremner on Nov 04 at 1:26 pm: > > Paul Wise wrote: > > > Last night I got this errorĀ from my `notmuch new --quiet` cron job. The > > file that the error message complains about is now in the cur directory > > of the maildir at the following path. > > > >

Re: [PATCH v4] emacs: add notmuch-address-post-completion-hook

2016-11-12 Thread Mark Walters
On Sat, 12 Nov 2016, David Bremner wrote: > Tomi Ollila writes: > >> Like someone (whose message I cannot find just now) mentioned in another >> thread, just now it is right time to mention here too... >> >>

Re: [PATCH] emacs: mua: add a pre-send-check-hook

2016-11-12 Thread Mark Walters
> For consistency with Emacs' own elisp, perhaps rename > notmuch-mua-pre-send-check-hooks to > notmuch-mua-pre-send-check-functions? Hi Yes you are correct. (Annoyingly I had thought about this and thought it was OK since I didn't need to pass an argument. I had missed the return value case).

Re: [PATCH v3] completion: complete mimetype: search prefix

2016-11-12 Thread David Bremner
Jani Nikula writes: > Use /etc/mime.types if available, parsed using a sed one-liner, and > fall back to a handful of common types otherwise. > > --- pushed to master ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH v2] emacs: add compatability functions for emacs 23

2016-11-12 Thread David Bremner
Tomi Ollila writes: > But this compatIbility change is not just emacs 23 -- iirc there were some > changes required to get emacs 24.1, 24.2, and 24.3 to work. It might be > easier to keep testing using emacs 23 until we deprecate everything before > emacs 24.4 (released

Re: [Patch v5 2/4] emacs: postpone a message

2016-11-12 Thread David Bremner
David Bremner writes: > From: Mark Walters This really Mark's work, that I have split out into a separate file. > +(defcustom notmuch-draft-tags '("+draft") > + "List of tags changes to apply to a draft message when it is saved in the >

Re: [Patch v5 3/4] emacs: check drafts for encryption tags before saving

2016-11-12 Thread David Bremner
Mark Walters writes: >> @@ -109,6 +140,15 @@ This saves the current message in the database with tags >> `notmuch-draft-tags` (in addition to any default tags >> applied to newly inserted messages)." >>(interactive) >> + (case notmuch-draft-save-plaintext >> +

Re: [Patch v5 4/4] emacs: resume messages

2016-11-12 Thread David Bremner
David Bremner writes: > Provide functionality to resume editing a mesage previously saved with > notmuch-draft-save, including decoding the X-Notmuch-Emacs-Secure > header. s/mesage/message/ > +(defun notmuch-draft-unquote-some-mml () > + "Unquote the mml tags in