[PATCH 1/5] minor whitespace cleanups

2017-06-16 Thread Piotr Trojanek
--- tag-util.c | 3 --- 1 file changed, 3 deletions(-) diff --git tag-util.c tag-util.c index 343c161f..7091d294 100644 --- tag-util.c +++ tag-util.c @@ -34,7 +34,6 @@ line_error (tag_parse_status_t status, const char * illegal_tag (const char *tag, notmuch_bool_t remove) { - if (*tag ==

[PATCH 2/5] add leaks due to missing invocations of va_end

2017-06-16 Thread Piotr Trojanek
As the Linux man page states: "Each invocation of va_start() must be matched by a corresponding invocation of va_end() in the same function." Detected by cppcheck. --- tag-util.c | 5 + 1 file changed, 5 insertions(+) diff --git tag-util.c tag-util.c index 7091d294..30c2c077 100644 ---

[PATCH 4/5] fix wrong printf formatting of signed/unsigned integers

2017-06-16 Thread Piotr Trojanek
--- notmuch-count.c | 2 +- notmuch-new.c | 4 ++-- notmuch-reply.c | 2 +- notmuch-show.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git notmuch-count.c notmuch-count.c index a05b430d..50b0c193 100644 --- notmuch-count.c +++ notmuch-count.c @@ -111,7 +111,7 @@

[PATCH 3/5] remove ineffective assignments

2017-06-16 Thread Piotr Trojanek
Detected by cppecheck. --- notmuch-new.c | 2 +- tag-util.c| 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git notmuch-new.c notmuch-new.c index e2822e23..4d40f3d0 100644 --- notmuch-new.c +++ notmuch-new.c @@ -850,7 +850,7 @@ _remove_directory (void *ctx,

[PATCH 5/5] flag potential problems with FIXME

2017-06-16 Thread Piotr Trojanek
Detected by cppcheck. --- lib/directory.cc | 1 + lib/string-map.c | 1 + 2 files changed, 2 insertions(+) diff --git lib/directory.cc lib/directory.cc index 5de3319c..801f1e5b 100644 --- lib/directory.cc +++ lib/directory.cc @@ -302,6 +302,7 @@ notmuch_directory_delete (notmuch_directory_t

Re: find threads where I and Jian participated but not Dave

2017-06-16 Thread Gaute Hope
David Bremner writes on juni 15, 2017 22:20: Daniel Kahn Gillmor writes: One of my long-standing wishes is to be able to say "show me mails in my inbox from people who have replied to messages i've sent them". This could be re-framed as "show me threads in which i've

High CPU usage on Tree View with many emails

2017-06-16 Thread Piotr Trojanek
Hi, I am trying notmuch + notmuch-emacs version 0.23.5-1~bpo8+1 from debian jessie backports, and reproduced this issue with both emacs 24.4 (jessie) and 24.5+1-6~bpo8+1 (jessie backports). When I make a query that gives many results (e.g. "review", which hits ~2200 emails with my Gerrit