[PATCH] cli/crypto: fix segfault on failed gmime2 crypto context creation

Commit 1fdc08d0ffab ("cli/crypto: treat failure to create a crypto context as fatal.") started treating crypto context creation failures "as fatal", returning NULL from _mime_node_create(). Unfortunately, we do not have NULL checks for _mime_node_create() failures. The only caller, mime_node_child

[PATCH 0/3] nmbug: clone core.worktree and auto-checkout (was: [PATCH 0/3] nmbug:)

On Sat, Oct 14, 2017 at 03:51:08PM +0300, Jani Nikula wrote: > Could we add a "nmbug required version" metadata to the repository… I'm not sure what you mean. The wiki page will mention the minimum nmbug version with which the wiki instructions are compatible (as it already does, [1]). But that'

[PATCH] lib: add support for thread: queries

Add support for querying threads using message-ids in addition to thread-ids. The main benefit is that thread queries via message-ids are portable across databases, re-indexing, and thread joining, while thread ids can be somewhat transient. A thread: query can be shared between notmuch users, whil

nmbug backtrace due to .mailmap

Presumably because of the .mailmap added in nmbug repository: commit 5ea99ebcb7d188003bf4854b566f6d21721f5ea1 Author: W. Trevor King Date: Mon Oct 16 10:46:27 2017 -0700 .mailmap: Consolidate David and Tomi's author names The format is documented in git-shortlog(1). In both case

Re: nmbug backtrace due to .mailmap

On Mon, Oct 16, 2017 at 10:14:40PM +0300, Jani Nikula wrote: > Presumably because of the .mailmap added in nmbug repository: Yup. > I also didn't see any discussion about adding a .mailmap prior to it > being pushed. Sorry :/. I didn't realize it would be an issue until I pushed it. I can't ro

[PATCH] nmbug: Only error for invalid diff lines in tags/

Avoid: Traceback (most recent call last): File "/home/nmbug/bin/nmbug", line 834, in args.func(**kwargs) File "/home/nmbug/bin/nmbug", line 385, in checkout status = get_status() File "/home/nmbug/bin/nmbug", line 580, in get_status maybe_deleted = _diff_index(inde

Re: nmbug backtrace due to .mailmap

"W. Trevor King" writes: > On Mon, Oct 16, 2017 at 10:14:40PM +0300, Jani Nikula wrote: >> Presumably because of the .mailmap added in nmbug repository: > > Yup. > >> I also didn't see any discussion about adding a .mailmap prior to it >> being pushed. > > Sorry :/. I didn't realize it would be

Re: nmbug backtrace due to .mailmap

On Mon, Oct 16, 2017 at 12:21:15PM -0700, W. Trevor King wrote: > Until then, you can work around the current master by applying this > patch locally. I'd thought this thread was in response to my patch, but it turns out my local nullmailer was off when I sent the patch. Sent now, and “this patch

Re: nmbug backtrace due to .mailmap

On Mon, Oct 16, 2017 at 05:37:32PM -0300, David Bremner wrote: > W. Trevor King writes: > > On Mon, Oct 16, 2017 at 10:14:40PM +0300, Jani Nikula wrote: > >> I also didn't see any discussion about adding a .mailmap prior to it > >> being pushed. > > > > Sorry :/. I didn't realize it would be an is

Re: nmbug backtrace due to .mailmap

On Mon, Oct 16, 2017 at 02:08:17PM -0700, W. Trevor King wrote: > So I've pushed bce5a55c removing .mailmap, and folks without [1] > should be back in business. > … > [1]: > id:4487e001b350aa8e343a1201d869cceca2a03ab6.1508176853.git.wk...@tremily.us But Jani reports still being stuck. It turns o

Re: cleartext indexing version 5

On Sun, Oct 15 2017, Daniel Kahn Gillmor wrote: > I welcome review and feedback. I have reviewed this patch series and everything looks in order. Coding style is consistent with notmuch standards. The patch is feature-complete, with appropriate documentation. All tests pass. I am now using th