subjects and duplicated message id's

2017-12-14 Thread David Bremner
There are currently several somewhat related issues with notmuch's handling of subject headers for messages with duplicate message-ids (i.e. several files on disk with the same message id). These are all reflections of the fact that we use a value slot for subjects in the database message documen

[PATCH] test: add known broken test for regexp search of second subject

2017-12-14 Thread David Bremner
We expect this to give the same answer as the non-regexp subject search. It does not because the regexp search relies on the value slot, which currently contains only one subject. --- test/T670-duplicate-mid.sh | 10 ++ 1 file changed, 10 insertions(+) diff --git a/test/T670-duplicate-mid

Re: subjects and duplicated message id's

2017-12-14 Thread Daniel Kahn Gillmor
On Thu 2017-12-14 10:03:12 -0400, David Bremner wrote: > There are currently several somewhat related issues with notmuch's > handling of subject headers for messages with duplicate message-ids > (i.e. several files on disk with the same message id). These are all > reflections of the fact that we

Re: subjects and duplicated message id's

2017-12-14 Thread David Bremner
>>- we could also force the value slot to have the lexico first files' >> subject during indexing. This would be a bit fiddly, but localized. >> It would have the surprising effect of having the subject updated >> when new messages arrived. > > This is a bit weird, unless we als

Re: [PATCH] doc: unify definition list usage across man pages

2017-12-14 Thread David Bremner
Jani Nikula writes: > Make all parameter descriptions etc. use reStructuredText definition > lists with uniform style and indentation. Remove redundant indentation > from around the lists. Remove blank lines between term lines and > definition blocks. Use four spaces for indentation. > > This is

Re: [PATCH] doc: unify definition list usage across man pages

2017-12-14 Thread David Bremner
David Bremner writes: > Jani Nikula writes: > >> Make all parameter descriptions etc. use reStructuredText definition >> lists with uniform style and indentation. Remove redundant indentation >> from around the lists. Remove blank lines between term lines and >> definition blocks. Use four space

[PATCH] lib: return "" rather than NULL from notmuch_thread_get_authors

2017-12-14 Thread David Bremner
The current beheviour is at best underdocumented. The modified test in T470-missing-headers.sh previously relied on printf doing the right thing with NULL, which seems ick. The use of talloc_strdup here is probably overkill, but it avoids having to enforce that thread->authors is never mutated out