Re: Bug?: manpages are only readable by root when doing sudo make install with umask 077

2018-01-10 Thread Antoine Amarilli
Hi Daniel, Thanks for your reply! On Wed, Jan 10, 2018 at 11:23:03AM -0500, Daniel Kahn Gillmor wrote: > On Wed 2018-01-10 16:38:14 +0100, Antoine Amarilli wrote: > how is the installation happening for you? In Makefile.local, i see: > > install -m0644 $(filter %.1.gz,$(MAN_GZIP_FILES))

Re: Bug?: manpages are only readable by root when doing sudo make install with umask 077

2018-01-10 Thread Tomi Ollila
On Wed, Jan 10 2018, Antoine Amarilli wrote: > Hi Daniel, > > Thanks for your reply! > > On Wed, Jan 10, 2018 at 11:23:03AM -0500, Daniel Kahn Gillmor wrote: >> On Wed 2018-01-10 16:38:14 +0100, Antoine Amarilli wrote: >> how is the installation happening for you? In Makefile.local, i see: >>

Re: Bug?: manpages are only readable by root when doing sudo make install with umask 077

2018-01-10 Thread Daniel Kahn Gillmor
On Wed 2018-01-10 21:45:34 +0200, Tomi Ollila wrote: > If user has set umask to 077, should we override that (as we're now doing > with the files by giving explicit permissions) ? /usr/bin/install itself does already override the user's umask, and it's being run by the superuser ("sudo make

Re: [PATCH 1/2] INSTALL: refer to python3-sphinx

2018-01-10 Thread Daniel Kahn Gillmor
On Wed 2018-01-10 13:09:20 -0400, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> @@ -88,11 +88,11 @@ dependencies with a simple simple command line. For >> example: > > BTW, "simple simple" is probably a typo but it's so simple, you have to say it twice!

Re: Bug?: manpages are only readable by root when doing sudo make install with umask 077

2018-01-10 Thread Daniel Kahn Gillmor
Hi Antoine-- On Wed 2018-01-10 19:29:59 +0100, Antoine Amarilli wrote: > On Wed, Jan 10, 2018 at 11:23:03AM -0500, Daniel Kahn Gillmor wrote: > That's right. Looking more closely I think the issue is only with the > permissions of the directories /usr/local/share/man/man*, not the files > that

Re: [PATCH 1/2] INSTALL: refer to python3-sphinx

2018-01-10 Thread Tomi Ollila
On Wed, Jan 10 2018, Daniel Kahn Gillmor wrote: > We're now preferring to build with python3 instead of python2. Update > the INSTALL to match. > > Thanks to Antoine Amarilli for pointing this out! I agree. LGTM > --- > INSTALL | 4 ++-- > 1 file changed, 2 insertions(+), 2

[PATCH 2/2] travis: build against python3-sphinx instead of python-sphinx

2018-01-10 Thread Daniel Kahn Gillmor
Ubuntu trusty has python3-sphinx 1.2.2+dfsg-1ubuntu1, so this should be OK. --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 802efd98..d18325e2 100644 --- a/.travis.yml +++ b/.travis.yml @@ -10,7 +10,7 @@ addons: -

Re: Bug: INSTALL should mention python3-sphinx not python-sphinx

2018-01-10 Thread Daniel Kahn Gillmor
On Wed 2018-01-10 16:38:18 +0100, Antoine Amarilli wrote: > In the current master (a727e7d4d398375c4a3ba5020e2ab25b5b874785), > INSTALL contains: > > For Debian and similar: > > sudo apt-get install libxapian-dev libgmime-3.0-dev libtalloc-dev > zlib1g-dev python-sphinx > > However it

Re: Bug?: manpages are only readable by root when doing sudo make install with umask 077

2018-01-10 Thread Daniel Kahn Gillmor
On Wed 2018-01-10 16:38:14 +0100, Antoine Amarilli wrote: > My user has umask 077. When I do sudo make install, this umask seems to > affect installation: the folders /usr/local/share/man/man* get created > as belonging to root:staff with permissions 2700, so the installed > manpages cannot be

Bug: INSTALL should mention python3-sphinx not python-sphinx

2018-01-10 Thread Antoine Amarilli
Hi all, In the current master (a727e7d4d398375c4a3ba5020e2ab25b5b874785), INSTALL contains: For Debian and similar: sudo apt-get install libxapian-dev libgmime-3.0-dev libtalloc-dev zlib1g-dev python-sphinx However it seems like what is currently used is python3-sphinx, cf commit

Bug?: manpages are only readable by root when doing sudo make install with umask 077

2018-01-10 Thread Antoine Amarilli
Hi all, My user has umask 077. When I do sudo make install, this umask seems to affect installation: the folders /usr/local/share/man/man* get created as belonging to root:staff with permissions 2700, so the installed manpages cannot be read by anyone except root. With the default umask of 002,

[PATCH 1/2] INSTALL: refer to python3-sphinx

2018-01-10 Thread Daniel Kahn Gillmor
We're now preferring to build with python3 instead of python2. Update the INSTALL to match. Thanks to Antoine Amarilli for pointing this out! --- INSTALL | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/INSTALL b/INSTALL index 875014f0..4a0dc741 100644 ---