Re: [PATCH 3/5] lib: break reference loop by choosing arbitrary top level msg

2018-04-15 Thread Daniel Kahn Gillmor
On Fri 2018-04-13 22:46:08 -0300, David Bremner wrote: > Other parts of notmuch (e.g. notmuch show) expect each thread to > contain at least one top level message, and crash if this expectation > is not met. > --- > lib/thread.cc| 8 +++- > test/T050-new.sh | 1 - > 2 files changed, 7

Re: [PATCH 1/5] test: two new messages for the 'broken' corpus

2018-04-15 Thread Daniel Kahn Gillmor
On Sun 2018-04-15 01:24:03 +0300, Tomi Ollila wrote: > Instead the huge amount of noise in these messages, I suggest: I agree with Tomi's suggestion that the simplest possible messages are the best for testing (i haven't tried either of them yet myself though). --dkg

Re: [PATCH] lib: work around xapian bug with get_mset(0,0, x)

2018-04-15 Thread Tomi Ollila
On Fri, Apr 06 2018, David Bremner wrote: > At least Fedora28 triggers this Xapian bug due to some toolchain change . > >https://bugzilla.redhat.com/show_bug.cgi?id=1546162 > > The underlying bug is fixed in xapian commit f92e2a936c1592, and > should be fixed in Xapian 1.4.6 > --- > > I have