Re: [PATCH 1/5] crypto: prepare for decryption of inline PGP encrypted messages

On Mon 2018-04-30 08:42:24 -0300, David Bremner wrote: > David Bremner writes: > >> Daniel Kahn Gillmor writes: >> >>> We make use here of GMime's optimization function for detecting the >>> presence of inline PGP encrypted content, which is only found

Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

Ruben Pollan writes: > Message.get_property (prop) returns a string with the value of the property > and > Message.get_properties (prop, exact=False) yields key, value pairs > --- > bindings/python/docs/source/message.rst | 4 ++ > bindings/python/notmuch/globals.py

Re: [PATCH 4/4] doc: document notmuch new --full-scan

On Sun, Apr 29 2018, David Bremner wrote: > --- > doc/man1/notmuch-new.rst | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/doc/man1/notmuch-new.rst b/doc/man1/notmuch-new.rst > index 16af5492..b0016ccc 100644 > --- a/doc/man1/notmuch-new.rst > +++ b/doc/man1/notmuch-new.rst > @@

Re: [PATCH v2 4/5] cli/show: reindex when we learned new session keys about a message

Daniel Kahn Gillmor writes: > + > +if (params->crypto.decrypt == NOTMUCH_DECRYPT_TRUE && > session_key_count_error == NOTMUCH_STATUS_SUCCESS) { > + unsigned int new_session_keys = 0; > + if (notmuch_message_count_properties (message, "session-key", >

Re: [PATCH v2 5/5] cli/show: enable --decrypt=stash

Daniel Kahn Gillmor writes: > + > +Note: ``--decrypt=stash`` requires a writable database. > +Otherwise, ``notmuch show`` operates entirely in read-only mode. I would rephrase this as "requires write access to the database"; otherwise it sounds like "writable"

Re: [PATCH v2 3/5] cli: write session keys to database, if asked to do so

Daniel Kahn Gillmor writes: > + > +#if HAVE_GMIME_SESSION_KEYS > + if (node->ctx->crypto->decrypt == NOTMUCH_DECRYPT_TRUE && message) { > + notmuch_database_t *db = notmuch_message_get_database (message); > + const char *sk =

Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

Ruben Pollan writes: > Message.get_property (prop) returns a string with the value of the property > and > Message.get_properties (prop, exact=False) yields key, value pairs > --- > bindings/python/docs/source/message.rst | 4 ++ > bindings/python/notmuch/globals.py

Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

Quoting David Bremner (2018-05-01 15:06:38) > running the test below, I get > > Traceback (most recent call last): > File "", line 4, in > File > "/home/bremner/software/upstream/notmuch/bindings/python/notmuch/message.py", > line 480, in get_property > value = c_char_p("") >

[PATCH] python: add bindings for notmuch_message_get_propert(y/ies)

Message.get_property (prop) returns a string with the value of the property and Message.get_properties (prop, exact=False) yields key, value pairs --- bindings/python/docs/source/message.rst | 4 ++ bindings/python/notmuch/globals.py | 5 +++ bindings/python/notmuch/message.py | 80