Re: [PATCH] devel: make printmimestructure py3 compatible

2018-06-12 Thread Reto Brunner
On Tue, Jun 12, 2018 at 11:35:09AM +0300, Tomi Ollila wrote: > -#!/usr/bin/env python > +#!/usr/bin/python > > just that 'python' should be able to run both python2 and python3 code. > > after the above change the code will not run on (those stupid) systems > that install python to e.g.

Re: [PATCH] devel: make printmimestructure py3 compatible

2018-06-12 Thread Thomas Schneider
Tomi Ollila writes: > On Mon, Jun 11 2018, Daniel Kahn Gillmor wrote: > >> Make printmimestructure work in python3 as well as python2. >> >> PEP 394 suggests that python scripts that work with both python2 and >> python3 should have a #!/usr/bin/python command line, so do that too. > > I did not

Re: [PATCH] devel: make printmimestructure py3 compatible

2018-06-12 Thread Tomi Ollila
On Mon, Jun 11 2018, Daniel Kahn Gillmor wrote: > Make printmimestructure work in python3 as well as python2. > > PEP 394 suggests that python scripts that work with both python2 and > python3 should have a #!/usr/bin/python command line, so do that too. I did not see PEP 394 suggesting to

Re: [PATCH v2 1/3] devel: make printmimestructure py3 compatible

2018-06-12 Thread David Bremner
Daniel Kahn Gillmor writes: > Make printmimestructure work in python3 as well as python2. > > PEP 394 suggests that python scripts that work with both python2 and > python3 should have a #!/usr/bin/python command line, so do that too. I think the second paragraph is vestigal. d

Re: [PATCH] emacs: use new show --decrypt=stash feature in emacs UI

2018-06-12 Thread Daniel Kahn Gillmor
On Tue 2018-06-12 10:00:18 -0400, Daniel Kahn Gillmor wrote: > (it'd be nice to be able to use notmuch-emacs to browse a notmuch > archive without locking the notmuch db or even needing read/write access > to the database) to be clear, it's not just about wanting to be able to avoid write access

[PATCH v2 1/3] devel: make printmimestructure py3 compatible

2018-06-12 Thread Daniel Kahn Gillmor
Make printmimestructure work in python3 as well as python2. PEP 394 suggests that python scripts that work with both python2 and python3 should have a #!/usr/bin/python command line, so do that too. --- devel/printmimestructure | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v2 3/3] use #!/usr/bin/env python consistently

2018-06-12 Thread Daniel Kahn Gillmor
--- devel/nmbug/notmuch-report | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devel/nmbug/notmuch-report b/devel/nmbug/notmuch-report index 5789c5f4..eaceb2ce 100755 --- a/devel/nmbug/notmuch-report +++ b/devel/nmbug/notmuch-report @@ -1,4 +1,4 @@ -#!/usr/bin/python

[PATCH v2 2/3] minor cleanup to printmimestructure

2018-06-12 Thread Daniel Kahn Gillmor
From: Jameson Graef Rollins make the source slightly easier to read. no functional change. --- devel/printmimestructure | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/devel/printmimestructure b/devel/printmimestructure index a5fc83e7..70e0a5c0 100755

[PATCH] doc: document notmuch show --decrypt=stash

2018-06-12 Thread Daniel Kahn Gillmor
Help users find this new indexed-cleartext workflow. --- NEWS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS b/NEWS index d1bc73b8..9c59d989 100644 --- a/NEWS +++ b/NEWS @@ -17,6 +17,12 @@ Add the --full-scan option to `notmuch new` This option disables mtime based

Re: [PATCH] devel: make printmimestructure py3 compatible

2018-06-12 Thread Daniel Kahn Gillmor
On Tue 2018-06-12 09:57:52 -0400, Daniel Kahn Gillmor wrote: > On Tue 2018-06-12 12:47:58 +0200, Thomas Schneider wrote: >> Tomi Ollila writes: >> >>> On Mon, Jun 11 2018, Daniel Kahn Gillmor wrote: >>> Make printmimestructure work in python3 as well as python2. PEP 394 suggests

Re: [PATCH v2 3/3] use #!/usr/bin/env python consistently

2018-06-12 Thread Tomi Ollila
On Tue, Jun 12 2018, Daniel Kahn Gillmor wrote: series LGTM. > --- > devel/nmbug/notmuch-report | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/devel/nmbug/notmuch-report b/devel/nmbug/notmuch-report > index 5789c5f4..eaceb2ce 100755 > --- a/devel/nmbug/notmuch-report

Re: [PATCH] devel: make printmimestructure py3 compatible

2018-06-12 Thread Daniel Kahn Gillmor
On Tue 2018-06-12 12:47:58 +0200, Thomas Schneider wrote: > Tomi Ollila writes: > >> On Mon, Jun 11 2018, Daniel Kahn Gillmor wrote: >> >>> Make printmimestructure work in python3 as well as python2. >>> >>> PEP 394 suggests that python scripts that work with both python2 and >>> python3 should

Re: [PATCH] emacs: use new show --decrypt=stash feature in emacs UI

2018-06-12 Thread Daniel Kahn Gillmor
On Mon 2018-06-11 16:09:00 -0700, Jameson Graef Rollins wrote: > This just changes the show --decrypt flag to "stash" in the emacs UI, > so that session keys will be stashed in the database when viewing > encrypted messages that have not previously been decrypted. As > always, this will only