Re: [PATCH v2 3/4] emacs: Add notmuch-crypto-gpg-program and use it

2018-10-01 Thread David Edmondson
On Sunday, 2018-09-30 at 08:34:29 -03, David Bremner wrote: > David Edmondson writes: > >> Allow the user to specify the gpg program to use when retriving keys, >> etc., defaulting to the value of `epg-gpg-program'. > > typo in retriving. Will fix. > More interestingly, would you mind

Re: unused/total message counts in hello screen?

2018-10-01 Thread Jeff Templon
William Casarin writes: > Jeff Templon writes: > >> An alternative would be if I could toggle the entire page to show just >> the unread tags (so any tags for which all messages were read would >> just not show up). Maybe even preferable, that last one. > > This can be done setting

Re: [PATCH v2 2/4] emacs: Minor refactoring of crypto code

2018-10-01 Thread David Edmondson
On Sunday, 2018-09-30 at 09:07:42 -03, David Bremner wrote: > David Edmondson writes: > > >> -(setq help-msg (concat "Click to retrieve key ID " keyid " from >> keyserver and redisplay." >> + (setq label (concat "Unknown key ID " keyid " or unsupported >> algorithm") >> +

Re: [PATCH v2 1/4] emacs: Asynchronous retrieval of GPG keys

2018-10-01 Thread David Edmondson
On Saturday, 2018-09-29 at 22:48:38 -03, David Bremner wrote: > David Edmondson writes: > >> +(defun notmuch-crypto--async-key-sentinel (process event) >> + "When the user asks for a GPG key to be retrieved >> +asynchronously, handle completion of that task." >> + (let ((status (process-status

Re: [PATCH v1 2/2] emacs: Call `notmuch-mua-send-hook' hooks when sending a message

2018-10-01 Thread David Edmondson
On Friday, 2018-09-28 at 21:12:53 -03, David Bremner wrote: > David Bremner writes: > >> >> This looks plausible to me, and of course the test passes. I did wonder >> if this means that people actually using notmuch-user-agent would run >> the hook twice now? > > After a certain amount of

[PATCH v3 0/4] Retrieve GPG keys asynchronously.

2018-10-01 Thread David Edmondson
Retrieve GPG keys asynchronously. v2: - Update the label on buttons when they are used to request asyncronous key retrieval. - Always update the buffer when key retrieval completes, even if the retrieval failed, so that the label is properly re-generated. v3: - Code review comments from

[PATCH v3 3/4] emacs: Add notmuch-crypto-gpg-program and use it

2018-10-01 Thread David Edmondson
Allow the user to specify the gpg program to use when retrieving keys, etc., defaulting to the value of `epg-gpg-program'. --- emacs/notmuch-crypto.el | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el index

[PATCH v3 1/4] emacs: Asynchronous retrieval of GPG keys

2018-10-01 Thread David Edmondson
Rather than blocking emacs while gpg does its' thing, by default run key retrieval asynchronously, possibly updating the display of the message on successful completion. --- emacs/notmuch-crypto.el | 85 +++-- 1 file changed, 74 insertions(+), 11 deletions(-)

[PATCH v3 4/4] emacs: Improve the reporting of key activity

2018-10-01 Thread David Edmondson
Improve the information provided about key retrieval and key validity. --- emacs/notmuch-crypto.el | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el index 99087d0b..553ddca8 100644 --- a/emacs/notmuch-crypto.el +++

[PATCH v3 2/4] emacs: Minor refactoring of crypto code

2018-10-01 Thread David Edmondson
--- emacs/notmuch-crypto.el | 96 + 1 file changed, 50 insertions(+), 46 deletions(-) diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el index c20fd4f8..f128f30e 100644 --- a/emacs/notmuch-crypto.el +++ b/emacs/notmuch-crypto.el @@ -96,36

Re: [PATCH v2 3/4] emacs: Add notmuch-crypto-gpg-program and use it

2018-10-01 Thread David Bremner
David Edmondson writes: > On Sunday, 2018-09-30 at 08:34:29 -03, David Bremner wrote: > >> David Edmondson writes: >> >>> Allow the user to specify the gpg program to use when retriving keys, >>> etc., defaulting to the value of `epg-gpg-program'. >> >> typo in retriving. > > Will fix. > >>

Re: [PATCH v2 1/4] emacs: Asynchronous retrieval of GPG keys

2018-10-01 Thread David Bremner
David Edmondson writes: > The condition is conservative because the refresh redraws the whole > buffer. If it just updated the button directly (which I've been fiddling > with, but don't have working well yet) then we might relax the > condition. > > Where would we document the behaviour? In

[PATCH v1 1/1] reply: Include sender as recipient if they were the original recipient

2018-10-01 Thread David Edmondson
When generating a reply message, if the user was the originator and only recipient of the original message, include the user as a recipient of the reply. --- notmuch-reply.c | 8 test/T220-reply.sh | 1 + test/T230-reply-to-sender.sh | 1 + test/T310-emacs.sh

[PATCH v1 0/1] Reply to a message including only self should include self.

2018-10-01 Thread David Edmondson
This was the cause of a failure in one of the emacs tests, but it's notmuch itself that is misbehaving. David Edmondson (1): reply: Include sender as recipient if they were the original recipient notmuch-reply.c | 8 test/T220-reply.sh | 1 +