Re: test/T010-help-test.sh fails after ./configure --without-docs

2019-04-21 Thread David Bremner
Daniel Kahn Gillmor writes: > On a system where man and notmuch are both already installed, i tried to > ./configure --without-docs to avoid the delays during development > associated with id:87r29wwgq2@fifthhorseman.net. > > The configuration succeeds, but now these tests fail: > > 0

Re: notmuch-emacs: avoiding deprecated message-default-charset

2019-04-21 Thread David Bremner
Daniel Kahn Gillmor writes: > When i'm building notmuch in a debian environment with emacs > 1:26.1+1-3.2, i notice the following deprecation warnings: > > In notmuch-maildir-setup-message-for-saving: > emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an > obsolete

Re: subsequent rebuilds of notmuch always re-build sphinx and ruby

2019-04-21 Thread David Bremner
Daniel Kahn Gillmor writes: > but it's not just texinfo, right? it starts with the html build > itself. can we at least diagnose why that's happening? > Yes, although the html rebuild is much faster than the texinfo + info rebuilds. >> This Makefile is generated by "ruby extconf.rb

[PATCH 2/4] doc: use stamp file to control rebuilding texi

2019-04-21 Thread David Bremner
Apparently the sphinx-doc texinfo builder is not smart enough to only rebuild those files where the source has changed. --- doc/Makefile.local | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/doc/Makefile.local b/doc/Makefile.local index c148d74a..2a701646 100644 ---

[PATCH 1/4] doc: don't attempt to build info pages if Emacs is missing.

2019-04-21 Thread David Bremner
This is a sledgehammer approach to conditionally (not) build the notmuch-emacs documentation, since it is currently the only thing that needs Emacs to build. Hopefully in the future we can come up with a cleaner way of disabling building the notmuch-emacs docs when emacs is missing. ---

[PATCH 4/4] build: ignore *.stamp

2019-04-21 Thread David Bremner
The current case is docstring.stamp, but it's likely that others will arise. --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index e06101ce..468b660a 100644 --- a/.gitignore +++ b/.gitignore @@ -15,3 +15,4 @@ tags .*.swp /releases /.stamps +*.stamp --

[PATCH 3/4] doc: use stamp file for html docs

2019-04-21 Thread David Bremner
These are less time consuming than the texi docs to rebuild (because the texi rebuild triggers info rebuild), but still take noticable time. --- doc/Makefile.local | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/doc/Makefile.local b/doc/Makefile.local index

Re: Drop support for pre-1.4 Xapian, prepare for 1.5.x

2019-04-21 Thread David Bremner
David Bremner writes: > David Bremner writes: > >> The current development release of Xapian drops several deprecated >> APIs. This hampers testing of notmuch against Xapian master (i.e. to >> see if a problem has been fixed). This series fixes most of the >> incompatibilities. >> >> The one

Re: notmuch-emacs: avoiding deprecated message-default-charset

2019-04-21 Thread Daniel Kahn Gillmor
On Sun 2019-04-21 11:41:22 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> When i'm building notmuch in a debian environment with emacs >> 1:26.1+1-3.2, i notice the following deprecation warnings: >> >> In notmuch-maildir-setup-message-for-saving: >>

Re: test/T010-help-test.sh fails after ./configure --without-docs

2019-04-21 Thread Daniel Kahn Gillmor
On Sun 2019-04-21 09:49:50 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> On a system where man and notmuch are both already installed, i tried to >> ./configure --without-docs to avoid the delays during development >> associated with id:87r29wwgq2@fifthhorseman.net. >> >> The

Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-04-21 Thread Daniel Kahn Gillmor
On Sun 2019-04-21 18:05:19 -0400, Noam Postavsky wrote: > The commit which marks this variable as obsolete, has a couple hunks > that just remove uses of it. Not clear why other uses were left in. > Oversight? Thanks, Noam! If that's the right thing for emacs itself, that's good to know. Do

Re: [PATCH 1/4] doc: don't attempt to build info pages if Emacs is missing.

2019-04-21 Thread David Bremner
David Bremner writes: > This is a sledgehammer approach to conditionally (not) build the > notmuch-emacs documentation, since it is currently the only thing that > needs Emacs to build. Hopefully in the future we can come up with a > cleaner way of disabling building the notmuch-emacs docs when

[PATCH 2/2] doc: exclude notmuch-emacs.rst if emacs is not present.

2019-04-21 Thread David Bremner
This will still generate a warning about an excluded document in the toctree, but it cuts down on the noise quite a lot. --- doc/Makefile.local | 2 +- doc/conf.py| 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/Makefile.local b/doc/Makefile.local index

[PATCH 1/2] build: only try to build .rsti files if we have emacs and sphinx

2019-04-21 Thread David Bremner
Emacs is needed to build them, and sphinx is needed to use them --- emacs/Makefile.local | 5 + 1 file changed, 5 insertions(+) diff --git a/emacs/Makefile.local b/emacs/Makefile.local index 04913a06..40b7c14f 100644 --- a/emacs/Makefile.local +++ b/emacs/Makefile.local @@ -47,8 +47,13 @@

Re: subsequent rebuilds of notmuch always re-build sphinx and ruby

2019-04-21 Thread Daniel Kahn Gillmor
thanks for the review, Bremner! On Sat 2019-04-20 21:12:07 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: >> 0 dkg@alice:~/src/notmuch/notmuch$ ./configure && make >> […] >> make[1]: Leaving directory '/home/dkg/src/notmuch/notmuch/bindings/ruby' >> 0 dkg@alice:~/src/notmuch/notmuch$