Re: Index user defined headers

2019-05-25 Thread David Bremner
David Bremner writes: > David Bremner writes: > >> This obsoletes [1]. Compared to the previous version the main change >> is that it imposes the restriction that user defined prefixes may not >> start with [a-z], and must consist of "unicode word characters". This >> assumes a utf8 input

Re: [PATCH] test: allow disabling timeout with NOTMUCH_TEST_TIMEOUT=0

2019-05-25 Thread David Bremner
Daniel Kahn Gillmor writes: > On Wed 2019-05-22 08:52:55 -0300, David Bremner wrote: >> Daniel Kahn Gillmor writes: >> >>> Tests appear to be hanging when run under GNU timeout on debian >>> stretch. To aid in diagnosing this or similar problems, it's handy to >>> be able to disable timeout

Re: [PATCH 2/2] emacs: Allow tagging regions in notmuch-tree

2019-05-25 Thread David Bremner
Pierre Neidhardt writes: Thanks for the updated patches. > >> 3) We generally want at least one test for a new >>feature. test/T460-emacs-tree.sh has the existing tree related >>tests. Again, if you need help with the test suite, let us know. > > I've added a test, but I wasn't able to

Re: [PATCH 3/3] emacs: Drop content-free "Unknown signature status" button

2019-05-25 Thread David Bremner
Daniel Kahn Gillmor writes: > When we have not been able to evaluate the signature status of a given > MIME part, showing a content-free (and interaction-free) "[ Unknown > signature status ]" button doesn't really help the user at all, and > takes up valuable screen real-estate. > > A visual

Re: Add notmuch-tree-toggle-order?

2019-05-25 Thread David Bremner
Pierre Neidhardt writes: > Hi, > > We have notmuch-search-toggle-order but surprisingly there is no > notmuch-tree-toggle-order. > > Besides, I find the default tree order somewhat counter-intuitive: the > threads are sorted newest at the top, but the messages within the thread > are sorted

Re: [PATCH 2/2] emacs: Allow tagging regions in notmuch-tree

2019-05-25 Thread David Bremner
Pierre Neidhardt writes: > David Bremner writes: > >>> --8<---cut here---start->8--- guix environment notmuch -- /home/ambrevar/.local/share/emacs/site-lisp/notmuch/test/T460-emacs-tree.sh >>> guix environment: error: execlp: No such file or

Re: [PATCH 3/3] emacs: Drop content-free "Unknown signature status" button

2019-05-25 Thread Daniel Kahn Gillmor
On Fri 2019-05-24 22:38:12 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> On Thu 2019-05-23 22:13:59 -0300, David Bremner wrote: >>> Daniel Kahn Gillmor writes: >>> diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el index 353f721e..68171153 100644 ---

[PATCH] test: report summary even when aborting

2019-05-25 Thread Daniel Kahn Gillmor
In certain cases of test suite failure, the summary report was not being printed. In particular, any failure on the parallel test suite, and any aborted test in the serialized test suite would end up hiding the summary. It's better to always show the summary where we can (while preserving the

[PATCH v3 3/4] mime-node: track whole-message crypto state while walking the tree

2019-05-25 Thread Daniel Kahn Gillmor
Deliberately populate the message's cryptographic status while walking the MIME tree from the CLI. Note that the additional numchild argument added to _mime_node_create is a passthrough needed to be able to adequately populate the crypto state object. --- mime-node.c | 23 +--

[PATCH v3 4/4] cli/show: emit new whole-message crypto status output

2019-05-25 Thread Daniel Kahn Gillmor
This allows MUAs that don't want to think about per-mime-part cryptographic status to have a simple high-level overview of the message's cryptographic state. Sensibly structured encrypted and/or signed messages will work fine with this. The only requirement for the simplest encryption + signing

[PATCH v3 1/4] util/crypto: _notmuch_message_crypto: tracks message-wide crypto state

2019-05-25 Thread Daniel Kahn Gillmor
E-mail encryption and signatures reported by notmuch are at the MIME part level. This makes sense in the dirty details, but for users we need to have a per-message conception of the cryptographic state of the e-mail. (see https://dkg.fifthhorseman.net/blog/e-mail-cryptography.html for more

[PATCH v3 2/4] cli: expose message-wide crypto status from mime-node

2019-05-25 Thread Daniel Kahn Gillmor
The mime node context (a per-message context) gains a cryptographic status object, and the mime_node_t object itself can return a view on that status to an interested party. The status is not yet populated, and for now we can keep that view read-only, so that it can only be populated/modified

revision 3: easing access to the cryptographic envelope

2019-05-25 Thread Daniel Kahn Gillmor
This is the third revision of the series originally posted at id:20190424183113.29242-1-...@fifthhorseman.net (revision 2 was at id:20190520032228.27420-1-...@fifthhorseman.net) This series addresses comments raised by David Bremner in his review. Thanks, Bremner! The most significant change

Re: [PATCH] test: report summary even when aborting

2019-05-25 Thread Tomi Ollila
On Sat, May 25 2019, Daniel Kahn Gillmor wrote: > In certain cases of test suite failure, the summary report was not > being printed. In particular, any failure on the parallel test suite, > and any aborted test in the serialized test suite would end up hiding > the summary. > > It's better to