[PATCH v3 06/17] cli/show: add information about which headers were protected

2019-05-27 Thread Daniel Kahn Gillmor
This allows a clever UI frontend to mark whether a header was protected (or not), and if it was protected, to show the details to an interested user. As before, we only handle Subject for now, but we might be able to handle other headers in the future. Signed-off-by: Daniel Kahn Gillmor ---

Re: [PATCH v2 06/17] cli/show: add information about which headers were protected

2019-05-27 Thread Daniel Kahn Gillmor
On Mon 2019-05-27 07:12:52 -0300, David Bremner wrote: > I think you also need to add a definition for header_name to schemata > (in the same way that messageid is defined as a string). thanks, done in v3, which you should see shortly. > The name "header-mask" is a bit generic, but I don't have

[PATCH v4 06/17] cli/show: add information about which headers were protected

2019-05-27 Thread Daniel Kahn Gillmor
The header-mask member of the per-message crypto object allows a clever UI frontend to mark whether a header was protected (or not). And if it was protected, it contains enough information to show useful detail to an interested user. For example, an MUA could offer a "show what this message's

Re: [PATCH v2 03/17] test: new test framework to compare json parts

2019-05-27 Thread Rollins, Jameson
On Mon, May 27 2019, David Bremner wrote: > Daniel Kahn Gillmor writes: >> + >> +Value test: test that object in json data found at address is equal to >> specified value: >> + >> + label:address|value >> + > > should this maybe be label:address=value ? At least looking that the > regex and

[PATCH v3 10/17] indexing: record protected subject when indexing cleartext

2019-05-27 Thread Daniel Kahn Gillmor
When indexing the cleartext of an encrypted message, record any protected subject in the database, which should make it findable and visible in search. Signed-off-by: Daniel Kahn Gillmor --- lib/index.cc | 46 +++--- lib/message.cc |

_notmuch_database_log vs _notmuch_database_log_append [was: Re: [PATCH v2 10/17] indexing: record protected subject when indexing cleartext]

2019-05-27 Thread Daniel Kahn Gillmor
On Mon 2019-05-27 07:24:41 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> +status = _notmuch_message_crypto_potential_payload (msg_crypto, clear, >> GMIME_OBJECT (encrypted_data), GMIME_MULTIPART_ENCRYPTED_CONTENT); >> +_index_mime_part (message, indexopts, clear,

Re: [PATCH v3 14/17] test: ensure that protected headers appear in notmuch-emacs search as expected

2019-05-27 Thread Daniel Kahn Gillmor
On Mon 2019-05-27 17:35:44 -0400, Daniel Kahn Gillmor wrote: > We initially test only notmuch-search; tests for other functionality > come in different patchsets later. > > Signed-off-by: Daniel Kahn Gillmor sorry, this patch (v3 14/17) is a minor update to the protected header series,

Re: Protected Headers (2nd major revision, more testing!)

2019-05-27 Thread Daniel Kahn Gillmor
On Sun 2019-05-26 18:15:53 -0400, Daniel Kahn Gillmor wrote: > this series delivers a concrete improvement: users of notmuch can now > read, index, and search for the subject lines of encrypted messages > sent from MUAs like Enigmail and K-9 mail. Many thanks to jrollins and bremner for their

[PATCH v3] test: new test framework to compare json parts

2019-05-27 Thread Rollins, Jameson
From: Jameson Graef Rollins This makes it easier to write fairly compact, readable tests of json output, without needing to sanitize away parts that we don't care about. Signed-off-by: Daniel Kahn Gillmor --- test/json_check_nodes.py | 114 +++

Re: [PATCH v3 06/17] cli/show: add information about which headers were protected

2019-05-27 Thread Daniel Kahn Gillmor
On Mon 2019-05-27 16:40:59 -0400, Daniel Kahn Gillmor wrote: > This allows a clever UI frontend to mark whether a header was > protected (or not), and if it was protected, to show the details to > an interested user. > > As before, we only handle Subject for now, but we might be able to > handle

Re: [PATCH] NEWS: News for my changes for 0.29

2019-05-27 Thread Daniel Kahn Gillmor
On Mon 2019-05-27 07:46:55 -0300, David Bremner wrote: > +Dependencies > + > + > +Support for GMime 2.6 is removed. > + I'd add here: The minimum supported version of GMime is now 3.0.3. GMime also needs to have been compiled with cryptographic support. --dkg

Re: [PATCH v3 03/17] test: new test framework to compare json parts

2019-05-27 Thread Rollins, Jameson
On Mon, May 27 2019, Daniel Kahn Gillmor wrote: > On Mon 2019-05-27 16:34:27 -0400, Daniel Kahn Gillmor wrote: >> From: Jameson Graef Rollins >> >> This makes it easier to write fairly compact, readable tests of json >> output, without needing to sanitize away parts that we don't care >> about.

[PATCH v3 03/17] test: new test framework to compare json parts

2019-05-27 Thread Daniel Kahn Gillmor
From: Jameson Graef Rollins This makes it easier to write fairly compact, readable tests of json output, without needing to sanitize away parts that we don't care about. Signed-off-by: Daniel Kahn Gillmor --- test/json_check_nodes.py | 113 +++

[PATCH v3 14/17] test: ensure that protected headers appear in notmuch-emacs search as expected

2019-05-27 Thread Daniel Kahn Gillmor
We initially test only notmuch-search; tests for other functionality come in different patchsets later. Signed-off-by: Daniel Kahn Gillmor --- test/T358-emacs-protected-headers.sh | 36 1 file changed, 36 insertions(+) create mode 100755

Re: [PATCH v3 03/17] test: new test framework to compare json parts

2019-05-27 Thread Daniel Kahn Gillmor
On Mon 2019-05-27 16:34:27 -0400, Daniel Kahn Gillmor wrote: > From: Jameson Graef Rollins > > This makes it easier to write fairly compact, readable tests of json > output, without needing to sanitize away parts that we don't care > about. woops, patches crossed in the ether! feel free to

stitching threads (v3 14/17)

2019-05-27 Thread Daniel Kahn Gillmor
hm, it appears that notmuch-emacs sends duplicate References: headers during reply when i add that manually to the headers field during compose. and then when notmuch indexes a message, it only indexes the first References: header it finds. These are curious things i find as i try to stitch the

Re: [PATCH v3 10/17] indexing: record protected subject when indexing cleartext

2019-05-27 Thread Daniel Kahn Gillmor
On Mon 2019-05-27 17:17:20 -0400, Daniel Kahn Gillmor wrote: > When indexing the cleartext of an encrypted message, record any > protected subject in the database, which should make it findable and > visible in search. ugh, please ignore v3 of this patch (10/17) as well. v4 should be coming

[PATCH v4 10/17] indexing: record protected subject when indexing cleartext

2019-05-27 Thread Daniel Kahn Gillmor
When indexing the cleartext of an encrypted message, record any protected subject in the database, which should make it findable and visible in search. Signed-off-by: Daniel Kahn Gillmor --- lib/index.cc | 42 ++ lib/message.cc |

Re: Protected Headers (2nd major revision, more testing!)

2019-05-27 Thread Rollins, Jameson
On Sun, May 26 2019, Daniel Kahn Gillmor wrote: > Way back in id:20180511055544.13676-1-...@fifthhorseman.net, i > proposed support for protected headers (in particular, for being able > to read and search for subject lines of encrypted messages which > protect the Subject). Although that series

Re: [PATCH v2 06/17] cli/show: add information about which headers were protected

2019-05-27 Thread Rollins, Jameson
On Mon, May 27 2019, David Bremner wrote: > The name "header-mask" is a bit generic, but I don't have my head in > this topic like you do. I was thinking of something like > "replaced-headers", but it's only a mild suggestion. I think the point is that the headers are more accurately "masked"

Re: [PATCH v2 06/17] cli/show: add information about which headers were protected

2019-05-27 Thread David Bremner
"Rollins, Jameson" writes: > On Mon, May 27 2019, David Bremner wrote: >> The name "header-mask" is a bit generic, but I don't have my head in >> this topic like you do. I was thinking of something like >> "replaced-headers", but it's only a mild suggestion. > > I think the point is that the

Re: [PATCH v2 14/17] test: ensure that protected headers appear in notmuch-emacs search as expected

2019-05-27 Thread Rollins, Jameson
On Sun, May 26 2019, Daniel Kahn Gillmor wrote: > diff --git a/test/T358-emacs-protected-headers.sh > b/test/T358-emacs-protected-headers.sh > new file mode 100755 > index ..56ac06ca > --- /dev/null > +++ b/test/T358-emacs-protected-headers.sh > @@ -0,0 +1,36 @@ > +#!/usr/bin/env bash >

[PATCH 1/2] NEWS: include information about per-message cryptographic status

2019-05-27 Thread Daniel Kahn Gillmor
--- NEWS | 4 1 file changed, 4 insertions(+) diff --git a/NEWS b/NEWS index d8aa272f..999affc7 100644 --- a/NEWS +++ b/NEWS @@ -7,6 +7,10 @@ Command Line Interface `notmuch show` now supports --body=false and --include-html with --format=text +`notmuch show` and `notmuch reply` now

[PATCH 2/2] NEWS: note parallel test suite

2019-05-27 Thread Daniel Kahn Gillmor
--- NEWS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS b/NEWS index 999affc7..60a69936 100644 --- a/NEWS +++ b/NEWS @@ -19,6 +19,13 @@ The minimum supported major version of Emacs is now 24. Support for GNU Emacs older than 25.1 is deprecated with this release, and may be

Re: revision 3: easing access to the cryptographic envelope

2019-05-27 Thread Tomi Ollila
On Sun, May 26 2019, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> On Sun 2019-05-26 09:01:46 -0300, David Bremner wrote: >>> Daniel Kahn Gillmor writes: >>> This is the third revision of the series originally posted at id:20190424183113.29242-1-...@fifthhorseman.net

Re: [PATCH v2 03/17] test: new test framework to compare json parts

2019-05-27 Thread David Bremner
Daniel Kahn Gillmor writes: > + > +Value test: test that object in json data found at address is equal to > specified value: > + > + label:address|value > + should this maybe be label:address=value ? At least looking that the regex and the examples.

Re: [PATCH v2 06/17] cli/show: add information about which headers were protected

2019-05-27 Thread David Bremner
Daniel Kahn Gillmor writes: > The header-mask member of the per-message crypto object allows a > clever UI frontend to mark whether a header was protected (or not). > And if it was protected, it contains enough information to show useful > detail to an interested user. For example, an MUA could

Re: [PATCH v2 10/17] indexing: record protected subject when indexing cleartext

2019-05-27 Thread David Bremner
Daniel Kahn Gillmor writes: > +status = _notmuch_message_crypto_potential_payload (msg_crypto, clear, > GMIME_OBJECT (encrypted_data), GMIME_MULTIPART_ENCRYPTED_CONTENT); > +_index_mime_part (message, indexopts, clear, msg_crypto); > g_object_unref (clear); If you're going to

[PATCH] NEWS: News for my changes for 0.29

2019-05-27 Thread David Bremner
These are pretty terse overall, and could be expanded in future commits. --- NEWS | 37 + 1 file changed, 37 insertions(+) diff --git a/NEWS b/NEWS index d8aa272f..b852efec 100644 --- a/NEWS +++ b/NEWS @@ -1,12 +1,33 @@ Notmuch 0.29 (UNRELEASED)