Re: [PATCH V2] test: aggregate-results.sh: consistent style. zero forks.

2019-06-11 Thread Daniel Kahn Gillmor
On Mon 2019-06-10 21:39:23 +0300, Tomi Ollila wrote: > - all variables in $((...)) without leading $ > - all comparisons use -gt, -eq or -ne > - no -a nor -o inside [ ... ] expressions > - all indentation levels using one tab > > Dropped unnecessary empty string check when reading results files. >

Re: [PATCH] python: bind add_property/remove_property and related methods

2019-06-11 Thread Daniel Kahn Gillmor
On Mon 2019-06-10 14:55:48 +0200, VA wrote: > Le 09/06/2019 à 21:58, Daniel Kahn Gillmor a écrit : >> We do expose this functionality in the library, so it's not the end of >> the world to expose it in the python bindings, but i do worry a little >> bit about encouraging people to fiddle with

Re: [PATCH] append _unused to the expression defined using unused() macro

2019-06-11 Thread David Bremner
Tomi Ollila writes: > This way if variables defined using unused() macro are actually > used then code will not compile... pushed to master d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] debian: bump Standards-Version to 4.3.0 (no changes needed)

2019-06-11 Thread David Bremner
Daniel Kahn Gillmor writes: > /usr/share/doc/debian-policy/upgrading-checklist.txt.gz suggests that > notmuch is already compliant with debian-policy 4.3.0. series pushed to amster d ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH] fix misspelling

2019-06-11 Thread David Bremner
pushed to master d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] debian: enable build hardening features

2019-06-11 Thread David Bremner
Daniel Kahn Gillmor writes: > Debian's build hardening toolchain options produce binary artifacts > that are more resistant to compromise. The most visible change for > notmuch today is likely to be the addition of the "bindnow" linker > flag, which contributes to making the "Global Offset

Re: [PATCH V2] test: aggregate-results.sh: consistent style. zero forks.

2019-06-11 Thread David Bremner
Tomi Ollila writes: > - all variables in $((...)) without leading $ > - all comparisons use -gt, -eq or -ne > - no -a nor -o inside [ ... ] expressions > - all indentation levels using one tab > pushed to master d ___ notmuch mailing list

Re: [PATCH 2/2] doc: Don't install emacs docs when they are not built

2019-06-11 Thread Tomi Ollila
On Mon, Jun 10 2019, David Bremner wrote: > In 40b025 we stopped building the notmuch-emacs documentation if > HAVE_EMACS=0 (i.e. no emacs was detected by configure). Unfortunately > we continued to try to install the (non-existent) documentation, which > causes build/install failures. > > As a

Re: [PATCH] doc: Makefile: stop build notmuch-emacs.info when not have emacs

2019-06-11 Thread Ralph Seichter
* Doan Tran Cong Danh: > I don't know if this is a _good_ fix for this issue. Did you see id:20190611005024.22814-2-da...@tethera.net ? -Ralph ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] doc: Makefile: stop build notmuch-emacs.info when not have emacs

2019-06-11 Thread Doan Tran Cong Danh
Current behavior: - When build on system without emacs: ./configure --without-emacs make make install `make install` failed with: > /usr/bin/install: cannot stat 'doc/_build/texinfo/notmuch-emacs.info': No > such file or directory Signed-off-by: Doan Tran Cong Danh --- I don't know if this is

Re: [PATCH] doc: Makefile: stop build notmuch-emacs.info when not have emacs

2019-06-11 Thread Danh Doan
No, I haven't seen it, until now. I used to follow the list but I stopped using notmuch. It seems like David has come up with a fix. I'll check the list first, next time. On June 11, 2019 3:21:42 PM UTC, Ralph Seichter wrote: >* Doan Tran Cong Danh: > >> I don't know if this is a _good_ fix for

Re: [emacs] Auto-rotate pictures

2019-06-11 Thread David Edmondson
On Wednesday, 2019-04-03 at 11:10:54 +02, Pierre Neidhardt wrote: > Some pictures embed "exif" metadata with autorotate information. > I know that mu4e can autorotate inlined pictures. > I guess it wouldn't be too hard to implement this for Emacs Notmuch > either. Can you send me (directly, not

Re: STYLE and uncrustify

2019-06-11 Thread Tomi Ollila
On Fri, Jun 07 2019, David Bremner wrote: > I'm pondering running uncrustify on all/most of the notmuch codebase, > but I noticed a few things that uncrustify does are either not > documented in STYLE, or maybe contradicted. > > 1) Should block comments start with '*' ? Uncrustify thinks yes,

Re: [PATCH 1/2] debian: bump Standards-Version to 4.3.0 (no changes needed)

2019-06-11 Thread David Bremner
Daniel Kahn Gillmor writes: > On Mon 2019-06-10 04:22:50 +0300, Daniel Kahn Gillmor wrote: >> /usr/share/doc/debian-policy/upgrading-checklist.txt.gz suggests that >> notmuch is already compliant with debian-policy 4.3.0. >> >> Signed-off-by: Daniel Kahn Gillmor > > just wanted to note that i

Re: [PATCH 1/2] debian: bump Standards-Version to 4.3.0 (no changes needed)

2019-06-11 Thread Daniel Kahn Gillmor
On Mon 2019-06-10 04:22:50 +0300, Daniel Kahn Gillmor wrote: > /usr/share/doc/debian-policy/upgrading-checklist.txt.gz suggests that > notmuch is already compliant with debian-policy 4.3.0. > > Signed-off-by: Daniel Kahn Gillmor just wanted to note that i screwed up my own e-mail address in the

notmuch release 0.29.1 now available

2019-06-11 Thread David Bremner
Where to obtain notmuch 0.29.1 === https://notmuchmail.org/releases/notmuch-0.29.1.tar.xz Which can be verified with: https://notmuchmail.org/releases/notmuch-0.29.1.tar.xz.sha256.asc -BEGIN PGP SIGNED MESSAGE- Hash: SHA256

Re: [PATCH 2/2] doc: Don't install emacs docs when they are not built

2019-06-11 Thread David Bremner
David Bremner writes: > In 40b025 we stopped building the notmuch-emacs documentation if > HAVE_EMACS=0 (i.e. no emacs was detected by configure). Unfortunately > we continued to try to install the (non-existent) documentation, which > causes build/install failures. > > As a bonus, we also avoid

[PATCH] build: drop variable HAVE_EMACS. use WITH_EMACS instead

2019-06-11 Thread David Bremner
The extra flexibility of having both HAVE_EMACS (for yes, there is an emacs we can use) and WITH_EMACS (the user wants emacs support) lead to confusion and bugs. We now just force WITH_EMACS to 0 if no suitable emacs is detected. --- configure| 18 --

[PATCH] configure: fix mktemp call for macOS

2019-06-11 Thread Ralph Seichter
The mktemp call in configure is incompatible with /usr/bin/mktemp as shipped with macOS, where it fails due to a missing parameter. I added the missing template, and the call is now working with both Apple's and GNU coreutils' mktemp. Signed-off-by: Ralph Seichter --- configure | 2 +- 1 file