[PATCH 7/7] cli: uncrustify mime-node.c

2019-06-12 Thread David Bremner
Cuddle a few parens on function calls per Tomi's suggestion to make uncrustify match emacs indentation. --- mime-node.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/mime-node.c b/mime-node.c index a93cbb31..3133ca44 100644 ---

[PATCH 2/7] devel: remove between ++ / -- and argument

2019-06-12 Thread David Bremner
Apparently we just missed the option to get "x++" while keeping "x + y". --- devel/uncrustify.cfg | 1 + 1 file changed, 1 insertion(+) diff --git a/devel/uncrustify.cfg b/devel/uncrustify.cfg index 6a8769c6..b8e57324 100644 --- a/devel/uncrustify.cfg +++ b/devel/uncrustify.cfg @@ -71,6 +71,7 @@

[PATCH 4/7] cli: uncrustify debugger.c

2019-06-12 Thread David Bremner
--- debugger.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/debugger.c b/debugger.c index 0febf170..5f47a1d7 100644 --- a/debugger.c +++ b/debugger.c @@ -39,8 +39,7 @@ debugger_is_active (void) sprintf (buf, "/proc/%d/exe", getppid ()); if (readlink (buf,

[PATCH 3/7] cli: uncrustify command-line-arguments.c

2019-06-12 Thread David Bremner
Ignore one exploding '!!' -> '! !' and add one pair of parens. --- command-line-arguments.c | 58 +++- 1 file changed, 33 insertions(+), 25 deletions(-) diff --git a/command-line-arguments.c b/command-line-arguments.c index 5f0607be..a628929b 100644 ---

[PATCH 5/7] cli: uncrustify gmime-filter-reply.c

2019-06-12 Thread David Bremner
The previous indentation used pure tabs. --- gmime-filter-reply.c | 190 +-- 1 file changed, 95 insertions(+), 95 deletions(-) diff --git a/gmime-filter-reply.c b/gmime-filter-reply.c index 480d9381..2b067669 100644 --- a/gmime-filter-reply.c +++

[PATCH 1/7] cli: replace use of !! with macro

2019-06-12 Thread David Bremner
The slightly annoying reason to do this is because uncrustify can't handle '!! foo' sensibly. The less annoying reason is that it helps understand what the code does. --- command-line-arguments.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git

Trial run uncrustifying some of the CLI

2019-06-12 Thread David Bremner
I made a few (hopefully inoffensive) changes to accomodate the enforced styling. What do people think? Assuming this series is OK, do you want mega patches (~500 line diff) or more small patches for semi-auto styling? ___ notmuch mailing list

[PATCH 6/7] cli: uncrustify hooks.c

2019-06-12 Thread David Bremner
--- hooks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hooks.c b/hooks.c index 7348d322..59c58070 100644 --- a/hooks.c +++ b/hooks.c @@ -53,7 +53,7 @@ notmuch_run_hook (const char *db_path, const char *hook) /* Flush any buffered output before forking. */

Re: [PATCH 1/7] cli: replace use of !! with macro

2019-06-12 Thread Tomi Ollila
On Wed, Jun 12 2019, David Bremner wrote: > The slightly annoying reason to do this is because uncrustify can't > handle '!! foo' sensibly. The less annoying reason is that it helps > understand what the code does. > --- > command-line-arguments.c | 16 +--- > 1 file changed, 9

Re: [PATCH] build: drop variable HAVE_EMACS. use WITH_EMACS instead

2019-06-12 Thread Tomi Ollila
On Tue, Jun 11 2019, David Bremner wrote: > The extra flexibility of having both HAVE_EMACS (for yes, there is an > emacs we can use) and WITH_EMACS (the user wants emacs support) lead > to confusion and bugs. We now just force WITH_EMACS to 0 if no > suitable emacs is detected. LGTM. Tomi >

Re: [PATCH 1/7] cli: replace use of !! with macro

2019-06-12 Thread Jorge P . de Morais Neto
Hi. Isn't it good practice to parenthesize the arguments of C macros? So TO_BOOL would be defined as #define TO_BOOL(thing) (!! (thing)) In fact, why not just cast to bool? Regards David Bremner writes: > The slightly annoying reason to do this is because uncrustify can't > handle '!! foo'

HTML email in notmuch-el.

2019-06-12 Thread Dmitry M
Good afternoon everyone, I've been struggling a bit customizing the reading view, particularly with HTML emails. A lot of my mail comes from Outlook, JIRA and other applications that generate HTML emails by default. In fact, now that I think about it, most of it is HTML. notmuch-el does an ok

Re: [PATCH] build: drop variable HAVE_EMACS. use WITH_EMACS instead

2019-06-12 Thread David Bremner
Tomi Ollila writes: > On Tue, Jun 11 2019, David Bremner wrote: > >> The extra flexibility of having both HAVE_EMACS (for yes, there is an >> emacs we can use) and WITH_EMACS (the user wants emacs support) lead >> to confusion and bugs. We now just force WITH_EMACS to 0 if no >> suitable emacs