[PATCH] fix file descriptor leak with compressed email

2019-09-22 Thread James Troup
Hi, I'm trying notmuch for the first time using notmuch 0.29.1-2ubuntu1 backported to Ubuntu 19.04. My email is stored in Gnus nnml format and is approximately 410K mails with 60% compressed. While trying to run 'notmuch new' I very quickly ran into issues with 'Too many open files', even after

[PATCH 1/2] test: known broken test file descriptor leak in gzip file open

2019-09-22 Thread David Bremner
James Troup reported this bug in id:87pnjsf9q5@canonical.com --- test/T750-gzip.sh | 8 1 file changed, 8 insertions(+) diff --git a/test/T750-gzip.sh b/test/T750-gzip.sh index 5b678fa1..f4e0c42a 100755 --- a/test/T750-gzip.sh +++ b/test/T750-gzip.sh @@ -167,4 +167,12 @@ This is just

[PATCH 2/2] util: unreference objects referenced by the returned stream obj

2019-09-22 Thread David Bremner
We want freeing the returned stream to also free these underlying objects. Compare tests/test-filters.c in the gmime 3.2.x source, which uses this same idiom. Thanks to James Troup for the report and the fix. --- test/T750-gzip.sh | 1 - util/gmime-extra.c | 2 ++ 2 files changed, 2 insertions(+

fix file descriptor leak

2019-09-22 Thread David Bremner
I'm think this probably deserves a point release. Please test/review. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch