Re: [PATCH 1/2] python/notmuch2: do not destroy messages owned by a query

2020-05-21 Thread Anton Khirnov
ping -- Anton Khirnov ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] python/notmuch2: do not destroy messages owned by a query

2020-05-21 Thread David Bremner
Anton Khirnov writes: > ping I'm hoping Floris will find a chance to review your patches. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: test suite: FIXED messages are misordered with tests

2020-05-21 Thread Daniel Kahn Gillmor
On Thu 2020-05-21 00:16:48 +0300, Tomi Ollila wrote: > (just tested this latest works) Thanks for looking into this, Tomi! Do you have a patch to propose? --dkg signature.asc Description: PGP signature ___ notmuch mailing list

Re: [PATCH 2/2 v2] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7

2020-05-21 Thread David Bremner
Daniel Kahn Gillmor writes: > When checking cryptographic signatures, Notmuch relies on GMime to > tell it whether the certificate that signs a message has a valid User > ID or not. > > If the User ID is not valid, then notmuch does not report the signer's > User ID to the user. This means that

Re: [PATCH] emacs: add notmuch-expr, sexp-style queries

2020-05-21 Thread Daniel Kahn Gillmor
On Wed 2020-05-13 20:00:24 +1000, Tom Fitzhenry wrote: > notmuch-expr allows you to write notmuch search queries in sexp style like: > > (notmuch-expr > '(and > (to "emacs-devel") > "info manual" > (or > (not (is "spam")) > (is "important" > > which will generate the

Re: test suite: FIXED messages are misordered with tests

2020-05-21 Thread Tomi Ollila
On Thu, May 21 2020, Daniel Kahn Gillmor wrote: > On Thu 2020-05-21 00:16:48 +0300, Tomi Ollila wrote: >> (just tested this latest works) > > Thanks for looking into this, Tomi! > > Do you have a patch to propose? Looked a bit (now). Somewhat complicated to make perfect (enemy of good) change.

[PATCH 2/2 v3] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7

2020-05-21 Thread Daniel Kahn Gillmor
When checking cryptographic signatures, Notmuch relies on GMime to tell it whether the certificate that signs a message has a valid User ID or not. If the User ID is not valid, then notmuch does not report the signer's User ID to the user. This means that the consumer of notmuch's cryptographic

Re: [PATCH 2/2 v2] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7

2020-05-21 Thread Daniel Kahn Gillmor
Thanks for the review, and for the poke about out-of-tree builds on IRC, Bremner. Another revision is coming in a minute. Notes below… On Thu 2020-05-21 20:29:05 -0300, David Bremner wrote: > I find these long lines with !! in the middle pretty surprising. Is > there some reason for this style?

Re: [PATCH 3/5] build: optionally build python-cffi bindings

2020-05-21 Thread Daniel Kahn Gillmor
On Mon 2019-11-04 23:26:25 +0200, Tomi Ollila wrote: > how bad does out-of-tree build break with this -- do we need to do > the same as with ruby bindings (copy sources -- do we still do so)? or does > python provide better alternative..? I've just posted

Re: [PATCH 1/2] python/notmuch2: do not destroy messages owned by a query

2020-05-21 Thread Floris Bruynooghe
Hi Anton, Thanks for improving the bindings! Any my apologies for the late response, I failed to spot this mail the first time round. Also, this is a pretty serious bug, thanks for finding it. This looks pretty solid, a few small style comments that aren't very important notwithstanding.

[PATCH] tests: fix test_json_nodes() in out-of-tree builds

2020-05-21 Thread Daniel Kahn Gillmor
In out-of-tree builds, $TEST_DIRECTORY doesn't contain json_check_nodes.py. This caused 27 tests to fail in such an environment. Signed-off-by: Daniel Kahn Gillmor --- test/test-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index

Re: waiting tag

2020-05-21 Thread Daniel Kahn Gillmor
On Mon 2020-05-04 09:25:59 +0200, Gregor Zattler wrote: > * Keegan Carruthers-Smith [2020-05-03; 22:37]: >> notmuch tag -waiting -- tag:waiting and 'thread:{tag:new}' > > but this removes the waiting tag if there is some response > to some message in the thread, not necessary to the message >

Re: [PATCH] emacs docstrings: consistent indentation, newlines, periods

2020-05-21 Thread Daniel Kahn Gillmor
On Mon 2020-05-04 00:21:36 +0300, Tomi Ollila wrote: > Fixed emacs docstrings to be consistent. No functional change. > > - removed some (accidental) indentation > - removed some trailing newlines > - added trailing periods where missing (some exclusions) This all looks good to me, except for the

Re: [PATCH] emacs: split-window-sensibly in tree mode with open message

2020-05-21 Thread Daniel Kahn Gillmor
On Sat 2020-05-02 20:11:09 -0400, Radu Butoi wrote: > This uses the standard Emacs function `split-window-sensibly` to split a > window horizontally or vertically depending on space when opening a > message in tree view. By default, split-width-threshold is 160 columns > (and -height- is nil), so

Re: test suite: FIXED messages are misordered with tests

2020-05-21 Thread Daniel Kahn Gillmor
On Fri 2020-05-22 00:57:14 +0300, Tomi Ollila wrote: > We've accumulated quite a bit of mess during these years to the test > system, which makes it harder to do larger adjustments (and not (yet) > mentioning even larger refactorings...). The last significant refactoring was probably when

[PATCH] python-cffi: enable out-of-tree builds

2020-05-21 Thread Daniel Kahn Gillmor
This is a simple hack to enable out-of-tree builds, a concern raised by Tomi in id:m24kzjib9a@guru.guru-group.fi This change at least enables "make check" to complete without error, but I'm sure it could be improved. I am not expert enough in setuptools to know how. Signed-off-by: Daniel

python-cffi and ruby test suites fail in out-of-tree builds

2020-05-21 Thread Daniel Kahn Gillmor
Hey folks-- I just did a bit of testing and cleanup for out-of-tree builds (see the minor patches that should have landed on the list in the last hour or two). For me, "make check" in an out-of-tree build works fine now, with the exception of T391-python-cffi.sh and T395-ruby.sh. I'm afraid i

Re: [PATCH] emacs docstrings: consistent indentation, newlines, periods

2020-05-21 Thread Tomi Ollila
On Thu, May 21 2020, Daniel Kahn Gillmor wrote: > On Mon 2020-05-04 00:21:36 +0300, Tomi Ollila wrote: >> Fixed emacs docstrings to be consistent. No functional change. >> >> - removed some (accidental) indentation >> - removed some trailing newlines >> - added trailing periods where missing

Re: [PATCH 2/2] python/notmuch2: add bindings for the database config strings

2020-05-21 Thread Floris Bruynooghe
Thanks for adding more of the API! This mostly is fine as well, again I'd mainly ask to add tests however. At least the things which are implemented directly I guess: setitem, getitem, iter and len. On Sat 09 May 2020 at 07:05 +0200, Anton Khirnov wrote: > --- >

Re: [PATCH] emacs: split-window-sensibly in tree mode with open message

2020-05-21 Thread Radu Butoi
Daniel Kahn Gillmor writes: > I like this proposal, and the simplification that it gives to the > notmuch-emacs codebase. However, this thread is the first place i've > learned about split-window-sensibly, so i'm probably not eligible to > really judge the merits here. For some historical