Re: [PATCH v3 3/3] emacs: Use `dolist' instead of `mapcar' for side-effects

2020-05-26 Thread David Bremner
Jonas Bernoulli writes: > As recommended by the byte-compiler. pushed to master. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: python-cffi and ruby test suites fail in out-of-tree builds

2020-05-26 Thread Daniel Kahn Gillmor
On Sat 2020-05-23 21:52:18 +0200, Floris Bruynooghe wrote: > modified test/T391-python-cffi.sh > @@ -8,7 +8,7 @@ fi > > > test_begin_subtest "python cffi tests" > -pytest_dir=$NOTMUCH_SRCDIR/bindings/python-cffi/build/stage > +pytest_dir=$NOTMUCH_BUILDDIR/bindings/python-cffi/build/stage >

Re: [PATCH] tests/ruby: Ensure that test works for out-of-tree builds

2020-05-26 Thread Daniel Kahn Gillmor
On Tue 2020-05-26 13:06:02 -0400, Daniel Kahn Gillmor wrote: > --- > test/test-lib.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/test-lib.sh b/test/test-lib.sh > index 792b1cb9..78a90862 100644 > --- a/test/test-lib.sh > +++ b/test/test-lib.sh > @@ -1081,7

Re: [PATCH v3 2/3] emacs: Add simple make target to compile emacs lisp tests

2020-05-26 Thread Jonas Bernoulli
David Bremner writes: > Jonas Bernoulli writes: > >> +compile-elisp-tests: >> +$(EMACS) --batch -L emacs -L test -l notmuch.el -l test-lib.el -f \ >> +batch-byte-compile test/*.el >> + > > Can you explain a bit (perhaps in an updated commit message) why we need > this target? The tests

Re: [PATCH] python-cffi: enable out-of-tree builds

2020-05-26 Thread Daniel Kahn Gillmor
On Thu 2020-05-21 21:03:59 -0400, Daniel Kahn Gillmor wrote: > This is a simple hack to enable out-of-tree builds, a concern raised > by Tomi in id:m24kzjib9a@guru.guru-group.fi > > This change at least enables "make check" to complete without error, > but I'm sure it could be improved. I am

[PATCH] tests/ruby: Ensure that test works for out-of-tree builds

2020-05-26 Thread Daniel Kahn Gillmor
--- test/test-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 792b1cb9..78a90862 100644 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -1081,7 +1081,7 @@ test_python() { } test_ruby() { -MAIL_DIR=$MAIL_DIR

Re: [PATCH] emacs: split-window-sensibly in tree mode with open message

2020-05-26 Thread Radu Butoi
Daniel Kahn Gillmor writes: > I find this argument compelling. When i've used split-pane MUAs, i > pretty much always want the tree view smaller than the message pane. Fair enough. I realized after these responses that my own settings were getting in the way -- I make all my windows equally

Re: [PATCH] tests: fix test_json_nodes() in out-of-tree builds

2020-05-26 Thread Daniel Kahn Gillmor
On Sun 2020-05-24 20:59:29 +0300, Tomi Ollila wrote: > On Thu, May 21 2020, Daniel Kahn Gillmor wrote: > >> In out-of-tree builds, $TEST_DIRECTORY doesn't contain >> json_check_nodes.py. This caused 27 tests to fail in such an >> environment. > > are you shure the run_emacs.sh change in > >

doc build warnings when building out-of-tree

2020-05-26 Thread Daniel Kahn Gillmor
When building out-of-tree, the documentation (both manpages and info files) are incomplete, but they do not explicitly fail. build logs follow from doing "mkdir build && ../configure && make". If there's a way to make these warnings into hard failures, i think that would be good -- we don't want