[PATCH v3] Emacs: Indent first header line only when indentation is turned on

2020-08-15 Thread Teemu Likonen
Previously in message-show mode message's first header line (From header) was always indented, even if user had turned thread indentation off with "<" (notmuch-show-toggle-thread-indentation) command. This change modifies notmuch-show-insert-headerline function so that it doesn't indent the first

[PATCH 1/2] Emacs: Add a new function for balancing bidi control chars

2020-08-15 Thread Teemu Likonen
The following Unicode's bidirectional control chars are modal so that they push a new bidirectional rendering mode to a stack: U+202A LEFT-TO-RIGHT EMBEDDING U+202B RIGHT-TO-LEFT EMBEDDING U+202D LEFT-TO-RIGHT OVERRIDE U+202E RIGHT-TO-LEFT OVERRIDE Every mode must be terminated

[PATCH 0/2] Balance bidi control chars

2020-08-15 Thread Teemu Likonen
These patches continue the ideas written in message: id:87sgcuuzio@iki.fi The first patch adds an new function which can be used to balance Unicode's bidirectional control characters in its string argument. The seconds patch modifies old "notmuch-sanitize" function so that it calls the

[PATCH 2/2] Emacs: Call notmuch-balance-bidi-ctrl-chars in notmuch-sanitize

2020-08-15 Thread Teemu Likonen
--- emacs/notmuch-lib.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el index e6252c6c..e0122f7a 100644 --- a/emacs/notmuch-lib.el +++ b/emacs/notmuch-lib.el @@ -527,7 +527,8 @@ function should be used when sanitizing arbitrary

Re: [PATCH v2 2/3] emacs/tree: enable moving to next thread in search results

2020-08-15 Thread David Bremner
William Casarin writes: > This introduces a new function called > notmuch-tree-next-thread-from-search which is analogous to > notmuch-show-next-thread. It will switch to the next or previous > thread from the parent search results. > This seems to work, and is pretty slick. If there are no

Re: [PATCH 0/2] Balance bidi control chars

2020-08-15 Thread Teemu Likonen
* 2020-08-15 12:30:34+03, Teemu Likonen wrote: > These patches continue the ideas written in message: > > id:87sgcuuzio@iki.fi Here is a nice and relatively short reference for anyone who is interested in the subject: https://www.iamcal.com/understanding-bidirectional-text -- ///

[PATCH] Fix database instructions in test/README: make download-corpus

2020-08-15 Thread Teemu Likonen
--- test/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Currently test/README file instructs user to download database files with command: make download-test-databases That doesn't work for me. I got tests running after executing "make download-corpus" instead. So maybe

Re: [PATCH v3] Emacs: Indent first header line only when indentation is turned on

2020-08-15 Thread David Bremner
Teemu Likonen writes: > Previously in message-show mode message's first header line (From > header) was always indented, even if user had turned thread > indentation off with "<" (notmuch-show-toggle-thread-indentation) > command. > > This change modifies notmuch-show-insert-headerline function

Re: [PATCH 3/3] test: Explicitly state that we want to sign with sender

2020-08-15 Thread David Bremner
Jonas Bernoulli writes: > Since Emacs 27 'mml-secure-epg-sign' errors out if we don't opt-in to > signing as the sender using 'mml-secure-openpgp-sign-with-sender'. > --- > test/test-lib.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/test/test-lib.sh

[PATCH] test: update README to reflect dropping upgrade tests

2020-08-15 Thread David Bremner
These test databases have been unneeded since ee897cab8. --- You're correct that the README needs updating, but download-corpus is for the performance tests. test/README | 8 1 file changed, 8 deletions(-) diff --git a/test/README b/test/README index 3f54af58..11eaf18f 100644 ---

Re: [PATCH v2 1/3] emacs/tree: introduce notmuch-tree-parent-buffer variable

2020-08-15 Thread David Bremner
William Casarin writes: > This variable will be used in a similar fashion to > notmuch-show-parent-buffer. It will be used to navigate between > threads from the parent search buffer. > > Signed-off-by: William Casarin Can someone explain the difference in behaviour before and after this

Re: [PATCH v2 1/3] emacs/tree: introduce notmuch-tree-parent-buffer variable

2020-08-15 Thread David Bremner
David Bremner writes: > William Casarin writes: > >> This variable will be used in a similar fashion to >> notmuch-show-parent-buffer. It will be used to navigate between >> threads from the parent search buffer. >> >> Signed-off-by: William Casarin > > Can someone explain the difference in

Re: [PATCH v2] emacs: Use pop-to-buffer-same-window rather than switch-to-buffer

2020-08-15 Thread David Bremner
Sean Whitton writes: > This means that notmuch commands obey display-buffer-alist so the user > can customize how buffers show up. > > It also permits the use of C-x 4 4, C-x 5 5 and C-x t t, available in > Emacs 28. For example, one can use C-x 4 4 M-x notmuch-jump-search RET > to open a saved