Re: [PATCH] configure: $(CC) -o /dev/null when output not run

On Sat, May 22 2021, David Bremner wrote: > Tomi Ollila writes: > >> When C compilation is used just to see whether compilation >> succeeds, there is no need to write any output file. >> >> Some compilations in configure already did this. >> >> Now also rm -f lines are used more consistently. >>

Re: [PATCH] perf-test: add test for reindexing after removal/renaming msgs

David Bremner writes: > At this point it is a bit tricky to measure the performance increase > from the new message deletion code, since the same commit (9ad19e4) > that improved the performance also seems to have fixed a bug with an > uncaught Xapian exception triggered by this test. series

Re: [PATCH 3/3] test: ruby: simplify basic tests

Felipe Contreras writes: > We don't need to check for the order here, that is done in another test. > > Signed-off-by: Felipe Contreras > --- > test/T395-ruby.sh | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/test/T395-ruby.sh b/test/T395-ruby.sh > index

Re: [PATCH 1/3] ruby: use notmuch_exclude_t enum

Felipe Contreras writes: > It exists since 2013, let's allow it to be used in Ruby. > > Signed-off-by: Felipe Contreras applied to master d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to

[PATCH v2] test: source $NOTMUCH_SRCDIR/test/test-lib-emacs.sh

Sourcing test-lib.sh will cd to TMP_DIRECTORY, so relative path in $0 will not work in previous version . $(dirname "$0")/test-lib-emacs.sh Now individual test scripts -- e.g. ./test/T310-emacs.sh will work. --- s/_BUILDD/_SRCD/ to id:20210522152741.27213-1-tomi.oll...@iki.fi now works with

Re: [PATCH] test: say_color() in one write(2)

On Sat, May 22 2021, David Bremner wrote: > Tomi Ollila writes: > >> say_color() used to call (builtin) printf (and tput(1) to stdout) >> several times, which caused attempts to write messages with color >> to have partial content (e.g. escape sequences) often intermixed >> with other tests when

Re: [PATCH 0/5] doc: man page cleanup

Jani Nikula writes: > I saw [1] and decided to give it some love. :) > > Mostly this is all about adding html cross-references all over the place > while trying to keep the roff man pages roughly the same. Also updating > the man page rst becomes easier by setting a clean example. > series

Re: Fixes for building with -DDEBUG

David Bremner writes: > The first patch is an attempt at fixing the build failure in the ruby > bindings. I'm not sure if this is an acceptable use of "env" or not. I > noticed that all of our shebangs use env, but I guess that is optional > in some sense. > > The remaining patches keep

Re: [PATCH v5] test: replace notmuch_passwd_sanitize() with _libconfig_sanitize()

Tomi Ollila writes: > notmuch_passwd_sanitize() in test-lib.sh is too generic, it cannot > work in many cases... applied to master d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: [PATCH] test: say_color() in one write(2)

Tomi Ollila writes: > say_color() used to call (builtin) printf (and tput(1) to stdout) > several times, which caused attempts to write messages with color > to have partial content (e.g. escape sequences) often intermixed > with other tests when parallel tests were run. applied to master. d

Re: [PATCH 2/3] ruby: add keyword arguments to db.query

Felipe Contreras writes: > That way we don't need pass them to the query object ourselves. LGTM, but when I tried to resolve the conflicts I messed something up and the ruby sort test(s) started failing. Rebase please? d ___ notmuch mailing list --

Re: [PATCH 2/3] ruby: add keyword arguments to db.query

On Sun, May 23, 2021 at 7:29 AM David Bremner wrote: > > Felipe Contreras writes: > > > That way we don't need pass them to the query object ourselves. > > LGTM, but when I tried to resolve the conflicts I messed something up > and the ruby sort test(s) started failing. Rebase please? Not sure

Re: [PATCH v3] test: replace notmuch_passwd_sanitize() with _libconfig_sanitize()

On Fri, May 21, 2021 at 1:22 PM Tomi Ollila wrote: > > On Fri, May 21 2021, Felipe Contreras wrote: > > > On Thu, May 20, 2021 at 2:43 AM Tomi Ollila wrote: > >> > >> On Wed, May 19 2021, Felipe Contreras wrote: > >> > >> > On Wed, May 19, 2021 at 12:34 PM Tomi Ollila wrote: > >> > > >> >>

[PATCH 2/2] lib/message: use passed database for error handling

'message' should always be initialized if we reach here, but in case it is not, we still want to be able to log an error message. --- lib/message.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/message.cc b/lib/message.cc index 7af6ab82..8a67e2a5 100644 ---

[PATCH 1/2] make _alloc_notmuch static

It is not used outside this file, so being extern seems like an oversight --- lib/open.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/open.cc b/lib/open.cc index 1ca69665..bf166e15 100644 --- a/lib/open.cc +++ b/lib/open.cc @@ -242,7 +242,7 @@ _choose_database_path

[PATCH v2 1/2] ruby: add keyword arguments to db.query

That way we don't need pass them to the query object ourselves. Signed-off-by: Felipe Contreras --- bindings/ruby/database.c | 47 +--- bindings/ruby/defs.h | 2 +- bindings/ruby/init.c | 2 +- test/T395-ruby.sh| 18 +++ 4 files

[PATCH v2 2/2] test: ruby: simplify basic tests

We don't need to check for the order here, that is done in another test. Signed-off-by: Felipe Contreras --- test/T395-ruby.sh | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/test/T395-ruby.sh b/test/T395-ruby.sh index e828efed..9298bc9e 100755 ---

[PATCH v2 0/2] ruby: improve db.query

I find it a bit annoying to have to modify the query object to add options when Notmuch::Database.query() can do that just fine. This series also adds a mapping to the notmuch_exclude_t enum in order to be able to specify NOTMUCH_EXCLUDE_ALL and others. Nothing changed from v1 except rebased on

Re: [PATCH 3/3] test: ruby: simplify basic tests

On Sun, May 23, 2021 at 7:32 AM David Bremner wrote: > > Felipe Contreras writes: > > > We don't need to check for the order here, that is done in another test. > > > > Signed-off-by: Felipe Contreras > > --- > > test/T395-ruby.sh | 12 > > 1 file changed, 4 insertions(+), 8