Re: [PATCH 3/7] emacs/tree: command to toggle search sort order in tree mode

2021-06-26 Thread David Bremner
jao writes: > New command notmuch-tree-toggle-order for switching the sort order (by > reissuing the search with a different flag) in a notmuch-tree buffer. > --- > emacs/notmuch-tree.el | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/emacs/notmuch-tree.el

Re: [PATCH 4/7] doc: updates for new --sort and related emacs commands

2021-06-26 Thread David Bremner
jao writes: | > -| =!= || > notmuch-show-toggle-elide-non-matching| > | > -| =#= || > notmuch-show-print-message

Re: [PATCH 7/7] emacs: fix notmuch-tree-toggle-order keybinding

2021-06-26 Thread David Bremner
jao writes: > Really assign the new emacs command notmuch-tree-toggle-order to o, as > previously documented. It seems like this one should be merged with 3/7? d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmu

Re: [PATCH 7/7] emacs: fix notmuch-tree-toggle-order keybinding

2021-06-26 Thread David Bremner
David Bremner writes: > jao writes: > >> Really assign the new emacs command notmuch-tree-toggle-order to o, as >> previously documented. > > It seems like this one should be merged with 3/7? > > d Apologies for the many replies, but can't you remap notmuch-search-toggle-order?

[PATCH 3/3] emacs/tree use notmuch-show-single-message

2021-06-26 Thread David Bremner
This is more efficient than notmuch-show-only-matching-messages, since we do not parse the potentially large thread structure to find a single message. This is only a partial fix for notmuch-tree view, because displaying the thread structure in the tree-mode window still crashes on long threads. I

[PATCH 1/3] test: start test file for emacs unthreaded view.

2021-06-26 Thread David Bremner
Initial focus is on behaviour with large threads. The second test replicates a bug reported by Alan Schmitt in id:87lf7sojbq@m4x.org. --- test/T465-emacs-unthreaded.sh | 38 +++ 1 file changed, 38 insertions(+) create mode 100755 test/T465-emacs-unthreaded.sh

[PATCH 2/3] emacs/show: add parameter notmuch-show-single-message

2021-06-26 Thread David Bremner
This dynamically bound variable can be set when the caller of notmuch-show guarantees that exactly one message will match the query. It avoids transporting and parsing the complete thread structure. --- emacs/notmuch-show.el | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff -

Re: [PATCH 1/2] test-lib-emacs: re-define test_emacs() after initialization

2021-06-26 Thread David Bremner
Tomi Ollila writes: > After test_emacs() has started emacs, it re-defines > itself as just calling the started emacs. > > First call to test_emacs() will execute to the end of it; > next calls will just execute the 2 lines, first clearing OUTPUT, > second and last executing TEST_EMACSCLIENT... >

Re: [PATCH 1/2] test-lib-emacs: re-define test_emacs() after initialization

2021-06-26 Thread David Bremner
Tomi Ollila writes: > After test_emacs() has started emacs, it re-defines > itself as just calling the started emacs. > > First call to test_emacs() will execute to the end of it; > next calls will just execute the 2 lines, first clearing OUTPUT, > second and last executing TEST_EMACSCLIENT... >

Re: [PATCH 3/7] emacs/tree: command to toggle search sort order in tree mode

2021-06-26 Thread Jose Antonio Ortega Ruiz
On Sat, Jun 26 2021, David Bremner wrote: > jao writes: > >> New command notmuch-tree-toggle-order for switching the sort order (by >> reissuing the search with a different flag) in a notmuch-tree buffer. >> --- >> emacs/notmuch-tree.el | 14 +- >> 1 file changed, 13 insertions(+), 1

Re: [PATCH 7/7] emacs: fix notmuch-tree-toggle-order keybinding

2021-06-26 Thread Jose Antonio Ortega Ruiz
On Sat, Jun 26 2021, David Bremner wrote: > David Bremner writes: > >> jao writes: >> >>> Really assign the new emacs command notmuch-tree-toggle-order to o, as >>> previously documented. >> >> It seems like this one should be merged with 3/7? >> >> d > > Apologies for the many replies, but can'

[PATCH] emacs: Prefer email address over User ID when showing valid signature

2021-06-26 Thread David Bremner
From: Daniel Kahn Gillmor Most concrete verification steps are likely only taken on the e-mail address in the first place, and e-mail addresses render more intelligibly than arbitrary User IDs in the first place. Signed-off-by: Daniel Kahn Gillmor Amended-by: db, apply dme restructuring suggest

Re: [PATCH 7/7] emacs: fix notmuch-tree-toggle-order keybinding

2021-06-26 Thread Jose Antonio Ortega Ruiz
On Sat, Jun 26 2021, Jose Antonio Ortega Ruiz wrote: > On Sat, Jun 26 2021, David Bremner wrote: > >> David Bremner writes: >> >>> jao writes: >>> Really assign the new emacs command notmuch-tree-toggle-order to o, as previously documented. >>> >>> It seems like this one should be merg

Re: [PATCH] lib: consider all instances of Delivered-To header

2021-06-26 Thread David Bremner
Hannu Hartikainen writes: > When using notmuch-reply and guessing the From: address from > Delivered-To headers, I had the wrong address chosen today. This was > because the messages from the notmuch list contain these headers in this > order: > > Delivered-To: hannu.hartikai...@gmail.com > ... >

Re: [PATCH 7/7] emacs: fix notmuch-tree-toggle-order keybinding

2021-06-26 Thread David Bremner
Jose Antonio Ortega Ruiz writes: > Ah, i just remembered the reason: notmuch-search-toggle-order is not > bound in notmuch-common-keymap, so, no, i think that it cannot be > remapped here. OIC. OK, so just definine it correctly the first time? d ___ n

[PATCH 1/5] CLI/show: accept --sort

2021-06-26 Thread jao
Add the command-line option --sort to the show command of the CLI notmuch interface, with the same possible values as the same option in notmuch search. --- notmuch-show.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/notmuch-show.c b/notmuch-show.c index bdb87321..947ffa8d 100644 ---

Here's a re-roll, with review comments so far addressed

2021-06-26 Thread jao
[PATCH 1/5] CLI/show: accept --sort [PATCH 2/5] CLI/show: tests for the new --sort option [PATCH 3/5] emacs/hello: honouring :sort-order in threaded queries [PATCH 4/5] emacs/tree: command to toggle search sort order in tree [PATCH 5/5] doc: new notmuch show --sort and related emacs commands __

[PATCH 2/5] CLI/show: tests for the new --sort option

2021-06-26 Thread jao
New unit tests for notmuch show --sort, covering the basic use cases. --- test/T520-show.sh | 17 + 1 file changed, 17 insertions(+) diff --git a/test/T520-show.sh b/test/T520-show.sh index 16222650..6f42ca12 100755 --- a/test/T520-show.sh +++ b/test/T520-show.sh @@ -10,4 +10,21 @

[PATCH 1/5] CLI/show: accept --sort

2021-06-26 Thread jao
Add the command-line option --sort to the show command of the CLI notmuch interface, with the same possible values as the same option in notmuch search. --- notmuch-show.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/notmuch-show.c b/notmuch-show.c index bdb87321..947ffa8d 100644 ---

[PATCH 3/5] emacs/hello: honouring :sort-order in threaded queries

2021-06-26 Thread jao
Now that notmuch show accepts --sort, we can, on the emacs side, use it according to the value of :sort-order in the definition of saved queries. --- emacs/notmuch-hello.el | 4 +++- emacs/notmuch-tree.el | 10 ++ 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/emacs/notmu

[PATCH 4/5] emacs/tree: command to toggle search sort order in tree mode

2021-06-26 Thread jao
New command notmuch-tree-toggle-order for switching the sort order (by reissuing the search with a different flag) in a notmuch-tree buffer. --- emacs/notmuch-tree.el | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el in

[PATCH 5/5] doc: new notmuch show --sort and related emacs commands

2021-06-26 Thread jao
New --sort CLI option documented in notmuch-show's man page, and notmuch-search-toggle-order mentioned in doc/notmuch-emacs.rst and devel/emacs-keybindings.org (in the latter, there's also some whitespace changes in a table introduced by org-mode). --- devel/emacs-keybindings.org | 10 +-

Re: [PATCH 7/7] emacs: fix notmuch-tree-toggle-order keybinding

2021-06-26 Thread Jose Antonio Ortega Ruiz
On Sat, Jun 26 2021, David Bremner wrote: > Jose Antonio Ortega Ruiz writes: > >> Ah, i just remembered the reason: notmuch-search-toggle-order is not >> bound in notmuch-common-keymap, so, no, i think that it cannot be >> remapped here. > > OIC. OK, so just definine it correctly the first time?

Re: [PATCH 2/2] ruby: enable garbage collection using talloc

2021-06-26 Thread Felipe Contreras
On Thu, Jun 10, 2021 at 7:46 PM David Bremner wrote: > > Felipe Contreras writes: > > > We basically steal all the objects from their notmuch parents, therefore > > they are completely under Ruby's gc control. > > > > The order at which these objects are freed does not matter any more, > > becaus

Re: [PATCH 2/2] ruby: enable garbage collection using talloc

2021-06-26 Thread Felipe Contreras
On Fri, Jun 11, 2021 at 3:54 AM David Bremner wrote: > > David Bremner writes: > > > Felipe Contreras writes: > > > >> We basically steal all the objects from their notmuch parents, therefore > >> they are completely under Ruby's gc control. > >> > >> The order at which these objects are freed d

Re: [PATCH 2/2] ruby: enable garbage collection using talloc

2021-06-26 Thread David Bremner
Felipe Contreras writes: >> >> One issue to double check: in a few places we explicitely _don't_ use >> talloc. What happens when those objects are passed to talloc_steal? > > Seems like talloc aborts. Are there any of such objects? > At least anything where notmuch.h says "allocated by malloc a

Re: [PATCH 2/2] ruby: enable garbage collection using talloc

2021-06-26 Thread David Bremner
Felipe Contreras writes: > > I have the test ready, the only question is how many times to run it > in a loop. 100 times takes about 10 minutes with the large corpus > size. > That sounds reasonable for a performance-test (in line with T00-new) d ___

Re: [PATCH 2/2] ruby: enable garbage collection using talloc

2021-06-26 Thread Felipe Contreras
On Sat, Jun 26, 2021 at 2:54 PM David Bremner wrote: > > Felipe Contreras writes: > > >> > >> One issue to double check: in a few places we explicitely _don't_ use > >> talloc. What happens when those objects are passed to talloc_steal? > > > > Seems like talloc aborts. Are there any of such obje

[PATCH] perf-test: add ruby test

2021-06-26 Thread Felipe Contreras
Simply list the message-id of all the messages in a loop 100 times. Suggested-by: David Bremner Signed-off-by: Felipe Contreras --- performance-test/T05-ruby.sh | 24 1 file changed, 24 insertions(+) create mode 100755 performance-test/T05-ruby.sh diff --git a/perform

[PATCH] perf-test: fix for verbose

2021-06-26 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- I don't know how $verbose is supposed to be set, but when I manually did it didn't work. performance-test/perf-test-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/performance-test/perf-test-lib.sh b/performance-test/perf-test-lib.