notmuch release 0.33.2 now available

2021-09-30 Thread David Bremner
Where to obtain notmuch 0.33.2 === https://notmuchmail.org/releases/notmuch-0.33.2.tar.xz Which can be verified with: https://notmuchmail.org/releases/notmuch-0.33.2.tar.xz.sha256.asc -BEGIN PGP SIGNED MESSAGE- Hash: SHA256

[PATCH 1/2] test: known broken tests for escape characters in config files.

2021-09-30 Thread David Bremner
glib generates the following escape characters with their usual meanings: \n, \t, \r, and \\, along with \s for _leading_ spaces. Currently notmuch fails to unescape these on reading the config files. These tests demonstrate this bug; the one new test that passes is because apparently glib only

[PATCH 2/2] lib/config: use g_key_file_get_string to read config values

2021-09-30 Thread David Bremner
Unlike the previous g_key_file_get_value, this version processes escape codes for whitespace and \. The remaining two broken tests from the last commit are because "notmuch config get" treats every value as a list, and thus the previously introduces stripping of leading whitespace applies. ---

[PATCH 1/2] test: known broken tests for leading/trailing ws in config

2021-09-30 Thread David Bremner
These tests duplicate the bug/misfeature reported in id:ca+tk8fzjplaed3vl1f9ebk_bf_rv8pdtlzdupratkclcpja...@mail.gmail.com --- test/T050-new.sh | 13 + test/T070-insert.sh| 13 + test/T590-libconfig.sh | 24 3 files changed, 50

[PATCH 2/2] config: ignore leading/trailing spaces in ';'-delimited lists

2021-09-30 Thread David Bremner
In [1] Ciprian observed that it was easy for users to mistakenly introduce leading and trailing space to new.tags when editing a notmuch config file. This commit strips spaces on either side of the ';' delimiter when splitting. In principle it would be possible to support tags (or other config

Re: Strip spaces in `tags` in `~/.notmuch-config` (and other fields)

2021-09-30 Thread David Bremner
Ciprian Dorin Craciun writes: > > Given that the `~/.notmuch-config` resembles an INI file, and given > how lax the actual syntax is in general, I would suggest the > following: > > * allow white-spaces around `[ section ]`, and `field = value`; This is somewhat out of our control, as we rely on

[PATCH v2] lib/config: use g_key_file_get_string to read config values

2021-09-30 Thread David Bremner
Unlike the previous g_key_file_get_value, this version processes escape codes for whitespace and \. The remaining two broken tests from the last commit are because "notmuch config get" treats every value as a list, and thus the previously introduces stripping of leading whitespace applies. ---