Re: [PATCH] doc: add dep. on stamp file for rebuilding gzipped man pages.

2021-12-25 Thread Tomi Ollila
On Fri, Dec 24 2021, David Bremner wrote: > In [1] Daniel observed that the gzipped man pages were only being > rebuild every second time when building with `make -j4'. This may be > caused by a race condition between sphinx-build rebuilding the roff > files and the recipe to gzip them. This commi

Re: [PATCH] doc: add dep. on stamp file for rebuilding gzipped man pages.

2021-12-25 Thread David Bremner
David Bremner writes: > In [1] Daniel observed that the gzipped man pages were only being > rebuild every second time when building with `make -j4'. This may be > caused by a race condition between sphinx-build rebuilding the roff > files and the recipe to gzip them. This commit sequentializes th

[PATCH 3/6] lib/open: use db struct as talloc ctx for choose_database_path

2021-12-25 Thread David Bremner
The extra talloc struct "local" was left over from before the notmuch struct was allocated earlier. Having the notmuch struct available in this function will allow more flexibility to track the configuration variations (e.g. split vs. non-split). --- lib/open.cc | 27 +-- 1

[PATCH 5/6] lib/config: make sure the config map exists when loading defaults

2021-12-25 Thread David Bremner
We should not rely on one of the other "_notmuch_config_load_*" functions being called before this one. --- lib/config.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/config.cc b/lib/config.cc index 7a2882de..8f6ef110 100644 --- a/lib/config.cc +++ b/lib/config.cc @@ -658,6 +658,9 @@

[PATCH 4/6] lib/open: use notmuch->params to track split status

2021-12-25 Thread David Bremner
Persisting this status will allow us to use the information in other compilation units, in particular when setting configuration defaults. --- lib/database-private.h | 7 ++- lib/open.cc| 19 --- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/lib/

[PATCH 6/6] lib/open: no default mail root in split configurations

2021-12-25 Thread David Bremner
If we know the configuration is split, but there is no mail root defined, this indicates a (lack of) configuration error. Currently this can only arise in XDG configurations. --- bindings/python-cffi/notmuch2/_build.py | 1 + lib/config.cc | 6 +- lib/database.cc

Re: [PATCH] cli: handle bash completion of all shared options

2021-12-25 Thread David Bremner
Tobias Backer Dirks writes: > A slight rework of base bash completion to handle all shared options. > This simplifies the handling of base commands and adds creature comforts > such as directory completion for --config, and removing trailing spaces > from options ending in an `=`. Also fixes a bu

Re: [BUG] emacs: notmuch-mua-attachment-check finds triggering string inside forwarded messages

2021-12-25 Thread David Bremner
Örjan Ekeberg writes: > Hi all, > > I have found what seems to be a bug, or at least a misbehaviour of the > "missing attachment warning" implemented by the otherwise so nice > notmuch-mua-attachment-check. > > It works fine to detect the regexp for attachments in simple messages. > The problem i

Re: Bug: fatal error with notmuch new, second run starts indexing all over again

2021-12-25 Thread David Bremner
David Bremner writes: > Gregor Zattler writes: > >> >> On my way reducing the corpus I had an intermediate corpus of >> ~43000 files on which notmuch new produced a xapian exeption. I >> kept this corpus but did not include the test results in my email >> because the later, smaller corpus seeme

[PATCH 1/2] test/new: add known broken test for missing xapian directory.

2021-12-25 Thread David Bremner
`notmuch new' should go ahead and create the xapian database if it is missing, even in the case where the parent .notmuch (or equivalent) directory exists. --- test/T055-path-config.sh | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/test/T055-path-config.sh b/test/T05

[PATCH 2/2] lib/open: do not consider .notmuch alone as an existing database.

2021-12-25 Thread David Bremner
It makes perfect sense for users to want to pre-create .notmuch, e.g. to install hooks, so we should handle the case of a .notmuch directory without an actual xapian database more gracefully. --- lib/open.cc | 8 ++-- test/T055-path-config.sh | 1 - 2 files changed, 2 insertions(+

[PATCH] emacs: update coolj-line-prefix-regexp to make space optional

2021-12-25 Thread David Bremner
Jani reported that lines prefixed with '>' (as opposed to '> ') are not highlighted properly [1]. David E responded with a updated regex [2]. This change implements David E's suggestion. [1]: id:87a8b5pcky@nikula.org [2]: id:m2pok1e3gv@dme.org --- emacs/coolj.el | 2 +- 1 file changed, 1

Re: [bug] notmuch doesn't commit changes before an open transaction on close

2021-12-25 Thread David Bremner
Steven Allen writes: > Notmuch claims to commit changes made before an open transaction on > close but actually throws them away (according to the documentation). > > According to the notmuch documentation, > >> For writable databases, notmuch_database_close commits all changes >> to disk before