[PATCH 1/6] test: start new corpus of test messages for indexing code

2022-02-05 Thread David Bremner
This particular message is not recognized by notmuch as mail, but is fine according to e.g. mutt. The trigger for this bad behaviour seems to be a second "From " ocurring at the beginning of the line but inside an attachment. --- test/corpora/indexing/mbox-attachment.eml | 83

[PATCH 5/6] lib/message-file: stash pointer to "parent" notmuch database

2022-02-05 Thread David Bremner
Since we know the database anyway when creating the notmuch_message_file struct, keep it to e.g. retrieve configuration information later. --- lib/message-file.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/message-file.c b/lib/message-file.c index 68f646a4..0f356cf1 100644 ---

[PATCH 4/6] test: add known broken test for index.check_mbox=false

2022-02-05 Thread David Bremner
This message should only fail to parse because it looks (rightly or wrongly) like a 2 message mbox. --- test/T050-new.sh | 9 + 1 file changed, 9 insertions(+) diff --git a/test/T050-new.sh b/test/T050-new.sh index 9ef24f18..e779bd2f 100755 --- a/test/T050-new.sh +++ b/test/T050-new.sh

[PATCH 3/6] lib/config: add configuration item for controlling check for mbox

2022-02-05 Thread David Bremner
Currently we always check for multi-message mboxes, but some people would prefer to disable this check. Set up infrastructure to disable check. --- lib/config.cc| 4 lib/notmuch.h| 1 + test/T030-config.sh | 1 + test/T055-path-config.sh | 1 +

[PATCH 6/6] lib/message-file: allow disabling check for mbox files.

2022-02-05 Thread David Bremner
This does not change the default (of enforcing the check) but does allow users to disable the check if they want. --- lib/message-file.c | 9 +++-- test/T050-new.sh | 1 - 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/message-file.c b/lib/message-file.c index

[PATCH 2/6] test: add known broken test for non-email false positive.

2022-02-05 Thread David Bremner
This message should parse fine, but notmuch heuristics are claiming it is not email. It differs from a version that parses fine only in the first line, which triggers the mbox detection code. --- test/T050-new.sh | 8 1 file changed, 8 insertions(+) diff --git a/test/T050-new.sh

allow disabling the check for multi-message mboxes

2022-02-05 Thread David Bremner
Notmuch tries to prevent users from shooting themselves in the foot by indexing mboxes containing multiple messages. On the other hand some MTAs (notably common configurations of postfix) like to deliver mail to file the looks like mboxes. This can occasionaly cause problems where notmuch thinks a

Re: Reusing descriptive sender name when replying

2022-02-05 Thread David Bremner
inasprecali writes: > Could you please point me towards the specific code which > notmuch-reply uses to obtain the address to use in the From: > header? Have a look at the function create_reply_message. As I hinted in my last message, I'm not very enthusiastic about upstreaming more features

Re: Reusing descriptive sender name when replying

2022-02-05 Thread Dan Čermák
inasprecali writes: > Thank you for the reply. > > I don’t think I have explained myself properly. What I would like > to have is to automatically have my descriptive name (the one > before the actual address in angled brackets) be filled in the > From: header when replying. Right now, the

[PATCH] emacs: remove png logo

2022-02-05 Thread David Bremner
Reduce chance of downstream packagers packing the wrong file. --- emacs/notmuch-logo.png | Bin 1671 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 emacs/notmuch-logo.png diff --git a/emacs/notmuch-logo.png b/emacs/notmuch-logo.png deleted file mode 100644 index

[PATCH] NEWS: remaining items for 0.35 release

2022-02-05 Thread David Bremner
These are my best guesses based on git commit messages. --- NEWS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/NEWS b/NEWS index d03d0a33..9545a1bb 100644 --- a/NEWS +++ b/NEWS @@ -47,6 +47,10 @@ signed and/or encrypted messages. Add notmuch-logo.svg and use it in

question about mbox and MIME

2022-02-05 Thread David Bremner
Hi gmime experts; In notmuch we are using g_mime_parser_set_format (parser, GMIME_FORMAT_MBOX) to try to distinguish mboxes containing multiple messages from those containing only a single message [1]. The attached message breaks this, because it has an unescaped "From " inside a (text/plain)