Re: [PATCH] lib: fix uninitialized field in message objects.

2022-05-26 Thread David Bremner
David Bremner writes: > Initially reported by Eliza Vasquez [1] (via valgrind). > > [1]: id:87o7zxj086.fsf@eliza. Applied to release and master. As soon as I did realized that pedantically it should be message->modified = false since it's a bool, not a notmuch_bool_t. It's hard

Re: [PATCH] lib: fix uninitialized field in message objects.

2022-05-26 Thread David Bremner
David Bremner writes: > David Bremner writes: > >> Initially reported by Eliza Vasquez [1] (via valgrind). >> >> [1]: id:87o7zxj086.fsf@eliza. > > Applied to release and master. As soon as I did realized that > pedantically it should be > > message->modified = false > > since it's

[PATCH] test: make T450 independent of application/octet-stream interpretation

2022-05-26 Thread michaeljgruber+grubix+git
From: Michael J Gruber The actual content type of `application/octet-stream` is up to content type detection of the reader, and thus may not be stable across implementations or versions. This showed up when fd46fc19 ("emacs: document/defcustom notmuch-multipart/alternative-discouraged",

Re: [PATCH] test: make T450 independent of application/octet-stream interpretation

2022-05-26 Thread David Bremner
michaeljgruber+grubix+...@gmail.com writes: > > Fix this by giving that message a specicific type of `text/x-diff` in > the test corpus, and adjust all affected test outputs. > LGTM. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe

Re: [PATCH v3] emacs: Make notmuch-show-next-thread return nil on failure

2022-05-26 Thread David Bremner
Leo Okawa Ericson writes: > +test_begin_subtest "notmuch-search-show-thread returns non-nil on success" > +test_emacs_expect_t '(notmuch-search > "id:20091117203301.gv3...@dottiness.seas.harvard.edu") > + (when (notmuch-search-show-thread) > + (error

Re: [PATCH] emacs: notmuch-show-header-line: allow format strings and functions

2022-05-26 Thread David Bremner
jao writes: > If a string value is assigned to notmuch-show-header-line, it's used > as a format string to be passed passed to format-spec with `%s` > substituted by the message's subject. If a function is given, it's > called with the subject as argument, and its return value used as > header