Re: [notmuch] Notmuch's search view sucks

2009-12-04 Thread Aaron Ecay
--- 2009ko Abenudak 4an, Olly Betts-ek idatzi zuen: [...] TextCat is in Perl. I don't know if there's a C or C++ implementation but it isn't a huge piece of code - finding a good technique was the clever part of it. The same algorithm is implemented in C here:

Re: [notmuch] [PATCH] notmuch.el: colorize lines in notmuch-search based on thread tags.

2010-02-07 Thread Aaron Ecay
--- 2010ko Otsailak 7an, Aneesh Kumar K. V-ek idatzi zuen: Doesn't 92c4dcc641e9dfb5f65026ebae5cedc8eb1d9e21 help you achive something similar ? That commit allows colors to be applied to the tag name only, whereas this patch applies the color to the whole line. Which method(s) notmuch should

Build problems on OS X

2010-04-11 Thread Aaron Ecay
In the process of updating to the latest sources, I've discovered that notmuch no longer builds on OS X. As a reply to this email, I'll be sending 4 patches. The first two are bugfixes; the third adds the infrastructure to the Makefiles to build a shared library on OS X, since the Mach-O

[PATCH 1/4] Use C++ compiler to link notmuch binaries

2010-04-11 Thread Aaron Ecay
Since the binaries contain C++ code, it is necessary to use the C++ linker, or errors result on some platforms (OS X). Signed-off-by: Aaron Ecay aarone...@gmail.com --- Makefile.local |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.local b/Makefile.local

[PATCH 2/4] Fix up Makefile for build.

2010-04-11 Thread Aaron Ecay
Must set extra_c(xx)flags before including subdir Makefile.local's, so that there is a blank slate that the subdirs can add on to. Must include subdir Makefile.local's before global one, otherwise the compat sources are not added to the list of those to be compiled. Signed-off-by: Aaron Ecay

[PATCH 4/4] Add CONFIGURE_LDFLAGS to the notmuch-shared buld command line.

2010-04-11 Thread Aaron Ecay
Otherwise, symbol not found errors result on OS X. I am not sure this is the correct solution for the problem, but it gets the build working. Signed-off-by: Aaron Ecay aarone...@gmail.com --- Makefile.local |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.local

Re: Use of strcasestr

2010-04-12 Thread Aaron Ecay
--- 2010ko Apirilak 12an, Tomas Carnecky-ek idatzi zuen: Adding that function to compat/ probably is the way to go, but the whole compat mechanism doesn't work here. It's like if compat/Makefile.local was not included in the top-level makefile, notmuch_compat_srcs is empty there. Any ideas

segfault: g_type_init() missing

2011-07-23 Thread Aaron Ecay
Dear all, I just pulled the last couple weeks' worth of changes and rebuilt notmuch, only to have the new binary give a segfault on notmuch new (running on OS X.6). The error message printed was: (process:21821): GLib-GObject-CRITICAL **: gtype.c:2708: You forgot to call g_type_init() And the

[PATCH] Add missing call to g_type_init()

2011-07-25 Thread Aaron Ecay
Signed-off-by: Aaron Ecay aarone...@gmail.com --- notmuch.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/notmuch.c b/notmuch.c index 3973e35..f9d6629 100644 --- a/notmuch.c +++ b/notmuch.c @@ -579,6 +579,7 @@ main (int argc, char *argv[]) local = talloc_new (NULL

[PATCH] Add missing call to g_type_init()

2011-07-25 Thread Aaron Ecay
The Glib docs state Prior to any use of the type system, g_type_init() has to be called.[1] To not do so can lead to segfaults. The g_type system is currently used by various filters that operate on uuencoded text, message headers, etc. [1]

[PATCH] [emacs] Add an argument to notmuch-mua-mail

2011-12-16 Thread Aaron Ecay
, to future-proof against such changes. This is adapted from the approach taken by message-mail, a similar function built into emacs. This patch was originally submitted by richardmu...@gmail.com on Aug. 1: id:877h6x6oor@veracitynetworks.com Signed-off-by: Aaron Ecay aarone...@gmail.com --- emacs

[PATCH] [emacs] Add an argument to notmuch-mua-mail

2011-12-16 Thread Aaron Ecay
From the emacs changelog: ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and passes it to the mail user agent function. This argument specifies an action for returning to the caller after finishing with the mail. This is currently used by Rmail to delete a mail window.

[PATCH] [emacs] Add an argument to notmuch-mua-mail

2011-12-17 Thread Aaron Ecay
From the emacs changelog: ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and passes it to the mail user agent function. This argument specifies an action for returning to the caller after finishing with the mail. This is currently used by Rmail to delete a mail window.

[PATCH] [emacs] Add an argument to notmuch-mua-mail

2011-12-17 Thread Aaron Ecay
From the emacs changelog: ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and passes it to the mail user agent function. This argument specifies an action for returning to the caller after finishing with the mail. This is currently used by Rmail to delete a mail window.

[PATCH] Give a path name to mktemp in Makefile.local

2011-12-17 Thread Aaron Ecay
On some systems (incl. OS X 10.6), mktemp expects an argument giving it the place to put the new temporary file. --- On my machine without this patch, make prints a message from mktemp about expecting an argument each time it is run. At some point, make got into a situation where it would print

[PATCH] Ignore dynamic libraries on OS X.

2011-12-17 Thread Aaron Ecay
Parallel to ignoring .so for linux. --- .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 9468e30..d64ec9f 100644 --- a/.gitignore +++ b/.gitignore @@ -9,6 +9,7 @@ notmuch.sym notmuch-shared notmuch.1.gz libnotmuch.so*

Re: [PATCH] Give a path name to mktemp in Makefile.local

2011-12-17 Thread Aaron Ecay
of the makefile is called unconditionally, on all systems. So it doesn't matter if one does make debian-snapshot or not, the error is still generated. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo

Re: [PATCH] emacs: Add `notmuch-jump-to-recent-buffer'.

2011-12-20 Thread Aaron Ecay
unrolls it into a native Lisp loop. Thus the performance hit, if any, is negligible.) ... memq is also nice; in case used the list should be done beforehand with (let* ... Given the fact about loop, let* isn’t really applicable. -- Aaron Ecay

Re: [RFC][PATCH] emacs: Provide scaffolding so that the new `shr' HTML renderer can run.

2011-12-20 Thread Aaron Ecay
be loaded to function. Aaron [1] I see that (featurep 'gnus) returns t for me, so that horse is already out of the barn. But it isn’t something we should be seeking to perpetuate. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH] emacs: fix off-by-one bug in notmuch-show-archive

2011-12-22 Thread Aaron Ecay
Text properties change between characters; prev-s-c-property-change returns the position after the change. Thus, it is still inside the invisible region. --- emacs/notmuch-show.el |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-show.el

Re: [RFC][PATCH v2] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-22 Thread Aaron Ecay
David, Would the problem you had with previous-s-c-prop-change be fixed by the patch to the original function I sent in the thread starting at id:m2y5u5cykp@kcals.intra.maillard.im ? -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org

Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-25 Thread Aaron Ecay
) (if ( last-msg-point (window-start)) (goto-char last-msg-point) (goto-char (window-start))) (notmuch-show-message-adjust)) Thanks, -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman

Re: [PATCH] emacs: Don't signal an error when reaching the end of the search results.

2011-12-25 Thread Aaron Ecay
, as this is the common case. Moreover, it's very annoying when `debug-on-error' is t. +1 from me on this change. I had added this to `debug-ignored-errors' long ago, and forgotten how annoying it was. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http

Re: [PATCH v3 1/4] emacs: Let the user choose where to compose new mails

2011-12-25 Thread Aaron Ecay
– this is a useful patch and it should be included once we can be sure it will work correctly. Thanks, -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-28 Thread Aaron Ecay
by messages, and the latter by screenfuls (with the added complication that the screenful movement commands also stop at intervening message boundaries). I’d prefer to maintain that symmetry. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH 1/4] emacs: unify search mechanisms

2011-12-30 Thread Aaron Ecay
use notmuch-hello, but when I do, I press `s' then look to the bottom of the screen and am always confused not to see a minibuffer prompt. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] Update NEWS for change by Aaron Ecay

2011-12-30 Thread Aaron Ecay
--- NEWS | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index eaed960..3688944 100644 --- a/NEWS +++ b/NEWS @@ -20,6 +20,16 @@ Automatic tag query optimization exclude messages whose tags won't change. In the past, we've suggested that people

Re: [notmuch] [PATCH] Calls to notmuch get queued and executed asynchronously.

2011-12-30 Thread Aaron Ecay
-conflict (and squash) the patches from James that might be useful, at least to compare the two approaches. Aaron -cut-here- From f0a0fe04254d9b5e17c873b293c6a5a270cb909a Mon Sep 17 00:00:00 2001 From: Aaron Ecay aarone...@gmail.com Date: Mon, 19 Dec 2011 12:14:31 -0500 Subject: [PATCH] [emacs

Re: [PATCH] Update NEWS for change by Aaron Ecay

2011-12-30 Thread Aaron Ecay
On Fri, 30 Dec 2011 22:54:30 -0400, David Bremner da...@tethera.net wrote: pushed, although I had to mess with it a fair amount. Maybe it was against master, rather than release? It was. I didn’t realize that the patch should be against the release branch; sorry about that... :-| -- Aaron

Re: [PATCH] emacs: call notmuch tag only once when archiving a thread

2012-01-05 Thread Aaron Ecay
thread:000whatever -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: call notmuch tag only once when archiving a thread

2012-01-08 Thread Aaron Ecay
think it would be useful, I can work on a patch to implement this approach. Footnotes: [1] Or having its tags changed generally. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging

2012-01-08 Thread Aaron Ecay
+ (notmuch-search-show-thread))) -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 2/4] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end

2012-01-08 Thread Aaron Ecay
-char (point-max)) (defun notmuch-show-previous-open-message () Show the previous message. -- 1.7.7.3 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch -- Aaron Ecay

Re: [PATCH 1/4] emacs: new customization variable to exclude deleted messages from search

2012-01-08 Thread Aaron Ecay
:” in searches – so this section of the code should look for it too. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 4/4] emacs: Use the new JSON reply format.

2012-01-08 Thread Aaron Ecay
of the above line? If it is to make the compiler aware of the function, you should use ‘declare-function’ instead. Defun will erase the original definition of the w3m-region function. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http

Re: [PATCH 0/4] Quoting HTML-only emails in replies redux

2012-01-08 Thread Aaron Ecay
. This requires the emacs reply functionality to distinguish between html parts that are part of a multipart/alternative and those which are not, which (AFAICT) the current code doesn’t do. I haven’t tested the patch yet, but it looks very promising. Thanks! -- Aaron Ecay

Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging

2012-01-08 Thread Aaron Ecay
On Sun, 08 Jan 2012 18:49:56 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: Thanks so much for the review, Aaron. On Sun, 08 Jan 2012 20:08:59 -0500, Aaron Ecay aarone...@gmail.com wrote: A couple of comments on the arguments: - It would be good to make show-next optional

Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging

2012-01-10 Thread Aaron Ecay
think I’m in the clear to bikeshed about its calling convention. :) It’s your patch, though, so it’s your call if you feel that the optional goes best in a new change. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org

Re: [PATCH 0/4] Quoting HTML-only emails in replies redux

2012-01-15 Thread Aaron Ecay
on this idea, from a different perspective. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] v2 emacs: colorize buttonized 'id:' links depending on the target message's state

2012-01-16 Thread Aaron Ecay
that are not on this listserv :), it would be nice to fix it. Maybe you could change the regex that matches id:’s to require a little more structure – an at-sign, perhaps. Or even requiring more than (say) 5 non-space characters after the message id would cut down sharply on the false positive rate. -- Aaron

Re: [PATCH] emacs: Truncate lines and do not enable visual-line-mode in notmuch-show buffers.

2012-01-16 Thread Aaron Ecay
-mode' were that it wrapped long lines in received messages. With `notmuch-wash-wrap-long-lines' now default behaviour, this is no longer required. +1 -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman

Re: [PATCH 0/4] Quoting HTML-only emails in replies redux

2012-01-16 Thread Aaron Ecay
On Mon, 16 Jan 2012 08:39:30 +, David Edmondson d...@dme.org wrote: On Mon, 16 Jan 2012 02:38:38 -0500, Aaron Ecay aarone...@gmail.com wrote: - Greater flexibility in the construction of address lists. For example, there are some email lists where I want replies to list mail to go only

Re: Infinite loop in emacs interface

2012-01-17 Thread Aaron Ecay
if it seems like this is the case.) If you do: M-x set-variable RET debug-on-quit RET t RET then trigger the loop and press C-g, you should get a buffer showing a backtrace of the lisp stack. What does that say? Thanks, -- Aaron Ecay ___ notmuch mailing

Re: show-mode message/thread archiving improvements

2012-01-17 Thread Aaron Ecay
+1 on this series from me. (Minor comments on a couple of the patches to follow.) -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions

2012-01-17 Thread Aaron Ecay
equally to the old version) -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: have notmuch-search-archive-thread use -next-thread function

2012-01-17 Thread Aaron Ecay
+1 -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/1] Make buttons for attachments allow viewing as well as saving

2012-01-17 Thread Aaron Ecay
) are needed for the function, there is no need to thread them through as arguments of notmuch-with-temp-part-buffer. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal into two generally useful functions

2012-01-17 Thread Aaron Ecay
a comment instead of a documentation string, | but that is no longer the case--documentation strings now take up | very little space in a running Emacs. ` -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman

Re: [PATCH] emacs: Improved printing support.

2012-01-18 Thread Aaron Ecay
- the comments were very useful in improving things - thanks! You’re welcome! The patch LGTM. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

2012-01-18 Thread Aaron Ecay
runtime use.) Aaron Footnotes: [1] He specifically objects to the way that the cl package uses keyword arguments, calling it un-Elisp-like. He has resisted past efforts to merge cl functions into Elisp core, although they are slowly diffusing across the barrier. -- Aaron Ecay

[PATCH] emacs: Quote MML tags in replies

2012-01-19 Thread Aaron Ecay
Emacs message-mode uses certain text strings to indicate how to attach files to outgoing mail. If these are present in the text of an email, and a user is tricked into replying to the message, the user’s files could be exposed. --- To demonstrate this, open a reply to this message then remove

Re: [PATCH v3 5/5] emacs: Use message-citation-line-format in reply

2012-01-19 Thread Aaron Ecay
show up in id:1326998589-37187-1-git-send-email-aarone...@gmail.com . -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Aaron Ecay
messages hidden - instead of the 6 (or however many) individual messages. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: Quote MML tags in replies

2012-01-19 Thread Aaron Ecay
. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: Quote MML tags in replies

2012-01-19 Thread Aaron Ecay
, but that doesn’t mean that we should break that usage. (defun notmuch-mua-forward-message () (message-forward) Speaking of future-proofing, it would be good to have a test. It would. ;) I’ll work on one. -- Aaron Ecay ___ notmuch mailing

Re: [PATCH] emacs: Quote MML tags in replies

2012-01-19 Thread Aaron Ecay
. If that case is a security hole, then the hole is in the user’s brain and not in notmuch. :) -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v3 5/5] emacs: Use message-citation-line-format in reply

2012-01-19 Thread Aaron Ecay
On Thu, 19 Jan 2012 21:46:46 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: On Thu, Jan 19, 2012 at 11:45, Aaron Ecay e...@sas.upenn.edu wrote: Shouldn’t this just use message-insert-formatted-citation-line? Yes, good idea. I just tried this and it almost works. The only issue

Re: tach.el: an attachment interface for message mode.

2012-01-20 Thread Aaron Ecay
files to email very often, but I’ll let you know how it works out. Thanks a lot, -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/2] emacs: Add tests for quoting of MML tags in replies

2012-01-28 Thread Aaron Ecay
The test is broken at this time; the next commit will introduce a fix. --- Thanks for the reminder, Austin. Things got hectic, and it took a little bludgeoning to get the test suite to behave. I *think* I got it, although I am by no means confident. Specifically, I am seeing some unrelated(?)

[PATCH 2/2] emacs: Quote MML tags in replies

2012-01-28 Thread Aaron Ecay
Emacs message-mode uses certain text strings to indicate how to attach files to outgoing mail. If these are present in the text of an email, and a user is tricked into replying to the message, the user’s files could be exposed. --- NEWS | 18 ++

Re: bug related to ical

2012-09-26 Thread Aaron Ecay
(find-file-noselect file)) (setq result (buffer-substring (point-min) (point-max))) (set-buffer-modified-p nil) (kill-buffer (current-buffer)) - cut here - -- Aaron Ecay ___ notmuch mailing list notmuch

Re: [PATCH v2] emacs: display tags in notmuch-show with links

2012-11-18 Thread Aaron Ecay
(that is, there are 0 instances of #'(lambda ...) in the code base). IMO that’s correct: the unnecessary #' is just line-noise-ish. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[RFC] [PATCH] lib/database.cc: change how the parent of a message is calculated

2013-02-25 Thread Aaron Ecay
Presently, the code which finds the parent of a message as it is being added to the database assumes that the first Message-ID-like substring of the In-Reply-To header is the parent Message ID. Some mail clients, however, put stuff other than the Message-ID of the parent in the In-Reply-To

[PATCH 1/2] test: add tests for the handling of References and In-Reply-To headers

2013-03-05 Thread Aaron Ecay
-replies new file mode 100755 index 000..a902691 --- /dev/null +++ b/test/thread-replies @@ -0,0 +1,144 @@ +#!/usr/bin/env bash +# +# Copyright (c) 2013 Aaron Ecay +# + +test_description='test of proper handling of in-reply-to and references headers + +This test makes sure that the thread structure

[PATCH 2/2] lib/database.cc: change how the parent of a message is calculated

2013-03-05 Thread Aaron Ecay
Presently, the code which finds the parent of a message as it is being added to the database assumes that the first Message-ID-like substring of the In-Reply-To header is the parent Message ID. Some mail clients, however, put stuff other than the Message-ID of the parent in the In-Reply-To

Re: [PATCH v2] emacs: Add support for saved search accelerators

2014-05-10 Thread Aaron Ecay
for a different purpose. -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: elisp completion patches v6

2015-10-25 Thread Aaron Ecay
. Maybe you could use a combination of ‘make-obsolete’ (for byte-compiler warnings) and ‘display-warning’ (for runtime)? I understand the desire to phase the function out eventually rather than have an eternal stub, but intentionally breaking .emacs is a really drastic ste

Re: elisp + company completion patches, v7

2015-10-25 Thread Aaron Ecay
prevent peoples emacs startup > from failing. Guess who wrote a reply before catching up on all the list mail. :P -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v1] emacs: Allow part preferences to depend on message content.

2016-01-19 Thread Aaron Ecay
+ (subject (plist-get headers :Subject)) > + (to (plist-get headers :To)) > + (cc (plist-get headers :Cc))) > + > +(eval directive))) This code is not compatible with lexical binding in emacs >= 24, which I assume notmuch will eventually want to adopt. What’s so bad about

[notmuch] Notmuch's search view sucks

2009-12-04 Thread Aaron Ecay
--- 2009ko Abenudak 4an, Olly Betts-ek idatzi zuen: [...] > TextCat is in Perl. I don't know if there's a C or C++ implementation but > it isn't a huge piece of code - finding a good technique was the clever part > of it. The same algorithm is implemented in C here:

[notmuch] [PATCH] Further improvements to tag-based coloring in search.

2010-02-06 Thread Aaron Ecay
Makes the following improvements: - fix up doc strings - suppress the creation of unnecessary let-bindings - create overlays lazily (to avoid creating many overlays for threads that do not get colored) Signed-off-by: Aaron Ecay --- notmuch.el | 29 ++--- 1 files

[notmuch] [PATCH] notmuch.el: colorize lines in notmuch-search based on thread tags.

2010-02-07 Thread Aaron Ecay
--- 2010ko Otsailak 7an, "Aneesh Kumar K. V"-ek idatzi zuen: > Doesn't 92c4dcc641e9dfb5f65026ebae5cedc8eb1d9e21 help you achive something > similar ? That commit allows colors to be applied to the tag name only, whereas this patch applies the color to the whole line. Which method(s) notmuch

[PATCH] Further improvements to tag-based coloring in search.

2010-04-11 Thread Aaron Ecay
Makes the following improvements: - fix up doc strings - suppress the creation of unnecessary let-bindings - create overlays lazily (to avoid creating many overlays for threads that do not get colored) Signed-off-by: Aaron Ecay --- emacs/notmuch.el | 21 ++--- 1 files

Build problems on OS X

2010-04-11 Thread Aaron Ecay
In the process of updating to the latest sources, I've discovered that notmuch no longer builds on OS X. As a reply to this email, I'll be sending 4 patches. The first two are bugfixes; the third adds the infrastructure to the Makefiles to build a shared library on OS X, since the Mach-O

[PATCH 1/4] Use C++ compiler to link notmuch binaries

2010-04-11 Thread Aaron Ecay
Since the binaries contain C++ code, it is necessary to use the C++ linker, or errors result on some platforms (OS X). Signed-off-by: Aaron Ecay --- Makefile.local |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.local b/Makefile.local index 71525e2..9e753cd

[PATCH 2/4] Fix up Makefile for build.

2010-04-11 Thread Aaron Ecay
Must set extra_c(xx)flags before including subdir Makefile.local's, so that there is a blank slate that the subdirs can add on to. Must include subdir Makefile.local's before global one, otherwise the compat sources are not added to the list of those to be compiled. Signed-off-by: Aaron Ecay

[PATCH 3/4] Add infrastructure for building shared library on OS X.

2010-04-11 Thread Aaron Ecay
This patch adds a configure check for OS X (actually Darwin), and sets up the Makefiles to build a proper shared library on that platform. Signed-off-by: Aaron Ecay --- Makefile |2 +- Makefile.local |2 +- configure | 13 + lib/Makefile.local | 16

[PATCH 4/4] Add CONFIGURE_LDFLAGS to the notmuch-shared buld command line.

2010-04-11 Thread Aaron Ecay
Otherwise, symbol not found errors result on OS X. I am not sure this is the correct solution for the problem, but it gets the build working. Signed-off-by: Aaron Ecay --- Makefile.local |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.local b/Makefile.local

Use of strcasestr

2010-04-12 Thread Aaron Ecay
--- 2010ko Apirilak 12an, Tomas Carnecky-ek idatzi zuen: > > Adding that function to compat/ probably is the way to go, but the whole > compat mechanism doesn't work here. It's like if compat/Makefile.local was > not included in the top-level makefile, notmuch_compat_srcs is empty > there. Any

segfault: g_type_init() missing

2011-07-24 Thread Aaron Ecay
Dear all, I just pulled the last couple weeks' worth of changes and rebuilt notmuch, only to have the new binary give a segfault on "notmuch new" (running on OS X.6). The error message printed was: (process:21821): GLib-GObject-CRITICAL **: gtype.c:2708: You forgot to call g_type_init() And

[PATCH] Add missing call to g_type_init()

2011-07-25 Thread Aaron Ecay
Signed-off-by: Aaron Ecay --- notmuch.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/notmuch.c b/notmuch.c index 3973e35..f9d6629 100644 --- a/notmuch.c +++ b/notmuch.c @@ -579,6 +579,7 @@ main (int argc, char *argv[]) local = talloc_new (NULL

[PATCH] Add missing call to g_type_init()

2011-07-25 Thread Aaron Ecay
The Glib docs state "Prior to any use of the type system, g_type_init() has to be called".[1] To not do so can lead to segfaults. The g_type system is currently used by various "filters" that operate on uuencoded text, message headers, etc. [1]

bug related to ical

2012-09-26 Thread Aaron Ecay
t-buffer (find-file-noselect file)) (setq result (buffer-substring (point-min) (point-max))) (set-buffer-modified-p nil) (kill-buffer (current-buffer)) - cut here ----- -- Aaron Ecay

[PATCH v2] emacs: display tags in notmuch-show with links

2012-11-18 Thread Aaron Ecay
ve #' on lambdas (that is, there are 0 instances of #'(lambda ...) in the code base). IMO that?s correct: the unnecessary #' is just line-noise-ish. -- Aaron Ecay

[RFC] [PATCH] lib/database.cc: change how the parent of a message is calculated

2013-02-25 Thread Aaron Ecay
Presently, the code which finds the parent of a message as it is being added to the database assumes that the first Message-ID-like substring of the In-Reply-To header is the parent Message ID. Some mail clients, however, put stuff other than the Message-ID of the parent in the In-Reply-To

[RFC] [PATCH] lib/database.cc: change how the parent of a message is calculated

2013-02-26 Thread Aaron Ecay
essage would be best. Here?s a message from the notmuch list that has passed through gmane, which inserts References but not In-Reply-To headers: id:877h0sa207.fsf at fester.com . Here?s a link to one with a borked In-Reply-To header: http://article.gmane.org/gmane.emacs.orgmode/66616/raw -- Aaron Ecay

[RFC] [PATCH] lib/database.cc: change how the parent of a message is calculated

2013-03-03 Thread Aaron Ecay
- next part ------ -- Aaron Ecay

[PATCH 1/2] test: add tests for the handling of References and In-Reply-To headers

2013-03-05 Thread Aaron Ecay
-replies new file mode 100755 index 000..a902691 --- /dev/null +++ b/test/thread-replies @@ -0,0 +1,144 @@ +#!/usr/bin/env bash +# +# Copyright (c) 2013 Aaron Ecay +# + +test_description='test of proper handling of in-reply-to and references headers + +This test makes sure that the thread structure

[PATCH 2/2] lib/database.cc: change how the parent of a message is calculated

2013-03-05 Thread Aaron Ecay
Presently, the code which finds the parent of a message as it is being added to the database assumes that the first Message-ID-like substring of the In-Reply-To header is the parent Message ID. Some mail clients, however, put stuff other than the Message-ID of the parent in the In-Reply-To

[PATCH] test/README: mention the test_expect_equal_json and *sanitize* functions

2013-03-05 Thread Aaron Ecay
also fix one typo --- test/README | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/test/README b/test/README index 81c232d..d12cff2 100644 --- a/test/README +++ b/test/README @@ -178,11 +178,18 @@ library for your script to use. test_expect_equal_file

[PATCH] [emacs] Add an argument to notmuch-mua-mail

2011-12-16 Thread Aaron Ecay
ure-proof against such changes. This is adapted from the approach taken by message-mail, a similar function built into emacs. This patch was originally submitted by richardmurri at gmail.com on Aug. 1: id:"877h6x6oor.fsf at veracitynetworks.com" Signed-off-by: Aaron Ecay --- emacs/n

[PATCH] [emacs] Add an argument to notmuch-mua-mail

2011-12-16 Thread Aaron Ecay
>From the emacs changelog: ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and passes it to the mail user agent function. This argument specifies an action for returning to the caller after finishing with the mail. This is currently used by Rmail to delete a mail

[PATCH] [emacs] Add an argument to notmuch-mua-mail

2011-12-17 Thread Aaron Ecay
>From the emacs changelog: ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and passes it to the mail user agent function. This argument specifies an action for returning to the caller after finishing with the mail. This is currently used by Rmail to delete a mail

[PATCH] [emacs] Add an argument to notmuch-mua-mail

2011-12-17 Thread Aaron Ecay
>From the emacs changelog: ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and passes it to the mail user agent function. This argument specifies an action for returning to the caller after finishing with the mail. This is currently used by Rmail to delete a mail

[PATCH] Give a path name to mktemp in Makefile.local

2011-12-17 Thread Aaron Ecay
On some systems (incl. OS X 10.6), mktemp expects an argument giving it the place to put the new temporary file. --- On my machine without this patch, make prints a message from mktemp about expecting an argument each time it is run. At some point, make got into a situation where it would print

[PATCH] Ignore dynamic libraries on OS X.

2011-12-17 Thread Aaron Ecay
Parallel to ignoring .so for linux. --- .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 9468e30..d64ec9f 100644 --- a/.gitignore +++ b/.gitignore @@ -9,6 +9,7 @@ notmuch.sym notmuch-shared notmuch.1.gz libnotmuch.so*

[PATCH] [emacs] Don't quote lambda forms

2011-12-17 Thread Aaron Ecay
This generates byte-compiler warnings on (at least) current trunk versions of Emacs. The quote is not necessary; lambda forms are self-quoting. --- emacs/notmuch-crypto.el |4 +- emacs/notmuch-hello.el | 64 +- emacs/notmuch-maildir-fcc.el

[PATCH] Give a path name to mktemp in Makefile.local

2011-12-17 Thread Aaron Ecay
is called unconditionally, on all systems. So it doesn't matter if one does "make debian-snapshot" or not, the error is still generated. -- Aaron Ecay

[RFC][PATCH] emacs: Provide scaffolding so that the new `shr' HTML renderer can run.

2011-12-19 Thread Aaron Ecay
ader problem. Aaron * I think that inhibit -> nil, block -> ".*" should achieve this, but I?m not sure/haven?t tested ** For example, Gmail makes you click a link at the top of an email before it will load any network images contained therein. -- Aaron Ecay

[PATCH] emacs: Add `notmuch-jump-to-recent-buffer'.

2011-12-19 Thread Aaron Ecay
(Please excuse the lack of inline comments on the patch ? the original patch email is so old that I had deleted it from my archives!) progn...set-buffer should be with-current-buffer or...eq...eq... would be cleaner as (memq major-mode '(foo bar baz)) Otherwise, LGTM -- Aaron Ecay

  1   2   >