RE: [PATCH 1/4] VIM: implemented message folding in thread view

2015-02-02 Thread Bartosz Telenczuk
Hi Franz, We already had folding via syntax in Ians fork. It turned out to be not that great. https://github.com/imain/notmuch-vim/issues/3 Ah all right, I just thought syntax fold would be more elegant. In short: Those syntax fold marks are for one specific notmuch-show-buffer. If you

RE: [PATCH v3] VIM: Improve moving between messages in a thread

2015-02-02 Thread Bartosz Telenczuk
I think the API should be clear and easy to understand, because people will probably bind them to custom shortcuts. You should not have to think about what that weird extra parameter (-1, false, ...) means and go read the docs. I agree. One might replace the parameter with a string like prev

RE: [PATCH] VIM: Automatically refresh folder screen

2015-02-02 Thread Bartosz Telenczuk
Franz Fellner wrote: Hi Bartosz, Great to see one more person interested in notmuch-vim! Hopefully this will make review a little bit easier. Bartosz Telenczuk wrote: Ian Main wrote: This patch makes the folder screen refresh each time you 'enter' it. This way when you read

Re: [PATCH] VIM: Make an option to save sent mail locally

2015-02-02 Thread Bartosz Telenczuk
I would appreciate an option to configure the sent box per provider. I implemented this feature in this patch: id:1420891384-992-4-git-send-email-telenc...@unic.cnrs-gif.fr Generally it might work. But there are other features that may rely on per-account-settings (drafts, outbox,

RE: [PATCH] VIM: Automatically refresh folder screen

2015-01-19 Thread Bartosz Telenczuk
Ian Main wrote: This patch makes the folder screen refresh each time you 'enter' it. This way when you read a folder and mark items as read the changes are reflected immediately when you return to the folder view. That is a good starting point, but why don't we refresh every time we mark an

Re: [DRAFT] New features in Vim interface

2015-01-19 Thread Bartosz Telenczuk
Yeah that would be ideal. Franz and I have been working in a github repo here: https://github.com/imain/notmuch-vim Indeed, that is a lot of commits. It is almost an independent fork. Even more so we should work hard to include the changes back into upstream for the benefit of the

Re: [DRAFT] New features in Vim interface

2015-01-12 Thread Bartosz Telenczuk
Dear David, (CC Ian and Franz) Before Christmas we had a flurry of patches from Ian Main (in copy). I think there is some functionality overlap with what you proposed. As far as I know Ian has mainly been working on his private fork of the vim client, but maybe if the two (or three,

Re: [PATCH] VIM: Make an option to save sent mail locally

2015-01-13 Thread Bartosz Telenczuk
Great work! Yeah, I can add it so the folder can be changed. I figured this was just the start of things. Really we should be able to fcc it to our upstream provider sent mailbox too. I would appreciate an option to configure the sent box per provider. I implemented this feature in this

RE: [PATCH v3] VIM: Improve moving between messages in a thread

2015-01-13 Thread Bartosz Telenczuk
Hi Ian, The patch looks good. I tested it on my system and it works fine. I just have one suggestion regarding coding style. +function! s:show_prev_msg() function! s:show_next_msg() Since these functions are almost the same, you could avoid code repetition by replacing them by a function

[DRAFT] New features in Vim interface

2015-01-11 Thread Bartosz Telenczuk
Dear David, (CC Ian and Franz) > Before Christmas we had a flurry of patches from Ian Main (in copy). I > think there is some functionality overlap with what you proposed. As far > as I know Ian has mainly been working on his private fork of the vim > client, but maybe if the two (or three,

[PATCH v3] VIM: Improve moving between messages in a thread

2015-01-13 Thread Bartosz Telenczuk
Hi Ian, The patch looks good. I tested it on my system and it works fine. I just have one suggestion regarding coding style. > +function! s:show_prev_msg() > function! s:show_next_msg() Since these functions are almost the same, you could avoid code repetition by replacing them by a

[PATCH] VIM: Make an option to save sent mail locally

2015-01-13 Thread Bartosz Telenczuk
Great work! > Yeah, I can add it so the folder can be changed. I figured this was just the > start of things. Really we should be able to fcc it to our upstream provider > sent mailbox too. I would appreciate an option to configure the "sent" box per provider. I implemented this feature in

[PATCH] VIM: Automatically refresh folder screen

2015-01-19 Thread Bartosz Telenczuk
Ian Main wrote: > This patch makes the folder screen refresh each time you 'enter' it. > This way when you read a folder and mark items as read the changes are > reflected immediately when you return to the folder view. That is a good starting point, but why don't we refresh every time we mark an

[DRAFT] New features in Vim interface

2015-01-20 Thread Bartosz Telenczuk
> Yeah that would be ideal. Franz and I have been working in a github repo > here: > > https://github.com/imain/notmuch-vim Indeed, that is a lot of commits. It is almost an independent fork. Even more so we should work hard to include the changes back into upstream for "the benefit of the

[PATCH 1/4] VIM: implemented message folding in thread view

2015-02-03 Thread Bartosz Telenczuk
Hi Franz, > We already had folding via syntax in Ians fork. It turned out to be not that > great. > https://github.com/imain/notmuch-vim/issues/3 Ah all right, I just thought syntax fold would be more elegant. > In short: > Those syntax fold marks are for one specific notmuch-show-buffer. If

[PATCH] VIM: Make an option to save sent mail locally

2015-02-03 Thread Bartosz Telenczuk
> > I would appreciate an option to configure the "sent" box per provider. I > > implemented this feature in this patch: > > > > id:1420891384-992-4-git-send-email-telenczuk at unic.cnrs-gif.fr > > Generally it might work. But there are other features that may rely on > per-account-settings

[PATCH v3] VIM: Improve moving between messages in a thread

2015-02-03 Thread Bartosz Telenczuk
> I think the API should be clear and easy to understand, because people will > probably bind them to custom shortcuts. You should not have to think about > what that weird extra parameter (-1, false, ...) means and go read the docs. I agree. One might replace the parameter with a string like

[PATCH] VIM: Automatically refresh folder screen

2015-02-03 Thread Bartosz Telenczuk
Franz Fellner wrote: > Hi Bartosz, > > Great to see one more person interested in notmuch-vim! Hopefully this will > make review a little bit easier. > > Bartosz Telenczuk wrote: > > Ian Main wrote: > > > This patch makes the folder screen refresh each time yo