The linking to talloc is hard-coded in the testing Makefile. This patch
causes the linking to talloc to be done according to how TALLOC_LDFLAGS
was configured.
Signed-off-by: Charles Celerier ccel...@cs.stanford.edu
---
test/Makefile.local | 2 +-
1 file changed, 1 insertion(+), 1 deletion
-by: Charles Celerier ccel...@cs.stanford.edu
---
test/T360-symbol-hiding.sh | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/test/T360-symbol-hiding.sh b/test/T360-symbol-hiding.sh
index 636ec91..97c734a 100755
--- a/test/T360-symbol-hiding.sh
+++ b/test/T360-symbol-hiding.sh
output format.
Signed-off-by: Charles Celerier ccel...@cs.stanford.edu
---
test/T360-symbol-hiding.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/test/T360-symbol-hiding.sh b/test/T360-symbol-hiding.sh
index 97c734a..c5bbf27 100755
--- a/test/T360-symbol-hiding.sh
+++ b
. The same was done for false.
Signed-off-by: Charles Celerier ccel...@cs.stanford.edu
---
configure | 6 ++
test/Makefile.local | 8
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/configure b/configure
index 9bde2eb..0bce0a3 100755
--- a/configure
+++ b/configure
On the Mac OS X platform, the rename() function symbol is not found
until the debugger begins running. The reason for this is unknown, but
allowing breakpoint symbols to be resolved later both solves the problem
and does not change the test.
Signed-off-by: Charles Celerier ccel...@cs.stanford.edu
Tomi Ollila tomi.oll...@iki.fi writes:
On Tue, May 06 2014, Charles Celerier ccel...@cs.stanford.edu wrote:
The Mac OS X platform uses *.dylib object files instead of *.so object
files for linking. Adding the path to notmuch.dylib to the end of
DYLD_FALLBACK_LIBRARY_PATH has a similar effect
functions appropriately where they are used.
Signed-off-by: Charles Celerier ccel...@cs.stanford.edu
---
lib/database.cc | 24
lib/message-file.c| 8
lib/message.cc| 8
lib/notmuch-private.h | 14 +++---
lib/sha1.c| 4
output format.
Signed-off-by: Charles Celerier ccel...@cs.stanford.edu
---
test/T360-symbol-hiding.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/T360-symbol-hiding.sh b/test/T360-symbol-hiding.sh
index 9239fc1..21cabca 100755
--- a/test/T360-symbol-hiding.sh
+++ b/test
-by: Charles Celerier ccel...@cs.stanford.edu
---
test/T360-symbol-hiding.sh | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/test/T360-symbol-hiding.sh b/test/T360-symbol-hiding.sh
index 636ec91..9239fc1 100755
--- a/test/T360-symbol-hiding.sh
+++ b/test/T360-symbol-hiding.sh
David Bremner da...@tethera.net writes:
Charles Celerier ccel...@cs.stanford.edu writes:
The path to true may not be the same on all platforms (e.g. on Mac OS X
it is /usr/bin/true), so the hard-coded path of /bin/true is not
portable. This is resolved by adding a step to the configure
David Bremner da...@tethera.net writes:
Charles Celerier ccel...@cs.stanford.edu writes:
test_begin_subtest 'comparing existing to exported symbols'
-objdump -t $TEST_DIRECTORY/../lib/*.o | awk '$4 == .text $6 ~
^notmuch {print $6}' | sort | uniq ACTUAL
+nm -g $TEST_DIRECTORY/../lib/*.o
David Bremner da...@tethera.net writes:
Charles Celerier ccel...@cs.stanford.edu writes:
Here is some of output of the matches made on the output of nm:
$ nm -g test/../lib/*.o | sed -n '/.*\s\+T\s\+_\(notmuch_.*\)/p'
28c0 T _notmuch_database_add_message
David Bremner da...@tethera.net writes:
Charles Celerier ccel...@cs.stanford.edu writes:
At this point, I'm not sure how to create a better version of this
patch. Are we renaming functions in notmuch-private.h? Should we stick
with objdump or switch to using nm?
I'd go with renaming any
of following the symbolic link.
Signed-off-by: Charles Celerier ccel...@cs.stanford.edu
---
test/Makefile.local| 8
test/T010-help-test.sh | 2 +-
test/T020-compact.sh | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/test/Makefile.local b/test/Makefile.local
index
David Bremner da...@tethera.net writes:
David Bremner da...@tethera.net writes:
Originally I thought this was uneccesarily intrusive, but on a second
look I see that there is only one symbol changed that doesn't start with
_notmuch, so I guess for consistency it's fine.
Actually, they all
notmuch_sha1_of_string
notmuch_message_file_close
notmuch_message_file_get_header
notmuch_message_file_open
notmuch_message_get_author
notmuch_message_set_author
Signed-off-by: Charles Celerier ccel...@cs.stanford.edu
---
lib/database.cc | 24
lib/message-file.c
As noted in the In-Reply-To header, this patch replaces
id:1399402716-13714-1-git-send-email-ccel...@cs.stanford.edu.
pgpOnVsuIV3Xa.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
The notmuch-search-terms man page states that tag:tag is equivalent
to is:tag. Completion for is:tag style searches is now supported
in the Emacs interface.
Signed-off-by: Charles Celerier ccel...@cs.stanford.edu
---
emacs/notmuch.el | 8 +---
1 file changed, 5 insertions(+), 3 deletions
The notmuch-search-terms man page states that tag:tag is equivalent
to is:tag. Completion for is:tag style searches is now supported
in the Emacs interface.
Signed-off-by: Charles Celerier ccel...@cs.stanford.edu
---
emacs/notmuch.el | 11 +++
1 file changed, 7 insertions(+), 4 deletions
Just updated the patch to use lexical-let as suggested. I'm not too
familiar with emacs-lisp, so please tell me if you had something else in
mind.
charles
David Bremner da...@tethera.net writes:
David Edmondson d...@dme.org writes:
On Sat, Nov 29 2014, Charles Celerier wrote:
Should use
am afraid something funny is happening here that is
beyond my understanding.
charles
David Bremner da...@tethera.net writes:
Charles Celerier ccel...@cs.stanford.edu writes:
Can the variables in the varlist depend on the definition of variables
that precede them in the list? I believe I tried
Hello,
I've been having trouble getting the folder: search-term to work
correctly. I can successfully do a query of the count for INBOX, but
nothing else. Here are some examples from running notmuch on the command
line.
$ pwd
/Users/cceleri/Maildir
$ ls
Archive INBOX
Doh! I just realized that everything in my Junk folder is tagged junk
which is one of my configured search.exclude_tags. Nevermind, all is
well.
Thank you to all the kind folks who continue to maintain notmuch!
-charles
Charles Celerier ccel...@cs.stanford.edu writes:
Hello,
I've been
David Bremner writes:
> David Bremner writes:
>
>> Originally I thought this was uneccesarily intrusive, but on a second
>> look I see that there is only one symbol changed that doesn't start with
>> _notmuch, so I guess for consistency it's fine.
Actually, they all start with _notmuch. The
notmuch_sha1_of_string
notmuch_message_file_close
notmuch_message_file_get_header
notmuch_message_file_open
notmuch_message_get_author
notmuch_message_set_author
Signed-off-by: Charles Celerier
---
lib/database.cc | 24
lib/message-file.c| 8
lib
As noted in the In-Reply-To header, this patch replaces
id:1399402716-13714-1-git-send-email-cceleri at cs.stanford.edu.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 494 bytes
Desc: not available
URL:
The notmuch-search-terms man page states that "tag:" is equivalent
to "is:". Completion for "is:" style searches is now supported
in the Emacs interface.
Signed-off-by: Charles Celerier
---
emacs/notmuch.el | 8 +---
1 file changed, 5 insertions(+), 3 de
The notmuch-search-terms man page states that "tag:" is equivalent
to "is:". Completion for "is:" style searches is now supported
in the Emacs interface.
Signed-off-by: Charles Celerier
---
emacs/notmuch.el | 11 +++
1 file changed, 7 insertions(+), 4 de
Just updated the patch to use lexical-let as suggested. I'm not too
familiar with emacs-lisp, so please tell me if you had something else in
mind.
charles
David Bremner writes:
> David Edmondson writes:
>
>> On Sat, Nov 29 2014, Charles Celerier wrote:
>
>>
>>
Can the variables in the varlist depend on the definition of variables
that precede them in the list? I believe I tried your suggestion, but
quickly gave up as Emacs gave me an error claiming that all-tags was
void.
charles
David Edmondson writes:
> On Sat, Nov 29 2014, Charles Celerier wr
am afraid something funny is happening here that is
beyond my understanding.
charles
David Bremner writes:
> Charles Celerier writes:
>
>> Can the variables in the varlist depend on the definition of variables
>> that precede them in the list? I believe I tried your suggesti
foolish mistakes in my attempt to submit changes.
Charles Celerier (5):
test/Makefile.local: Added configured TALLOC_LDFLAGS.
configure, test: Added variables for paths to true and false.
atomicity.gdb: Allow breakpoint symbols to be resolved later.
T360-symbol-hiding: Added code to support
The linking to talloc is hard-coded in the testing Makefile. This patch
causes the linking to talloc to be done according to how TALLOC_LDFLAGS
was configured.
Signed-off-by: Charles Celerier
---
test/Makefile.local | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test
. The same was done for false.
Signed-off-by: Charles Celerier
---
configure | 6 ++
test/Makefile.local | 8
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/configure b/configure
index 9bde2eb..0bce0a3 100755
--- a/configure
+++ b/configure
@@ -50,6 +50,8
output format.
Signed-off-by: Charles Celerier
---
test/T360-symbol-hiding.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/test/T360-symbol-hiding.sh b/test/T360-symbol-hiding.sh
index 97c734a..c5bbf27 100755
--- a/test/T360-symbol-hiding.sh
+++ b/test/T360-symbol-hiding.sh
Tomi Ollila writes:
> On Tue, May 06 2014, Charles Celerier wrote:
>
>> The Mac OS X platform uses *.dylib object files instead of *.so object
>> files for linking. Adding the path to notmuch.dylib to the end of
>> DYLD_FALLBACK_LIBRARY_PATH has a similar e
functions appropriately where they are used.
Signed-off-by: Charles Celerier
---
lib/database.cc | 24
lib/message-file.c| 8
lib/message.cc| 8
lib/notmuch-private.h | 14 +++---
lib/sha1.c| 4 ++--
lib/thread.cc
-by: Charles Celerier
---
test/T360-symbol-hiding.sh | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/test/T360-symbol-hiding.sh b/test/T360-symbol-hiding.sh
index 636ec91..9239fc1 100755
--- a/test/T360-symbol-hiding.sh
+++ b/test/T360-symbol-hiding.sh
@@ -12,7 +12,14
output format.
Signed-off-by: Charles Celerier
---
test/T360-symbol-hiding.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/T360-symbol-hiding.sh b/test/T360-symbol-hiding.sh
index 9239fc1..21cabca 100755
--- a/test/T360-symbol-hiding.sh
+++ b/test/T360-symbol-hiding.sh
David Bremner writes:
> Charles Celerier writes:
>
>> The path to true may not be the same on all platforms (e.g. on Mac OS X
>> it is /usr/bin/true), so the hard-coded path of /bin/true is not
>> portable. This is resolved by adding a step to the configure script to
&g
David Bremner writes:
> Charles Celerier writes:
>> test_begin_subtest 'comparing existing to exported symbols'
>> -objdump -t $TEST_DIRECTORY/../lib/*.o | awk '$4 == ".text" && $6 ~
>> "^notmuch" {print $6}' | sort | uniq > ACTUAL
>>
David Bremner writes:
> Charles Celerier writes:
>
>> At this point, I'm not sure how to create a better version of this
>> patch. Are we renaming functions in notmuch-private.h? Should we stick
>> with objdump or switch to using nm?
>
> I'd go with ren
of following the symbolic link.
Signed-off-by: Charles Celerier
---
test/Makefile.local| 8
test/T010-help-test.sh | 2 +-
test/T020-compact.sh | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/test/Makefile.local b/test/Makefile.local
index d622eaf..8fd333c 100644
43 matches
Mail list logo
