Re: [notmuch] [PATCH 2/2] * avoid gcc 4.4.1 compiler warning due to ignored 'fflush' return value

Hi Carl, Carl == Carl Worth cwo...@cworth.org writes: Carl [1 text/plain (quoted-printable)] Carl On Mon, 23 Nov 2009 08:21:50 +0200, Dirk-Jan C. Binnema djcb.b...@gmail.com wrote: -#define prompt(format, ...) \ -do

[notmuch] Subject: [PATCH] update the check whether a dir entry should be ignored.

Hi all, This is a draft patch which hopefully improves the check whether a dir entry should be ignored for that. It adds one feature: if you put a file '.noindex' in a dir, the whole dir will be ignored for indexing. I find this very useful for removing e.g. folders with spam messages from the

Re: [notmuch] indexing mail?

*/ if (entry-d_type == DT_UNKNOWN) _set_dtype (dirname, entry); Note, that is untested as of yet. Best wishes, Dirk. -- Dirk-Jan C. Binnema Helsinki, Finland e:d...@djcbsoftware.nl w:www.djcbsoftware.nl pgp: D09C E664 897D 7D39 5047 A178 E96A C7A1 017D

Re: [notmuch] indexing mail?

Hi Olly, Olly == Olly Betts o...@survex.com writes: Olly On 2010-01-15, Dirk-Jan C Binnema wrote: Olly == Olly Betts o...@survex.com writes: Olly Not a full patch, but I already posted what this code should look like Olly to handle both systems without d_type, and those which

Re: Re: thread ordering based on references and/or in-reply-to

/ (starting point is mu_threader_calculate). I didn't implement subject matching yet, but it does build the hierarchy as per JWZ and References:. Best wishes, Dirk. -- Dirk-Jan C. Binnema Helsinki, Finland e:d...@djcbsoftware.nl w:www.djcbsoftware.nl pgp: D09C E664 897D

Re: ignore folders patch?

://notmuchmail.org/pipermail/notmuch/2010/001103.html which support ignoring directories by dropping a '.noindex' file in them. I've been happily using that with the mu program for years. Best wishes, Dirk. -- Dirk-Jan C. Binnema Helsinki, Finland e:d...@djcbsoftware.nl

[notmuch] interesting project!

. [1] http://www.djcbsoftware.nl/code/mu/ [2] http://djcbflux.blogspot.com/2008/10/seek-destroy.html -- Dirk-Jan C. Binnema Helsinki, Finland e:djcb at djcbsoftware.nl w:www.djcbsoftware.nl pgp: D09C E664 897D 7D39 5047 A178 E96A C7A1 017D DA3C

[notmuch] interesting project!

tly (of course, it depend on it anyway through GMime); is this because of OOM-handling? It'd be nice if GLib could be used, it would make some things quite a bit easier. Best wishes, Dirk. -- Dirk-Jan C. Binnema Helsinki, Finland e:djcb at djcbsoftware.nl w:www.djcbsoftware.nl pgp: D09C E664 897D 7D39 5047 A178 E96A C7A1 017D DA3C

[notmuch] [PATCH] notmuch: Add Maildir directory name as tag name for messages

could Carl> replace the original tag, it's probably still beneficial to have it Carl> there when starting out. So, an alternative would be something like: notmuch search path:inbox But this requires notmuch to be able to update things when paths cha

[notmuch] [PATCH] notmuch: Add Maildir directory name as tag name for messages

-- is that deliberate? Also, a minor addition may to also allow for '!' instead of ':' as a separator, as that's the semi-official way to use Maildirs on (V)FAT filesystems (which don't allow for colons in filenames). Best wishes, Dirk. -- Dirk-Jan C. Binnema Helsinki, Finland e:

[notmuch] [PATCH] fix compiler warnings

(hopefully this is the correct way to send patches...) With these minor changes, notmuch compiles warning-free with gcc 4.4.1 --- notmuch-new.c |4 +++- notmuch-setup.c | 13 +++-- notmuch-tag.c |4 +++- 3 files changed, 13 insertions(+), 8 deletions(-) diff --git

[notmuch] [PATCH] notmuch: Add Maildir directory name as tag name for messages

Hi Michiel, >>>>> "MB" == Michiel Buddingh' writes: MB> Dirk-Jan C. Binnema wrote: Michiel> + Michiel> +static void Michiel> +derive_tags_from_maildir_flags (notmuch_message_t Michiel> *message, const char * Michiel> path)

[notmuch] [PATCH 1/2] * avoid gcc 4.4.1 compiler warnings due to ignored write return values

From: Dirk-Jan C. Binnema <djcb.b...@gmail.com> Date: Mon, 23 Nov 2009 08:03:35 +0200 --- notmuch-new.c |4 +++- notmuch-tag.c |4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/notmuch-new.c b/notmuch-new.c index a2b30bd..3d04efa 100644 --- a/notmuch-new.c

[notmuch] [PATCH 2/2] * avoid gcc 4.4.1 compiler warning due to ignored 'fflush' return value

--- notmuch-setup.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/notmuch-setup.c b/notmuch-setup.c index d06fbf8..c50f812 100644 --- a/notmuch-setup.c +++ b/notmuch-setup.c @@ -100,12 +100,13 @@ notmuch_setup_command (unused (void *ctx), unsigned int

[notmuch] interesting project!

Hi Carl, >>>>> "Carl" == Carl Worth writes: Carl> On Sun, 22 Nov 2009 14:23:10 +0200, Dirk-Jan C. Binnema Carl> wrote: >> A small question: it seems that notmuch is avoiding the use of GLib directly >> (of course, it depend o

[notmuch] interesting project!

role pretty well for me, and I don't really pay for the parts that I don't use. But tastes differ, no problem ;-) Carl> Thanks for understanding. :-) Carl> And I enjoy the conversation, Same here :) Best wishes, Dirk. -- Dirk-Jan C. Binnema Helsinki, Finland e:djcb at djcbsoftware.nl w:www.djcbsoftware.nl pgp: D09C E664 897D 7D39 5047 A178 E96A C7A1 017D DA3C

[notmuch] [PATCH] notmuch-count: make sure all created items are freed, even in error paths

Another minor patch, fixing a couple of resource leaks in error paths. --- notmuch-count.c | 52 1 files changed, 36 insertions(+), 16 deletions(-) diff --git a/notmuch-count.c b/notmuch-count.c index 77aa433..b5808f5 100644 ---

[notmuch] [PATCH 2/2] * avoid gcc 4.4.1 compiler warning due to ignored 'fflush' return value

Hi Carl, >>>>> "Carl" == Carl Worth writes: Carl> [1 ] Carl> On Mon, 23 Nov 2009 08:21:50 +0200, Dirk-Jan C. Binnema wrote: >> -#define prompt(format, ...) \ >> -do {

[notmuch] [PATCH 2/2] * free the response data from 'prompt'

Free the results of the prompt; this patch does the minimal job for that. It may be nice to refactor the function a bit. Signed-off-by: Dirk-Jan C. Binnema --- notmuch-setup.c | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/notmuch-setup.c b/notmuch

[notmuch] [PATCH 1/2] * notmuch-config: fix small leak from 'g_key_file_to_data'

Signed-off-by: Dirk-Jan C. Binnema --- notmuch-config.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/notmuch-config.c b/notmuch-config.c index fc65d6b..95430db 100644 --- a/notmuch-config.c +++ b/notmuch-config.c @@ -317,9 +317,11 @@ notmuch_config_save

[notmuch] Subject: [PATCH] update the check whether a dir entry should be ignored.

Hi all, This is a draft patch which hopefully improves the check whether a dir entry should be ignored for that. It adds one feature: if you put a file '.noindex' in a dir, the whole dir will be ignored for indexing. I find this very useful for removing e.g. folders with spam messages from the

[notmuch] Subject: [PATCH] update the check whether a dir entry should be ignored.

Hi David, > "DM" == David Maus writes: >> There is one maybe controversial change, namely that it ignores all >> dot-dirs; this works fine for .notmuch and .nnmaildir (gnus), but maybe >> there is some valid use case for having mail in dot-dirs. Maybe one of >> the

[notmuch] [PATCH] * notmuch-new.c: refactor and improve dirs-to-ignore a bit

if (strcmp (entry->d_name, ".") == 0 || - strcmp (entry->d_name, "..") == 0 || - strcmp (entry->d_name, ".notmuch") == 0) - { + if (ignore_dir_entry (path, entry)) continue; - } - + if (asprintf (, &quo

[notmuch] indexing mail?

statbuf.st_mode)) entry->d_type = DT_LNK; return TRUE; } and then in some other places: /* handle FSs that don't support entry->d_type */ if (entry->d_type == DT_UNKNOWN) _set_dtype (dirname, entry); Note, that is untested as of yet. Best wishes, Dirk. -- Dirk-Jan C. Binnema Helsinki, Finland e:djcb at djcbsoftware.nl w:www.djcbsoftware.nl pgp: D09C E664 897D 7D39 5047 A178 E96A C7A1 017D DA3C

[notmuch] indexing mail?

Hi Olly, >>>>> "Olly" == Olly Betts writes: Olly> On 2010-01-15, Dirk-Jan C Binnema wrote: >>>>>>> "Olly" == Olly Betts writes: Olly> Not a full patch, but I already posted what this code should look like Olly&

[notmuch] indexing mail?

Hi Olly, >>>>> "OB" == Olly Betts writes: OB> On 2010-01-15, Dirk-Jan C Binnema wrote: Olly> Other than Linux, the d_type field is available mainly only on BSD Olly> systems. >> >> Yes, my patch could me gener

thread ordering based on references and/or in-reply-to

and mu-container.[ch] in http://gitorious.org/mu/mu/blobs/master/src/ (starting point is mu_threader_calculate). I didn't implement subject matching yet, but it does build the hierarchy as per JWZ and "References:". Best wishes, Dirk. -- Dirk-Jan C. Binnema Hel

ignore folders patch?

I don't think my patch made it either: http://notmuchmail.org/pipermail/notmuch/2010/001103.html which support ignoring directories by dropping a '.noindex' file in them. I've been happily using that with the "mu" program for years. Best wishes, Dirk. -- Dirk-Jan C.