[notmuch] [PATCH] d_type fix

2010-01-21 Thread Geo Carncross
A review of notmuch-new.c shows three uses of -d_type: Near line 153, in _entries_resemble_maildir() we can simply allow for DT_UNKNOWN. This would fail if people have MH-style folders which have three folders called new cur and tmp, but that seems unlikely, in which case the tmp folder would

[notmuch] [PATCH] GCC3.5 fix

2010-01-21 Thread Geo Carncross
I have reason to need GCC 3.5 which doesn't process the unused(x) macro correctly. This is probably a bug in 3.5, nevertheless the patch is simple and corrects the build. GCC 3.5 also does not understand -Wextra but Makefile is bound to change less frequently, so I did not include a patch for

[notmuch] [PATCH] d_type fix

2010-01-21 Thread Geo Carncross
A review of notmuch-new.c shows three uses of ->d_type: Near line 153, in _entries_resemble_maildir() we can simply allow for DT_UNKNOWN. This would fail if people have MH-style folders which have three folders called "new" "cur" and "tmp", but that seems unlikely, in which case the "tmp" folder

[notmuch] [PATCH] GCC3.5 fix

2010-01-21 Thread Geo Carncross
I have reason to need GCC 3.5 which doesn't process the unused(x) macro correctly. This is probably a bug in 3.5, nevertheless the patch is simple and corrects the build. GCC 3.5 also does not understand -Wextra but Makefile is bound to change less frequently, so I did not include a patch for