Re: [notmuch] [PATCH 2/9] Adjust autoload comments

2009-12-03 Thread Jameson Graef Rollins
On Thu, Dec 03, 2009 at 05:04:52PM -0800, Carl Worth wrote: The notmuch-folder command is definitely a nice primary interface to notmuch for some people. I'm seriously considering making it the view that one gets with M-x notmuch (after the notmuch-folder view gets a little sprucing up). I

[notmuch] emacs UI customization

2009-12-04 Thread Jameson Graef Rollins
Hey, Carl et. al. The recent improvements to the notmuch emacs mode look great. I have a couple of suggestions/questions about the UI that I wanted to put to the group. Here are some things that I would really like to see: * in thread view, show read messages as initially collapsed * show

Re: [notmuch] [PATCH 1/3] fix configure script to handle --prefix= and properly create Makefile.config

2009-12-04 Thread Jameson Graef Rollins
On Fri, Dec 04, 2009 at 04:12:47PM -0800, Carl Worth wrote: Handling --prefix will be a nice addition to our configure script. So, thanks! Yeah, it's definitely needed for the Debian packaging as well. Your commit message has that flag word of also in it, and as it turns out, the removal of

Re: [notmuch] [PATCH 3/3] fix Makefile.local to install bash completion definitions as not executable

2009-12-04 Thread Jameson Graef Rollins
On Fri, Dec 04, 2009 at 04:16:20PM -0800, Carl Worth wrote: On Sat, 28 Nov 2009 18:57:37 -0500, Jameson Graef Rollins jroll...@finestructure.net wrote: - install contrib/notmuch-completion.bash \ + install -m0644 contrib/notmuch-completion.bash \ $(DESTDIR

Re: [notmuch] keeping a copy of sent mail locally

2009-12-20 Thread Jameson Graef Rollins
On Sun, Dec 20, 2009 at 07:22:55PM +0100, Marten Veldthuis wrote: There's a message-send-hook, which we should probably use. Something like: (add-hook 'message-send-hook 'notmuch-always-bcc-sender) (defun notmuch-always-bcc-sender () (message-add-header (concat Bcc:

Re: [notmuch] update on delete/rename support

2009-12-27 Thread Jameson Graef Rollins
On Sat, Dec 26, 2009 at 10:06:24AM -0800, Carl Worth wrote: Yes. I've got a series of about 20 commits reworking the internals a bit, and then one patch past that that I still need to break down into several clean commits. Carl, that's really great to hear. Thanks so much for the response.

[notmuch] modifying emacs keymap

2009-12-28 Thread Jameson Graef Rollins
Hey, folks. This is the first in what is surely to be a long line of requests for help customizing the notmuch emacs UI. In this episode, I'm trying to add a function to the default keymap in notmuch-search-mode. Here's what I tried to do: (add-hook 'notmuch-search-mode (define-key

Re: [notmuch] modifying emacs keymap

2009-12-28 Thread Jameson Graef Rollins
On Mon, Dec 28, 2009 at 11:27:30PM +0100, Tassilo Horn wrote: (add-hook 'notmuch-search-mode (define-key notmuch-search-mode-map A 'notmuch-show-mark-read-then-archive-thread) ) `notmuch-search-mode' is no hook, and even if it was, you couldn't add what you like, because that's no

Re: [notmuch] [PATCHv2] notmuch.el: colorize lines in notmuch-search based on thread tags.

2010-02-05 Thread Jameson Graef Rollins
I realize I should have mentioned that this patch is meant to supercede the previous patch. There are just a couple of minor improvements, including turning on highlighting for deleted threads by default. jamie. pgpXjXWTROZ0t.pgp Description: PGP signature

[PATCH] use custom-face-edit value-type in notmuch-search-line-faces

2011-03-26 Thread Jameson Graef Rollins
This enables the proper face customization UI for notmuch-search-line-faces. --- emacs/notmuch.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 92a86cf..a23d0c2 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -612,7

Re: Sorting and attachments

2011-03-26 Thread Jameson Graef Rollins
On Sat, 26 Mar 2011 21:53:49 -0700, mu...@nawaz.org wrote: 1. Can notmuch return results sorted by size? As far as I know, there is currently no way to do that (but see below). 2. Can I tell notmuch to limit the items it returns (e.g. show me first ten messages matching ... ) Are you looking

crypto branch rebased

2011-03-27 Thread Jameson Graef Rollins
I've rebased my crypto branch [0] against cworth's master at 74bc93f0. jamie. [0] git://finestructure.net/notmuch pgpMuzlPJMH09.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH] use custom-face-edit value-type in notmuch-search-line-faces

2011-03-28 Thread Jameson Graef Rollins
On Sun, 27 Mar 2011 22:57:46 -0400, Austin Clements amdra...@mit.edu wrote: My concern is that it's unclear if the custom-face-edit widget is considered a public interface, or if it's internal to customize and thus could change at any time. These things are always a bit murky in Emacs.

Re: Not build threads option?

2011-04-04 Thread Jameson Graef Rollins
On Fri, 01 Apr 2011 20:42:23 -0700, mu...@nawaz.org wrote: Is there a way in the notmuch emacs client not to build the threads for each query? It can be a bit time consuming. Sometimes (often, actually), I just want to read all mails from someone, and am not interested in the whole threads.

Re: Strange match to my query

2011-04-19 Thread Jameson Graef Rollins
On Thu, 14 Apr 2011 09:32:30 +0200, Florian Friesdorf f...@chaoflow.net wrote: On Tue, 01 Mar 2011 15:15:22 -0800, Jameson Rollins jroll...@finestructure.net wrote: A simple rebuild when you go to bed can look like: I think you're missing an important step: notmuch dump dump.txt

tracking non-mail files [was: Re: (auto-)tagging sent messages]

2011-04-25 Thread Jameson Graef Rollins
On Mon, 25 Apr 2011 14:41:28 -0700, Carl Worth cwo...@cworth.org wrote: Though, even if that were the only problem, we could just teach notmuch to remember that particular files were detected as not-email to fix the performance problem without requiring any user configuration. This is actually

Re: new crypto branch providing full PGP/MIME support

2011-04-25 Thread Jameson Graef Rollins
Quick! While cworth is working I want to push this back to the top of the queue! crypto branch is still ready for merge! git://finestructure.net/notmuch Thanks! jamie. pgpU4YPWyQSEZ.pgp Description: PGP signature ___ notmuch mailing list

Re: doc: notmuch help search-terms, boolean operators

2011-04-26 Thread Jameson Graef Rollins
On Tue, 26 Apr 2011 16:01:17 -0700, Carl Worth cwo...@cworth.org wrote: Complete list of boolean operators in order of precedence: - NOT - AND - XOR - OR Is this correct? If yes, I would extend the manpage accordingly. Currently, notmuch doesn't implement this behavior but relies

Re: [PATCH] create and set temporary home directory

2011-05-06 Thread Jameson Graef Rollins
On Fri, 06 May 2011 11:09:19 +0200, Florian Friesdorf f...@chaoflow.net wrote: any chance of getting this patch into 0.6? Hi, Florian. Yes, I have included this patch in the release-candidate/0.6 branch. jamie. pgpkckcJzTQkq.pgp Description: PGP signature

release-candidate/0.6

2011-05-06 Thread Jameson Graef Rollins
Hi, folks. As some of you already know, I am trying to put together a release candidate for a 0.6 release that we can present to cworth for approval. This branch can be found in my public notmuch repository in the release-candidate/0.6 branch: git remote add jrollins

vim support improvements for 0.6

2011-05-06 Thread Jameson Graef Rollins
Hi, Filipe. I notice that you have been submitting a lot of patches for vim support. As you may have seen, I'm trying to put together a release candidate for notmuch 0.6. Since I know nothing about vim, would you be willing to prepare a patch set that includes all of the patches to vim support

Re: [PATCH] implement search --format=sanitized_text + emacs UI to use it

2011-05-06 Thread Jameson Graef Rollins
On Fri, 6 May 2011 19:55:26 -0400, Austin Clements amdra...@mit.edu wrote: Perhaps text summary output should *always* do this. The text summary format is meant half for user consumption and half for emacs consumption and allowing newlines that don't indicate the end of a summary line seems

Re: [PATCH] Sanitize Subject: and Author: fields to not contain control characters in notmuch-search

2011-05-08 Thread Jameson Graef Rollins
Hey, Florian. I applied this patch to release-candidate/0.6, manually adding in the formatting fixes in the same patch. I also applied the test patch, modified to use the add_message test suite function, which makes the patch a bit simpler. Thanks for the fixes. jamie. pgpSo56tz6dHL.pgp

Re: release-candidate/0.6

2011-05-08 Thread Jameson Graef Rollins
On Fri, 06 May 2011 19:56:30 -0400, James Vasile ja...@hackervisions.org wrote: I sent two patches to the list on March 16. They were a bug fix to allow notmuch to correctly handle some poorly formatted email. Nobody ever replied, but I'd like to see the bug fixed nonetheless, as it results

Re: release-candidate/0.6

2011-05-08 Thread Jameson Graef Rollins
Hi, folks. I've pushed some more patches to the release-candidate/0.6 branch [0] (which should now be at commit id 89ca01b6104dd732903104e50777a7b4a211e1f4): * support for decryption of parts with notmuch show --format=part * emacs support for retrieving parts (like attachments) from encrypted

Re: release-candidate/0.6

2011-05-08 Thread Jameson Graef Rollins
On Sun, 08 May 2011 21:24:52 -0400, Daniel Kahn Gillmor d...@fifthhorseman.net wrote: One new feature that you didn't mention is that --decrypt is passed through to notmuch reply based on the state of the current buffer. That is: it used to be that you had to remember whether you'd viewed a

Re: storing From and Subject in xapian

2011-05-08 Thread Jameson Graef Rollins
On Wed, 4 May 2011 21:48:39 -0400, Austin Clements amdra...@mit.edu wrote: This is awesome. What was your machine configuration? Does anyone else have an opinions about this patch? It seems reasonable to me (other than a couple errant comments that were left in and should be removed). It

Re: [PATCH] Fix old style notmuch-fcc-dirs configuration check.

2011-05-09 Thread Jameson Graef Rollins
On Mon, 9 May 2011 20:04:54 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: In notmuch 0.5 notmuch-fcc-dirs style changed. The previous code did not correctly identify an old configuration and, as a consequence, broke new configurations. The fix was extracted from a bigger patch

Re: [PATCH] Use message-field-value instead of message-fetch-field in FCC header setup.

2011-05-09 Thread Jameson Graef Rollins
On Mon, 9 May 2011 16:06:20 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: For message-fetch-field the buffer is expected to be narrowed to just the header of the message. That is not the case when notmuch-fcc-header-setup is run, hence a wrong header value may be returned. E.g.

Re: [PATCH] lib/message-file: plug three memleaks.

2011-05-09 Thread Jameson Graef Rollins
Hey, Anton. Thanks for identifying and fixing these. I've pushed this to the r-c/0.6 branch. jamie. pgpAdvniISBRY.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: release-candidate/0.6

2011-05-09 Thread Jameson Graef Rollins
Hi, folks. I have pushed a couple of more patches to release-candidate/0.6 [0]: * Dmitry's fix for emacs fcc * Anton Khirnov's memleak fixes I think that everything else can wait for later releases. ***I hereby declare that release-candidate/0.6 is ready for release.*** I think the only

Re: release-candidate/0.6

2011-05-10 Thread Jameson Graef Rollins
On Mon, 09 May 2011 10:20:18 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: ***I hereby declare that release-candidate/0.6 is ready for release.*** After all of that pomp, I take it all back! Fully fearful of further delaying release of 0.6, I decided I wanted to slip

Re: [PATCH] test: use `princ' instead of `message' calls in emacs tests

2011-05-10 Thread Jameson Graef Rollins
On Tue, 10 May 2011 10:25:08 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: The patch replaces all (message (buffer-string)) calls in emacs tests with (princ (buffer-string)). This avoids accidentally interpreting '%' as format specifiers and makes code simpler because we do not

Re: vim support improvements for 0.6

2011-05-10 Thread Jameson Graef Rollins
On Tue, 10 May 2011 01:30:11 +0300, Felipe Contreras felipe.contre...@gmail.com wrote: All right. Hopefully nobody will request further changes to these patches: git://github.com/felipec/notmuch.git [fc-vim-next] It's not rebased on top of your branch, but there are no merge conflicts.

Re: [PATCH] avoid segfault when calling sanitize_string() on NULL

2011-05-10 Thread Jameson Graef Rollins
Yikes! Thanks for finding this, dkg. I just pushed this to r-c/0.6. It looks like we need to expand the tests to test this corner case. jamie. pgpdZpqR2ALSs.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org

Re: release-candidate/0.6

2011-05-10 Thread Jameson Graef Rollins
Arg. One last bit of churn. dkg found a bug in the new sanitize_string function that was causing segfaults on messages with empty headers. This is obviously an imprtant thing to fix. After chatting with some folks on #notmuch, we decided that the debian build dependency on libgmime 2.4.24 is a

Re: address completion when composing

2011-05-11 Thread Jameson Graef Rollins
On Wed, 11 May 2011 14:31:36 +0200, Florian Friesdorf f...@chaoflow.net wrote: In addition, about a year ago, Sebastian indicated, that notmuch itself could offer returning email addresses [3]. Are there arguments against or just nobody found the time to do it? As with pretty much everything

Re: [PATCH] Fix search output sanitization test.

2011-05-11 Thread Jameson Graef Rollins
On Wed, 11 May 2011 13:48:29 -0400, Austin Clements amdra...@mit.edu wrote: Previously, the test assumed the generated message would be assigned a specific thread ID; now it doesn't. Also, spelling fix. Thanks, Austin. I applied this to the r-c/0.6 branch. jamie. pgppeiTHnwvjB.pgp

Re: address completion when composing

2011-05-12 Thread Jameson Graef Rollins
On Thu, 12 May 2011 02:04:41 +0200, Florian Friesdorf f...@chaoflow.net wrote: 1. store to/cc/bcc in xapian Hey, Florian. I think all of these fields are actually already stored in the database. 2. provide a mechanism to query those fields from the cmdline I think this is the idea. You

Re: [PATCH] test: search-by-folder single-word search terms should be updated correctly when directories are renamed.

2011-05-12 Thread Jameson Graef Rollins
On Thu, 12 May 2011 15:22:25 +0200, Pieter Praet pie...@praet.org wrote: I've pushed a cleaner version of this patch to my github repo, for inclusion in release-candidate/0.6. Hey, Pieter. I realize we've been passing around git urls a lot recently, particularly in regards to the

Re: release-candidate/0.6

2011-05-13 Thread Jameson Graef Rollins
On Thu, 12 May 2011 15:36:43 -0700, Carl Worth cwo...@cworth.org wrote: Does anyone want to attempt to fix up this first patch? (It doesn't necessarily have to be David). Hi, Carl. I went through dme's multipart patch series and cleaned things up. I split up that first commit into a couple of

Re: MIME restructuring [was: Re: release-candidate/0.6]

2011-05-16 Thread Jameson Graef Rollins
On Mon, 16 May 2011 14:20:07 -0700, Carl Worth cwo...@cworth.org wrote: I'll have to learn better how to control the emacs mail composer in order to understand how to get signatures to cover attachments if I want to do that kind of thing. See mml-secure-message-sign-pgpmime to sign an entire

New crypto patch series

2011-05-25 Thread Jameson Graef Rollins
Hi, folks. This is a series of patches that constitute a complete rework of notmuch crypto support (signature verification and decryption of PGP/MIME messages, with emacs ui support), including some relevant preparatory patches, on top of the notmuch/master branch at

[PATCH 03/11] Use empty strings instead of NULL in format_reply structure.

2011-05-25 Thread Jameson Graef Rollins
This keeps things consistent with notmuch-show, and prevents having to check for the existence of the field pointer for simple string output formats. --- notmuch-reply.c | 12 ++-- show-message.c |2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/notmuch-reply.c

[PATCH 05/11] test: new test-lib function to test for equality between files

2011-05-25 Thread Jameson Graef Rollins
We need to be able to test for the presence of a newline at the end of output. There's no good way to capture trailing newlines in bash, so redirecting output to a file is the next best thing. This new function should be used when testing for output that is expected to have trailing newlines.

[PATCH 01/11] Simplify reply_part function to eliminate redundant code paths.

2011-05-25 Thread Jameson Graef Rollins
This is the same logic but with less code. --- notmuch-reply.c | 41 ++--- 1 files changed, 14 insertions(+), 27 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index ab15650..5d72b1f 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -88,31

[PATCH 09/11] Add decryption of PGP/MIME-encrypted parts with --decrypt.

2011-05-25 Thread Jameson Graef Rollins
This adds support for decrypting PGP/MIME-encrypted parts to notmuch-show and notmuch-reply. The --decrypt option implies --verify. Once decryption (and possibly signature verification) is done, a new part_encstatus formatter is emitted, the part_sigstatus formatter is emitted, and the entire

[PATCH 02/11] Integrate reply_part_content function into reply_part function.

2011-05-25 Thread Jameson Graef Rollins
After the last patch to eliminate some redundant code paths in reply_part, the reply_part_content function was only being called once. Disolving the function and integrating its contents into the reply_part function makes things a little simpler, and frees up some name space that will be needed

[PATCH 07/11] test: add crypto tests for signature verification and decryption

2011-05-25 Thread Jameson Graef Rollins
This adds a new crypto test script to the test suite to test PGP/MIME signature verification and message decryption. Included here is a test GNUPGHOME with a test secret key (passwordless), and test for: * signing/verification * signing/verification with full owner trust * verification

[PATCH 06/11] test: add notmuch_show_sanitize_all function that is a little more aggressive.

2011-05-25 Thread Jameson Graef Rollins
The old notmuch_show_sanitize function only scrubed part of the filename. This one scrubs the full filename, as well as the message id. --- test/test-lib.sh |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 9e2e0b5..ae25635

[PATCH 04/11] Break up format-part function into part_start and part_content functions.

2011-05-25 Thread Jameson Graef Rollins
Future improvements (eg. crypto support) will require adding new part header. By breaking up the output of part headers from the output of part content, we can easily out new part headers with new formatting functions. --- notmuch-client.h |5 +- notmuch-reply.c | 13 --

[PATCH 10/11] emacs: Add support for PGP/MIME verification/decryption

2011-05-25 Thread Jameson Graef Rollins
A new emacs configuration variable notmuch-crypto-process-mime controls the processing of PGP/MIME signatures and encrypted parts. When this is set true, notmuch-query will use the notmuch show --decrypt flag to decrypt encrypted messages and/or calculate the sigstatus of signed messages. If

[PATCH 08/11] Add signature verification of PGP/MIME-signed parts with --verify.

2011-05-25 Thread Jameson Graef Rollins
This is primarily for notmuch-show, although the functionality is added to show-message. Once signatures are processed a new part_sigstatus formatter is emitted, and the entire multipart/signed part is replaced with the contents of the signed part. At the moment only a json part_sigstatus

[PATCH 11/11] tag signed/encrypted during notmuch new

2011-05-25 Thread Jameson Graef Rollins
This patch adds the tag signed to messages with any multipart/signed parts, and the tag encrypted to messages with any multipart/encrypted parts. This only occurs when messages are indexed during notmuch new, so a database rebuild is required to have old messages tagged. --- lib/index.cc

Re: [PATCH] emacs: Allow user to choose From address when composing a new message.

2011-05-26 Thread Jameson Graef Rollins
On Thu, 26 May 2011 10:39:58 +0200, Thomas Jost schno...@schnouki.net wrote: When I first started implementing the custom-from feature I planned to use a prefix argument to get the behavior (such as C-u m rather than M for compose-new-mail-with-custom-from). You might even see I've got

Re: [PATCH] emacs: Add a customization allowing to always prompt for the From address when composing a new message

2011-05-26 Thread Jameson Graef Rollins
On Thu, 26 May 2011 19:22:41 +0200, Thomas Jost schno...@schnouki.net wrote: Here it is :) I'm sure it will be useful for many other people too, including myself. To be applied on top of my other patches, then you can set notmuch-always-prompt-for-sender to t. Awesome! Thanks, Thomas. jamie.

Re: [PATCH] emacs: Add a customization allowing to always prompt for the From address when composing a new message

2011-05-26 Thread Jameson Graef Rollins
On Thu, 26 May 2011 14:11:11 -0700, Carl Worth cwo...@cworth.org wrote: It's a nice patch series, and I've pushed it all out now. After using this feature for a day, I think it's great. But it would be nice if the name was just automatically filled in, since that doesn't change, and the ido

normalizing part numbering across PGP/MIME processing

2011-05-27 Thread Jameson Graef Rollins
Ok. So I very much hope this patch series satisfies those who were bothered by the part renumbering that was happening when PGP/MIME parts were processed. For signed messages we no longer modify the parts at all, so numbering always remains constant, and for encrypted messages the numbering will

[PATCH 3/4] emacs: Do not attempt to render arbitrary application parts.

2011-05-27 Thread Jameson Graef Rollins
We probably shouldn't have been doing this anyway, but we do it here specifically because we don't want the content of the application/pgp-encrypted parts to be displayed and cluttering the message show. --- emacs/notmuch-show.el |5 + 1 files changed, 5 insertions(+), 0 deletions(-)

[PATCH 2/4] Render all parts of multipart/encrypted when decrypting.

2011-05-27 Thread Jameson Graef Rollins
The primary goal here is to keep the decrypted output as similarly structured as undecrypted output as possible. Now, when decrypting parts, only the original encrypted part is replaced by the it's decrypted content. If this part isn't itself a multipart, then all part numbering should remain

[PATCH 1/4] Do not replace multipart/signed part with content part when doing verification.

2011-05-27 Thread Jameson Graef Rollins
Some folks have complained about the part renumbering that occurs when the entire multipart/signed part is replaced with the part contents after verification. This is primarily because it incurs an additional computational cost to retrieve individual parts, since verification has to be performed

Re: [PATCH 1/2] emacs: Don't always prompt for the From address when replying

2011-05-27 Thread Jameson Graef Rollins
On Fri, 27 May 2011 11:14:59 +0200, Thomas Jost schno...@schnouki.net wrote: You're right, this is mostly annoying when replying to messages. Here's a fix. Awesome. Thanks, Thomas. Tested and works great. jamie. pgpQ1DnF9hcWt.pgp Description: PGP signature

Re: [PATCH 2/2] emacs: Cleaner interface when prompting for sender address

2011-05-27 Thread Jameson Graef Rollins
On Fri, 27 May 2011 11:15:00 +0200, Thomas Jost schno...@schnouki.net wrote: Once again, a very good suggestion. I had doubts at first (because I sometimes send mails using a nickname or on behalf of a group using that group's name), but then I noticed I already had only one name in

[PATCH] emacs: Give mutlipart/{signed, encrypted} their own part handler.

2011-05-27 Thread Jameson Graef Rollins
This is the best way to make the displayed output for decrypted/verified messages clearer. The special sigstatus and encstatus buttons are now displayed under the part header button. The part header button is also tweaked to provide information to user about how to proces crypto. --- This patch

Re: normalizing part numbering across PGP/MIME processing

2011-05-28 Thread Jameson Graef Rollins
On Fri, 27 May 2011 17:53:44 -0700, Carl Worth cwo...@cworth.org wrote: So, well done, Jameson! You've been extremely patient as I sat on this patch series for *so* long, and then made you rebuild it so many times. I hope you think the rebuilds were at least worth it for the much cleaner final

[PATCH 02/25] add note about updating the debian symbols file to the RELEASE file

2011-05-28 Thread Jameson Graef Rollins
--- RELEASING | 22 ++ 1 files changed, 18 insertions(+), 4 deletions(-) diff --git a/RELEASING b/RELEASING index a392d81..475100a 100644 --- a/RELEASING +++ b/RELEASING @@ -35,7 +35,21 @@ repository. From here, there are just a few steps to release: Commit this

[PATCH 04/25] test: move Search for non-existent message prints nothing to search-output, and add similar test for format=json

2011-05-28 Thread Jameson Graef Rollins
These tests also use the new test_expect_equal_file test. --- test/search|5 - test/search-output | 12 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/test/search b/test/search index 0981f66..4835872 100755 --- a/test/search +++ b/test/search @@

[PATCH 06/25] test: move utf-8 subject search test from json to search test script

2011-05-28 Thread Jameson Graef Rollins
This test doesn't have anything to do with json, and has everything to do with testing search capability, so I'm not sure why it was in the wrong place. --- test/json |5 - test/search |6 ++ 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/test/json b/test/json

[PATCH 12/25] test: cleanup search-output test names (no functional change)

2011-05-28 Thread Jameson Graef Rollins
Signed-off-by: Jameson Graef Rollins jroll...@finestructure.net --- test/search-output | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/test/search-output b/test/search-output index 8edc26a..02cf602 100755 --- a/test/search-output +++ b/test/search

release-candidate/0.6 redux

2011-05-28 Thread Jameson Graef Rollins
So what follows is a patch series for a bunch of miscellaneous patches that should be included in 0.6. Most of them were originally part of the release-candiate/0.6 branch, and they are here rebased on top of notmuch/master at cb8418784c21155ffea79cce8409a7ea3c546937, which includes all the

[PATCH 08/25] create and set temporary home directory

2011-05-28 Thread Jameson Graef Rollins
home directory. The patch creates a directory in the temporary test directory and sets home accordingly. In case of a non-existent home directory, the tests are failing without this patch. Signed-off-by: Jameson Graef Rollins jroll...@finestructure.net --- test/test-lib.sh |7 +++ 1 files

[PATCH 09/25] emacs: Define several faces for the crypto-status button

2011-05-28 Thread Jameson Graef Rollins
From: Thomas Jost schno...@schnouki.net Signed-off-by: Jameson Graef Rollins jroll...@finestructure.net jrollins modified this patch to conform to recent changes in the crypto processing since this patch was originally sent in. --- emacs/notmuch-crypto.el | 42

[PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check.

2011-05-28 Thread Jameson Graef Rollins
-30283-2-git-send-email-...@dme.org. Signed-off-by: Jameson Graef Rollins jroll...@finestructure.net --- emacs/notmuch-maildir-fcc.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el index 3f1c124..b79f6a3 100644

[PATCH 01/25] fix check for libdir in ldconfig paths

2011-05-28 Thread Jameson Graef Rollins
The configure script tries to check that the libdir is included in the ldconfig paths, and then sets the RPATH compiler flag if it's not. This check was broken, and was always setting RPATH. This fixes the path check. --- configure |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)

[PATCH 11/25] test: add test for sanitized notmuch-search output

2011-05-28 Thread Jameson Graef Rollins
From: Florian Friesdorf f...@chaoflow.net Signed-off-by: Jameson Graef Rollins jroll...@finestructure.net --- test/search-output |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/test/search-output b/test/search-output index 13f9613..8edc26a 100755 --- a/test

[PATCH 07/25] test: remove json test for search null result, since it's being more properly tested in search-output

2011-05-28 Thread Jameson Graef Rollins
The test in json was inferior to the one in search-output, since it wasn't properly testing for the presence of a trailing newline. --- test/json |4 test/search-output |4 +--- 2 files changed, 1 insertions(+), 7 deletions(-) diff --git a/test/json b/test/json index

[PATCH 05/25] fix trailing newlines in notmuch search

2011-05-28 Thread Jameson Graef Rollins
A previous commit to fix json formatting for null results (0b1ddc5f6652bde99d63d9d553777b3d926694cf) accidentally introduced a regression that removed trailing newlines for non-json output. (There wasn't a good test for this previously, but there is now). The problem is due to the fundamental

[PATCH 03/25] test: modify search-output test to use the new test_expect_equal_file function

2011-05-28 Thread Jameson Graef Rollins
These test now properly test for the presence of a newline at the end of all output. Right now some of these test will fail because the search output is currently broken to *not* produce proper newlines in some cases. --- test/search-output | 72

[PATCH 13/25] emacs: Use message-cited-text instead of message-cited-text-face

2011-05-28 Thread Jameson Graef Rollins
From: Pieter Praet pie...@praet.org (describe-face 'message-cited-text-face) message-cited-text-face is an alias for the face `message-cited-text'. This face is obsolete since 22.1; use `message-cited-text' instead. Signed-off-by: Pieter Praet pie...@praet.org Signed-off-by: Jameson Graef

[PATCH 10/25] Sanitize Subject: and Author: fields to not contain control characters in notmuch-search

2011-05-28 Thread Jameson Graef Rollins
with ASCII code less than 32 with a question mark. Signed-off-by: Jameson Graef Rollins jroll...@finestructure.net --- notmuch-search.c | 22 -- 1 files changed, 20 insertions(+), 2 deletions(-) diff --git a/notmuch-search.c b/notmuch-search.c index 69af617..530cecc 100644

[PATCH 20/25] emacs: Don't always prompt for the From address when replying

2011-05-28 Thread Jameson Graef Rollins
From: Thomas Jost schno...@schnouki.net When replying, the From: address is already filled in by notmuch reply, so most of the time there is no need to prompt the user for it. --- emacs/notmuch-mua.el |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git

[PATCH 22/25] test: fix test_expect_equal_file test to copy instead of mv test files

2011-05-28 Thread Jameson Graef Rollins
This is a pretty important fix to this test, so that it can be used to test against existing files, without deleting them in the case of test failure. --- test/test-lib.sh |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index

[PATCH 21/25] emacs: Cleaner interface when prompting for sender address

2011-05-28 Thread Jameson Graef Rollins
From: Thomas Jost schno...@schnouki.net Most of the time, every entry in the list of identities has the same user name part. It can then be filled in automatically, and the user can only be prompted for the email address, which makes the interface much cleaner. --- emacs/notmuch-mua.el | 33

[PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

2011-05-28 Thread Jameson Graef Rollins
The declaration of the GMimeStream pointer to stdout in format_part_content_text was somehow preventing subsequent printf calls from outputting to stdout if the output was redirected to a file. Scoping the declaration to the actual use of the stream pointer works around this problem. ---

[PATCH 23/25] test: update emacs test to use test_expect_equal_file

2011-05-28 Thread Jameson Graef Rollins
This is a much cleaner way to do the emacs tests, since we're actually comparing output against existing files with expected output. We also won't miss any trailing newlines this way. And speaking of which, one of the expected output files was actually missing a trailing blank line that was

[PATCH 24/25] test: modify multipart test to use test_expect_equal_file

2011-05-28 Thread Jameson Graef Rollins
Again, this is a much cleaner and more thorough test, and in fact exposes a bug in the format=text output, that will be fixed the next commit. Because of this, some of the multipart tests currently fail. --- test/multipart | 189 1 files

Re: release-candidate/0.6 redux

2011-05-28 Thread Jameson Graef Rollins
On Sat, 28 May 2011 14:51:35 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: So what follows is a patch series for a bunch of miscellaneous patches that should be included in 0.6. Most of them were originally part of the release-candiate/0.6 branch, and they are here rebased

[PATCH 2/2] emacs: Unbind M-RET as display of thread with crypto switch.

2011-05-28 Thread Jameson Graef Rollins
Use prefix argument instead to set switch. --- emacs/notmuch.el |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 3311fe8..0978c66 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -218,7 +218,6 @@ For a mouse binding,

[PATCH 2/2] emacs: add notmuch-show-worker function for specifying crypto processing directly

2011-05-30 Thread Jameson Graef Rollins
The main reason to introduce this new unexposed function is to allow the buffer redisplay crypto switch to behaving in a more expected way. The prefix to notmuch-show-redisplay buffer now switches the crypto processing of the current show buffer, as opposed to switching the logic of the

Re: compile error of current git on F15

2011-05-30 Thread Jameson Graef Rollins
On Sun, 29 May 2011 11:44:05 -0700, Dirk Hohndel hohn...@infradead.org wrote: CC -O2 notmuch-reply.o notmuch-reply.c: In function ‘notmuch_reply_command’: notmuch-reply.c:658:3: error: unknown type name ‘GMimeSession’ notmuch-reply.c:659:3: warning: passing argument 1 of

[PATCH] emacs: update notmuch-crypto-process-mime config variable documentation.

2011-05-31 Thread Jameson Graef Rollins
This mentions the fact that prefix arguments are now used to enable to crypto switch. --- emacs/notmuch-crypto.el |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el index 096dc5e..44fccae 100644 ---

[PATCH] emacs: Add callback functions to crypto sigstatus button.

2011-05-31 Thread Jameson Graef Rollins
This adds two callback functions to the sigstatus button. If the sig status is good, then clicking the button displays the output of gpg --list-keys on the key fingerprint. If the sigstatus is bad, then clicking the button will retrieve the key from the keyserver, and redisplay the current

Re: release-candidate/0.6 redux

2011-05-31 Thread Jameson Graef Rollins
Hi, folks. I have pushed a new version of the release-candidate/0.6 branch to my repo [0]. It is all reworked on top of notmuch/master [1], and includes: * the miscellaneous fixes/improvements patch series starting at id:1306619520-25730-2-git-send-email-jroll...@finestructure.net * the

Re: compile error of current git on F15

2011-06-01 Thread Jameson Graef Rollins
On Wed, 01 Jun 2011 05:35:29 -0700, Dirk Hohndel hohn...@infradead.org wrote: This used to work and used to be supported and was broken in a recent notmuch patch. Hey, Dirk. I would actually say that support for gmime 2.6 was merely coincidental up until now. For all functionality we had been

Re: [PATCH 01/25] fix check for libdir in ldconfig paths

2011-06-01 Thread Jameson Graef Rollins
On Wed, 01 Jun 2011 16:22:19 -0700, Carl Worth cwo...@cworth.org wrote: Thanks for the patch. I was intrigued about what was actually broken here, so tracked down the problem and fixed it with an alternate patch (see below). Cool. Yeah, that issue took a while to track down. jamie.

Re: Decryption fails

2011-06-02 Thread Jameson Graef Rollins
On Tue, 31 May 2011 19:33:29 +0200, Felix Geller fgel...@gmail.com wrote: I get the following trace when using show --decrypt to decrypt a specific message (have to kill the process to actually get the trace): #0 0x0001006121a6 in poll () #1 0x00010006d3d2 in gpg_ctx_op_step () #2

[PATCH] Do not attept to output part raw if part is not GMimePart.

2011-06-02 Thread Jameson Graef Rollins
This was a minor oversite in checking of part type when outputing content raw. This was causing gmime was to throw an exception to stderr. Unfortunately the gmime exception was not being caught by notmuch, or the test suite. I'm not sure if notmuch should have done anything in this case, but

[PATCH] emacs: Fix handling of message/rfc822 parts.

2011-06-02 Thread Jameson Graef Rollins
After the recent part-handling overhaul, emacs handling of message/rfc822 parts broke, not outputting the message contents. This fixes then handling as is, but there are still problems with how notmuch is outputting message parts that needs to be addressed (for instance, message headers are not

problems with message/rfc822 parts

2011-06-02 Thread Jameson Graef Rollins
Hey, folks. I've been noticing a couple of issues with message/rfc822 part handling in recent builds of notmuch/master. They are rooted in the new part handling rework that was done recently. I just want to mention them here, to make people aware of them, until we get a chance to address them.

Re: Decryption fails

2011-06-02 Thread Jameson Graef Rollins
On Thu, 02 Jun 2011 18:49:22 +0200, Felix Geller fgel...@gmail.com wrote: Jeff replied and sent me a working patch :) Not sure yet how he prefers to publish the patch, but the problem is fixed. That's great! What did Jeff say exactly? Is the patch to gmime 2.4? Did he mention that he was

  1   2   3   4   5   6   7   8   9   10   >